From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 946FD2116DA14 for ; Sun, 14 Oct 2018 09:00:15 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id 63-v6so18413855wra.11 for ; Sun, 14 Oct 2018 09:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dfOqYx3jP+50WpGDpKbhiKOQFrEKBrPVb7ynK2ZTfm4=; b=kT15JhueHk9A1f9p3sxKYpkVlw456K0WBdSyGCBfkY+s3M0gG8WwCKjPICXpAiybg6 kBUpdd/99MWb6xWZ9rMspaBccuWyFKnaiJ6K1kNTrCgkXkTzl5Q5XqrU/MaxmQ8gWkpT Q7TErP3OOLMlADYq+nBRAj5+BRFAAfeSuKczI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dfOqYx3jP+50WpGDpKbhiKOQFrEKBrPVb7ynK2ZTfm4=; b=Au2ahE8G0ZZ2F9MvEiQvv1WFIgsK5DKdtARyDI3ROTZe4mjqO/OLYGpNIdj20KLZjt 4Ry7mrb+zd2Q/KIqv1GFyhH//8i7Rl2N+75Wh2GXU0gWLPogPW9Ma5Vu5RCHbEKls7Av HUIwcvUXmbPmlpQEB+bJhiIM6Wu/LsSVpjjlF8f+9dry5s+JQH8eUTnVGJrPl3LbLWfW RxN6Ri0ahCMcs/hjQ5+dWg/v4fjq2NMleTDkhmJWMBwm0vgCzluUZAFpN7LK9/ZbRQu7 6M0Ixp6ig1CBITGknylQWR0DuOgIXCOKAgSEZ+b7/qJvbVIySisfZs/+z15XQfXRZ+Qw BUvw== X-Gm-Message-State: ABuFfoigsYcCKQ8mgg/kYMmgTV7kH31Ka3Q1rnwHdJXfO0unZ29fI16y K9Kfy5eHSAb+n3XKEdZ9R48i9w== X-Google-Smtp-Source: ACcGV62I48bzzI6665ZmCyIzY7Qg2FuMpeXbOewTK/m7N4GTgRZt/r88C/280VYn7T7wbfTpYJQRKA== X-Received: by 2002:adf:cd0c:: with SMTP id w12-v6mr12092791wrm.67.1539532813410; Sun, 14 Oct 2018 09:00:13 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b81-v6sm5526754wmh.47.2018.10.14.09.00.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Oct 2018 09:00:12 -0700 (PDT) Date: Sun, 14 Oct 2018 17:00:09 +0100 From: Leif Lindholm To: "Gao, Liming" Cc: "Zhu, Yonghong" , Ard Biesheuvel , "edk2-devel@lists.01.org" Message-ID: <20181014160009.diomx7zs2kttcfpu@bivouac.eciton.net> References: <1539448829-13824-1-git-send-email-yonghong.zhu@intel.com> <20181013204023.tz4bomxz7ds26du2@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E339CD0@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339CD0@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2018 16:00:16 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Oct 14, 2018 at 02:51:06PM +0000, Gao, Liming wrote: > Leif: > OK. I will move this patch set to edk2 staging repo for people > verification. Thats sounds like a good idea. > I will use git revert command to revert total 27 patches one by > one. Then, there will be 27 commit for the revert patches. Or, one > commit to combine all revert patches. One commit is enough. Do you > agree it? On commit is enough. > Below is the commit message for the revert patch. Could you help > review it? > Python3 migration is the fundamental change. It requires every > developer to install Python3. Before this migration, the well > communication and wide verification must be done. But now, most > people is not aware of this change, and not try it. So, Python3 > migration is reverted and be moved to edk2-staging Python3 branch > for the edk2 user evaluation. This looks good to me, thanks! Regards, Leif > Thanks > Liming > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Sunday, October 14, 2018 4:40 AM > > To: Zhu, Yonghong > > Cc: Ard Biesheuvel ; edk2-devel@lists.01.org; Gao, Liming > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > > > Hi Yonghong, > > > > Please revert this patch. The broken state of the master branch must > > be undone, not hacked on until individual bits seem to work. > > > > Plese do no further work on the master branch until the contents of > > the tree is identical to what it was at > > 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a > > git push -f, I am talking about a git revert.) > > > > Best Regards, > > > > Leif > > > > On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > > > Hi Ard, > > > > > > Thanks. I pushed this patch since it is critical block issue. > > > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > > > > > Best Regards, > > > Zhu Yonghong > > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Sunday, October 14, 2018 12:44 AM > > > To: Zhu, Yonghong > > > Cc: edk2-devel@lists.01.org; Leif Lindholm > > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > > > > > On 13 October 2018 at 18:40, Yonghong Zhu wrote: > > > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > > > file. > > > > > > > > Cc: Ard Biesheuvel > > > > Cc: Leif Lindholm > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Yonghong Zhu > > > > > > Reviewed-by: Ard Biesheuvel > > > Tested-by: Ard Biesheuvel > > > > > > > --- > > > > BaseTools/Tests/GNUmakefile | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > > > > index af334a8a..536f0b7 100644 > > > > --- a/BaseTools/Tests/GNUmakefile > > > > +++ b/BaseTools/Tests/GNUmakefile > > > > @@ -12,10 +12,10 @@ > > > > # > > > > > > > > all: test > > > > > > > > test: > > > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > > > > + @if command -v python3 >/dev/null 2>&1; then python3 > > > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > > > > > clean: > > > > find . -name '*.pyc' -exec rm '{}' ';' > > > > > > > > -- > > > > 2.6.1.windows.1 > > > >