* [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable @ 2018-10-13 16:40 Yonghong Zhu 2018-10-13 16:43 ` Ard Biesheuvel 2018-10-13 16:45 ` Gao, Liming 0 siblings, 2 replies; 8+ messages in thread From: Yonghong Zhu @ 2018-10-13 16:40 UTC (permalink / raw) To: edk2-devel Cover the case use do make -C BaseTools before run the .edksetup.sh file. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Leif Lindholm <leif.lindholm@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile index af334a8a..536f0b7 100644 --- a/BaseTools/Tests/GNUmakefile +++ b/BaseTools/Tests/GNUmakefile @@ -12,10 +12,10 @@ # all: test test: - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi + @if command -v python3 >/dev/null 2>&1; then python3 RunTests.py; else echo "Error: Please install a python 3 tool!"; fi clean: find . -name '*.pyc' -exec rm '{}' ';' -- 2.6.1.windows.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 16:40 [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable Yonghong Zhu @ 2018-10-13 16:43 ` Ard Biesheuvel 2018-10-13 16:53 ` Zhu, Yonghong 2018-10-13 16:45 ` Gao, Liming 1 sibling, 1 reply; 8+ messages in thread From: Ard Biesheuvel @ 2018-10-13 16:43 UTC (permalink / raw) To: Yonghong Zhu; +Cc: edk2-devel@lists.01.org, Leif Lindholm On 13 October 2018 at 18:40, Yonghong Zhu <yonghong.zhu@intel.com> wrote: > Cover the case use do make -C BaseTools before run the .edksetup.sh > file. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > BaseTools/Tests/GNUmakefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > index af334a8a..536f0b7 100644 > --- a/BaseTools/Tests/GNUmakefile > +++ b/BaseTools/Tests/GNUmakefile > @@ -12,10 +12,10 @@ > # > > all: test > > test: > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > + @if command -v python3 >/dev/null 2>&1; then python3 RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > clean: > find . -name '*.pyc' -exec rm '{}' ';' > > -- > 2.6.1.windows.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 16:43 ` Ard Biesheuvel @ 2018-10-13 16:53 ` Zhu, Yonghong 2018-10-13 20:40 ` Leif Lindholm 0 siblings, 1 reply; 8+ messages in thread From: Zhu, Yonghong @ 2018-10-13 16:53 UTC (permalink / raw) To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Leif Lindholm, Zhu, Yonghong Hi Ard, Thanks. I pushed this patch since it is critical block issue. Version SHA-1: 678f85131238622e576705117e299d81cff755c9 Best Regards, Zhu Yonghong -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Sunday, October 14, 2018 12:44 AM To: Zhu, Yonghong <yonghong.zhu@intel.com> Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org> Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable On 13 October 2018 at 18:40, Yonghong Zhu <yonghong.zhu@intel.com> wrote: > Cover the case use do make -C BaseTools before run the .edksetup.sh > file. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > BaseTools/Tests/GNUmakefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > index af334a8a..536f0b7 100644 > --- a/BaseTools/Tests/GNUmakefile > +++ b/BaseTools/Tests/GNUmakefile > @@ -12,10 +12,10 @@ > # > > all: test > > test: > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > + @if command -v python3 >/dev/null 2>&1; then python3 > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > clean: > find . -name '*.pyc' -exec rm '{}' ';' > > -- > 2.6.1.windows.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 16:53 ` Zhu, Yonghong @ 2018-10-13 20:40 ` Leif Lindholm 2018-10-14 9:03 ` Laszlo Ersek 2018-10-14 14:51 ` Gao, Liming 0 siblings, 2 replies; 8+ messages in thread From: Leif Lindholm @ 2018-10-13 20:40 UTC (permalink / raw) To: Zhu, Yonghong; +Cc: Ard Biesheuvel, edk2-devel@lists.01.org, Liming Gao Hi Yonghong, Please revert this patch. The broken state of the master branch must be undone, not hacked on until individual bits seem to work. Plese do no further work on the master branch until the contents of the tree is identical to what it was at 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a git push -f, I am talking about a git revert.) Best Regards, Leif On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > Hi Ard, > > Thanks. I pushed this patch since it is critical block issue. > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > Best Regards, > Zhu Yonghong > > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Sunday, October 14, 2018 12:44 AM > To: Zhu, Yonghong <yonghong.zhu@intel.com> > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org> > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > On 13 October 2018 at 18:40, Yonghong Zhu <yonghong.zhu@intel.com> wrote: > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > file. > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > --- > > BaseTools/Tests/GNUmakefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > > index af334a8a..536f0b7 100644 > > --- a/BaseTools/Tests/GNUmakefile > > +++ b/BaseTools/Tests/GNUmakefile > > @@ -12,10 +12,10 @@ > > # > > > > all: test > > > > test: > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > > + @if command -v python3 >/dev/null 2>&1; then python3 > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > clean: > > find . -name '*.pyc' -exec rm '{}' ';' > > > > -- > > 2.6.1.windows.1 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 20:40 ` Leif Lindholm @ 2018-10-14 9:03 ` Laszlo Ersek 2018-10-14 14:51 ` Gao, Liming 1 sibling, 0 replies; 8+ messages in thread From: Laszlo Ersek @ 2018-10-14 9:03 UTC (permalink / raw) To: Leif Lindholm, Zhu, Yonghong; +Cc: edk2-devel@lists.01.org, Liming Gao On 10/13/18 22:40, Leif Lindholm wrote: > Hi Yonghong, > > Please revert this patch. The broken state of the master branch must > be undone, not hacked on until individual bits seem to work. > > Plese do no further work on the master branch until the contents of > the tree is identical to what it was at > 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a > git push -f, I am talking about a git revert.) +1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 20:40 ` Leif Lindholm 2018-10-14 9:03 ` Laszlo Ersek @ 2018-10-14 14:51 ` Gao, Liming 2018-10-14 16:00 ` Leif Lindholm 1 sibling, 1 reply; 8+ messages in thread From: Gao, Liming @ 2018-10-14 14:51 UTC (permalink / raw) To: Leif Lindholm, Zhu, Yonghong; +Cc: Ard Biesheuvel, edk2-devel@lists.01.org Leif: OK. I will move this patch set to edk2 staging repo for people verification. I will use git revert command to revert total 27 patches one by one. Then, there will be 27 commit for the revert patches. Or, one commit to combine all revert patches. One commit is enough. Do you agree it? Below is the commit message for the revert patch. Could you help review it? Python3 migration is the fundamental change. It requires every developer to install Python3. Before this migration, the well communication and wide verification must be done. But now, most people is not aware of this change, and not try it. So, Python3 migration is reverted and be moved to edk2-staging Python3 branch for the edk2 user evaluation. Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Sunday, October 14, 2018 4:40 AM > To: Zhu, Yonghong <yonghong.zhu@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com> > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > Hi Yonghong, > > Please revert this patch. The broken state of the master branch must > be undone, not hacked on until individual bits seem to work. > > Plese do no further work on the master branch until the contents of > the tree is identical to what it was at > 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a > git push -f, I am talking about a git revert.) > > Best Regards, > > Leif > > On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > > Hi Ard, > > > > Thanks. I pushed this patch since it is critical block issue. > > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > > > Best Regards, > > Zhu Yonghong > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Sunday, October 14, 2018 12:44 AM > > To: Zhu, Yonghong <yonghong.zhu@intel.com> > > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org> > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > > > On 13 October 2018 at 18:40, Yonghong Zhu <yonghong.zhu@intel.com> wrote: > > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > > file. > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> > > > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > --- > > > BaseTools/Tests/GNUmakefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > > > index af334a8a..536f0b7 100644 > > > --- a/BaseTools/Tests/GNUmakefile > > > +++ b/BaseTools/Tests/GNUmakefile > > > @@ -12,10 +12,10 @@ > > > # > > > > > > all: test > > > > > > test: > > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > > > + @if command -v python3 >/dev/null 2>&1; then python3 > > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > > > clean: > > > find . -name '*.pyc' -exec rm '{}' ';' > > > > > > -- > > > 2.6.1.windows.1 > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-14 14:51 ` Gao, Liming @ 2018-10-14 16:00 ` Leif Lindholm 0 siblings, 0 replies; 8+ messages in thread From: Leif Lindholm @ 2018-10-14 16:00 UTC (permalink / raw) To: Gao, Liming; +Cc: Zhu, Yonghong, Ard Biesheuvel, edk2-devel@lists.01.org On Sun, Oct 14, 2018 at 02:51:06PM +0000, Gao, Liming wrote: > Leif: > OK. I will move this patch set to edk2 staging repo for people > verification. Thats sounds like a good idea. > I will use git revert command to revert total 27 patches one by > one. Then, there will be 27 commit for the revert patches. Or, one > commit to combine all revert patches. One commit is enough. Do you > agree it? On commit is enough. > Below is the commit message for the revert patch. Could you help > review it? > Python3 migration is the fundamental change. It requires every > developer to install Python3. Before this migration, the well > communication and wide verification must be done. But now, most > people is not aware of this change, and not try it. So, Python3 > migration is reverted and be moved to edk2-staging Python3 branch > for the edk2 user evaluation. This looks good to me, thanks! Regards, Leif > Thanks > Liming > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Sunday, October 14, 2018 4:40 AM > > To: Zhu, Yonghong <yonghong.zhu@intel.com> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com> > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > > > Hi Yonghong, > > > > Please revert this patch. The broken state of the master branch must > > be undone, not hacked on until individual bits seem to work. > > > > Plese do no further work on the master branch until the contents of > > the tree is identical to what it was at > > 301402fa4797ac3a141e575329ca2ea91756414c. (I am not talking about a > > git push -f, I am talking about a git revert.) > > > > Best Regards, > > > > Leif > > > > On Sat, Oct 13, 2018 at 04:53:21PM +0000, Zhu, Yonghong wrote: > > > Hi Ard, > > > > > > Thanks. I pushed this patch since it is critical block issue. > > > Version SHA-1: 678f85131238622e576705117e299d81cff755c9 > > > > > > Best Regards, > > > Zhu Yonghong > > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Sunday, October 14, 2018 12:44 AM > > > To: Zhu, Yonghong <yonghong.zhu@intel.com> > > > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org> > > > Subject: Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > > > > > On 13 October 2018 at 18:40, Yonghong Zhu <yonghong.zhu@intel.com> wrote: > > > > Cover the case use do make -C BaseTools before run the .edksetup.sh > > > > file. > > > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> > > > > > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > > > --- > > > > BaseTools/Tests/GNUmakefile | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > > > > index af334a8a..536f0b7 100644 > > > > --- a/BaseTools/Tests/GNUmakefile > > > > +++ b/BaseTools/Tests/GNUmakefile > > > > @@ -12,10 +12,10 @@ > > > > # > > > > > > > > all: test > > > > > > > > test: > > > > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > > > > + @if command -v python3 >/dev/null 2>&1; then python3 > > > > + RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > > > > > > > clean: > > > > find . -name '*.pyc' -exec rm '{}' ';' > > > > > > > > -- > > > > 2.6.1.windows.1 > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable 2018-10-13 16:40 [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable Yonghong Zhu 2018-10-13 16:43 ` Ard Biesheuvel @ 2018-10-13 16:45 ` Gao, Liming 1 sibling, 0 replies; 8+ messages in thread From: Gao, Liming @ 2018-10-13 16:45 UTC (permalink / raw) To: Zhu, Yonghong, edk2-devel@lists.01.org Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu > Sent: Sunday, October 14, 2018 12:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable > > Cover the case use do make -C BaseTools before run the .edksetup.sh > file. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> > --- > BaseTools/Tests/GNUmakefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile > index af334a8a..536f0b7 100644 > --- a/BaseTools/Tests/GNUmakefile > +++ b/BaseTools/Tests/GNUmakefile > @@ -12,10 +12,10 @@ > # > > all: test > > test: > - @if command -v $(PYTHON3) >/dev/null 2>&1; then $(PYTHON3) RunTests.py; else python RunTests.py; fi > + @if command -v python3 >/dev/null 2>&1; then python3 RunTests.py; else echo "Error: Please install a python 3 tool!"; fi > > clean: > find . -name '*.pyc' -exec rm '{}' ';' > > -- > 2.6.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-10-14 16:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-13 16:40 [Patch] BaseTools/Tests: Update GNUmakefile to use python3 variable Yonghong Zhu 2018-10-13 16:43 ` Ard Biesheuvel 2018-10-13 16:53 ` Zhu, Yonghong 2018-10-13 20:40 ` Leif Lindholm 2018-10-14 9:03 ` Laszlo Ersek 2018-10-14 14:51 ` Gao, Liming 2018-10-14 16:00 ` Leif Lindholm 2018-10-13 16:45 ` Gao, Liming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox