Missing Library in StandaloneMmPkg

Missing Library in StandaloneMmPkg

[Cohen, Eugene]

Greetings,

It appears that StandaloneMmPkg/StandaloneMmPkg.dsc contains a reference to this library:

	ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf

but it does not actually appear in the tree.

The AArch64StandaloneMm branch on edk2-staging is "stale" (not my words but what GitHub calls it) and it does not contain this library so I'm led to believe that there is some other branch where this is being developed.  I also see patch submissions from July that are not yet integrated (StandaloneMmServicesTableLib in particular).


Can I get a summary of the state of the project, in general and on ARM platforms?  Is there a repo or branch we should be going to where we can see a usable system?

Thanks,

Eugene

Re: Missing Library in StandaloneMmPkg

[Supreeth Venkatesh]

Eugene,

The working StandaloneMm available here:
https://github.com/supven01/edk2
https://github.com/supven01/edk2-platforms
(Caveat: Working Version as of July 2018, May not be latest)

As you mentioned, the patches were sent in June/July for Review.
I have not received any comments/feedback on those.
As you say, it has either not been reviewed by the maintainers or merged yet.

I am no longer working on StandaloneMm at this point.
However, Achin or Sughosh will be able to point you to the latest code base.

Thanks,
Supreeth

-----Original Message-----
From: Cohen, Eugene <eugene@hp.com>
Sent: Monday, October 15, 2018 2:29 PM
To: edk2-devel@lists.01.org; Achin Gupta <Achin.Gupta@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; Sughosh Ganu <Sughosh.Ganu@arm.com>
Subject: Missing Library in StandaloneMmPkg

Greetings,

It appears that StandaloneMmPkg/StandaloneMmPkg.dsc contains a reference to this library:

ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf

but it does not actually appear in the tree.

The AArch64StandaloneMm branch on edk2-staging is "stale" (not my words but what GitHub calls it) and it does not contain this library so I'm led to believe that there is some other branch where this is being developed.  I also see patch submissions from July that are not yet integrated (StandaloneMmServicesTableLib in particular).


Can I get a summary of the state of the project, in general and on ARM platforms?  Is there a repo or branch we should be going to where we can see a usable system?

Thanks,

Eugene



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: Missing Library in StandaloneMmPkg

[Cohen, Eugene]

Supreeth, thanks for the fast response.

I'm struggling with what to do next - it sounds like we have a partial StandaloneMmPkg implementation on master.  I'm willing to complete the implementation for our needs but would first like to understand what the plan is for completing and maintaining the package (and not just on the ARM side).

Thanks,

Eugene

From: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Sent: Monday, October 15, 2018 1:49 PM
To: Cohen, Eugene <eugene@hp.com>; edk2-devel@lists.01.org; Achin Gupta <Achin.Gupta@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Sughosh Ganu <Sughosh.Ganu@arm.com>
Cc: Dong Wei <Dong.Wei@arm.com>
Subject: RE: Missing Library in StandaloneMmPkg

Eugene,

The working StandaloneMm available here:
https://github.com/supven01/edk2<https://github.com/supven01/edk2>
https://github.com/supven01/edk2-platforms<https://github.com/supven01/edk2-platforms>
(Caveat: Working Version as of July 2018, May not be latest)

As you mentioned, the patches were sent in June/July for Review.
I have not received any comments/feedback on those.
As you say, it has either not been reviewed by the maintainers or merged yet.

I am no longer working on StandaloneMm at this point.
However, Achin or Sughosh will be able to point you to the latest code base.

Thanks,
Supreeth

-----Original Message-----
From: Cohen, Eugene <eugene@hp.com<mailto:eugene@hp.com>>
Sent: Monday, October 15, 2018 2:29 PM
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Achin Gupta <Achin.Gupta@arm.com<mailto:Achin.Gupta@arm.com>>; Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com<mailto:Supreeth.Venkatesh@arm.com>>; Sughosh Ganu <Sughosh.Ganu@arm.com<mailto:Sughosh.Ganu@arm.com>>
Subject: Missing Library in StandaloneMmPkg

Greetings,

It appears that StandaloneMmPkg/StandaloneMmPkg.dsc contains a reference to this library:

ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf

but it does not actually appear in the tree.

The AArch64StandaloneMm branch on edk2-staging is "stale" (not my words but what GitHub calls it) and it does not contain this library so I'm led to believe that there is some other branch where this is being developed. I also see patch submissions from July that are not yet integrated (StandaloneMmServicesTableLib in particular).


Can I get a summary of the state of the project, in general and on ARM platforms? Is there a repo or branch we should be going to where we can see a usable system?

Thanks,

Eugene



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: Missing Library in StandaloneMmPkg

[Achin Gupta]

Hi Eugene,

Apologies for the confusion and inconvenience! I will try and explain.

The original patchset for MM Standalone support on x86 and AArch64 had around 16
patches. These included changes to the StandaloneMmPkg, ArmPkg, BaseTools & the
Arm VExpressPkg mainly. This patchset was split into three main categories (The
BaseTools changes were upstreamed separately)

1. StandaloneMmPkg changes. These were merged into master as described here
   [1]. These include all the generic code, Secure world code on AArch64 and x86
   support.

2. edk2-platform changes. These are still under review here [2]. These include
   the ARM AEM FVP changes to support Standalone MM.

3. ArmPkg changes. These are under review here [3]. These include all the Normal
   world code to support Standalone MM e.g. the communication driver. They also
   include the ArmMmuStandaloneMmCoreLib implementation.

Late in the review cycle, Ard raised some valid concerns about how the
PeCoffExtraActionLib has been used by patchset [3]. You can see this thread here
[4]. He has also suggested an alternative approach to solve the impasse. We are
investigating this within Arm at the moment.

The plan is to get [2] & [3] merged and this would complete upstream support for
Standalone MM on AArch64 AEM FVP. In the meantime, these patches should work in
any case. Please let me or Sughosh know if you run into any issues. We can
provide instructions if that helps. Please let us know.

Once we are past this hurdle, there is a plan to add support for Standalone MM
for AArch64 on QEMU.

One the maintenance front, me and Yao Jiewen are the maintainers. 

Feature wise, on the Arm front, the next major step is to add support for
multiple S-EL0 Standalone MM partitions. This will take 6-9 months at least to
be available upstream as we are still writing the Arm specifications to support
this.

I hope this makes things clearer. Please let me know.

cheers,
Achin
 
[1] https://lists.01.org/pipermail/edk2-devel/2018-July/027322.html
[2] https://lists.01.org/pipermail/edk2-devel/2018-May/024489.html
[3] https://lists.01.org/pipermail/edk2-devel/2018-July/027383.html
[4] https://lists.01.org/pipermail/edk2-devel/2018-August/029003.html

On Mon, Oct 15, 2018 at 08:00:41PM +0000, Cohen, Eugene wrote:
>    Supreeth, thanks for the fast response.
> 
> 
>    I'm struggling with what to do next - it sounds like we have a partial
>    StandaloneMmPkg implementation on master.  I'm willing to complete the
>    implementation for our needs but would first like to understand what
>    the plan is for completing and maintaining the package (and not just on
>    the ARM side).
> 
> 
>    Thanks,
> 
> 
>    Eugene
> 
> 
>    From: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
>    Sent: Monday, October 15, 2018 1:49 PM
>    To: Cohen, Eugene <eugene@hp.com>; edk2-devel@lists.01.org; Achin Gupta
>    <Achin.Gupta@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Sughosh Ganu
>    <Sughosh.Ganu@arm.com>
>    Cc: Dong Wei <Dong.Wei@arm.com>
>    Subject: RE: Missing Library in StandaloneMmPkg
> 
> 
>    Eugene,
>    The working StandaloneMm available here:
>    [1]https://github.com/supven01/edk2
>    [2]https://github.com/supven01/edk2-platforms
>    (Caveat: Working Version as of July 2018, May not be latest)
>    As you mentioned, the patches were sent in June/July for Review.
>    I have not received any comments/feedback on those.
>    As you say, it has either not been reviewed by the maintainers or
>    merged yet.
>    I am no longer working on StandaloneMm at this point.
>    However, Achin or Sughosh will be able to point you to the latest code
>    base.
>    Thanks,
>    Supreeth
>    -----Original Message-----
>    From: Cohen, Eugene <[3]eugene@hp.com>
>    Sent: Monday, October 15, 2018 2:29 PM
>    To: [4]edk2-devel@lists.01.org; Achin Gupta <[5]Achin.Gupta@arm.com>;
>    Jiewen Yao <[6]jiewen.yao@intel.com>; Supreeth Venkatesh
>    <[7]Supreeth.Venkatesh@arm.com>; Sughosh Ganu <[8]Sughosh.Ganu@arm.com>
>    Subject: Missing Library in StandaloneMmPkg
>    Greetings,
>    It appears that StandaloneMmPkg/StandaloneMmPkg.dsc contains a
>    reference to this library:
>    ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf
>    but it does not actually appear in the tree.
>    The AArch64StandaloneMm branch on edk2-staging is "stale" (not my words
>    but what GitHub calls it) and it does not contain this library so I'm
>    led to believe that there is some other branch where this is being
>    developed. I also see patch submissions from July that are not yet
>    integrated (StandaloneMmServicesTableLib in particular).
>    Can I get a summary of the state of the project, in general and on ARM
>    platforms? Is there a repo or branch we should be going to where we can
>    see a usable system?
>    Thanks,
>    Eugene
>    IMPORTANT NOTICE: The contents of this email and any attachments are
>    confidential and may also be privileged. If you are not the intended
>    recipient, please notify the sender immediately and do not disclose the
>    contents to any other person, use it for any purpose, or store or copy
>    the information in any medium. Thank you.
> 
> References
> 
>    1. https://github.com/supven01/edk2
>    2. https://github.com/supven01/edk2-platforms
>    3. mailto:eugene@hp.com
>    4. mailto:edk2-devel@lists.01.org
>    5. mailto:Achin.Gupta@arm.com
>    6. mailto:jiewen.yao@intel.com
>    7. mailto:Supreeth.Venkatesh@arm.com
>    8. mailto:Sughosh.Ganu@arm.com