public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Paulo Alcantara <palcantara@suse.de>,
	Paulo Alcantara <paulo@paulo.ac>, Ruiyu Ni <ruiyu.ni@intel.com>,
	Star Zeng <star.zeng@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH v2 0/6] Code refinements in UdfDxe
Date: Tue, 16 Oct 2018 16:14:36 +0800	[thread overview]
Message-ID: <20181016081442.24236-1-hao.a.wu@intel.com> (raw)

Note:
Since PATCH v2 1/6 ~ 5/6 have not been changed, add the 'Reviewed-by:' tag
during the v1 series review.


V2 changes:

A. Drop PATCH v1 6/7, since removing those codes will make the function
   MangleFileName() not matching its original implementation purpose
   (according to the function description).

B. Drop change C in PATCH v1 7/7. It is reasonable for function
   SetFileInfo() to handle the expected value for the input parameters.

C. Refine the log message for PATCH v1 7/7.


V1 history:

This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe
for:

A. Refine asserts used for memory allocation failure and error cases that
   are possible to happen. Will use error handling logic for them;

B. Address some dead codes within this module.

Cc: Paulo Alcantara <palcantara@suse.de>
Cc: Paulo Alcantara <paulo@paulo.ac>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>

Hao Wu (6):
  MdeModulePkg/UdfDxe: Use error handling for memory allocation failure
  MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref
  MdeModulePkg/UdfDxe: Use error handling when fail to return LSN
  MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen()
  MdeModulePkg/UdfDxe: Handle dead codes in File.c
  MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c

 MdeModulePkg/Universal/Disk/UdfDxe/File.c                 |  19 ++-
 MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 158 +++++++++++++++-----
 2 files changed, 138 insertions(+), 39 deletions(-)

-- 
2.12.0.windows.1



             reply	other threads:[~2018-10-16  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  8:14 Hao Wu [this message]
2018-10-16  8:14 ` [PATCH v2 1/6] MdeModulePkg/UdfDxe: Use error handling for memory allocation failure Hao Wu
2018-10-16  8:14 ` [PATCH v2 2/6] MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref Hao Wu
2018-10-16  8:14 ` [PATCH v2 3/6] MdeModulePkg/UdfDxe: Use error handling when fail to return LSN Hao Wu
2018-10-16  8:14 ` [PATCH v2 4/6] MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() Hao Wu
2018-10-16  8:14 ` [PATCH v2 5/6] MdeModulePkg/UdfDxe: Handle dead codes in File.c Hao Wu
2018-10-16  8:14 ` [PATCH v2 6/6] MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c Hao Wu
2018-10-17  2:48 ` [PATCH v2 0/6] Code refinements in UdfDxe Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016081442.24236-1-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox