From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Long, Qin" <qin.long@intel.com>
Cc: "Richardson, Brian" <brian.richardson@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [staging/MicroPythonTestFramework]: MicroPython Test Framework for UEFI
Date: Sat, 20 Oct 2018 11:09:33 +0100 [thread overview]
Message-ID: <20181020100933.bglpjpykvg5xbqdg@bivouac.eciton.net> (raw)
In-Reply-To: <80AC2BAA3152784F98F581129E5CF5AFBAA5BA28@ORSMSX114.amr.corp.intel.com>
Thanks Brian,
Long, could you please
1) Send me the commit hashes of micropython and oniguruma that you
have tested with the overrides?
2) Add a top-level Readme.md to the MicroPythonTestFramework branch,
mentioning yourself as maintainer and the commit hashes of any
external projects used?
Best Regards,
Leif
On Fri, Oct 19, 2018 at 06:18:35AM +0000, Richardson, Brian wrote:
> Leif:
>
> Thank you for your feedback. Long Qin is a good starting contact for MicroPython issues.
>
> There are readme files for the sub-components, but I agree that the missing top-level readme file is an issue.
> https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MpyTestFrameworkPkg
> https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MicroPythonPkg
>
> Thanks … br
> ---
> Brian Richardson, Firmware Ecosystem Development, Intel Software
> brian.richardson@intel.com<mailto:brian.richardson@intel.com> -- @intel_brian (Twitter & WeChat)
> https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson
>
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Friday, October 19, 2018 12:34 AM
> To: Richardson, Brian <brian.richardson@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [staging/MicroPythonTestFramework]: MicroPython Test Framework for UEFI
>
> Hi Brian,
>
> I've started having a look at this, and have a few comments:
> - There is no Readme.md at the top level, as set out in https://github.com/tianocore/edk2-staging/blob/about/README
> Mainly, this means I don't know who I should cc on any comments I have.
> - There have been substantial changes to oniguruma, and the module no longer builds. Can we have exact commit hashes for the two external projects added to the toplevel Readme.md?
> - At least Uefi/modets.c and Uefi/modos.c contain Ia32/X64-specific bits. Could these bits be put in architecture-specific subdirectories?
>
> Regards,
>
> Leif
>
> On 10 August 2018 at 03:44, Richardson, Brian <brian.richardson@intel.com<mailto:brian.richardson@intel.com>> wrote:
> The "MicroPython Test Framework for UEFI" project has been added to edk2-staging for community feedback.
> https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework
>
> This includes a port of MicroPython to UEFI and a test execution environment that can run from the UEFI Shell.
> https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MicroPythonPkg
> https://github.com/tianocore/edk2-staging/tree/MicroPythonTestFramework/MpyTestFrameworkPkg
>
> Additional Info:
> https://github.com/tianocore/tianocore.github.io/wiki/MicroPython-Test-Framework-for-UEFI
>
> Thanks ... br
> ---
> Brian Richardson, Senior Technical Marketing Engineer, Intel Software
> brian.richardson@intel.com<mailto:brian.richardson@intel.com><mailto:brian.richardson@intel.com<mailto:brian.richardson@intel.com>> -- @intel_brian (Twitter & WeChat)
> https://software.intel.com/en-us/meet-the-developers/evangelists/team/brian-richardson
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel
>
next prev parent reply other threads:[~2018-10-20 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 19:44 [staging/MicroPythonTestFramework]: MicroPython Test Framework for UEFI Richardson, Brian
2018-10-19 4:33 ` Leif Lindholm
2018-10-19 6:18 ` Richardson, Brian
2018-10-20 10:09 ` Leif Lindholm [this message]
2018-10-22 3:28 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020100933.bglpjpykvg5xbqdg@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox