public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: yuchenlin@synology.com
To: edk2-devel@lists.01.org
Cc: jordan.l.justen@intel.com, lersek@redhat.com,
	ard.biesheuvel@linaro.org, anthony.perard@citrix.com,
	julien.grall@linaro.org, yuchenlin <yuchenlin@synology.com>
Subject: [PATCH] OvmfPkg: initialize bochs when initializing vmsvga
Date: Tue, 23 Oct 2018 10:40:57 +0800	[thread overview]
Message-ID: <20181023024057.21942-1-yuchenlin@synology.com> (raw)

From: yuchenlin <yuchenlin@synology.com>

When driver doesn't set fifo config, the vmsvga will fall back
to std vga. However, we don't initialize vbe related port. It
causes blank screen in qemu console.

This patch will fix "Guest has not initialized the display (yet)"
when using qemu -device vmware-svga with ovmf.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin <yuchenlin@synology.com>
---
 OvmfPkg/QemuVideoDxe/Driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/OvmfPkg/QemuVideoDxe/Driver.c b/OvmfPkg/QemuVideoDxe/Driver.c
index 0dce80e59..255c01881 100644
--- a/OvmfPkg/QemuVideoDxe/Driver.c
+++ b/OvmfPkg/QemuVideoDxe/Driver.c
@@ -1067,8 +1067,7 @@ InitializeVmwareSvgaGraphicsMode (
 
   VmwareSvgaWrite (Private, VmwareSvgaRegEnable, 1);
 
-  SetDefaultPalette (Private);
-  ClearScreen (Private);
+  InitializeBochsGraphicsMode (Private, ModeData);
 }
 
 EFI_STATUS
-- 
2.18.0



             reply	other threads:[~2018-10-23  2:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  2:40 yuchenlin [this message]
2018-10-23 10:18 ` [PATCH] OvmfPkg: initialize bochs when initializing vmsvga Laszlo Ersek
2018-10-23 11:12   ` yuchenlin
2018-10-23 12:45     ` Laszlo Ersek
2018-10-23 13:42       ` Gerd Hoffmann
2018-10-23 14:02         ` Laszlo Ersek
2018-10-24  1:33           ` yuchenlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181023024057.21942-1-yuchenlin@synology.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox