From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=kraxel@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 12F662117AE61 for ; Wed, 24 Oct 2018 02:16:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE46FBCD4A; Wed, 24 Oct 2018 09:16:16 +0000 (UTC) Received: from lupin.home.kraxel.org (ovpn-117-121.ams2.redhat.com [10.36.117.121]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D50A5DA67; Wed, 24 Oct 2018 09:16:16 +0000 (UTC) Received: by lupin.home.kraxel.org (Postfix, from userid 1000) id CF4BD6114B45; Wed, 24 Oct 2018 11:16:13 +0200 (CEST) Date: Wed, 24 Oct 2018 11:16:13 +0200 From: Gerd Hoffmann To: yuchenlin@synology.com Cc: edk2-devel@lists.01.org, jordan.l.justen@intel.com, lersek@redhat.com, ard.biesheuvel@linaro.org, anthony.perard@citrix.com, julien.grall@linaro.org, phil@philjordan.eu Message-ID: <20181024091613.ldkvwawwslgd34ud@lupin.home.kraxel.org> References: <20181024064008.26535-1-yuchenlin@synology.com> <20181024064008.26535-5-yuchenlin@synology.com> MIME-Version: 1.0 In-Reply-To: <20181024064008.26535-5-yuchenlin@synology.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 24 Oct 2018 09:16:17 +0000 (UTC) Subject: Re: [PATCH 4/4] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 09:16:18 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 24, 2018 at 02:40:08PM +0800, yuchenlin@synology.com wrote: > From: yuchenlin > > BAR | std vga | vmsvga > --------------------------------- > 0 | Framebuffer | I/O space > 1 | Reserved | Framebuffer > 2 | MMIO | FIFO > > Because of the PCI BARs difference between std vga and > vmsvga, we can not simply recognize the "QEMU VMWare SVGA" > as the QEMU_VIDEO_BOCHS_MMIO variant. > > Instead, we remain variant QEMU_VIDEO_VMWARE_SVGA, and use > it for: > > (1) Get framebuffer from correct PCI BAR > (2) Prevent using BAR2 for MMIO looks good to me. seavgabios uses the same logic. cheers, Gerd