From: Eric Dong <eric.dong@intel.com>
To: edk2-devel@lists.01.org
Cc: Dandan Bi <dandan.bi@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: [Patch 3/6] UefiCpuPkg/RegisterCpuFeaturesLib: Fix ECC issues.
Date: Thu, 25 Oct 2018 10:25:58 +0800 [thread overview]
Message-ID: <20181025022601.25136-4-eric.dong@intel.com> (raw)
In-Reply-To: <20181025022601.25136-1-eric.dong@intel.com>
Changes include:
1. Remove extra white space at the end of line.
2. Add comments for the new add function parameter.
3. Update IN OUT tag for function parameter.
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
.../PeiRegisterCpuFeaturesLib.c | 2 ++
.../RegisterCpuFeaturesLib.c | 24 +++++++++++-----------
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
index a688e03152..4bab2837cc 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.c
@@ -146,6 +146,8 @@ GetProcessorInformation (
@param[in] Procedure A pointer to the function to be run on
enabled APs of the system.
+ @param[in] MpEvent The Event used to sync the result.
+
**/
VOID
StartupAPsWorker (
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
index 5b49bc4504..b6e108b8ad 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
@@ -160,7 +160,7 @@ DetectFeatureScope (
/**
Clear dependence for the specified type.
- @param[in] CurrentFeature Cpu feature need to clear.
+ @param[in] CpuFeature Cpu feature need to clear.
@param[in] Before Before or after dependence relationship.
**/
@@ -202,14 +202,14 @@ ClearFeatureScope (
/**
Base on dependence relationship to asjust feature dependence.
- ONLY when the feature before(or after) the find feature also has
+ ONLY when the feature before(or after) the find feature also has
dependence with the find feature. In this case, driver need to base
on dependce relationship to decide how to insert current feature and
adjust the feature dependence.
- @param[in] PreviousFeature CPU feature current before the find one.
- @param[in] CurrentFeature Cpu feature need to adjust.
- @param[in] Before Before or after dependence relationship.
+ @param[in, out] PreviousFeature CPU feature current before the find one.
+ @param[in, out] CurrentFeature Cpu feature need to adjust.
+ @param[in] Before Before or after dependence relationship.
@retval TRUE means the current feature dependence has been adjusted.
@@ -239,7 +239,7 @@ AdjustFeaturesDependence (
}
//
- // If both feature have dependence, keep the one which needs use more
+ // If both feature have dependence, keep the one which needs use more
// processors and clear the dependence for the other one.
//
if (PreDependType >= CurrentDependType) {
@@ -254,10 +254,10 @@ AdjustFeaturesDependence (
/**
Base on dependence relationship to asjust feature order.
- @param[in] FeatureList Pointer to CPU feature list
- @param[in] FindEntry The entry this feature depend on.
- @param[in] CurrentEntry The entry for this feature.
- @param[in] Before Before or after dependence relationship.
+ @param[in] FeatureList Pointer to CPU feature list
+ @param[in, out] FindEntry The entry this feature depend on.
+ @param[in, out] CurrentEntry The entry for this feature.
+ @param[in] Before Before or after dependence relationship.
**/
VOID
@@ -279,8 +279,8 @@ AdjustEntry (
// base on dependence type of feature A and B to update the logic here.
// For example, feature A has package type dependence and feature B has core type dependence,
// because package type dependence need to wait for more processors which has strong dependence
- // than core type dependence. So driver will adjust the feature order to B -> A -> C. and driver
- // will remove the feature dependence in feature B.
+ // than core type dependence. So driver will adjust the feature order to B -> A -> C. and driver
+ // will remove the feature dependence in feature B.
// Driver just needs to make sure before feature C been executed, feature A has finished its task
// in all all thread. Feature A finished in all threads also means feature B have finshed in all
// threads.
--
2.15.0.windows.1
next prev parent reply other threads:[~2018-10-25 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 2:25 [Patch 0/6] Fix coding style issues Eric Dong
2018-10-25 2:25 ` [Patch 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure for VS2012 and GCC49 Eric Dong
2018-10-25 2:25 ` [Patch 2/6] UefiCpuPkg/CpuCommonFeaturesLib: Remove white space at line end Eric Dong
2018-10-25 2:25 ` Eric Dong [this message]
2018-10-25 2:25 ` [Patch 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: " Eric Dong
2018-10-25 2:26 ` [Patch 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Clean up useless code Eric Dong
2018-10-25 5:50 ` Ni, Ruiyu
2018-10-25 2:26 ` [Patch 6/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix build failure for VS2012 and GCC49 Eric Dong
2018-10-25 5:50 ` [Patch 0/6] Fix coding style issues Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025022601.25136-4-eric.dong@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox