* [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
@ 2018-10-26 1:57 Liming Gao
2018-10-26 3:28 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Liming Gao @ 2018-10-26 1:57 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng
SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
defined in MdeModulePkg.dec for IA32 and X64 only.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/MdeModulePkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index 2465d39..e88516d 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -120,6 +120,8 @@
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
+
+[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
[LibraryClasses.common.DXE_CORE]
--
2.10.0.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
2018-10-26 1:57 [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch Liming Gao
@ 2018-10-26 3:28 ` Zeng, Star
2018-10-26 3:43 ` Gao, Liming
0 siblings, 1 reply; 5+ messages in thread
From: Zeng, Star @ 2018-10-26 3:28 UTC (permalink / raw)
To: Liming Gao, edk2-devel; +Cc: star.zeng
On 2018/10/26 9:57, Liming Gao wrote:
> SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
> defined in MdeModulePkg.dec for IA32 and X64 only.
Could we explain more in the commit log about why this change is not
needed before but required now?
Thanks,
Star
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dsc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 2465d39..e88516d 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -120,6 +120,8 @@
> HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> +
> +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
> LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
>
> [LibraryClasses.common.DXE_CORE]
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
2018-10-26 3:28 ` Zeng, Star
@ 2018-10-26 3:43 ` Gao, Liming
2018-10-26 4:28 ` Zeng, Star
0 siblings, 1 reply; 5+ messages in thread
From: Gao, Liming @ 2018-10-26 3:43 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Star:
Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF. But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure PCD value in the early phase. With this change, SmmLockBoxPeiLib library instance can't be used for EBC arch. This patch fixes it.
Thanks
Liming
> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, October 26, 2018 11:29 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
>
> On 2018/10/26 9:57, Liming Gao wrote:
> > SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this PCD is
> > defined in MdeModulePkg.dec for IA32 and X64 only.
>
> Could we explain more in the commit log about why this change is not
> needed before but required now?
>
> Thanks,
> Star
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> > MdeModulePkg/MdeModulePkg.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> > index 2465d39..e88516d 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -120,6 +120,8 @@
> > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> > +
> > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
> > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
> >
> > [LibraryClasses.common.DXE_CORE]
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
2018-10-26 3:43 ` Gao, Liming
@ 2018-10-26 4:28 ` Zeng, Star
2018-10-26 5:05 ` Gao, Liming
0 siblings, 1 reply; 5+ messages in thread
From: Zeng, Star @ 2018-10-26 4:28 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Zeng, Star
Liming,
I saw MdeModulePkg only builds MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf at EBC arch.
You mean even the *unused* library INF files will be considered? Why? Sorry I am still confused.
Thanks,
Star
-----Original Message-----
From: Gao, Liming
Sent: Friday, October 26, 2018 11:43 AM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
Star:
Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF. But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure PCD value in the early phase. With this change, SmmLockBoxPeiLib library instance can't be used for EBC arch. This patch fixes it.
Thanks
Liming
> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, October 26, 2018 11:29 AM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib
> library instance for IA32/X64 arch
>
> On 2018/10/26 9:57, Liming Gao wrote:
> > SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this
> > PCD is defined in MdeModulePkg.dec for IA32 and X64 only.
>
> Could we explain more in the commit log about why this change is not
> needed before but required now?
>
> Thanks,
> Star
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > ---
> > MdeModulePkg/MdeModulePkg.dsc | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc index 2465d39..e88516d 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -120,6 +120,8 @@
> > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> >
> > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/Pe
> > iExtractGuidedSectionLib.inf
> > +
> > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
> >
> > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
> >
> > [LibraryClasses.common.DXE_CORE]
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
2018-10-26 4:28 ` Zeng, Star
@ 2018-10-26 5:05 ` Gao, Liming
0 siblings, 0 replies; 5+ messages in thread
From: Gao, Liming @ 2018-10-26 5:05 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
BaseTools collects PCD information in early phase in order to prepare StrucutrePcd value. At this point, it doesn't know whether the library inf is used or not. So, it checks PCD from all INF files listed in DSC/FDF. This is a behavior change. I don't realize that the unused library INF SmmLockBoxPeiLib is listed in common arch. So, BaseTools behavior change causes the build break in MdeModulePkg EBC Arch. Because this change causes the real impact, we will update this change to keep the original behavior. Then, start new topic on check the unused INF files in DSC/FDF.
Thanks
Liming
> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, October 26, 2018 12:29 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: RE: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
>
> Liming,
>
> I saw MdeModulePkg only builds MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf at EBC arch.
> You mean even the *unused* library INF files will be considered? Why? Sorry I am still confused.
>
> Thanks,
> Star
> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, October 26, 2018 11:43 AM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch
>
> Star:
> Yes. BaseTools commit 51d17bb7b0da0d9c9e91c226f1982d7020f43795 will collect PCD information from all INF files list in DSC/FDF.
> But before, only the used library INF files are considered. This change is to decide which PCD is really used, then generate the structure
> PCD value in the early phase. With this change, SmmLockBoxPeiLib library instance can't be used for EBC arch. This patch fixes it.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Zeng, Star
> > Sent: Friday, October 26, 2018 11:29 AM
> > To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> > Cc: Zeng, Star <star.zeng@intel.com>
> > Subject: Re: [edk2] [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib
> > library instance for IA32/X64 arch
> >
> > On 2018/10/26 9:57, Liming Gao wrote:
> > > SmmLockBoxPeiLib.inf depends on PcdDxeIplSwitchToLongMode. But, this
> > > PCD is defined in MdeModulePkg.dec for IA32 and X64 only.
> >
> > Could we explain more in the commit log about why this change is not
> > needed before but required now?
> >
> > Thanks,
> > Star
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > > Cc: Star Zeng <star.zeng@intel.com>
> > > ---
> > > MdeModulePkg/MdeModulePkg.dsc | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > > b/MdeModulePkg/MdeModulePkg.dsc index 2465d39..e88516d 100644
> > > --- a/MdeModulePkg/MdeModulePkg.dsc
> > > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > > @@ -120,6 +120,8 @@
> > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> > > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
> > >
> > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/Pe
> > > iExtractGuidedSectionLib.inf
> > > +
> > > +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM]
> > >
> > > LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
> > >
> > > [LibraryClasses.common.DXE_CORE]
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-26 5:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-26 1:57 [Patch] MdeModulePkg: Specify SmmLockBoxPeiLib library instance for IA32/X64 arch Liming Gao
2018-10-26 3:28 ` Zeng, Star
2018-10-26 3:43 ` Gao, Liming
2018-10-26 4:28 ` Zeng, Star
2018-10-26 5:05 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox