* [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. @ 2018-10-27 9:09 Eric Dong 2018-10-27 14:30 ` Gao, Liming 2018-10-29 11:34 ` Leif Lindholm 0 siblings, 2 replies; 4+ messages in thread From: Eric Dong @ 2018-10-27 9:09 UTC (permalink / raw) To: edk2-devel; +Cc: Liming Gao, Dandan Bi Cc: Liming Gao <liming.gao@intel.com> Cc: Dandan Bi <dandan.bi@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eric Dong <eric.dong@intel.com> --- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +- UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h index b5fe8fbce1..b4c8ab777e 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE DetectFeatureScope ( IN CPU_FEATURES_ENTRY *CpuFeature, IN BOOLEAN Before, - IN CHAR8 *NextCpuFeatureMask + IN UINT8 *NextCpuFeatureMask ); /** diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 9a66bc49ff..394695baf2 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE DetectFeatureScope ( IN CPU_FEATURES_ENTRY *CpuFeature, IN BOOLEAN Before, - IN CHAR8 *NextCpuFeatureMask + IN UINT8 *NextCpuFeatureMask ) { // -- 2.16.2.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. 2018-10-27 9:09 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure Eric Dong @ 2018-10-27 14:30 ` Gao, Liming 2018-10-29 11:34 ` Leif Lindholm 1 sibling, 0 replies; 4+ messages in thread From: Gao, Liming @ 2018-10-27 14:30 UTC (permalink / raw) To: Dong, Eric, edk2-devel@lists.01.org; +Cc: Bi, Dandan Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: Dong, Eric > Sent: Saturday, October 27, 2018 5:09 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com> > Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. > > Cc: Liming Gao <liming.gao@intel.com> > Cc: Dandan Bi <dandan.bi@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong <eric.dong@intel.com> > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > index b5fe8fbce1..b4c8ab777e 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > IN CPU_FEATURES_ENTRY *CpuFeature, > IN BOOLEAN Before, > - IN CHAR8 *NextCpuFeatureMask > + IN UINT8 *NextCpuFeatureMask > ); > > /** > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > index 9a66bc49ff..394695baf2 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > IN CPU_FEATURES_ENTRY *CpuFeature, > IN BOOLEAN Before, > - IN CHAR8 *NextCpuFeatureMask > + IN UINT8 *NextCpuFeatureMask > ) > { > // > -- > 2.16.2.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. 2018-10-27 9:09 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure Eric Dong 2018-10-27 14:30 ` Gao, Liming @ 2018-10-29 11:34 ` Leif Lindholm 2018-10-29 23:40 ` Dong, Eric 1 sibling, 1 reply; 4+ messages in thread From: Leif Lindholm @ 2018-10-29 11:34 UTC (permalink / raw) To: Eric Dong; +Cc: edk2-devel, Dandan Bi, Liming Gao Hi Eric, This has already been pushed, but for future similar fixes, please add a commit message specifying: - What failed. - Why it failed. - For which targets. - Versions of toolchain where the failure has been observed. (This does not need to be exhaustive, just mention where the failure has been seen.) Best Regards, Leif On Sat, Oct 27, 2018 at 05:09:21PM +0800, Eric Dong wrote: > Cc: Liming Gao <liming.gao@intel.com> > Cc: Dandan Bi <dandan.bi@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong <eric.dong@intel.com> > --- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > index b5fe8fbce1..b4c8ab777e 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > IN CPU_FEATURES_ENTRY *CpuFeature, > IN BOOLEAN Before, > - IN CHAR8 *NextCpuFeatureMask > + IN UINT8 *NextCpuFeatureMask > ); > > /** > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > index 9a66bc49ff..394695baf2 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > IN CPU_FEATURES_ENTRY *CpuFeature, > IN BOOLEAN Before, > - IN CHAR8 *NextCpuFeatureMask > + IN UINT8 *NextCpuFeatureMask > ) > { > // > -- > 2.16.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure. 2018-10-29 11:34 ` Leif Lindholm @ 2018-10-29 23:40 ` Dong, Eric 0 siblings, 0 replies; 4+ messages in thread From: Dong, Eric @ 2018-10-29 23:40 UTC (permalink / raw) To: Leif Lindholm; +Cc: edk2-devel@lists.01.org, Bi, Dandan, Gao, Liming Hi Leif, Got it. Will follow this rule when met similar case next time, Thanks. Thanks, Eric > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Monday, October 29, 2018 7:34 PM > To: Dong, Eric <eric.dong@intel.com> > Cc: edk2-devel@lists.01.org; Bi, Dandan <dandan.bi@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: Re: [edk2] [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC > build failure. > > Hi Eric, > > This has already been pushed, but for future similar fixes, please add a > commit message specifying: > - What failed. > - Why it failed. > - For which targets. > - Versions of toolchain where the failure has been observed. (This > does not need to be exhaustive, just mention where the failure has > been seen.) > > Best Regards, > > Leif > > On Sat, Oct 27, 2018 at 05:09:21PM +0800, Eric Dong wrote: > > Cc: Liming Gao <liming.gao@intel.com> > > Cc: Dandan Bi <dandan.bi@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Eric Dong <eric.dong@intel.com> > > --- > > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 > +- > > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | > > 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > index b5fe8fbce1..b4c8ab777e 100644 > > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h > > @@ -203,7 +203,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > > IN CPU_FEATURES_ENTRY *CpuFeature, > > IN BOOLEAN Before, > > - IN CHAR8 *NextCpuFeatureMask > > + IN UINT8 *NextCpuFeatureMask > > ); > > > > /** > > diff --git > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > index 9a66bc49ff..394695baf2 100644 > > --- > > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > > +++ > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib > > +++ .c > > @@ -125,7 +125,7 @@ CPU_FEATURE_DEPENDENCE_TYPE > DetectFeatureScope ( > > IN CPU_FEATURES_ENTRY *CpuFeature, > > IN BOOLEAN Before, > > - IN CHAR8 *NextCpuFeatureMask > > + IN UINT8 *NextCpuFeatureMask > > ) > > { > > // > > -- > > 2.16.2.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-29 23:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-27 9:09 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix GCC build failure Eric Dong 2018-10-27 14:30 ` Gao, Liming 2018-10-29 11:34 ` Leif Lindholm 2018-10-29 23:40 ` Dong, Eric
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox