public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Songpeng Li <songpeng.li@intel.com>
Cc: edk2-devel@lists.01.org, Ye Ting <ting.ye@intel.com>,
	Fu Siyuan <siyuan.fu@intel.com>, Wu Jiaxin <jiaxin.wu@intel.com>
Subject: Re: [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver
Date: Mon, 29 Oct 2018 11:40:14 +0000	[thread overview]
Message-ID: <20181029114014.mr44nd673siy6w5x@bivouac.eciton.net> (raw)
In-Reply-To: <20181029015326.8528-1-songpeng.li@intel.com>

Hi Songpeng,

On Mon, Oct 29, 2018 at 09:53:22AM +0800, Songpeng Li wrote:
> Please refer to the log message of each commit for more details.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1278
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Songpeng Li (4):
>   MdeModulePkg: Add Tag Protocol for PxeBc Driver Conflict Detection.
>   MdeModulePkg/UefiPxeBcDxe: Add Conflict Detection Process.
>   NetworkPkg/UefiPxeBcDxe: Add Conflict Detection Process.
>   NetworkPkg/TcpDxe: Modify the Version of Driver Binding Protocol
> 
>  MdeModulePkg/Include/Protocol/PxeBcTag.h      | 26 ++++++++++++
>  MdeModulePkg/MdeModulePkg.dec                 |  5 +++
>  .../Network/UefiPxeBcDxe/PxeBcDriver.c        | 19 ++++++++-
>  .../Network/UefiPxeBcDxe/PxeBcImpl.h          |  3 +-
>  .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf     |  1 +

Can you ensure you use the options specified in
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
when generating your patches?

This way we don't need to guess which files are being modified when
looking at the summary. And it sorts the files modified by decreasing
level of abstraction - so we (for example) see changes to structs
before we see changes to how structs are used.

(This comment does not in itself motivate a v2.)

Best Regards,

Leif

>  NetworkPkg/TcpDxe/TcpDriver.c                 |  4 +-
>  NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c         | 42 ++++++++++++++++++-
>  NetworkPkg/UefiPxeBcDxe/PxeBcImpl.h           |  1 +
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf      |  1 +
>  9 files changed, 96 insertions(+), 6 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Protocol/PxeBcTag.h
>
> -- 
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2018-10-29 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29  1:53 [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver Songpeng Li
2018-10-29  1:53 ` [PATCH 1/4] MdeModulePkg: Add Tag Protocol for PxeBc Driver Conflict Detection Songpeng Li
2018-10-29  1:53 ` [PATCH 2/4] MdeModulePkg/UefiPxeBcDxe: Add Conflict Detection Process Songpeng Li
2018-10-29  3:14   ` Fu, Siyuan
2018-10-29  1:53 ` [PATCH 3/4] NetworkPkg/UefiPxeBcDxe: " Songpeng Li
2018-10-29  1:53 ` [PATCH 4/4] NetworkPkg/TcpDxe: Modify the Version of Driver Binding Protocol Songpeng Li
2018-10-29 11:40 ` Leif Lindholm [this message]
2018-10-30  2:22   ` [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver Li, Songpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029114014.mr44nd673siy6w5x@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox