From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE3192117D761 for ; Mon, 29 Oct 2018 04:40:18 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id p2-v6so7584717wmc.2 for ; Mon, 29 Oct 2018 04:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8wmAyuSwcEBMIj4Qwh7D+ERdrU7HqUkJVi//O2pdI3A=; b=bWc4NGClhcfKvU5aJh3ccRY6L7H3SCabfAoMzoxIkdMSe/jO/6NU1CIJ9ipezsZBE8 rmChwVGdTGK9FWejNv+NVOoPauuDwBJfOJbhWix6fvLd32SCsGlMsfPnL1WAuYAIwb0i Y8i9Y08n/NeG7NQqxbFmj2supgDNocOTGJ0Zs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8wmAyuSwcEBMIj4Qwh7D+ERdrU7HqUkJVi//O2pdI3A=; b=TLvh53Jxv3XSlwb5KNDVdd2RHVgKb0cOOwx2lRW3WxeyMPWRg+/3Qm7tDOjZnSrHfr neHw/p2rg3SoTB+EM8BaGM2butVXokk7zuFJ6C9YDKwJkTmz/CmvgaupVkQ5BpEEAdfK MgOFgNKjC1cW9+6PG3NaFzCBSvx12CNZe8G0fNgfTThL4dBOBVNpE8ilYLZMBG3y3W8A Nti6cLz0sm98g/YozGvwhC8IQShEe7PWbh3cDsFkpKGQXf69VEGRbRy7VMAULPbRGbbQ fGanUne0wv2MGCFaiw+ICIgJRzOdlvwRqToNbh55F1T8c1V1fiKm6TQbsPIiPMzzt/Xy FVRg== X-Gm-Message-State: AGRZ1gL7IufrnJx45FWhCJnqbPxdyRQZGPL/1GC8A9KWNBZH+WUF47HF mYzww0B1yhbPO7fHgGjgqzSJJQ== X-Google-Smtp-Source: AJdET5c/pnt71RLpP3UHYhJHsC5OwiD5ae1GPpONCDiJrMgnSHxdrgBvu/MrudELoXR1ZXCQdkoRPw== X-Received: by 2002:a1c:3c82:: with SMTP id j124-v6mr12508265wma.62.1540813216807; Mon, 29 Oct 2018 04:40:16 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f18-v6sm12898887wre.86.2018.10.29.04.40.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 04:40:15 -0700 (PDT) Date: Mon, 29 Oct 2018 11:40:14 +0000 From: Leif Lindholm To: Songpeng Li Cc: edk2-devel@lists.01.org, Ye Ting , Fu Siyuan , Wu Jiaxin Message-ID: <20181029114014.mr44nd673siy6w5x@bivouac.eciton.net> References: <20181029015326.8528-1-songpeng.li@intel.com> MIME-Version: 1.0 In-Reply-To: <20181029015326.8528-1-songpeng.li@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 0/4] Conflict Detection for Tcp and PxeBc Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 11:40:19 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Songpeng, On Mon, Oct 29, 2018 at 09:53:22AM +0800, Songpeng Li wrote: > Please refer to the log message of each commit for more details. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1278 > Cc: Ye Ting > Cc: Wu Jiaxin > Cc: Fu Siyuan > Songpeng Li (4): > MdeModulePkg: Add Tag Protocol for PxeBc Driver Conflict Detection. > MdeModulePkg/UefiPxeBcDxe: Add Conflict Detection Process. > NetworkPkg/UefiPxeBcDxe: Add Conflict Detection Process. > NetworkPkg/TcpDxe: Modify the Version of Driver Binding Protocol > > MdeModulePkg/Include/Protocol/PxeBcTag.h | 26 ++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 5 +++ > .../Network/UefiPxeBcDxe/PxeBcDriver.c | 19 ++++++++- > .../Network/UefiPxeBcDxe/PxeBcImpl.h | 3 +- > .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 1 + Can you ensure you use the options specified in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 when generating your patches? This way we don't need to guess which files are being modified when looking at the summary. And it sorts the files modified by decreasing level of abstraction - so we (for example) see changes to structs before we see changes to how structs are used. (This comment does not in itself motivate a v2.) Best Regards, Leif > NetworkPkg/TcpDxe/TcpDriver.c | 4 +- > NetworkPkg/UefiPxeBcDxe/PxeBcDriver.c | 42 ++++++++++++++++++- > NetworkPkg/UefiPxeBcDxe/PxeBcImpl.h | 1 + > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 1 + > 9 files changed, 96 insertions(+), 6 deletions(-) > create mode 100644 MdeModulePkg/Include/Protocol/PxeBcTag.h > > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel