From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF8882117D76A for ; Mon, 29 Oct 2018 04:43:09 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id i17-v6so8260295wre.7 for ; Mon, 29 Oct 2018 04:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HpPb0nsFcZloXt3ZuCiJ19CN06e4IcUkvqxsqGBUO6U=; b=afwTghSWpXq77Sy89+YJPBESKxnBnxGPAT8fgUNBeMj+51U2iMrJZ9PPyfowuBN0AJ i1xfQz/hBe7u5HknJ+l0HdwQ3X0/OYKoUlbzCRooUXYnSjbcY34gUhYqgBKZyGxgCIxr tDuiXoFd7P9H/znSkeTJAOO+LYD9EDXFTt9yU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HpPb0nsFcZloXt3ZuCiJ19CN06e4IcUkvqxsqGBUO6U=; b=dm9HPCrQELkCeTRx1jOSlkdH0siy1INdKqip7kIUOsAbZTriU3kAkAxzcUdeiE8FoB RIj3QqV68qBPpgZH3HShI17Aow/rPpMS7ESQH6hvUcpxC1a71klSvBXc8gfXOq/IpAtB JVmRdSXAHB/CJFd8z3uCHaqFoOvBtwGlk53EsRgb3334PmBwQPqlskPBN0dEl7IpBoyt Y4RuiSMKnp44fUbfAGg73MViZyQd6y34WQLhmlXyul0QdjjdxmlW7LLdj6R/twBIZPP9 wwgmfAZy5cDPEtu9tWJLQhW/lUU9dPXMKuBXGDbXVSiklRaih7m6KEU0cdWV8jzhhw8M n6DA== X-Gm-Message-State: AGRZ1gLaHeD0oNGhlFSodp31OTorHUNyEhRVIgpc2lXarwRgkPhvYyD1 zuh7JhmMQOcY4B0kgmu4QqOyZA== X-Google-Smtp-Source: AJdET5eSWN9vPEkrRWNvKTZI1sliJon31zHMS8ME7mqkOUTiKm8TgDPn/K33fwaAa18jwON0XGeUiQ== X-Received: by 2002:a5d:47d2:: with SMTP id l18-v6mr15422569wrs.319.1540813388350; Mon, 29 Oct 2018 04:43:08 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o17-v6sm30900585wro.2.2018.10.29.04.43.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 04:43:06 -0700 (PDT) Date: Mon, 29 Oct 2018 11:43:05 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181029114305.iixbeg2u7rel5gyq@bivouac.eciton.net> References: <20181029033249.45363-1-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181029033249.45363-1-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 11:43:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ming, On Mon, Oct 29, 2018 at 11:32:37AM +0800, Ming Huang wrote: > The major features of this patchset include: > 1. Modify acpi table for ACS test; > 2. Enable secure boot for SBBR-SCT; > 3. Other change for ACS test; > > For this SCT issue: > RT.SetVariable - Create one Time Base Auth Variable, the expect return status > should be EFI_SUCCESS – FAILURE > > The resule of fail is effected by the edk2 commit(67943427). > If Modify Variable.c as below, this case will pass. > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -3188,7 +3188,7 @@ VariableServiceSetVariable ( > // Maybe it's the delete operation of common authenticated variable at > // user physical presence. > // > if (DataSize != AUTHINFO_SIZE) { > - return EFI_UNSUPPORTED; > + return EFI_SECURITY_VIOLATION; > > I supect ACS SCT compatible with UEFI 2.7 spec. We will analyze this issue > continue. > > Code can also be found in github: > https://github.com/hisilicon/OpenPlatformPkg.git > branch: d06-acs-platforms > > > Ming Huang (12): > Silicon/Hisilicon/D06: Add watchdog to GTDT > Silicon/Hisilicon/D06: Drop _CID for fwts issue > Silicon/Hisilicon/D06: Fix fwts issue in Dbg2 > Silicon/Hisilicon/D06: Fix fwts issue in FADT > Hisilicon/D06: Move some functions to OemMiscLib > Silicon/Hisilicon: Modify for SBBR fwts SetTime_Func test case > Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe > Hisilicon/D06: Fix SBBR-SCT AuthVar issue > Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT > Silicon/Hisilicon/D06: Modify GTDT timer flag > Hisilicon/D06: Modify Gic base > Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot > > Silicon/Hisilicon/HisiPkg.dec | 1 + > Silicon/Hisilicon/Hisilicon.dsc.inc | 16 ++ > Platform/Hisilicon/D03/D03.dsc | 5 + > Platform/Hisilicon/D05/D05.dsc | 5 + > Platform/Hisilicon/D06/D06.dsc | 9 +- > .../Drivers/FlashFvbDxe/FlashFvbDxe.inf | 2 + > .../M41T83RealTimeClockLib.inf | 3 +- > .../Hi1620/Hi1620AcpiTables/Hi1620Platform.h | 2 +- > .../Hisilicon/Include/Library/OemMiscLib.h | 9 + > .../M41T83RealTimeClock.h | 8 +- > .../D06/Library/OemMiscLibD06/OemMiscLibD06.c | 82 ++++++ > .../Drivers/FlashFvbDxe/FlashFvbDxe.c | 14 +- > .../M41T83RealTimeClockLib.c | 263 ++++++++++++------ > .../Hi1620/Hi1620AcpiTables/Dsdt/Com.asl | 1 - > .../Hi1620AcpiTables/Dsdt/Hi1620Mbig.asl | 48 ---- > .../Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 36 ++- > .../Hi1620/Hi1620AcpiTables/Fadt.aslc | 2 +- > .../Hi1620/Hi1620AcpiTables/Gtdt.aslc | 35 +-- > .../Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 +- > .../Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 18 +- > .../Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc | 194 ++++++------- > .../Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- Can you ensure you use the options specified in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 when generating your patches? This way we don't need to guess which files are being modified when looking at the summary. Regards, Leif > 22 files changed, 475 insertions(+), 284 deletions(-) > > -- > 2.18.0 >