From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F26A21BADAB9 for ; Mon, 29 Oct 2018 09:14:11 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id y140-v6so9890563wmd.0 for ; Mon, 29 Oct 2018 09:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=S/dCr9I/tHuNA2A2mNj1qV2oH5fUIE7mwI2QY2ddHqs=; b=UQeU3M1BIAEuH3kompHEl7hKXoy0SAo9av9yS8XT46WiA0mSHoW59MncRQBvqbuAro GZDM9+gz6qC0Peg6HnvotpxFkTUC29b0nU3vPzBrtuGQsWV7BbEwLKx1LuyvhYHzwYNU 8g4jmaZTTruW8RowymJi7Ui0kDqIlhRp9GJdY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=S/dCr9I/tHuNA2A2mNj1qV2oH5fUIE7mwI2QY2ddHqs=; b=dUXkzRpraG0/xyGyo6o33dZ++23zp6FzrpZQ96OIMG++gD8KSXWos5taincLa/YELn EenUoueeTOuMlccvNzf/Ox+SEDPH5hnolbvnya5OcReexgDM16ujlLt+d8+jubIotko0 yls9Rsmm2Rr3k3s0QF5kIQ7ijaJjSv1lPpSqdVzUlfp6Yjziu5N9OMKqAhLM4nZgtxIF 0y/8sTP6z2SdLs2QF1zSg9LTZ7UAHOEVKYJNfeKAwVCyshXQco6T3lPmAEvqhddQx0G2 dOsDmTbYkfd/VE4oB5g5gSC8rnIhKx/h/mLY2xlHN2ndKP/p0m1qRjYbXzFFMqCAsh1L Yr2w== X-Gm-Message-State: AGRZ1gKhN+H/Qu5lWHtmzwUnzVZ4J+kz11z1zIFaR2Flg7V54CRJRtfu tnjOMgsLt1CCiXy9HKbxjEKBMw== X-Google-Smtp-Source: AJdET5cFOtR15V4KQ7/40g/QbGhd6DAt0e0mRfOzJAym6FgfYDV8AUzdGyVbLjYNuy7AUXFaz6bIJA== X-Received: by 2002:a1c:b504:: with SMTP id e4-v6mr13714990wmf.134.1540829649486; Mon, 29 Oct 2018 09:14:09 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 64-v6sm27906074wrr.64.2018.10.29.09.14.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 09:14:07 -0700 (PDT) Date: Mon, 29 Oct 2018 16:14:05 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181029161405.jpem6zmtgf3f6my3@bivouac.eciton.net> References: <20181029033249.45363-1-ming.huang@linaro.org> <20181029114305.iixbeg2u7rel5gyq@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 16:14:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Oct 29, 2018 at 11:01:19PM +0800, Ming Huang wrote: > Hi Leif, > > Yes, I generated this patchset with the same git configuration as previous patchset: > ([PATCH edk2-platforms v5 00/28] Upload for D06 platform) > and use the same command: > git format-patch --stat=1000 --stat-graph-width=20 --cover-letter --no-binary --subject-prefix="PATCH edk2-platforms" -12 -v 1 -o v1 > > I check the URL below, no important different configuration found. > Have problems with this patchset? See below: > Thanks, > Ming > > On 10/29/2018 7:43 PM, Leif Lindholm wrote: > > Hi Ming, > > > > On Mon, Oct 29, 2018 at 11:32:37AM +0800, Ming Huang wrote: > >> The major features of this patchset include: > >> 1. Modify acpi table for ACS test; > >> 2. Enable secure boot for SBBR-SCT; > >> 3. Other change for ACS test; > >> > >> For this SCT issue: > >> RT.SetVariable - Create one Time Base Auth Variable, the expect return status > >> should be EFI_SUCCESS – FAILURE > >> > >> The resule of fail is effected by the edk2 commit(67943427). > >> If Modify Variable.c as below, this case will pass. > >> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > >> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > >> @@ -3188,7 +3188,7 @@ VariableServiceSetVariable ( > >> // Maybe it's the delete operation of common authenticated variable at > >> // user physical presence. > >> // > >> if (DataSize != AUTHINFO_SIZE) { > >> - return EFI_UNSUPPORTED; > >> + return EFI_SECURITY_VIOLATION; > >> > >> I supect ACS SCT compatible with UEFI 2.7 spec. We will analyze this issue > >> continue. > >> > >> Code can also be found in github: > >> https://github.com/hisilicon/OpenPlatformPkg.git > >> branch: d06-acs-platforms > >> > >> > >> Ming Huang (12): > >> Silicon/Hisilicon/D06: Add watchdog to GTDT > >> Silicon/Hisilicon/D06: Drop _CID for fwts issue > >> Silicon/Hisilicon/D06: Fix fwts issue in Dbg2 > >> Silicon/Hisilicon/D06: Fix fwts issue in FADT > >> Hisilicon/D06: Move some functions to OemMiscLib > >> Silicon/Hisilicon: Modify for SBBR fwts SetTime_Func test case > >> Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe > >> Hisilicon/D06: Fix SBBR-SCT AuthVar issue > >> Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT > >> Silicon/Hisilicon/D06: Modify GTDT timer flag > >> Hisilicon/D06: Modify Gic base > >> Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot > >> > >> Silicon/Hisilicon/HisiPkg.dec | 1 + > >> Silicon/Hisilicon/Hisilicon.dsc.inc | 16 ++ > >> Platform/Hisilicon/D03/D03.dsc | 5 + > >> Platform/Hisilicon/D05/D05.dsc | 5 + > >> Platform/Hisilicon/D06/D06.dsc | 9 +- > >> .../Drivers/FlashFvbDxe/FlashFvbDxe.inf | 2 + > >> .../M41T83RealTimeClockLib.inf | 3 +- > >> .../Hi1620/Hi1620AcpiTables/Hi1620Platform.h | 2 +- > >> .../Hisilicon/Include/Library/OemMiscLib.h | 9 + > >> .../M41T83RealTimeClock.h | 8 +- > >> .../D06/Library/OemMiscLibD06/OemMiscLibD06.c | 82 ++++++ > >> .../Drivers/FlashFvbDxe/FlashFvbDxe.c | 14 +- > >> .../M41T83RealTimeClockLib.c | 263 ++++++++++++------ > >> .../Hi1620/Hi1620AcpiTables/Dsdt/Com.asl | 1 - > >> .../Hi1620AcpiTables/Dsdt/Hi1620Mbig.asl | 48 ---- > >> .../Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 36 ++- > >> .../Hi1620/Hi1620AcpiTables/Fadt.aslc | 2 +- > >> .../Hi1620/Hi1620AcpiTables/Gtdt.aslc | 35 +-- > >> .../Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 +- > >> .../Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 18 +- > >> .../Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc | 194 ++++++------- > >> .../Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- These ... suggest --stat=1000 was not used. Can you verify please? Regards, Leif