public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
@ 2018-10-30  3:04 Eric Dong
  2018-10-30  5:00 ` Ni, Ruiyu
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dong @ 2018-10-30  3:04 UTC (permalink / raw)
  To: edk2-devel; +Cc: Dandan Bi, Ruiyu Ni

Build UefiCpuPkg with below configuration:
Architecture(s)  = IA32
Build target     = NOOPT
Toolchain        = VS2015x86

Below error info shows up:
DxeRegisterCpuFeaturesLib.lib(CpuFeaturesInitialize.obj) :
error LNK2001: unresolved external symbol __allmul

Valid mDependTypeStr type only have 5 items, use UINT32 type cast
to fix this error.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
index bc372a338f..8588800e4a 100644
--- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
+++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
@@ -517,7 +517,7 @@ DumpRegisterTableOnProcessor (
         DebugPrintErrorLevel,
         "Processor: %d: Semaphore: Scope Value: %s\r\n",
         ProcessorNumber,
-        mDependTypeStr[MIN (RegisterTableEntry->Value, InvalidDepType)]
+        mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value, InvalidDepType)]
         ));
       break;
 
-- 
2.15.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
  2018-10-30  3:04 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure Eric Dong
@ 2018-10-30  5:00 ` Ni, Ruiyu
  0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ruiyu @ 2018-10-30  5:00 UTC (permalink / raw)
  To: Dong, Eric, edk2-devel@lists.01.org; +Cc: Bi, Dandan

Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Dong, Eric
> Sent: Tuesday, October 30, 2018 11:05 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure.
> 
> Build UefiCpuPkg with below configuration:
> Architecture(s)  = IA32
> Build target     = NOOPT
> Toolchain        = VS2015x86
> 
> Below error info shows up:
> DxeRegisterCpuFeaturesLib.lib(CpuFeaturesInitialize.obj) :
> error LNK2001: unresolved external symbol __allmul
> 
> Valid mDependTypeStr type only have 5 items, use UINT32 type cast to fix
> this error.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> index bc372a338f..8588800e4a 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
> @@ -517,7 +517,7 @@ DumpRegisterTableOnProcessor (
>          DebugPrintErrorLevel,
>          "Processor: %d: Semaphore: Scope Value: %s\r\n",
>          ProcessorNumber,
> -        mDependTypeStr[MIN (RegisterTableEntry->Value, InvalidDepType)]
> +        mDependTypeStr[MIN ((UINT32)RegisterTableEntry->Value,
> + InvalidDepType)]
>          ));
>        break;
> 
> --
> 2.15.0.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-30  5:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30  3:04 [Patch] UefiCpuPkg/RegisterCpuFeaturesLib: Fix build failure Eric Dong
2018-10-30  5:00 ` Ni, Ruiyu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox