From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glin@suse.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=195.135.221.5; helo=smtp.nue.novell.com; envelope-from=glin@suse.com;
 receiver=edk2-devel@lists.01.org 
Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 52C0321A09130
 for <edk2-devel@lists.01.org>; Tue, 30 Oct 2018 00:57:12 -0700 (PDT)
Received: from localhost.localdomain (unknown.telstraglobal.net
 [134.159.103.118]) by smtp.nue.novell.com with ESMTP (NOT encrypted);
 Tue, 30 Oct 2018 08:56:55 +0100
From: Gary Lin <glin@suse.com>
To: edk2-devel@lists.01.org
Cc: David Wei <david.wei@intel.com>, Mang Guo <mang.guo@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
Date: Tue, 30 Oct 2018 15:56:38 +0800
Message-Id: <20181030075638.7173-1-glin@suse.com>
X-Mailer: git-send-email 2.19.0
MIME-Version: 1.0
Subject: [PATCH 1/1] Vlv2TbltDevicePkg/SmBiosMiscDxe: fix the comparison of characters
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2018 07:57:40 -0000
Content-Transfer-Encoding: 8bit

Dereference MatchLang before comparing it with a character.

Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Gary Lin <glin@suse.com>
---
 .../SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
index 7cf3453a62f4..612e1261fdaa 100644
--- a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
+++ b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFunction.c
@@ -73,7 +73,7 @@ CurrentLanguageMatch (
     // Find the best matching RFC 4646 language, compute the offset.
     //
     CompareLength = AsciiStrLen (BestLanguage);
-    for (MatchLang = Languages, (*Offset) = 0; MatchLang != '\0'; (*Offset)++) {
+    for (MatchLang = Languages, (*Offset) = 0; *MatchLang != '\0'; (*Offset)++) {
       //
       // Seek to the end of current match language.
       //
-- 
2.19.0