From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 57FC62117FD72 for ; Tue, 30 Oct 2018 02:37:24 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id s10-v6so10976801wmc.5 for ; Tue, 30 Oct 2018 02:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=/WA11haclkV/XMF0Bnr0c5qGwuadCw5SPmDS1hiikYc=; b=WSMjOe4E4aZjV0A8JzsT8RWVepUP8YGChuztjDT0sDOjjshmyvymQcFaDePWaXz3RY hDxULdK8rlWMp5QvluQJnV+qXCMzxD/hnFQHJfWcwqy0KOiC4ap7V8qdRE4dBCOAif5b XRJzdCc9gN/I6ruEEIIW2NV40qNRE0oo5qB1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=/WA11haclkV/XMF0Bnr0c5qGwuadCw5SPmDS1hiikYc=; b=mho298bubrv8HZvA+gpmNicgf/JxsyiC/6Kk4u5H8WagA1u2nAbQYWRvxOf5K8ysOG ehJTxIDLtqN5gkZaQ2TEb/Vp/TvUxj8NKxc4BWZxf3vif10W0wPns9IFlyBQ0G+veXfj gEkQy2RKRsIwEU5zu3JPxL9H9o+rVG+YPsOilRquP2MTovZbsMNq8INcNs70sjZfnObV HJ/ibadXvUKDzMoD7DMfkb4d7PO/gAqqd+UiSFfgGqGvzm2eiqIlpENAriVKFJgjDWms E3JoGDzJnH5sO9UWkO4QvZtc6R2P1Lw1P+5FGAacsEP/QItbsh9kwHuvBhPc64Gtphvz SfGw== X-Gm-Message-State: AGRZ1gIQqOFA4ZZ9Do4dnRfwA4XGHANU1jUkkeYYR0Nsw7PTRshs8IFe 6/tQ8xrYcNEt8itp0FZVl4UTvw== X-Google-Smtp-Source: AJdET5cF4cEbVmJeNlMn/rTYgmLYf/ifaurEzvgYMks2ZtfjAEkLECbmnS0ZqXOlcNM6yy6euNeScg== X-Received: by 2002:a1c:bb42:: with SMTP id l63-v6mr1092806wmf.32.1540892242624; Tue, 30 Oct 2018 02:37:22 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 4-v6sm4508402wmg.21.2018.10.30.02.37.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Oct 2018 02:37:21 -0700 (PDT) Date: Tue, 30 Oct 2018 09:37:19 +0000 From: Leif Lindholm To: "Huangming (Mark)" Cc: Ming Huang , linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181030093719.xokqeimcy4ufgol7@bivouac.eciton.net> References: <20181029033249.45363-1-ming.huang@linaro.org> <20181029114305.iixbeg2u7rel5gyq@bivouac.eciton.net> <20181029161405.jpem6zmtgf3f6my3@bivouac.eciton.net> <5eaaf9d7-e76b-2e98-f4c8-bb0a27007cfc@huawei.com> MIME-Version: 1.0 In-Reply-To: <5eaaf9d7-e76b-2e98-f4c8-bb0a27007cfc@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 00/12] Fix D06 SBSA/SBBR issue and improve X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 09:37:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ming, I don't know when --stat was introduced, but it was a very long time ago. The oldest version of git I have easily available is 2.1.4, and that handles it properly. Something else must be going on. Regards, Leif On Tue, Oct 30, 2018 at 02:54:42PM +0800, Huangming (Mark) wrote: > Hi Leif, > > The cause of '...' is the git version, it is 2.18.0 in my build server. > I have ask the administrator to upgrade git. > Should I re-send this set(edk2-platforms) with new git version? > > Thanks, > Ming > > On 2018/10/30 0:14, Leif Lindholm wrote: > > On Mon, Oct 29, 2018 at 11:01:19PM +0800, Ming Huang wrote: > >> Hi Leif, > >> > >> Yes, I generated this patchset with the same git configuration as previous patchset: > >> ([PATCH edk2-platforms v5 00/28] Upload for D06 platform) > >> and use the same command: > >> git format-patch --stat=1000 --stat-graph-width=20 --cover-letter --no-binary --subject-prefix="PATCH edk2-platforms" -12 -v 1 -o v1 > >> > >> I check the URL below, no important different configuration found. > >> Have problems with this patchset? > > > > See below: > > > >> Thanks, > >> Ming > >> > >> On 10/29/2018 7:43 PM, Leif Lindholm wrote: > >>> Hi Ming, > >>> > >>> On Mon, Oct 29, 2018 at 11:32:37AM +0800, Ming Huang wrote: > >>>> The major features of this patchset include: > >>>> 1. Modify acpi table for ACS test; > >>>> 2. Enable secure boot for SBBR-SCT; > >>>> 3. Other change for ACS test; > >>>> > >>>> For this SCT issue: > >>>> RT.SetVariable - Create one Time Base Auth Variable, the expect return status > >>>> should be EFI_SUCCESS – FAILURE > >>>> > >>>> The resule of fail is effected by the edk2 commit(67943427). > >>>> If Modify Variable.c as below, this case will pass. > >>>> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > >>>> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > >>>> @@ -3188,7 +3188,7 @@ VariableServiceSetVariable ( > >>>> // Maybe it's the delete operation of common authenticated variable at > >>>> // user physical presence. > >>>> // > >>>> if (DataSize != AUTHINFO_SIZE) { > >>>> - return EFI_UNSUPPORTED; > >>>> + return EFI_SECURITY_VIOLATION; > >>>> > >>>> I supect ACS SCT compatible with UEFI 2.7 spec. We will analyze this issue > >>>> continue. > >>>> > >>>> Code can also be found in github: > >>>> https://github.com/hisilicon/OpenPlatformPkg.git > >>>> branch: d06-acs-platforms > >>>> > >>>> > >>>> Ming Huang (12): > >>>> Silicon/Hisilicon/D06: Add watchdog to GTDT > >>>> Silicon/Hisilicon/D06: Drop _CID for fwts issue > >>>> Silicon/Hisilicon/D06: Fix fwts issue in Dbg2 > >>>> Silicon/Hisilicon/D06: Fix fwts issue in FADT > >>>> Hisilicon/D06: Move some functions to OemMiscLib > >>>> Silicon/Hisilicon: Modify for SBBR fwts SetTime_Func test case > >>>> Hisilicon/D0x: Fix secure boot bug in FlashFvbDxe > >>>> Hisilicon/D06: Fix SBBR-SCT AuthVar issue > >>>> Silicon/Hisilicon/D06: Reserve ECAM resource in DSDT > >>>> Silicon/Hisilicon/D06: Modify GTDT timer flag > >>>> Hisilicon/D06: Modify Gic base > >>>> Silicon/Hisilicon/D06: Set TA as Node 0 for TA boot > >>>> > >>>> Silicon/Hisilicon/HisiPkg.dec | 1 + > >>>> Silicon/Hisilicon/Hisilicon.dsc.inc | 16 ++ > >>>> Platform/Hisilicon/D03/D03.dsc | 5 + > >>>> Platform/Hisilicon/D05/D05.dsc | 5 + > >>>> Platform/Hisilicon/D06/D06.dsc | 9 +- > >>>> .../Drivers/FlashFvbDxe/FlashFvbDxe.inf | 2 + > >>>> .../M41T83RealTimeClockLib.inf | 3 +- > >>>> .../Hi1620/Hi1620AcpiTables/Hi1620Platform.h | 2 +- > >>>> .../Hisilicon/Include/Library/OemMiscLib.h | 9 + > >>>> .../M41T83RealTimeClock.h | 8 +- > >>>> .../D06/Library/OemMiscLibD06/OemMiscLibD06.c | 82 ++++++ > >>>> .../Drivers/FlashFvbDxe/FlashFvbDxe.c | 14 +- > >>>> .../M41T83RealTimeClockLib.c | 263 ++++++++++++------ > >>>> .../Hi1620/Hi1620AcpiTables/Dsdt/Com.asl | 1 - > >>>> .../Hi1620AcpiTables/Dsdt/Hi1620Mbig.asl | 48 ---- > >>>> .../Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 36 ++- > >>>> .../Hi1620/Hi1620AcpiTables/Fadt.aslc | 2 +- > >>>> .../Hi1620/Hi1620AcpiTables/Gtdt.aslc | 35 +-- > >>>> .../Hi1620/Hi1620AcpiTables/Hi1620Dbg2.aslc | 4 +- > >>>> .../Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 18 +- > >>>> .../Hi1620/Hi1620AcpiTables/Hi1620Srat.aslc | 194 ++++++------- > >>>> .../Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- > > > > These ... suggest --stat=1000 was not used. Can you verify please? > > > > Regards, > > > > Leif > > > > . > > > > -- > Best Regards, > > Ming >