From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Fu, Siyuan" <siyuan.fu@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: Reminder for deleting 3 network drivers in MdeModulePkg
Date: Wed, 31 Oct 2018 10:50:04 +0000 [thread overview]
Message-ID: <20181031105003.5vzguraclqhe4bqy@bivouac.eciton.net> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58B678B1F@SHSMSX103.ccr.corp.intel.com>
Hi Fu Siyuan,
That is fine too.
But I expect the change to be one to go in the week after a stable tag
has been made.
(My own philosophy is that one can be quite aggressive with removals,
because if it turns out to have been a bad idea, git revert can
quickly restore the tree to the state it was.)
Best Regards,
Leif
On Wed, Oct 31, 2018 at 02:58:47AM +0000, Fu, Siyuan wrote:
> Hi, Leif
>
> Just notice that you are saying edk2-stable201811 tag.
>
> We need more time to collect community/marketing feedback on
> deleting these driver, so it may won't be able to catch the stable
> tag in next month.
>
> BestRegards
> Fu Siyuan
>
>
> > -----Original Message-----
> > From: Fu, Siyuan
> > Sent: Wednesday, October 31, 2018 8:49 AM
> > To: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: edk2-devel@lists.01.org
> > Subject: RE: [edk2] Reminder for deleting 3 network drivers in
> > MdeModulePkg
> >
> > Hi, Leif
> >
> > I think checking the branch is a little better than the tag, because we
> > may still have critical bug fixes after the official release.
> >
> > While any of them are not recommended, always using the NetworkPkg version
> > driver is the best choice.
> >
> > I will modify the edk2 network wiki page for an updated sample DSC/FDF
> > section, if this patch could pass review w/o objection.
> > https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg-Getting-
> > Started-Guide
> >
> >
> > BestRegards
> > Fu Siyuan
> >
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > > Leif Lindholm
> > > Sent: Tuesday, October 30, 2018 6:47 PM
> > > To: Fu, Siyuan <siyuan.fu@intel.com>
> > > Cc: edk2-devel@lists.01.org
> > > Subject: Re: [edk2] Reminder for deleting 3 network drivers in
> > > MdeModulePkg
> > >
> > > Hi Fu Siyan,
> > >
> > > On Tue, Oct 30, 2018 at 08:11:52AM +0000, Fu, Siyuan wrote:
> > > > People who want to continue use these deleted drivers could go to
> > > > edk2/UDK2018 branch to get them, but it's *highly not recommended*.
> > >
> > > They should also be able to use edk2-stable201811, right?
> > >
> > > > *If you have any opposition on deleting these drivers, please let me
> > > > know before this weekend, thanks.*
> > >
> > > I am all for this change. The diffstat is very nice :)
> > >
> > > Best Regards,
> > >
> > > Leif
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-31 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 8:11 Reminder for deleting 3 network drivers in MdeModulePkg Fu, Siyuan
2018-10-30 10:46 ` Leif Lindholm
2018-10-31 0:49 ` Fu, Siyuan
2018-10-31 2:58 ` Fu, Siyuan
2018-10-31 10:50 ` Leif Lindholm [this message]
2018-11-01 6:01 ` Gao, Liming
2018-11-01 9:01 ` Leif Lindholm
2018-11-02 14:21 ` Gao, Liming
2018-11-02 15:00 ` Andrew Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031105003.5vzguraclqhe4bqy@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox