From: Leif Lindholm <leif.lindholm@linaro.org>
To: "Fu, Siyuan" <siyuan.fu@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Ming Huang <ming.huang@linaro.org>
Subject: Re: [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg.
Date: Wed, 31 Oct 2018 10:59:11 +0000 [thread overview]
Message-ID: <20181031105911.wr3x4crlu2fnfcti@bivouac.eciton.net> (raw)
In-Reply-To: <B1FF2E9001CE9041BD10B825821D5BC58B678719@SHSMSX103.ccr.corp.intel.com>
Hi Fu Siyuan,
Hmm, strange.
Ming Huang (cc) has also had issues with this in his latest set (but
not before). Can you guys work together to try to figure out what is
going wrong?
Can you start by testing with an older version of git?
Best Regards,
Leif
On Wed, Oct 31, 2018 at 12:41:39AM +0000, Fu, Siyuan wrote:
> Hi, Leif
>
> I have followed your wiki page to configure my Git when I generate
> this patch, and I don't know why the files are still unordered and
> truncated. I will do more test and try to figure out the problem.
>
> BestRegards
> Fu Siyuan
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Leif Lindholm
> > Sent: Tuesday, October 30, 2018 6:51 PM
> > To: Fu, Siyuan <siyuan.fu@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in
> > MdeModulePkg.
> >
> > On Tue, Oct 30, 2018 at 03:33:21PM +0800, Fu Siyuan wrote:
> > > This patch series is to delete the Tcp4Dxe, UefiPxeBcDxe and IScsi4Dxe
> > > drivers in MdeModulePkg. These drivers will not be maintained and can't
> > > co-work with the dual-stack drivers in NetworkPkg.
> > >
> > > People should use below NetworkPkg drivers instead:
> > > NetworkPkg/IScsiDxe/IScsiDxe.inf
> > > NetworkPkg/TcpDxe/TcpDxe.inf
> > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > > These drivers are actively maintained with more bug fixes and new
> > feature
> > > support.
> > >
> > > Patch 1~5 update edk2 platform DSC/FDF files to use NetworkPkg drivers.
> > > Patch 6 deletes the TCP,PXE,iSCSI driver in MdeModulePkg.
> > > Patch 7 removes some clarification in NetworkPkg drivers since the
> > > related driver has been deleted in Patch 6.
> > >
> > > Fu Siyuan (7):
> > > Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF.
> > > EmulatorPkg: Replace obsoleted network drivers from platform DSC/FDF.
> > > OvmfPkg: Replace obsoleted network drivers from platform DSC/FDF.
> > > Vlv2TbltDevicePkg: Replace obsoleted drivers from platform DSC/FDF.
> > > ArmVirtPkg: Replace obsoleted network drivers from platform DSC/FDF.
> > > MdeModulePkg: Delete the TCP/PXE/ISCSI drivers in MdeModulePkg.
> > > NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF.
> > >
> > > .../Network/IScsiDxe/ComponentName.c | 283 --
> > > .../Universal/Network/IScsiDxe/IScsiCHAP.c | 430 ---
> > > .../Universal/Network/IScsiDxe/IScsiConfig.c | 1264 -------
> > > .../Universal/Network/IScsiDxe/IScsiDhcp.c | 472 ---
> > > .../Universal/Network/IScsiDxe/IScsiDriver.c | 676 ----
> > > .../Network/IScsiDxe/IScsiExtScsiPassThru.c | 412 ---
> > > .../Universal/Network/IScsiDxe/IScsiIbft.c | 539 ---
> > > .../Network/IScsiDxe/IScsiInitiatorName.c | 116 -
> > > .../Universal/Network/IScsiDxe/IScsiMisc.c | 948 ------
> > > .../Universal/Network/IScsiDxe/IScsiProto.c | 2799 ---------------
> > > .../Universal/Network/IScsiDxe/IScsiTcp4Io.c | 487 ---
> >
> > If there is a v2, can you follow the steps from
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-
> > git-guide-for-edk2-contributors-and-maintainers#contrib-23
> > when generating it, to order the files, and to get rid of the
> > ... truncation of file names?
> >
> > Regards,
> >
> > Leif
> >
> > > MdeModulePkg/Universal/Network/IScsiDxe/Md5.c | 350 --
> > > .../Universal/Network/Tcp4Dxe/ComponentName.c | 433 ---
> > > .../Universal/Network/Tcp4Dxe/SockImpl.c | 1201 -------
> > > .../Universal/Network/Tcp4Dxe/SockInterface.c | 990 ------
> > > .../Network/Tcp4Dxe/Tcp4Dispatcher.c | 717 ----
> > > .../Universal/Network/Tcp4Dxe/Tcp4Driver.c | 782 -----
> > > .../Universal/Network/Tcp4Dxe/Tcp4Input.c | 1497 ---------
> > > .../Universal/Network/Tcp4Dxe/Tcp4Io.c | 112 -
> > > .../Universal/Network/Tcp4Dxe/Tcp4Main.c | 674 ----
> > > .../Universal/Network/Tcp4Dxe/Tcp4Misc.c | 940 ------
> > > .../Universal/Network/Tcp4Dxe/Tcp4Option.c | 352 --
> > > .../Universal/Network/Tcp4Dxe/Tcp4Output.c | 1238 -------
> > > .../Universal/Network/Tcp4Dxe/Tcp4Timer.c | 584 ----
> > > .../Network/UefiPxeBcDxe/ComponentName.c | 365 --
> > > .../Network/UefiPxeBcDxe/PxeBcDhcp.c | 1999 -----------
> > > .../Network/UefiPxeBcDxe/PxeBcDriver.c | 665 ----
> > > .../Network/UefiPxeBcDxe/PxeBcImpl.c | 2989 -----------------
> > > .../Network/UefiPxeBcDxe/PxeBcMtftp.c | 454 ---
> > > .../Network/UefiPxeBcDxe/PxeBcSupport.c | 221 --
> > > ArmVirtPkg/ArmVirtQemu.dsc | 10 +-
> > > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 10 +-
> > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 10 +-
> > > EmulatorPkg/EmulatorPkg.dsc | 2 +-
> > > EmulatorPkg/EmulatorPkg.fdf | 2 +-
> > > MdeModulePkg/MdeModulePkg.dsc | 3 -
> > > .../Network/IScsiDxe/ComponentName.h | 165 -
> > > .../Universal/Network/IScsiDxe/IScsi4Dxe.uni | 25 -
> > > .../Network/IScsiDxe/IScsi4DxeExtra.uni | 20 -
> > > .../Universal/Network/IScsiDxe/IScsiCHAP.h | 106 -
> > > .../Universal/Network/IScsiDxe/IScsiCommon.h | 22 -
> > > .../Universal/Network/IScsiDxe/IScsiConfig.h | 166 -
> > > .../Network/IScsiDxe/IScsiConfigDxe.vfr | 219 --
> > > .../IScsiDxe/IScsiConfigDxeStrings.uni | 62 -
> > > .../Network/IScsiDxe/IScsiConfigNVDataStruc.h | 109 -
> > > .../Universal/Network/IScsiDxe/IScsiDhcp.h | 55 -
> > > .../Universal/Network/IScsiDxe/IScsiDriver.h | 140 -
> > > .../Universal/Network/IScsiDxe/IScsiDxe.inf | 134 -
> > > .../Network/IScsiDxe/IScsiExtScsiPassThru.h | 22 -
> > > .../Universal/Network/IScsiDxe/IScsiIbft.h | 38 -
> > > .../Universal/Network/IScsiDxe/IScsiImpl.h | 168 -
> > > .../Network/IScsiDxe/IScsiInitiatorName.h | 74 -
> > > .../Universal/Network/IScsiDxe/IScsiMisc.h | 317 --
> > > .../Universal/Network/IScsiDxe/IScsiProto.h | 1005 ------
> > > .../Universal/Network/IScsiDxe/IScsiTcp4Io.h | 142 -
> > > MdeModulePkg/Universal/Network/IScsiDxe/Md5.h | 80 -
> > > .../Universal/Network/Tcp4Dxe/SockImpl.h | 131 -
> > > .../Universal/Network/Tcp4Dxe/Socket.h | 954 ------
> > > .../Universal/Network/Tcp4Dxe/Tcp4Driver.h | 342 --
> > > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 94 -
> > > .../Universal/Network/Tcp4Dxe/Tcp4Dxe.uni | 23 -
> > > .../Network/Tcp4Dxe/Tcp4DxeExtra.uni | 20 -
> > > .../Universal/Network/Tcp4Dxe/Tcp4Func.h | 781 -----
> > > .../Universal/Network/Tcp4Dxe/Tcp4Main.h | 494 ---
> > > .../Universal/Network/Tcp4Dxe/Tcp4Option.h | 130 -
> > > .../Universal/Network/Tcp4Dxe/Tcp4Proto.h | 357 --
> > > .../Network/UefiPxeBcDxe/PxeBcDhcp.h | 502 ---
> > > .../Network/UefiPxeBcDxe/PxeBcDriver.h | 102 -
> > > .../Network/UefiPxeBcDxe/PxeBcImpl.h | 189 --
> > > .../Network/UefiPxeBcDxe/PxeBcMtftp.h | 137 -
> > > .../Network/UefiPxeBcDxe/PxeBcSupport.h | 134 -
> > > .../Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni | 25 -
> > > .../UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni | 20 -
> > > .../Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 102 -
> > > NetworkPkg/IScsiDxe/IScsiDxe.inf | 10 -
> > > NetworkPkg/TcpDxe/TcpDxe.inf | 6 -
> > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 6 -
> > > Nt32Pkg/Nt32Pkg.dsc | 12 +-
> > > Nt32Pkg/Nt32Pkg.fdf | 12 +-
> > > OvmfPkg/OvmfPkgIa32.dsc | 12 +-
> > > OvmfPkg/OvmfPkgIa32.fdf | 10 +-
> > > OvmfPkg/OvmfPkgIa32X64.dsc | 12 +-
> > > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +-
> > > OvmfPkg/OvmfPkgX64.dsc | 12 +-
> > > OvmfPkg/OvmfPkgX64.fdf | 10 +-
> > > Vlv2TbltDevicePkg/PlatformPkg.fdf | 14 +-
> > > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 14 +-
> > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 18 +-
> > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 18 +-
> > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 18 +-
> > > 90 files changed, 55 insertions(+), 32771 deletions(-)
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/Tcp4Dxe/ComponentName.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/Tcp4Dxe/SockInterface.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dispatcher.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Input.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Io.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Misc.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Output.c
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Timer.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/ComponentName.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/ComponentName.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsi4Dxe.uni
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsi4DxeExtra.uni
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiCHAP.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiCommon.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxe.vfr
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigDxeStrings.uni
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfigNVDataStruc.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDriver.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiIbft.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiImpl.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiInitiatorName.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/IScsiProto.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/IScsiDxe/IScsiTcp4Io.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/IScsiDxe/Md5.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/SockImpl.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Socket.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Driver.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.uni
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4DxeExtra.uni
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Func.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Main.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Option.h
> > > delete mode 100644 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Proto.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDhcp.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcDriver.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcImpl.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcMtftp.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxe.uni
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxe4BcDxeExtra.uni
> > > delete mode 100644
> > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > >
> > > --
> > > 2.18.0.windows.1
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-31 10:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 7:33 [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg Fu Siyuan
2018-10-30 7:33 ` [PATCH v1 1/7] Nt32Pkg: Replace obsoleted network drivers from NT32 platform DSC/FDF Fu Siyuan
2018-10-30 7:57 ` Ni, Ruiyu
2018-10-30 7:33 ` [PATCH v1 2/7] EmulatorPkg: Replace obsoleted network drivers from " Fu Siyuan
2018-10-30 7:57 ` Ni, Ruiyu
2018-10-30 7:33 ` [PATCH v1 3/7] OvmfPkg: " Fu Siyuan
2018-10-30 7:33 ` [PATCH v1 4/7] Vlv2TbltDevicePkg: Replace obsoleted " Fu Siyuan
2018-11-04 6:14 ` Wei, David
2018-10-30 7:33 ` [PATCH v1 5/7] ArmVirtPkg: Replace obsoleted network " Fu Siyuan
2018-10-30 7:33 ` [PATCH v1 6/7] MdeModulePkg: Delete the TCP/PXE/ISCSI drivers in MdeModulePkg Fu Siyuan
2018-10-31 8:23 ` Ni, Ruiyu
2018-10-31 8:37 ` Fu, Siyuan
2018-11-01 3:08 ` Zeng, Star
2018-10-30 7:33 ` [PATCH v1 7/7] NetworkPkg: Remove some clarification from TCP/PXE/ISCSI driver INF Fu Siyuan
2018-10-30 8:16 ` Ye, Ting
2018-10-30 7:42 ` [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg Zeng, Star
2018-10-30 8:23 ` Fu, Siyuan
2018-10-30 21:14 ` Kinney, Michael D
2018-10-31 0:51 ` Fu, Siyuan
2018-10-31 16:29 ` Kinney, Michael D
2018-10-30 10:50 ` Leif Lindholm
2018-10-31 0:41 ` Fu, Siyuan
2018-10-31 10:59 ` Leif Lindholm [this message]
2018-10-31 14:02 ` Gao, Liming
2018-11-05 22:12 ` Laszlo Ersek
2018-11-06 0:59 ` Fu, Siyuan
2018-11-06 14:38 ` Laszlo Ersek
2018-11-06 11:02 ` Leif Lindholm
2018-11-06 14:34 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031105911.wr3x4crlu2fnfcti@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox