Re: [PATCH edk2-platforms 03/27] Platform/Microsoft: Add MsPkg

[Leif Lindholm <leif.lindholm@linaro.org>]

(You'll note I'm skipping over the SdMmc bits for now.)

On Fri, Sep 21, 2018 at 08:25:55AM +0000, Chris Co wrote:
> MsPkg is a collection of libraries and drivers that are specific
> to supporting Windows IoT Core but are not Platform/Silicon specific.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Christopher Co <christopher.co@microsoft.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/Microsoft/MsPkg.dec | 39 ++++++++++++++++++++
>  Platform/Microsoft/MsPkg.dsc | 31 ++++++++++++++++
>  2 files changed, 70 insertions(+)
> 
> diff --git a/Platform/Microsoft/MsPkg.dec b/Platform/Microsoft/MsPkg.dec
> new file mode 100644
> index 000000000000..c19913603e4f
> --- /dev/null
> +++ b/Platform/Microsoft/MsPkg.dec
> @@ -0,0 +1,39 @@
> +#/** @file
> +#
> +#  Copyright (c) 2018 Microsoft Corporation. All rights reserved.
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +#**/
> +
> +[Defines]
> +  DEC_SPECIFICATION              = 0x0001001A
> +  PACKAGE_NAME                   = MsPkg
> +  PACKAGE_GUID                   = DC909FB7-F45E-4D7F-BF10-327BD9BFA21C
> +  PACKAGE_VERSION                = 0.1
> +
> +[Includes.common]
> +  Include                        # Root include for the package
> +
> +[LibraryClasses.common]
> +
> +[Guids.common]
> +  gMsPkgTokenSpaceGuid = { 0x3ecb4bb9, 0xb80a, 0x4efd, { 0x92, 0xb8, 0x3a, 0x16, 0xe0, 0xc8, 0x19, 0xb } }
> +
> +[PcdsFixedAtBuild.common]
> +  gMsPkgTokenSpaceGuid.PcdSecureBootEnable|FALSE|BOOLEAN|0x00

Do we need a Pcd under MsPkg namespace for this?
Many other platforms use a SECURE_BOOT_ENABLE test and set global Pcds
and include components based on that value. See for example
edk2/QuarkPlatformPkg/Quark.dsc

> +
> +  # The DevicePath to a partition on a writeable media used for logging and misc
> +  # storage purposes. SD card DevicePath example:
> +  # gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L"VenHw(AAFB8DAA-7340-43AC-8D49-0CCE14812489,03000000)/SD(0x0)/HD(1,MBR,0xAE420040,0x1000,0x20000)"
> +  gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L""|VOID*|0x03
> +
> +[Protocols.common]
> +  gEfiRpmbIoProtocolGuid = { 0xfbaee5b2, 0x8b0, 0x41b8, { 0xb0, 0xb0, 0x86, 0xb7, 0x2e, 0xed, 0x1b, 0xb6 } }
> +  gEfiSdhcProtocolGuid = { 0x46055b0f, 0x992a, 0x4ad7, { 0x8f, 0x81, 0x14, 0x81, 0x86, 0xff, 0xdf, 0x72 } }
> diff --git a/Platform/Microsoft/MsPkg.dsc b/Platform/Microsoft/MsPkg.dsc
> new file mode 100644
> index 000000000000..fc92208673da
> --- /dev/null
> +++ b/Platform/Microsoft/MsPkg.dsc
> @@ -0,0 +1,31 @@
> +## @file
> +#
> +#  Copyright (c) 2018 Microsoft Corporation. All rights reserved.
> +#
> +#   This program and the accompanying materials
> +#   are licensed and made available under the terms and conditions of the BSD License
> +#   which accompanies this distribution. The full text of the license may be found at
> +#   http://opensource.org/licenses/bsd-license.
> +#
> +#   THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#   WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = MsPkg
> +  PLATFORM_GUID                  = 2F78367E-9C74-4FBE-82E7-1D2DAAF18CC6
> +  PLATFORM_VERSION               = 0.01
> +  DSC_SPECIFICATION              = 0x0001001A
> +  OUTPUT_DIRECTORY               = Build/MsPkg
> +  SUPPORTED_ARCHITECTURES        = ARM|AARCH64
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +[PcdsFeatureFlag]
> +
> +[PcdsFixedAtBuild]
> +
> +[LibraryClasses]
> +
> +[Components]
> +  Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf

The one thing I'd say here is that we usually set up .dsc files to let
us build individual components. So in this case,
  build -p Platform/Microsoft/MsPkg.dsc -m Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf

This means wiring up a lot of the boilerplate under [LibraryClasses].

/
    Leif