From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A4722117B579 for ; Wed, 31 Oct 2018 14:00:35 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id i17-v6so17951301wre.7 for ; Wed, 31 Oct 2018 14:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=D7ukX0L+zfJF213B2Nbvd8+wgNzS3y3S865NBjzevow=; b=H2twr35ZB+8lHJkvbqd2VckcAi/5iXHFRIOpUgpOAOrjhAwQ1Z1H4EeWeVft2JX++F F3jY9eEYTxEuhPTSDrWssoref5u4Yc7g47yJ1pgwMqdXaHKiBw0LmL/zZm/Kx4S8vJ0k G/sjcDGSAaQ1Cyetmt+dBegjKdKFeTgWAyzac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=D7ukX0L+zfJF213B2Nbvd8+wgNzS3y3S865NBjzevow=; b=fNFpPvx6QqPOoggwlFVu7XwOeyW/enAkfm6Nxe3TP8RlMr/WByUTCKwNMdTd2VN02Z JC2Nd/7mZ1zvYpQpCNcdq6EHTXdCb7peH4WWT40EUoVEXJ2LqZm4jfzvda34i8MI3Yp5 6yC2TDNmLm2OQj84TJcjSshV4oF7/zlmtWea5HdgucpH9yoTKS/nuQN8A91nwNraydIW HNXzAA/UyZpyRI3dQAMG6s3CI21g8ALgKHjkoxhAkMGtEdG9HsjHpfz3BYfCI/x8CAuY zrRqOO5K6JRTjvZpPXEdNgO902ducoBrHnO/iRKBoe4fcvqxXK3bPmBZU0WqKbV7yMYC s7ZQ== X-Gm-Message-State: AGRZ1gINJS43w5PjQfF26Nzqxyut6UCQRq/gx67/R1EhTNb2lWqg6NHm VlxI6/J/UdyI653Dv8WQu95DBw== X-Google-Smtp-Source: AJdET5eFHB4M9xMbksvl2fe/3IM9kyD4F2udq7HHGXPYfP3BSlD+eqF/Om6PxuZFEX2AQ/xdboT9Tw== X-Received: by 2002:a5d:6585:: with SMTP id q5-v6mr4098037wru.141.1541019634083; Wed, 31 Oct 2018 14:00:34 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b15-v6sm16565272wrr.90.2018.10.31.14.00.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Oct 2018 14:00:17 -0700 (PDT) Date: Wed, 31 Oct 2018 21:00:10 +0000 From: Leif Lindholm To: Chris Co Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Michael D Kinney Message-ID: <20181031210010.ymunyl5pm677m7fj@bivouac.eciton.net> References: <20180921082542.35768-1-christopher.co@microsoft.com> <20180921082542.35768-4-christopher.co@microsoft.com> MIME-Version: 1.0 In-Reply-To: <20180921082542.35768-4-christopher.co@microsoft.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms 03/27] Platform/Microsoft: Add MsPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 21:00:36 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline (You'll note I'm skipping over the SdMmc bits for now.) On Fri, Sep 21, 2018 at 08:25:55AM +0000, Chris Co wrote: > MsPkg is a collection of libraries and drivers that are specific > to supporting Windows IoT Core but are not Platform/Silicon specific. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Christopher Co > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Platform/Microsoft/MsPkg.dec | 39 ++++++++++++++++++++ > Platform/Microsoft/MsPkg.dsc | 31 ++++++++++++++++ > 2 files changed, 70 insertions(+) > > diff --git a/Platform/Microsoft/MsPkg.dec b/Platform/Microsoft/MsPkg.dec > new file mode 100644 > index 000000000000..c19913603e4f > --- /dev/null > +++ b/Platform/Microsoft/MsPkg.dec > @@ -0,0 +1,39 @@ > +#/** @file > +# > +# Copyright (c) 2018 Microsoft Corporation. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + DEC_SPECIFICATION = 0x0001001A > + PACKAGE_NAME = MsPkg > + PACKAGE_GUID = DC909FB7-F45E-4D7F-BF10-327BD9BFA21C > + PACKAGE_VERSION = 0.1 > + > +[Includes.common] > + Include # Root include for the package > + > +[LibraryClasses.common] > + > +[Guids.common] > + gMsPkgTokenSpaceGuid = { 0x3ecb4bb9, 0xb80a, 0x4efd, { 0x92, 0xb8, 0x3a, 0x16, 0xe0, 0xc8, 0x19, 0xb } } > + > +[PcdsFixedAtBuild.common] > + gMsPkgTokenSpaceGuid.PcdSecureBootEnable|FALSE|BOOLEAN|0x00 Do we need a Pcd under MsPkg namespace for this? Many other platforms use a SECURE_BOOT_ENABLE test and set global Pcds and include components based on that value. See for example edk2/QuarkPlatformPkg/Quark.dsc > + > + # The DevicePath to a partition on a writeable media used for logging and misc > + # storage purposes. SD card DevicePath example: > + # gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L"VenHw(AAFB8DAA-7340-43AC-8D49-0CCE14812489,03000000)/SD(0x0)/HD(1,MBR,0xAE420040,0x1000,0x20000)" > + gMsPkgTokenSpaceGuid.PcdStorageMediaPartitionDevicePath|L""|VOID*|0x03 > + > +[Protocols.common] > + gEfiRpmbIoProtocolGuid = { 0xfbaee5b2, 0x8b0, 0x41b8, { 0xb0, 0xb0, 0x86, 0xb7, 0x2e, 0xed, 0x1b, 0xb6 } } > + gEfiSdhcProtocolGuid = { 0x46055b0f, 0x992a, 0x4ad7, { 0x8f, 0x81, 0x14, 0x81, 0x86, 0xff, 0xdf, 0x72 } } > diff --git a/Platform/Microsoft/MsPkg.dsc b/Platform/Microsoft/MsPkg.dsc > new file mode 100644 > index 000000000000..fc92208673da > --- /dev/null > +++ b/Platform/Microsoft/MsPkg.dsc > @@ -0,0 +1,31 @@ > +## @file > +# > +# Copyright (c) 2018 Microsoft Corporation. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license. > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +## > + > +[Defines] > + PLATFORM_NAME = MsPkg > + PLATFORM_GUID = 2F78367E-9C74-4FBE-82E7-1D2DAAF18CC6 > + PLATFORM_VERSION = 0.01 > + DSC_SPECIFICATION = 0x0001001A > + OUTPUT_DIRECTORY = Build/MsPkg > + SUPPORTED_ARCHITECTURES = ARM|AARCH64 > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT > + SKUID_IDENTIFIER = DEFAULT > + > +[PcdsFeatureFlag] > + > +[PcdsFixedAtBuild] > + > +[LibraryClasses] > + > +[Components] > + Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf The one thing I'd say here is that we usually set up .dsc files to let us build individual components. So in this case, build -p Platform/Microsoft/MsPkg.dsc -m Platform/Microsoft/Drivers/SdMmcDxe/SdMmcDxe.inf This means wiring up a lot of the boilerplate under [LibraryClasses]. / Leif