From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22B6321188C5B for ; Thu, 1 Nov 2018 04:31:25 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j26-v6so5552832wre.1 for ; Thu, 01 Nov 2018 04:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XWPvp2nmYKT5q2JU5QMxRFet9Exr9T28ieu5sJyxxnw=; b=NQn4Er+UU9T7XWkZcw9/bsb5fmt9sj3pS7Y+y7xgwM27Difh8UAQ1V74cv6edT0T10 qbt+/vl7QIsc20G9Jrv32dirxf8aGPwnFof0qt44N/eIv8v4wTzeqwprjXpVNN1iW+vt kcizYdDJm6xXc5dDUkvUd2Lx/vrfW4VA2KktU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XWPvp2nmYKT5q2JU5QMxRFet9Exr9T28ieu5sJyxxnw=; b=WlbFRDlq1J42PWDQuLQdwaimxXsCDDai94P/H+fSloUDub1NvehfMRMwk/FuaCgVCF zposnL5K/kaSooksxD5SEzCEaAKI4rfTlktyskb3Zx0ix/6wwa8A7zYoC2ga4hj8q8IK U8MaCJOf+Jj9Fq91JsEoHwpigNrhYHKe86iGL88PPplRUdjgcylneVMutxaAUiAsQyBU VvHkkGXHDRT+4+Ck6dd+Fhzg77OAWVO4pMW16LKKvgH84DflCaIz/MN52/uPUOpieEZJ rSwra3F9Mcs/PjHSK9QpZ5DmxSLPO3HQGb2/KB9MIxb7J1hcqokbfiC1CXM2CYEMJiPF pThA== X-Gm-Message-State: AGRZ1gIGNxx2O7SqGuVa5hOFO7L2SYj6xDcr7uS/ShQd4ww5m/y8vLNG ADhjxr16OgjS/jstBp6Zlswo7w== X-Google-Smtp-Source: AJdET5d8O2NiiqbdjsxMWr51t5+zlbFORu8TFRd/Jvc+myzSAsgsioThSQ02gNPpyxdI7emwnzLfZg== X-Received: by 2002:adf:f20a:: with SMTP id p10-v6mr1018210wro.293.1541071884235; Thu, 01 Nov 2018 04:31:24 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e8-v6sm3346623wrw.75.2018.11.01.04.31.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 04:31:23 -0700 (PDT) Date: Thu, 1 Nov 2018 11:31:21 +0000 From: Leif Lindholm To: "Zhang, Shenglei" Cc: "edk2-devel@lists.01.org" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" Message-ID: <20181101113121.c5zlto2narai5htg@bivouac.eciton.net> References: <20181031060525.16696-1-shenglei.zhang@intel.com> <20181031060525.16696-2-shenglei.zhang@intel.com> <20181031110157.cw3rytphr4ajc5fe@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and EkdShellBinPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 11:31:26 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 01, 2018 at 06:03:22AM +0000, Zhang, Shenglei wrote: > Hi Leif, > > Thanks for your comments. Actually there is a cover letter. > https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html Ah, I missed that one since I was on cc on the rest of the set, but not the cover letter. > It may not be needed to rework but I 'll push the patches in order according to > the comments you mentioned. If you do that: Reviewed-by: Leif Lindholm (After the November stable tag has been made.) Regards, Leif > Thanks, > Shenglei > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Wednesday, October 31, 2018 7:02 PM > > To: Zhang, Shenglei > > Cc: edk2-devel@lists.01.org; Andrew Fish ; Laszlo Ersek > > ; Kinney, Michael D > > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > > EkdShellBinPkg > > > > Hi Shenglei, > > > > I am happy with this change, but I think the deletion from > > Maintainers.txt should come last (as 3/3). > > Could you rework and resubmit, and add a cover letter (0/3)? > > > > Best Regards, > > > > Leif > > > > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > > information about them in Maintainers.txt should also be > > > deleted. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > > > > > Cc: Andrew Fish > > > Cc: Laszlo Ersek > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: shenglei > > > --- > > > Maintainers.txt | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > > index 36c6689afd..98f104b674 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > > W: > > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > > M: Liming Gao > > > > > > -EdkShellPkg, EdkShellBinPkg > > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > > -M: Ruiyu Ni > > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > > - > > > EmbeddedPkg > > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > > M: Leif Lindholm > > > -- > > > 2.18.0.windows.1 > > >