public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: Andrew Turner <andrew@fubar.geek.nz>
Cc: edk2-devel@lists.01.org,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
	Nariman Poushin <nariman.poushin@linaro.org>
Subject: Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
Date: Thu, 1 Nov 2018 11:47:58 +0000	[thread overview]
Message-ID: <20181101114758.ij3v72kqj4otdqpa@bivouac.eciton.net> (raw)
In-Reply-To: <c8eadf41720001df935088ab9da03702f621dcf4.1541072094.git.andrew@fubar.geek.nz>

Thanks Andrew,

Thomas, Nariman - can I have a review from one of you guys before I
push?

Regards,

Leif

On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote:
> The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
> "-D DT_SUPPORT" buildoption.
> 
> ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
> and fails with:
> .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
> fatal error: VExpressMotherBoard.h: No such file or directory
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
> ---
>  .../ArmVExpressDtPlatformDtbLoaderLib.inf                                | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> index 5012101..eb821c7 100644
> --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> @@ -26,6 +26,7 @@
>  [Packages]
>    ArmPkg/ArmPkg.dec
>    MdePkg/MdePkg.dec
> ++  Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
>    EmbeddedPkg/EmbeddedPkg.dec
>  
>  [LibraryClasses]
> -- 
> 2.7.4
> 


  reply	other threads:[~2018-11-01 11:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 11:35 [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" Andrew Turner
2018-11-01 11:47 ` Leif Lindholm [this message]
2018-11-01 12:50   ` Thomas Abraham
2018-11-01 12:55   ` Thomas Abraham
2018-11-08 11:37 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101114758.ij3v72kqj4otdqpa@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox