* [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
@ 2018-11-01 11:35 Andrew Turner
2018-11-01 11:47 ` Leif Lindholm
2018-11-08 11:37 ` Leif Lindholm
0 siblings, 2 replies; 5+ messages in thread
From: Andrew Turner @ 2018-11-01 11:35 UTC (permalink / raw)
To: edk2-devel
The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
"-D DT_SUPPORT" buildoption.
ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
and fails with:
.../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
fatal error: VExpressMotherBoard.h: No such file or directory
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
---
.../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
index 5012101..eb821c7 100644
--- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
+++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
@@ -26,6 +26,7 @@
[Packages]
ArmPkg/ArmPkg.dec
MdePkg/MdePkg.dec
++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
EmbeddedPkg/EmbeddedPkg.dec
[LibraryClasses]
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
2018-11-01 11:35 [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" Andrew Turner
@ 2018-11-01 11:47 ` Leif Lindholm
2018-11-01 12:50 ` Thomas Abraham
2018-11-01 12:55 ` Thomas Abraham
2018-11-08 11:37 ` Leif Lindholm
1 sibling, 2 replies; 5+ messages in thread
From: Leif Lindholm @ 2018-11-01 11:47 UTC (permalink / raw)
To: Andrew Turner
Cc: edk2-devel, Ard Biesheuvel, Thomas Panakamattam Abraham,
Nariman Poushin
Thanks Andrew,
Thomas, Nariman - can I have a review from one of you guys before I
push?
Regards,
Leif
On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote:
> The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
> "-D DT_SUPPORT" buildoption.
>
> ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
> and fails with:
> .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
> fatal error: VExpressMotherBoard.h: No such file or directory
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
> ---
> .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> index 5012101..eb821c7 100644
> --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> @@ -26,6 +26,7 @@
> [Packages]
> ArmPkg/ArmPkg.dec
> MdePkg/MdePkg.dec
> ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
>
> [LibraryClasses]
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
2018-11-01 11:47 ` Leif Lindholm
@ 2018-11-01 12:50 ` Thomas Abraham
2018-11-01 12:55 ` Thomas Abraham
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Abraham @ 2018-11-01 12:50 UTC (permalink / raw)
To: Leif Lindholm; +Cc: andrew, edk2-devel, Nariman Poushin
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Thanks Andrew,
>
> Thomas, Nariman - can I have a review from one of you guys before I
> push?
>
> Regards,
>
> Leif
>
> On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote:
> > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
> > "-D DT_SUPPORT" buildoption.
> >
> > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
> > and fails with:
> > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
> > fatal error: VExpressMotherBoard.h: No such file or directory
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
> > ---
> > .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 +
> > 1 file changed, 1 insertion(+)
Tested with -D DT_SUPPORT as additional build option and the below
change does fix the build issue reported in this commit message.
Tested-by: Thomas Abraham <thomas.abraham@arm.com>
> >
> > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > index 5012101..eb821c7 100644
> > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > @@ -26,6 +26,7 @@
> > [Packages]
> > ArmPkg/ArmPkg.dec
> > MdePkg/MdePkg.dec
> > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
> > EmbeddedPkg/EmbeddedPkg.dec
> >
> > [LibraryClasses]
> > --
> > 2.7.4
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
2018-11-01 11:47 ` Leif Lindholm
2018-11-01 12:50 ` Thomas Abraham
@ 2018-11-01 12:55 ` Thomas Abraham
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Abraham @ 2018-11-01 12:55 UTC (permalink / raw)
To: Leif Lindholm; +Cc: andrew, edk2-devel, Nariman Poushin
On Thu, Nov 1, 2018 at 5:18 PM Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Thanks Andrew,
>
> Thomas, Nariman - can I have a review from one of you guys before I
> push?
>
> Regards,
>
> Leif
>
> On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote:
> > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
> > "-D DT_SUPPORT" buildoption.
> >
> > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
> > and fails with:
> > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
> > fatal error: VExpressMotherBoard.h: No such file or directory
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
> > ---
> > .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 +
> > 1 file changed, 1 insertion(+)
Tested with -D DT_SUPPORT as additional build option and the below
change does fix the build issue reported in this commit message.
Tested-by: Thomas Abraham <thomas.abraham@arm.com>
> >
> > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > index 5012101..eb821c7 100644
> > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> > @@ -26,6 +26,7 @@
> > [Packages]
> > ArmPkg/ArmPkg.dec
> > MdePkg/MdePkg.dec
> > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
> > EmbeddedPkg/EmbeddedPkg.dec
> >
> > [LibraryClasses]
> > --
> > 2.7.4
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT"
2018-11-01 11:35 [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" Andrew Turner
2018-11-01 11:47 ` Leif Lindholm
@ 2018-11-08 11:37 ` Leif Lindholm
1 sibling, 0 replies; 5+ messages in thread
From: Leif Lindholm @ 2018-11-08 11:37 UTC (permalink / raw)
To: Andrew Turner; +Cc: edk2-devel, Ard Biesheuvel
On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote:
> The UEFI build fails for ArmVExpress-FVP-AArch64 when using the
> "-D DT_SUPPORT" buildoption.
>
> ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package
> and fails with:
> .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33:
> fatal error: VExpressMotherBoard.h: No such file or directory
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Andrew Turner <andrew@fubar.geek.nz>
> ---
> .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> index 5012101..eb821c7 100644
> --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf
> @@ -26,6 +26,7 @@
> [Packages]
> ArmPkg/ArmPkg.dec
> MdePkg/MdePkg.dec
> ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
Dropped this extra leading + (is this some sort of alternative diff
format or a character encoding issue?). With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 113d2def98.
> EmbeddedPkg/EmbeddedPkg.dec
>
> [LibraryClasses]
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-08 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-01 11:35 [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" Andrew Turner
2018-11-01 11:47 ` Leif Lindholm
2018-11-01 12:50 ` Thomas Abraham
2018-11-01 12:55 ` Thomas Abraham
2018-11-08 11:37 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox