From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E1B4421188C58 for ; Thu, 1 Nov 2018 04:48:07 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id q12-v6so1102093wmq.0 for ; Thu, 01 Nov 2018 04:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ny080kmFi5qBw4ZMAbPk6FTetXix0RHbBy+R4paFvxA=; b=Jbp7Wd+OcDG4UlQErVVqplVqRrKsBKnpCvYiLrpN9soMdr9EfIVLK9sejpbJbg8jUY u7VBgMskEUXX4YTNr+0Oy1G4QVBkGxmyisHSZj+9J4GfcKH+PZCGP5cJZn6THsa7sGCB Ra8FwJ3sgfNLUvu36d9gHlZrv9Ir/DaSoj03o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ny080kmFi5qBw4ZMAbPk6FTetXix0RHbBy+R4paFvxA=; b=WXU97GW8+ppHD9EBQpxgPuBstLWUNKkJB57VoOJ4CZWt8dU5lAshOzbSPpuw0w1XSv 2fFFMTiqvt/jLXFQtXzPjhwcKXOD4xDa5a625P/jI4HwXmwSJDkpWfysiVky+A9Y1F7s 1JvTyfFi8Wlw/puTn/jzBiDaz3h726VKFbfwNW3Noy2jQ0NBPb99bUmrOPNuMmDE8O3+ KKab1Kt9oOm0nxVisOUUEI0Vuj2A4aEafaRAzfUzvlg6wSXqo+B1DPoJ8A5tqEuUxujz BsefYI/w7uX3al6Biq9uzqPFcx5nYjHm1QSKoDbMcKVF2bTvt8f+z/yYeUC90H0AB4L+ ju2w== X-Gm-Message-State: AGRZ1gI98BXMYBtW0ZpliO649mOtyYc/4OEZIeCHsbn16hpYbIAh0O9f SlWoGi3CcZaW1z1j5MjhMAvNXJRwZLc= X-Google-Smtp-Source: AJdET5cW7bUIIFVchnoFMvnN19JRiHePhzawa8bf/Bo5rKMUvHYawnKECX6CrnpPWxfmeLsaiR1Wvg== X-Received: by 2002:a1c:248b:: with SMTP id k133-v6mr5085037wmk.148.1541072886112; Thu, 01 Nov 2018 04:48:06 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p19-v6sm13958656wmc.46.2018.11.01.04.48.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Nov 2018 04:48:05 -0700 (PDT) Date: Thu, 1 Nov 2018 11:47:58 +0000 From: Leif Lindholm To: Andrew Turner Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Thomas Panakamattam Abraham , Nariman Poushin Message-ID: <20181101114758.ij3v72kqj4otdqpa@bivouac.eciton.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 11:48:08 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Andrew, Thomas, Nariman - can I have a review from one of you guys before I push? Regards, Leif On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote: > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > "-D DT_SUPPORT" buildoption. > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > and fails with: > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Andrew Turner > --- > .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > index 5012101..eb821c7 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > @@ -26,6 +26,7 @@ > [Packages] > ArmPkg/ArmPkg.dec > MdePkg/MdePkg.dec > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > > [LibraryClasses] > -- > 2.7.4 >