* [Patch] MdeModulePkg: Remove the trailing space in three source files.
@ 2018-11-01 13:38 Liming Gao
2018-11-02 0:30 ` Ni, Ruiyu
2018-11-02 1:25 ` Zeng, Star
0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2018-11-01 13:38 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng
The recent changes in these three source files introduce the trailing space.
This patch removes them to follow edk2 coding style.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c | 2 +-
MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
index c31247a..513575d 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
@@ -958,7 +958,7 @@ GetExpectedDescriptor (
UINTN Offset;
//
- // Total length is too small that cannot hold the single descriptor header plus data.
+ // Total length is too small that cannot hold the single descriptor header plus data.
//
if (Length <= sizeof (USB_DESC_HEAD)) {
DEBUG ((DEBUG_ERROR, "GetExpectedDescriptor: met mal-format descriptor, total length = %d!\n", Length));
diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
index be2f8af..ad3afa6 100644
--- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
+++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
@@ -129,7 +129,7 @@ struct _MTFTP4_PROTOCOL {
// Record the total received and saved block number.
//
UINT64 TotalBlock;
-
+
//
// Record the acked block number.
//
diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
index 7ccab57..30c955f 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
@@ -112,7 +112,7 @@
# Oniguruma: tag_end in parse_callout_of_name
GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
-
+
# Not add -Wno-error=maybe-uninitialized option for XCODE
# XCODE doesn't know this option
XCODE:*_*_*_CC_FLAGS =
--
2.10.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg: Remove the trailing space in three source files.
2018-11-01 13:38 [Patch] MdeModulePkg: Remove the trailing space in three source files Liming Gao
@ 2018-11-02 0:30 ` Ni, Ruiyu
2018-11-02 1:25 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ruiyu @ 2018-11-02 0:30 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Zeng, Star
My fault! Thanks!
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Liming Gao
> Sent: Thursday, November 1, 2018 9:38 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [Patch] MdeModulePkg: Remove the trailing space in three
> source files.
>
> The recent changes in these three source files introduce the trailing space.
> This patch removes them to follow edk2 coding style.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c | 2 +-
> MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 2
> +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
> b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
> index c31247a..513575d 100644
> --- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
> +++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
> @@ -958,7 +958,7 @@ GetExpectedDescriptor (
> UINTN Offset;
>
> //
> - // Total length is too small that cannot hold the single descriptor header plus
> data.
> + // Total length is too small that cannot hold the single descriptor header plus
> data.
> //
> if (Length <= sizeof (USB_DESC_HEAD)) {
> DEBUG ((DEBUG_ERROR, "GetExpectedDescriptor: met mal-format
> descriptor, total length = %d!\n", Length)); diff --git
> a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
> b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
> index be2f8af..ad3afa6 100644
> --- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
> +++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
> @@ -129,7 +129,7 @@ struct _MTFTP4_PROTOCOL {
> // Record the total received and saved block number.
> //
> UINT64 TotalBlock;
> -
> +
> //
> // Record the acked block number.
> //
> diff --git
> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> index 7ccab57..30c955f 100644
> ---
> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i
> +++ nf
> @@ -112,7 +112,7 @@
>
> # Oniguruma: tag_end in parse_callout_of_name
> GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
> -
> +
> # Not add -Wno-error=maybe-uninitialized option for XCODE
> # XCODE doesn't know this option
> XCODE:*_*_*_CC_FLAGS =
> --
> 2.10.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] MdeModulePkg: Remove the trailing space in three source files.
2018-11-01 13:38 [Patch] MdeModulePkg: Remove the trailing space in three source files Liming Gao
2018-11-02 0:30 ` Ni, Ruiyu
@ 2018-11-02 1:25 ` Zeng, Star
1 sibling, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2018-11-02 1:25 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
Thanks,
Star
-----Original Message-----
From: Gao, Liming
Sent: Thursday, November 1, 2018 9:38 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [Patch] MdeModulePkg: Remove the trailing space in three source files.
The recent changes in these three source files introduce the trailing space.
This patch removes them to follow edk2 coding style.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c | 2 +-
MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h | 2 +-
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
index c31247a..513575d 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusPei/UsbPeim.c
@@ -958,7 +958,7 @@ GetExpectedDescriptor (
UINTN Offset;
//
- // Total length is too small that cannot hold the single descriptor header plus data.
+ // Total length is too small that cannot hold the single descriptor header plus data.
//
if (Length <= sizeof (USB_DESC_HEAD)) {
DEBUG ((DEBUG_ERROR, "GetExpectedDescriptor: met mal-format descriptor, total length = %d!\n", Length)); diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
index be2f8af..ad3afa6 100644
--- a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
+++ b/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Impl.h
@@ -129,7 +129,7 @@ struct _MTFTP4_PROTOCOL {
// Record the total received and saved block number.
//
UINT64 TotalBlock;
-
+
//
// Record the acked block number.
//
diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
index 7ccab57..30c955f 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.i
+++ nf
@@ -112,7 +112,7 @@
# Oniguruma: tag_end in parse_callout_of_name
GCC:*_*_*_CC_FLAGS = -Wno-error=maybe-uninitialized
-
+
# Not add -Wno-error=maybe-uninitialized option for XCODE
# XCODE doesn't know this option
XCODE:*_*_*_CC_FLAGS =
--
2.10.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-02 1:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-01 13:38 [Patch] MdeModulePkg: Remove the trailing space in three source files Liming Gao
2018-11-02 0:30 ` Ni, Ruiyu
2018-11-02 1:25 ` Zeng, Star
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox