public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leif Lindholm <leif.lindholm@linaro.org>
To: edk2-devel@lists.01.org
Cc: Daryl McDaniel <edk2-lists@mc2research.org>,
	Jaben Carsey <jaben.carsey@intel.com>
Subject: [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64
Date: Thu,  1 Nov 2018 15:36:37 +0000	[thread overview]
Message-ID: <20181101153642.11315-2-leif.lindholm@linaro.org> (raw)
In-Reply-To: <20181101153642.11315-1-leif.lindholm@linaro.org>

The WebServer application is really quite Ia32/X64 specific, but fundamentally
it builds for other architectures as long as the architecture-specific
  #include <Register/Msr.h>
header file is filtered out.
So add an architecture-based filter on that to enable AppPkg.dsc to build for
AARCH64/ARM (both listed in SUPPORTED_ARCHITECTURES).

Cc: Daryl McDaniel <edk2-lists@mc2research.org>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---

Note: there is definitely a case here for just disabling this component
      for !Ia32/X64, but the _interesting_ bits of this application are
      completely architecture independent, so my preference would be to
      do this for now, and worry about remaining issues (like MTRR dump)
      at some point in the future.

 AppPkg/Applications/Sockets/WebServer/WebServer.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/AppPkg/Applications/Sockets/WebServer/WebServer.h b/AppPkg/Applications/Sockets/WebServer/WebServer.h
index 21b07b63df..610abdcf9e 100644
--- a/AppPkg/Applications/Sockets/WebServer/WebServer.h
+++ b/AppPkg/Applications/Sockets/WebServer/WebServer.h
@@ -20,7 +20,9 @@
 
 #include <Guid/EventGroup.h>
 
+#if defined(__x86_64__) || defined(__i386__)
 #include <Register/Msr.h>
+#endif
 #include <Library/BaseMemoryLib.h>
 #include <Library/DebugLib.h>
 #include <Library/MemoryAllocationLib.h>
-- 
2.11.0



  reply	other threads:[~2018-11-01 15:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 15:36 [PATCH 0/6] fix top-level package builds for AARCH64/ARM Leif Lindholm
2018-11-01 15:36 ` Leif Lindholm [this message]
2018-11-01 17:19   ` [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 Kinney, Michael D
2018-11-01 17:56     ` Leif Lindholm
2018-11-01 15:36 ` [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM Leif Lindholm
2018-11-02  1:39   ` Gao, Liming
2018-11-02 10:15     ` Leif Lindholm
2018-11-02 14:20       ` Gao, Liming
2018-11-01 15:36 ` [PATCH 3/6] IntelFrameworkPkg: " Leif Lindholm
2018-11-01 17:23   ` Kinney, Michael D
2018-11-01 15:36 ` [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 components Leif Lindholm
2018-11-02  1:24   ` Zeng, Star
2018-11-01 15:36 ` [PATCH 5/6] SecurityPkg: fix package build on ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen
2018-11-01 15:36 ` [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen
2019-02-04 17:13 ` [PATCH 0/6] fix top-level package builds " Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101153642.11315-2-leif.lindholm@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox