From: yuchenlin@synology.com
To: edk2-devel@lists.01.org
Cc: jordan.l.justen@intel.com, lersek@redhat.com,
ard.biesheuvel@linaro.org, anthony.perard@citrix.com,
julien.grall@linaro.org, phil@philjordan.eu, kraxel@redhat.com,
philmd@redhat.com, yuchenlin <yuchenlin@synology.com>
Subject: [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga
Date: Fri, 2 Nov 2018 11:23:57 +0800 [thread overview]
Message-ID: <20181102032402.19686-1-yuchenlin@synology.com> (raw)
From: yuchenlin <yuchenlin@synology.com>
In this series, replace the original vmsvga driver to Bochs
interface.
Simply revert vmsvga driver implementation. After it, use Bochs
interface for initializing vmsvga.
Because of the PCI BARs difference between std vga and vmsvga.
We can not simply recognize the "QEMU VMWare SVGA" as the
QEMU_VIDEO_BOCHS_MMIO variant.
BAR | std vga | vmsvga
---------------------------------
0 | Framebuffer | I/O space
1 | Reserved | Framebuffer
2 | MMIO | FIFO
To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA,
and use it for:
(1) Get framebuffer from correct PCI BAR
(2) Prevent using BAR2 for MMIO
We have tested on qemu before and after commit 104bd1dc70 and all
worked.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: yuchenlin <yuchenlin@synology.com>
Changelog:
v1 -> v2
* use 'else' clause (Thanks Philippe).
* add more comment in revert patches (Thanks Philippe).
* reorder the revert patches, we should revert the last commit first.
* use correct framebuffer to ClearScreen.
* revert VMWare svga definitions.
yuchenlin (5):
Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF
file"
Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support"
Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port
I/O."
Revert "OvmfPkg: VMWare SVGA display device register definitions"
OvmfPkg: simply use the Bochs interface for vmsvga
OvmfPkg/Include/IndustryStandard/VmwareSvga.h | 104 ------------
OvmfPkg/QemuVideoDxe/Driver.c | 141 ++--------------
OvmfPkg/QemuVideoDxe/Gop.c | 68 +-------
OvmfPkg/QemuVideoDxe/Initialize.c | 157 ------------------
OvmfPkg/QemuVideoDxe/Qemu.h | 27 ---
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 7 -
OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c | 70 --------
OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c | 80 ---------
OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h | 59 -------
OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c | 78 ---------
OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c | 66 --------
11 files changed, 19 insertions(+), 838 deletions(-)
delete mode 100644 OvmfPkg/Include/IndustryStandard/VmwareSvga.h
delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoGcc.c
delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoIcc.c
delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h
delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c
delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c
--
2.18.0
next reply other threads:[~2018-11-02 3:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 3:23 yuchenlin [this message]
2018-11-02 3:23 ` [PATCH v2 1/5] Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file" yuchenlin
2018-11-06 10:03 ` Laszlo Ersek
2018-11-02 3:23 ` [PATCH v2 2/5] Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" yuchenlin
2018-11-06 10:36 ` Laszlo Ersek
2018-11-02 3:24 ` [PATCH v2 3/5] Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O." yuchenlin
2018-11-06 10:44 ` Laszlo Ersek
2018-11-02 3:24 ` [PATCH v2 4/5] Revert "OvmfPkg: VMWare SVGA display device register definitions" yuchenlin
2018-11-06 10:48 ` Laszlo Ersek
2018-11-02 3:24 ` [PATCH v2 5/5] OvmfPkg: simply use the Bochs interface for vmsvga yuchenlin
2018-11-06 11:47 ` Laszlo Ersek
2018-11-06 13:36 ` Laszlo Ersek
2018-11-06 13:44 ` Philippe Mathieu-Daudé
2018-11-06 16:20 ` Laszlo Ersek
2018-11-07 2:37 ` yuchenlin
2018-11-12 11:19 ` Laszlo Ersek
2018-11-12 11:28 ` Philippe Mathieu-Daudé
2018-11-12 12:21 ` Laszlo Ersek
2018-11-07 2:36 ` yuchenlin
2018-11-05 22:52 ` [PATCH v2 0/5] " Laszlo Ersek
2018-11-12 14:16 ` Philippe Mathieu-Daudé
2018-11-12 15:40 ` Laszlo Ersek
2018-11-15 11:56 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102032402.19686-1-yuchenlin@synology.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox