From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C657D2118A5B3 for ; Fri, 2 Nov 2018 03:15:12 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id x12-v6so1388215wrw.8 for ; Fri, 02 Nov 2018 03:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v7s3GyuTf75FRF+QkA5wa66TxRO96DOI/Jukxsi6g78=; b=LeNOJ1CJwG2L5tKuQGJv+dV6hg/vj/L7Muh8OUmxDysxuHBUfaJzev4AJvObpJm7i1 TBJg8L38o34mwm81drga3dzKvjiULZAbQ3cjYQYVaW2LgtPR9y1c6SvL/k9i2YRNOlYd bD5rcJA4RZFgDjyk9ZD34VVGRKKT+a2dXbp70= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v7s3GyuTf75FRF+QkA5wa66TxRO96DOI/Jukxsi6g78=; b=Sgg4WdEtCzpK+MaHyOSxJiKzowEZsRUosDWQzJE7sWZ9Twnx3Eo2rF/EG1T12JNjIn 6BSGO3hX/SMmX+wfB8tmTz4BPo02gdYG+bYTEuGhqARFAzgES1vNWBHYzsMp9Tq27hkF telLGWCBjULBnJ6oN09QJj5d8y9zhjCPCkOds8TkysznsJWcW7rJ7kL+DqCL2b/Do5JX WD/IOzfGq7+rwf9zWHSABExl4iy8ktIZBFDRrGZjRS02PJcR/iJOjPj3VSbPyH5G0Cf7 Ang5zmBJ8vckeHJaWELoIpzt0JpCYe97iHaNHDQIjrQjTrnaGY6oxkZddQ/F9JI04djK VLlA== X-Gm-Message-State: AGRZ1gIwLLub4kIlmEar34w/BeLmNlxaIGXHqpotZmYVIkUyzbBKxz+z Ai1NKRC8eKREPJ17WxL+pJxz0Ag98HY= X-Google-Smtp-Source: AJdET5eHhw3q1Pu/zdE3EpDkewoyVouxN43gcOAEC0OHw4DsUCoLaFMFDVL4ohnpzYhisoZdjcoJwA== X-Received: by 2002:a5d:5544:: with SMTP id g4-v6mr9351554wrw.222.1541153710480; Fri, 02 Nov 2018 03:15:10 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 195-v6sm33039947wmx.21.2018.11.02.03.15.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Nov 2018 03:15:08 -0700 (PDT) Date: Fri, 2 Nov 2018 10:15:07 +0000 From: Leif Lindholm To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" Message-ID: <20181102101506.wa6b2pnlvkww4gif@bivouac.eciton.net> References: <20181101153642.11315-1-leif.lindholm@linaro.org> <20181101153642.11315-3-leif.lindholm@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E36382B@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E36382B@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:15:13 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 02, 2018 at 01:39:24AM +0000, Gao, Liming wrote: > Leif: > There is one mistake in comments >+ #^M. Could you clean it? > With this change, Reviewed-by: Liming Gao . Whoops, thanks for spotting. Will do. > Besides, have you verified AARCH64 GCC build? AARCH64 and ARM, GCC5 and CLANG38. Several modules from this package are already used by ARM/AARCH64 platforms, it was just not working to build only the package. Regards, Leif > Thanks > Liming > >-----Original Message----- > >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > >Sent: Thursday, November 01, 2018 11:37 PM > >To: edk2-devel@lists.01.org > >Cc: Gao, Liming > >Subject: [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM > > > >Contrary to what the name suggests, some modules in this package are used > >on other architecture. ARM is already listed in SUPPORTED_ARCHITECTURES > >in the .dsc, but AARCH64 was never added. > > > >Add that, and force inclusion of CompilerIntrinsicsLib and > >BaseStackCheckLib for AARCH64/ARM to make the build successful. > > > >Cc: Liming Gao > >Contributed-under: TianoCore Contribution Agreement 1.1 > >Signed-off-by: Leif Lindholm > >--- > > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 13 > >++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > >diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > >b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > >index 894c5340a0..14bef5356e 100644 > >--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > >+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > >@@ -25,7 +25,7 @@ [Defines] > > PLATFORM_VERSION = 0.96 > > DSC_SPECIFICATION = 0x00010005 > > OUTPUT_DIRECTORY = Build/IntelFrameworkModuleAll > >- SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM > >+ SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64 > > BUILD_TARGETS = DEBUG|RELEASE|NOOPT > > SKUID_IDENTIFIER = DEFAULT > > > >@@ -76,6 +76,17 @@ [LibraryClasses] > > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > > > >+[LibraryClasses.ARM, LibraryClasses.AARCH64] > >+ # > >+ # It is not possible to prevent the ARM compiler for generic intrinsic > >functions. > >+ # This library provides the instrinsic functions generate by a given compiler. > >+ # And NULL mean link this library into all ARM images. > >+ #^M > >+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > >+ > >+ # Add support for GCC stack protector > >+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > >+ > > [LibraryClasses.common.PEIM] > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf > >-- > >2.11.0 >