From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26B2221180F5E for ; Tue, 6 Nov 2018 03:02:40 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k15-v6so9992782wre.12 for ; Tue, 06 Nov 2018 03:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h3C9mK6/KqweJ8zDfNGMRLvOa0jl4gmeNfj69JehK9k=; b=j9RU42TC/HMVzYhyfM7qY3E4pONUS7TnnH0iVUhdMzOdMijf4VZ7+6gMqrhN4Vchy6 07kCHIKaM63e+Qd+blb1YFNsxWA3Dgb9lvpVK5o7Hrr17QQaq/hOkGaBsfbphXwhXmXZ 4LpU2n9J6ue+erFK5R9hWRL+iexof8yebkKhk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h3C9mK6/KqweJ8zDfNGMRLvOa0jl4gmeNfj69JehK9k=; b=H7tHVXYTniCykXXMDeXcYsqpFUGK8hLhtk+G7LP7w5RVT7gEhvH+JbJUKOpScCHmfp FkOb47VvtyBV/T2cbTILNoBLp2+CLNlhHwhfsx0ESAuGlmgDCStK4T6XgdMOW9g1wvWK 1E549VynhgpmhnysrtzbVqvXE0R6WOlurSIvXzvVadt4b/XQW4bqZ9xPgRsADt9KPYsy aL+Tupp8ni4R6xwxLWx3vp4pC0rB8MtzsSo8zitB09SQF4lSV5WyEhxsdLajROncLunU /OdCgEBo8Vz0J/H9FhwDzSEj7O21JeKjnQnnFytFVtcqwPpAAD6KRqcFFRtnPgqyG6SJ 8Vjw== X-Gm-Message-State: AGRZ1gKujcj9p8v1wysm/yGrP3ecNGmlvNvF2WL6BVtIIqDAVeKV4/Zz z37U46CWLgQyIa1XTUwA9EoKoA== X-Google-Smtp-Source: AJdET5fXm0frblMeAxDeWHxD+KeasZAvl+7QCv4p1vMjeI/o3G/kouz5h27B8SoU0hPf+aldRYpoAg== X-Received: by 2002:a5d:51cb:: with SMTP id n11-v6mr22599540wrv.121.1541502159134; Tue, 06 Nov 2018 03:02:39 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t82-v6sm1718447wme.30.2018.11.06.03.02.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 03:02:37 -0800 (PST) Date: Tue, 6 Nov 2018 11:02:35 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: "Fu, Siyuan" , "edk2-devel@lists.01.org" Message-ID: <20181106110235.thk7hzjk5eackqe2@bivouac.eciton.net> References: <20181030073328.62924-1-siyuan.fu@intel.com> <20181030105036.sz6opnxgvt4amg75@bivouac.eciton.net> <20181031105911.wr3x4crlu2fnfcti@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH v1 0/7] Delete TCP, PXE, iSCSI driver in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 11:02:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 05, 2018 at 11:12:20PM +0100, Laszlo Ersek wrote: > > Ming Huang (cc) has also had issues with this in his latest set (but > > not before). Can you guys work together to try to figure out what is > > going wrong? > > > > Can you start by testing with an older version of git? > > this is indeed a git regression. I ran into it myself recently, when I > upgraded git from v2.14.1 to v2.19.1. I dug a little into the git source > code, but couldn't spend much time on it. Ultimately I rolled back the > upgrade. Argh. > The diffstats are still well-formed (not truncated) in the individual > patch emails, under v2.19.1, as long as the "recommended" options are > used on the cmdline. However, the cumulative diffstat is truncated > regardless. I couldn't convince git v2.19.1 to keep the previous > (desired) behavior. > > "Documentation/RelNotes/2.17.0.txt" has some words on "diffstat". Thanks for tracking this down. I've submitted a patch here: https://public-inbox.org/git/20181106104811.14625-1-leif.lindholm@linaro.org/T/#u But I guess we'll just need to live with this for a while :/ / Leif