Re: [edk2-test][RFC PATCH 03/12] uefi-sct/SctPkg: sbbr: Add System Environment Configuration Test Cases

[Leif Lindholm <leif.lindholm@linaro.org>]

Hi Sakar,

On Tue, Nov 06, 2018 at 02:17:37PM +0530, Sakar Arora wrote:
> From: John Powell <john.powell@arm.com>
> 
> Add test cases for SBBR v1.0 requirements 3.3.1, 3.3.2, 3.3.3 and 3.3.4.
> 
> Change-Id: I3801314af1ffabaa2d71cee76417c4277f5f5521
> Signed-off-by: John Powell <john.powell@arm.com>
> ---
>  uefi-sct/SctPkg/CommonGenFramework.sh              |   3 +
>  uefi-sct/SctPkg/Config/Data/Category.ini           |  11 +-
>  .../Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.c   |  67 +++
>  .../Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.h   |  81 ++++
>  .../BlackBoxTest/SysEnvConfigBBTest.inf            |  84 ++++
>  .../BlackBoxTest/SysEnvConfigBBTestFunction.c      | 527 +++++++++++++++++++++
>  .../BlackBoxTest/SysEnvConfigBBTestFunction.h      | 104 ++++
>  .../BlackBoxTest/SysEnvConfigBBTestMain.c          | 157 ++++++
>  .../BlackBoxTest/SysEnvConfigBBTestMain.h          |  96 ++++
>  uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc                  |   7 +
>  10 files changed, 1135 insertions(+), 2 deletions(-)

Can you generate patches using the steps outlined in
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
?

This has two major benefits to the reviewer (and can reduce the number
of revisions required for a set):
- full paths are displayed, instead of truncated ones (.../)
- interfaces (or changes to) get reviewed before their first use

>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTest.inf
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestFunction.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestFunction.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestMain.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestMain.h
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh
> index e0f9658..c9b6ca9 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -361,6 +361,9 @@ then
>      cp $ProcessorType/MiscBootServicesBBTest.efi                        $Framework/Test/  > NUL
>      cp $ProcessorType/ProtocolHandlerServicesBBTest.efi                 $Framework/Test/  > NUL
>  
> +    # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4
> +    cp $ProcessorType/SysEnvConfigBBTest.efi                            $Framework/Test/ > NUL
> +
>      # *********************************************
>      # Copy ENTS binary
>      # *********************************************
> diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi-sct/SctPkg/Config/Data/Category.ini
> index 3e9f5e5..9a81c1d 100644
> --- a/uefi-sct/SctPkg/Config/Data/Category.ini
> +++ b/uefi-sct/SctPkg/Config/Data/Category.ini
> @@ -89,8 +89,15 @@ Description   =
>  
>  [Category Data]
>  Revision      = 0x00010000
> -CategoryGuid  = E9EF7553-F833-4E56-96E8-38AE679523CC
> -InterfaceGuid = E9EF7553-F833-4E56-96E8-38AE679523CC
> +CategoryGuid  = D84A6430-99F5-4660-8454-6E4C896A7E51
> +InterfaceGuid = 71652D04-BF38-434a-BCB8-6547D7FD8384
> +Name          = GenericTest\SbbrSysEnvConfig
> +Description   =
> +
> +[Category Data]
> +Revision      = 0x00010000
> +CategoryGuid  = E9EF7553-F833-4e56-96E8-38AE679523CC
> +InterfaceGuid = E9EF7553-F833-4e56-96E8-38AE679523CC
>  Name          = BootServicesTest
>  Description   =

This diff would be much more clear if GenericTest\SbbrSysEnvConfig was
introduced afer the existing BootServicesTest rather than before.

/
    Leif