From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A4DE21188C31 for ; Tue, 6 Nov 2018 09:38:20 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id u9-v6so4157393wrr.0 for ; Tue, 06 Nov 2018 09:38:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mg27Fw78LrhNvnrPHeNc1h2xlex0a3fN5cyH0TXTfrw=; b=DgVq64sfkkBX98jty9P4Vu1sIIFKZpW9u2wjUXUkhyBSQMyNXVDIpkUTcfCkalO8Pu xppB+KRwTz09TQSyCiagrxcz1qlFViA1ZaXqBKTeEfgtad2O6BTo+q3kWpkHFwoEBkBd E/b8M6NuVDMlZ9Bt5aHgVhasCJT9gzBPz4HlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mg27Fw78LrhNvnrPHeNc1h2xlex0a3fN5cyH0TXTfrw=; b=U2F6WSiG+yAYQTVQCWjRo7RZ7qstvZ2iw5D/8XKDwmGu0Fx3CeCZqw/AVr9Y3mi6h8 IzxHYpmZoSDuvz1XHjrTLGWrFPEOaR+VmhO/Wx3IkO0xSB+CX07oILGbRaIDDXDY9EwL SrdnMRglShtoAdMe043rBZOScE4aDp7ZUQl25Iay/uCmDFmwnlqOfQh41bZ7V1/A/y6k KV+p4g0hlHMjIG6SQ9arxYVSkz1dfV6xsb6qZAY2D1rLS9hogqv8yYTQpFf69QZwo9HR LgVYYBc2C1svXUkC0IdyoaPnHR1MaV1pCRrBwZgwNJ+mZU2Y1BStvwB8u0bieo/KNTZd lNFw== X-Gm-Message-State: AGRZ1gIhBpE+I/eNEqL/VNeCqbjkzZOeeNAQbah2nGlabFsxTYcBN0n4 mEovmQX/3jVxQ08bBtO5aiXwUw== X-Google-Smtp-Source: AJdET5fqNluntU4P/opX1r2TUUl7gp1/M54XeCrbwU7epI24k51CFK6Y7nMJt/bwETAFgQTa0BLYvQ== X-Received: by 2002:a5d:68cc:: with SMTP id p12-v6mr26676669wrw.34.1541525898498; Tue, 06 Nov 2018 09:38:18 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z8sm1733194wrw.78.2018.11.06.09.38.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:38:17 -0800 (PST) Date: Tue, 6 Nov 2018 17:38:15 +0000 From: Leif Lindholm To: Sakar Arora Cc: edk2-devel@lists.01.org, prasanth.pulla@arm.com, Eric Jin , Supreeth Venkatesh Message-ID: <20181106173815.2hhkof36f6ghhdv2@bivouac.eciton.net> References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> <1541494066-16288-3-git-send-email-sakar.arora@arm.com> MIME-Version: 1.0 In-Reply-To: <1541494066-16288-3-git-send-email-sakar.arora@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [edk2-test][RFC PATCH 03/12] uefi-sct/SctPkg: sbbr: Add System Environment Configuration Test Cases X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 17:38:20 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sakar, On Tue, Nov 06, 2018 at 02:17:37PM +0530, Sakar Arora wrote: > From: John Powell > > Add test cases for SBBR v1.0 requirements 3.3.1, 3.3.2, 3.3.3 and 3.3.4. > > Change-Id: I3801314af1ffabaa2d71cee76417c4277f5f5521 > Signed-off-by: John Powell > --- > uefi-sct/SctPkg/CommonGenFramework.sh | 3 + > uefi-sct/SctPkg/Config/Data/Category.ini | 11 +- > .../Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.c | 67 +++ > .../Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.h | 81 ++++ > .../BlackBoxTest/SysEnvConfigBBTest.inf | 84 ++++ > .../BlackBoxTest/SysEnvConfigBBTestFunction.c | 527 +++++++++++++++++++++ > .../BlackBoxTest/SysEnvConfigBBTestFunction.h | 104 ++++ > .../BlackBoxTest/SysEnvConfigBBTestMain.c | 157 ++++++ > .../BlackBoxTest/SysEnvConfigBBTestMain.h | 96 ++++ > uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc | 7 + > 10 files changed, 1135 insertions(+), 2 deletions(-) Can you generate patches using the steps outlined in https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 ? This has two major benefits to the reviewer (and can reduce the number of revisions required for a set): - full paths are displayed, instead of truncated ones (.../) - interfaces (or changes to) get reviewed before their first use > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/Guid.h > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTest.inf > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestFunction.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestFunction.h > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestMain.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/SbbrSysEnvConfig/BlackBoxTest/SysEnvConfigBBTestMain.h > > diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh > index e0f9658..c9b6ca9 100755 > --- a/uefi-sct/SctPkg/CommonGenFramework.sh > +++ b/uefi-sct/SctPkg/CommonGenFramework.sh > @@ -361,6 +361,9 @@ then > cp $ProcessorType/MiscBootServicesBBTest.efi $Framework/Test/ > NUL > cp $ProcessorType/ProtocolHandlerServicesBBTest.efi $Framework/Test/ > NUL > > + # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4 > + cp $ProcessorType/SysEnvConfigBBTest.efi $Framework/Test/ > NUL > + > # ********************************************* > # Copy ENTS binary > # ********************************************* > diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi-sct/SctPkg/Config/Data/Category.ini > index 3e9f5e5..9a81c1d 100644 > --- a/uefi-sct/SctPkg/Config/Data/Category.ini > +++ b/uefi-sct/SctPkg/Config/Data/Category.ini > @@ -89,8 +89,15 @@ Description = > > [Category Data] > Revision = 0x00010000 > -CategoryGuid = E9EF7553-F833-4E56-96E8-38AE679523CC > -InterfaceGuid = E9EF7553-F833-4E56-96E8-38AE679523CC > +CategoryGuid = D84A6430-99F5-4660-8454-6E4C896A7E51 > +InterfaceGuid = 71652D04-BF38-434a-BCB8-6547D7FD8384 > +Name = GenericTest\SbbrSysEnvConfig > +Description = > + > +[Category Data] > +Revision = 0x00010000 > +CategoryGuid = E9EF7553-F833-4e56-96E8-38AE679523CC > +InterfaceGuid = E9EF7553-F833-4e56-96E8-38AE679523CC > Name = BootServicesTest > Description = This diff would be much more clear if GenericTest\SbbrSysEnvConfig was introduced afer the existing BootServicesTest rather than before. / Leif