Re: [edk2-test][RFC PATCH 04/12] uefi-sct/SctPkg: sbbr: Add Required UEFI Runtime Services tests.

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 06, 2018 at 02:17:38PM +0530, Sakar Arora wrote:
> Required UEFI Runtime Services Tests - SBBR v1.0 Appendix B
> 1. EFI_GET_TIME
> 2. EFI_SET_TIME
> 3. EFI_GET_WAKEUP_TIME
> 4. EFI_SET_WAKEUP_TIME
> 5. EFI_GET_VARIABLE
> 6. EFI_GET_NEXT_VARIABLE_NAME
> 7. EFI_SET_VARIABLE
> 8. EFI_QUERY_VARIABLE_INFO
> 9. EFI_QUERY_CAPSULE_CAPABILITIES
> 10. EFI_UPDATE_CAPSULE
> 11. EFI_RESET_SYSTEM
> 12. EFI_SET_VIRTUAL_ADDRESS_MAP
> 13. EFI_CONVERT_POINTER
> 
> Signed-off-by: Sakar Arora <sakar.arora@arm.com>
> ---
>  uefi-sct/SctPkg/CommonGenFramework.sh              |   6 +
>  uefi-sct/SctPkg/Config/Data/Category.ini           |  11 +-
>  .../SBBRRuntimeServices/BlackBoxTest/Guid.c        |  61 ++++++
>  .../SBBRRuntimeServices/BlackBoxTest/Guid.h        |  65 ++++++
>  .../BlackBoxTest/SBBRRuntimeServicesBBTest.inf     |  81 ++++++++
>  .../SBBRRuntimeServicesBBTestFunction.c            | 218 +++++++++++++++++++++
>  .../SBBRRuntimeServicesBBTestFunction.h            |  71 +++++++
>  .../BlackBoxTest/SBBRRuntimeServicesBBTestMain.c   | 131 +++++++++++++
>  .../BlackBoxTest/SBBRRuntimeServicesBBTestMain.h   |  86 ++++++++
>  uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc                  |  24 +++
>  10 files changed, 752 insertions(+), 2 deletions(-)
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/Guid.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/Guid.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTest.inf
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestFunction.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestFunction.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestMain.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestMain.h
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh
> index c9b6ca9..bf94d8e 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -364,6 +364,12 @@ then
>      # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4
>      cp $ProcessorType/SysEnvConfigBBTest.efi                            $Framework/Test/ > NUL
>  
> +    # Runtime Services Tests - SBBR v1.0 Appendix B
> +    cp $ProcessorType/VariableServicesBBTest.efi               $Framework/Test/ > NUL
> +    cp $ProcessorType/TimeServicesBBTest.efi                   $Framework/Test/ > NUL
> +    cp $ProcessorType/MiscRuntimeServicesBBTest.efi            $Framework/Test/ > NUL
> +    cp $ProcessorType/SBBRRuntimeServicesBBTest.efi            $Framework/Test/ > NUL
> +
>      # *********************************************
>      # Copy ENTS binary
>      # *********************************************
> diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi-sct/SctPkg/Config/Data/Category.ini
> index 9a81c1d..a41cd0f 100644
> --- a/uefi-sct/SctPkg/Config/Data/Category.ini
> +++ b/uefi-sct/SctPkg/Config/Data/Category.ini
> @@ -173,8 +173,15 @@ Description   =
>  
>  [Category Data]
>  Revision      = 0x00010000
> -CategoryGuid  = 5B1B31A1-9562-11D2-8E3F-00A0C969723B
> -InterfaceGuid = 5B1B31A1-9562-11D2-8E3F-00A0C969723B
> +CategoryGuid  = 52A69BBF-E19F-4e82-93D6-AAC46E2E1E06
> +InterfaceGuid = AFF115FB-387B-4c18-8C41-6AFC7F03BB90
> +Name          = RuntimeServicesTest\SBBRRuntimeServicesTest
> +Description   =
> +
> +[Category Data]
> +Revision      = 0x00010000
> +CategoryGuid  = 5B1B31A1-9562-11d2-8E3F-00A0C969723B
> +InterfaceGuid = 5B1B31A1-9562-11d2-8E3F-00A0C969723B
>  Name          = LoadedImageProtocolTest
>  Description   =

Again, the actual change would be much more clear if
RuntimeServicesTest\SBBRRuntimeServicesTest was added after
LoadedImageProtocolTest.

/
    Leif