From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CEE0521188C31 for ; Tue, 6 Nov 2018 09:40:14 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id d10-v6so14511142wrs.5 for ; Tue, 06 Nov 2018 09:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8g6FEO25ZyGsZ/ZGANfr78o9mtJWyCSLQzUbcXJCFKs=; b=Y6tGPYA4/AJa+rKMZoPw07AMiskrpOGScVEiJSfMh8YzTsug26vhXtRl63QPwR4p7O c5RW7axoHsazuGu45LRmW0RS+WD2wyeFIwvxFA9W6GS53WKP0RWfBGatYB2yyG1NMOTF hAuT9qPbE1ba9dWrP9yM2SXopD9e+gTwek7F4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8g6FEO25ZyGsZ/ZGANfr78o9mtJWyCSLQzUbcXJCFKs=; b=lmJCHPBkEJhL/Dnx7qHYcYU9ix0JhHp43CcsH566Vn3dI5AZGw/b14vEZi1f7TgZvT gH3vHMwyyMMdJQUFM1fHYTN8GtNn7taZk1fo7C3KQhnQGugu/Qv28cM2h/WbnJ1Z06k4 quMjiGYV6jz6X0dVBntjJ1AnQZ0YYLJ+e4K6Po8QsrSTM83j9+VibskuWS473xTu/TGt NEN6sNotc4glVdqKIKIkJ14yDwuDb1AMoeJDdFAQG5S9pdg2qfLsBs7dW1qMV38M+tGG YApRrJUsG2Iz9SqyAac3ApWjGXWaZafcFBXQCx2SAzpvDiqDS2pZ6LN0ffobyyy/C/Pv Z67A== X-Gm-Message-State: AGRZ1gKxByd1VTaRG3wg79HqB5ZnHbrj98SnT4ovH2nB4uArCfHXmX1f Fy5yq3uslHgS4ODRFQGdpf1g4+HtMYk= X-Google-Smtp-Source: AJdET5eqQkgU7fucBZw10YrOua0RDpN1/8g8jVxL1f2e55GB/Q24aPqd28Cts9gz3Q00+3y7kmfczw== X-Received: by 2002:adf:8c09:: with SMTP id z9-v6mr24092711wra.82.1541526013320; Tue, 06 Nov 2018 09:40:13 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w11-v6sm20140423wrr.96.2018.11.06.09.40.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:40:12 -0800 (PST) Date: Tue, 6 Nov 2018 17:40:10 +0000 From: Leif Lindholm To: Sakar Arora Cc: edk2-devel@lists.01.org, prasanth.pulla@arm.com, Eric Jin , Supreeth Venkatesh Message-ID: <20181106174010.ypu3x64xdqo56hub@bivouac.eciton.net> References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> <1541494066-16288-4-git-send-email-sakar.arora@arm.com> MIME-Version: 1.0 In-Reply-To: <1541494066-16288-4-git-send-email-sakar.arora@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [edk2-test][RFC PATCH 04/12] uefi-sct/SctPkg: sbbr: Add Required UEFI Runtime Services tests. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 17:40:15 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 06, 2018 at 02:17:38PM +0530, Sakar Arora wrote: > Required UEFI Runtime Services Tests - SBBR v1.0 Appendix B > 1. EFI_GET_TIME > 2. EFI_SET_TIME > 3. EFI_GET_WAKEUP_TIME > 4. EFI_SET_WAKEUP_TIME > 5. EFI_GET_VARIABLE > 6. EFI_GET_NEXT_VARIABLE_NAME > 7. EFI_SET_VARIABLE > 8. EFI_QUERY_VARIABLE_INFO > 9. EFI_QUERY_CAPSULE_CAPABILITIES > 10. EFI_UPDATE_CAPSULE > 11. EFI_RESET_SYSTEM > 12. EFI_SET_VIRTUAL_ADDRESS_MAP > 13. EFI_CONVERT_POINTER > > Signed-off-by: Sakar Arora > --- > uefi-sct/SctPkg/CommonGenFramework.sh | 6 + > uefi-sct/SctPkg/Config/Data/Category.ini | 11 +- > .../SBBRRuntimeServices/BlackBoxTest/Guid.c | 61 ++++++ > .../SBBRRuntimeServices/BlackBoxTest/Guid.h | 65 ++++++ > .../BlackBoxTest/SBBRRuntimeServicesBBTest.inf | 81 ++++++++ > .../SBBRRuntimeServicesBBTestFunction.c | 218 +++++++++++++++++++++ > .../SBBRRuntimeServicesBBTestFunction.h | 71 +++++++ > .../BlackBoxTest/SBBRRuntimeServicesBBTestMain.c | 131 +++++++++++++ > .../BlackBoxTest/SBBRRuntimeServicesBBTestMain.h | 86 ++++++++ > uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc | 24 +++ > 10 files changed, 752 insertions(+), 2 deletions(-) > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/Guid.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/Guid.h > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTest.inf > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestFunction.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestFunction.h > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestMain.c > create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/SBBRRuntimeServices/BlackBoxTest/SBBRRuntimeServicesBBTestMain.h > > diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh > index c9b6ca9..bf94d8e 100755 > --- a/uefi-sct/SctPkg/CommonGenFramework.sh > +++ b/uefi-sct/SctPkg/CommonGenFramework.sh > @@ -364,6 +364,12 @@ then > # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4 > cp $ProcessorType/SysEnvConfigBBTest.efi $Framework/Test/ > NUL > > + # Runtime Services Tests - SBBR v1.0 Appendix B > + cp $ProcessorType/VariableServicesBBTest.efi $Framework/Test/ > NUL > + cp $ProcessorType/TimeServicesBBTest.efi $Framework/Test/ > NUL > + cp $ProcessorType/MiscRuntimeServicesBBTest.efi $Framework/Test/ > NUL > + cp $ProcessorType/SBBRRuntimeServicesBBTest.efi $Framework/Test/ > NUL > + > # ********************************************* > # Copy ENTS binary > # ********************************************* > diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi-sct/SctPkg/Config/Data/Category.ini > index 9a81c1d..a41cd0f 100644 > --- a/uefi-sct/SctPkg/Config/Data/Category.ini > +++ b/uefi-sct/SctPkg/Config/Data/Category.ini > @@ -173,8 +173,15 @@ Description = > > [Category Data] > Revision = 0x00010000 > -CategoryGuid = 5B1B31A1-9562-11D2-8E3F-00A0C969723B > -InterfaceGuid = 5B1B31A1-9562-11D2-8E3F-00A0C969723B > +CategoryGuid = 52A69BBF-E19F-4e82-93D6-AAC46E2E1E06 > +InterfaceGuid = AFF115FB-387B-4c18-8C41-6AFC7F03BB90 > +Name = RuntimeServicesTest\SBBRRuntimeServicesTest > +Description = > + > +[Category Data] > +Revision = 0x00010000 > +CategoryGuid = 5B1B31A1-9562-11d2-8E3F-00A0C969723B > +InterfaceGuid = 5B1B31A1-9562-11d2-8E3F-00A0C969723B > Name = LoadedImageProtocolTest > Description = Again, the actual change would be much more clear if RuntimeServicesTest\SBBRRuntimeServicesTest was added after LoadedImageProtocolTest. / Leif