Re: [edk2-test][RFC PATCH 07/12] uefi-sct/SctPkg: sbbr: Add test cases for SBBR v1.0 boot services

[Leif Lindholm <leif.lindholm@linaro.org>]

On Tue, Nov 06, 2018 at 02:17:41PM +0530, Sakar Arora wrote:
> From: John Powell <john.powell@arm.com>
> 
> Tests SBBR requirements 3.4.1 and 3.4.4.
> 
> Change-Id: I0dd625851db65d04d2a7572a2d6838951c8f7c67
> Signed-off-by: John Powell <john.powell@arm.com>
> ---
>  uefi-sct/SctPkg/CommonGenFramework.sh              |   3 +
>  uefi-sct/SctPkg/Config/Data/Category.ini           |  11 +-
>  .../SbbrBootServices/BlackBoxTest/Guid.c           |  65 +++
>  .../SbbrBootServices/BlackBoxTest/Guid.h           |  76 +++
>  .../BlackBoxTest/SbbrBootServicesBBTest.inf        |  85 ++++
>  .../BlackBoxTest/SbbrBootServicesBBTestFunction.c  | 549 +++++++++++++++++++++
>  .../BlackBoxTest/SbbrBootServicesBBTestFunction.h  |  85 ++++
>  .../BlackBoxTest/SbbrBootServicesBBTestMain.c      | 149 ++++++
>  .../BlackBoxTest/SbbrBootServicesBBTestMain.h      |  99 ++++
>  uefi-sct/SctPkg/UEFI/SBBR_SCT.dsc                  |   7 +
>  10 files changed, 1127 insertions(+), 2 deletions(-)
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/Guid.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/Guid.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTest.inf
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.h
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestMain.c
>  create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestMain.h
> 
> diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh
> index aecd21b..ab35c5a 100755
> --- a/uefi-sct/SctPkg/CommonGenFramework.sh
> +++ b/uefi-sct/SctPkg/CommonGenFramework.sh
> @@ -364,6 +364,9 @@ then
>      # Tests SBBR sections 3.3.1, 3.3.2, 3.3.3, and 3.3.4
>      cp $ProcessorType/SysEnvConfigBBTest.efi                   $Framework/Test/ > NUL
>  
> +    # UEFI Boot Services - SBBR v1.0 3.4
> +    cp $ProcessorType/SbbrBootServicesBBTest.efi               $Framework/Test/ > NUL
> +
>      # Runtime Services Tests - SBBR v1.0 Appendix B
>      cp $ProcessorType/VariableServicesBBTest.efi               $Framework/Test/ > NUL
>      cp $ProcessorType/TimeServicesBBTest.efi                   $Framework/Test/ > NUL
> diff --git a/uefi-sct/SctPkg/Config/Data/Category.ini b/uefi-sct/SctPkg/Config/Data/Category.ini
> index 9576971..17ca639 100644
> --- a/uefi-sct/SctPkg/Config/Data/Category.ini
> +++ b/uefi-sct/SctPkg/Config/Data/Category.ini
> @@ -145,8 +145,15 @@ Description   =
>  
>  [Category Data]
>  Revision      = 0x00010000
> -CategoryGuid  = AFF115FB-387B-4C18-8C41-6AFC7F03BB90
> -InterfaceGuid = AFF115FB-387B-4C18-8C41-6AFC7F03BB90
> +CategoryGuid  = 8dafd7a7-44d0-4cf4-9d28-9f87080fc091
> +InterfaceGuid = E9EF7553-F833-4E56-96E8-38AE679523CC
> +Name          = BootServicesTest\SbbrBootServices
> +Description   = Tests SBBR boot services requirements.
> +
> +[Category Data]
> +Revision      = 0x00010000
> +CategoryGuid  = AFF115FB-387B-4c18-8C41-6AFC7F03BB90
> +InterfaceGuid = AFF115FB-387B-4c18-8C41-6AFC7F03BB90
>  Name          = RuntimeServicesTest
>  Description   =

Diff would be more clear if added test was added after existing test.

/
    Leif