From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A051A21188C31 for ; Tue, 6 Nov 2018 09:53:30 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id p2-v6so12989952wmc.2 for ; Tue, 06 Nov 2018 09:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dD4pK6t+D58GynudDBY2/EYJhDi6BavK9IajShMW6S4=; b=AGUtCJfrsHKiRRadB7rBfnbOFoLWd+ze6YJqcMxzEw4HzfZm0ne8ByqFX80OvIjAr1 mXwxhLp/8SCMpBtEW7kL8TfbFHGE3nJi9ZQRtj2+fVLFQzfY/bCQ7bYBAN91A02PGvHi bR4i6Zdp6zH2nG8KerNWf+z7Zr3MeXVB/I0yo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dD4pK6t+D58GynudDBY2/EYJhDi6BavK9IajShMW6S4=; b=CDxOQhTPguxk8IabJpKIjTj1IJgQ0Tg1Vkt19ds5oVx6XNxbKW0VgC6r2Hd4MHxSTH PRK7E6lQf/8MLDSRbNDnVbGQelqP7X/UUfOlXwbrwwbDP3r5BB12sM7pCRekw1H+XO5N DyiP+R8EZHlTV5052eLcQH+7muDGvGvAVwtwqUbaEord/6RJgiAlP21PEEr8UX8i3SW0 BoBE3B5fR1f1hrDS1HoNly6wnqpIt9jcuCGLdORN5DD2yPh0iEP7uyIdhraFDBuF/d0Q iPMVHIe0b+9XfYkojysB8cHMLkvATg0HGFLeKttr+6RIHDlggaHHcfS3pDzHmPT7bQ4J RwOw== X-Gm-Message-State: AGRZ1gJn6mNj0uu2dj+6UCE9rlxqokAExG8JbLUzoya5RMOleUontvxy lq6yM5eIQ41b1BLvWcpA/VgNLFqE3Fs= X-Google-Smtp-Source: AJdET5d8VTJJeQvBuMaVaw6xrT6MQRhIlkA+fM5r3Lu7Jeh4lVLhNq+xgzqrem2W3uxigTiDFEsTeg== X-Received: by 2002:a1c:1752:: with SMTP id 79-v6mr2890484wmx.145.1541526809072; Tue, 06 Nov 2018 09:53:29 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c24-v6sm81236133wre.44.2018.11.06.09.53.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:53:28 -0800 (PST) Date: Tue, 6 Nov 2018 17:53:26 +0000 From: Leif Lindholm To: Sakar Arora Cc: edk2-devel@lists.01.org, prasanth.pulla@arm.com, Eric Jin , Supreeth Venkatesh Message-ID: <20181106175326.ajwchv6wxen2o3xe@bivouac.eciton.net> References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> <1541494066-16288-11-git-send-email-sakar.arora@arm.com> MIME-Version: 1.0 In-Reply-To: <1541494066-16288-11-git-send-email-sakar.arora@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 17:53:31 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 06, 2018 at 02:17:45PM +0530, Sakar Arora wrote: > As per SBBR specification, "A UEFI runtime environment compliant with > SBBR must not be written with any assumption of an identity mapping > between virtual and physical memory maps." > > Test case implementation was failing the test, if it is not identity > mapped, which is incorrect. > > Corrected test case to warn the user that UEFI runtime environment is > identity mapped, instead of failure. > > Signed-off-by: Sakar Arora > Reported-by: Felix Poludov > --- > .../SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > index fb50702..c88d60b 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c > @@ -201,13 +201,13 @@ BBTestMemoryMapTest ( > // > // Checking for identity mapping > // > - if (MemoryMapDescriptor->PhysicalStart != MemoryMapDescriptor->VirtualStart) { > + if (MemoryMapDescriptor->PhysicalStart == MemoryMapDescriptor->VirtualStart) { > StandardLib->RecordAssertion ( > StandardLib, > - EFI_TEST_ASSERTION_FAILED, > + EFI_TEST_ASSERTION_WARNING, > gSbbrBootServicesAssertion001Guid, > L"MemoryMap", > - L"%a:%d - MemoryMap 0x%X Not Identity Mapped", > + L"%a:%d - MemoryMap 0x%X is Identity Mapped. UEFI runtime environment must not be written with any assumption of an identity mapping between virtual and physical memory maps.", > __FILE__, > __LINE__, > MemoryMapDescriptor This file was only added as part of this set - please fold this change into the original patch adding it. Development history before upstreaming is not something we need (or want) to track. / Leif > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel