* [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-29 13:54 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
` (19 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
index 21b1fb27984e..ca440bde2cb4 100644
--- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
+++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
@@ -29,7 +29,7 @@
PLATFORM_VERSION = 0.1
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/IntelUndiPkg
- SUPPORTED_ARCHITECTURES = IA32|IPF|X64
+ SUPPORTED_ARCHITECTURES = IA32|IPF|X64|ARM|AARCH64
BUILD_TARGETS = DEBUG|RELEASE|DEV
SKUID_IDENTIFIER = DEFAULT
@@ -62,6 +62,17 @@
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+[LibraryClasses.ARM, LibraryClasses.AARCH64]
+ #
+ # It is not possible to prevent the ARM compiler from inserting calls to
+ # intrinsic functions. This library provides the instrinsic functions such
+ # a compiler may generate calls to.
+ #
+ NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
+
+ # Add support for GCC stack protector
+ NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
################################################################################
#
# Pcd Section - list of all EDK II PCD Entries defined by this Platform
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures
2018-11-06 17:58 ` [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures Ard Biesheuvel
@ 2019-01-29 13:54 ` Ryszard Knop
2019-01-29 14:04 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 13:54 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
One thing of note here: We're primarily using MSVC for IA32/X64 builds,
and that's the only thing we "officially" support. I'll try to build
and test GCC binaries once in a while as well, but things might break
once now and then. Our team also doesn't have any ARM hardware to test
this on, so I'd appreciate any reports if it breaks :)
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> index 21b1fb27984e..ca440bde2cb4 100644
> --- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> +++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> @@ -29,7 +29,7 @@
> PLATFORM_VERSION = 0.1
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/IntelUndiPkg
> - SUPPORTED_ARCHITECTURES = IA32|IPF|X64
> + SUPPORTED_ARCHITECTURES = IA32|IPF|X64|ARM|AARCH64
> BUILD_TARGETS = DEBUG|RELEASE|DEV
> SKUID_IDENTIFIER = DEFAULT
>
> @@ -62,6 +62,17 @@
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynch
> ronizationLib.inf
> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib
> /BaseDebugPrintErrorLevelLib.inf
>
> +[LibraryClasses.ARM, LibraryClasses.AARCH64]
> + #
> + # It is not possible to prevent the ARM compiler from inserting
> calls to
> + # intrinsic functions. This library provides the instrinsic
> functions such
> + # a compiler may generate calls to.
> + #
> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.in
> f
> +
> + # Add support for GCC stack protector
> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> ####################################################################
> ############
> #
> # Pcd Section - list of all EDK II PCD Entries defined by this
> Platform
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures
2019-01-29 13:54 ` Ryszard Knop
@ 2019-01-29 14:04 ` Ard Biesheuvel
0 siblings, 0 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2019-01-29 14:04 UTC (permalink / raw)
To: Ryszard Knop
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Tue, 29 Jan 2019 at 14:54, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> One thing of note here: We're primarily using MSVC for IA32/X64 builds,
> and that's the only thing we "officially" support. I'll try to build
> and test GCC binaries once in a while as well, but things might break
> once now and then. Our team also doesn't have any ARM hardware to test
> this on, so I'd appreciate any reports if it breaks :)
>
> Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
>
Thanks!
Let me know once these changes have hit the upstream. I'll add GCC
builds for IA32, X64, ARM and AARCH64 to our CI setup.
> On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > ---
> > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> > b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> > index 21b1fb27984e..ca440bde2cb4 100644
> > --- a/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> > +++ b/IntelUndiPkg/IntelOpenSourceUndiPkg.dsc
> > @@ -29,7 +29,7 @@
> > PLATFORM_VERSION = 0.1
> > DSC_SPECIFICATION = 0x00010005
> > OUTPUT_DIRECTORY = Build/IntelUndiPkg
> > - SUPPORTED_ARCHITECTURES = IA32|IPF|X64
> > + SUPPORTED_ARCHITECTURES = IA32|IPF|X64|ARM|AARCH64
> > BUILD_TARGETS = DEBUG|RELEASE|DEV
> > SKUID_IDENTIFIER = DEFAULT
> >
> > @@ -62,6 +62,17 @@
> > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynch
> > ronizationLib.inf
> > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib
> > /BaseDebugPrintErrorLevelLib.inf
> >
> > +[LibraryClasses.ARM, LibraryClasses.AARCH64]
> > + #
> > + # It is not possible to prevent the ARM compiler from inserting
> > calls to
> > + # intrinsic functions. This library provides the instrinsic
> > functions such
> > + # a compiler may generate calls to.
> > + #
> > + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.in
> > f
> > +
> > + # Add support for GCC stack protector
> > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> > +
> > ####################################################################
> > ############
> > #
> > # Pcd Section - list of all EDK II PCD Entries defined by this
> > Platform
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 19:34 ` Philippe Mathieu-Daudé
2019-01-29 13:58 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
` (18 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Remove the Ctrl-Z markers at the end of each file: these break the
GCC build on Linux.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 1 -
IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
IntelUndiPkg/GigUndiDxe/ComponentName.c | 1 -
IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 -
IntelUndiPkg/GigUndiDxe/Decode.c | 1 -
IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 1 -
IntelUndiPkg/GigUndiDxe/Dma.c | 1 -
IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 1 -
IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 -
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
IntelUndiPkg/GigUndiDxe/DriverHealth.c | 1 -
IntelUndiPkg/GigUndiDxe/E1000.c | 1 -
IntelUndiPkg/GigUndiDxe/E1000.h | 1 -
IntelUndiPkg/GigUndiDxe/E1000_osdep.c | 1 -
IntelUndiPkg/GigUndiDxe/E1000_osdep.h | 1 -
IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
IntelUndiPkg/GigUndiDxe/EepromConfig.h | 1 -
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 1 -
IntelUndiPkg/GigUndiDxe/Hii.c | 1 -
IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 1 -
IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
IntelUndiPkg/GigUndiDxe/Init.c | 1 -
IntelUndiPkg/GigUndiDxe/Init.h | 1 -
IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 1 -
IntelUndiPkg/GigUndiDxe/StartStop.c | 1 -
IntelUndiPkg/GigUndiDxe/StartStop.h | 1 -
IntelUndiPkg/GigUndiDxe/Version.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_defines.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 1 -
IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
170 files changed, 170 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
index 8268f0da5e9b..b0320b11839b 100644
--- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
+++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
@@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
SetInformation,
GetSupportedTypes
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
index 72d08a891d06..3b2039bc5cb2 100644
--- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
+++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
@@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
#endif /* ADAPTER_INFORMATION_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Brand.c b/IntelUndiPkg/GigUndiDxe/Brand.c
index 2aba217eb4c5..b29ebce16c71 100644
--- a/IntelUndiPkg/GigUndiDxe/Brand.c
+++ b/IntelUndiPkg/GigUndiDxe/Brand.c
@@ -213,4 +213,3 @@ BRAND_STRUCT mBrandingTable[] = {
};
UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
index 6ee0dd991505..1473bfbed0af 100644
--- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
+++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
@@ -272,4 +272,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
EFI_2_70_SYSTEM_TABLE_REVISION
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h
index e3a386ea66f3..5a3d414c6970 100644
--- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
+++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
@@ -72,4 +72,3 @@ ComponentNameGetDriverName (
);
#endif /* COMPONENT_NAME_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
index f858abe10785..88e8be315bd1 100644
--- a/IntelUndiPkg/GigUndiDxe/Decode.c
+++ b/IntelUndiPkg/GigUndiDxe/Decode.c
@@ -1866,4 +1866,3 @@ BadCdb:
CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Decode.h b/IntelUndiPkg/GigUndiDxe/Decode.h
index b00670f4d290..fb01267d0b2f 100644
--- a/IntelUndiPkg/GigUndiDxe/Decode.h
+++ b/IntelUndiPkg/GigUndiDxe/Decode.h
@@ -46,4 +46,3 @@ E1000UndiApiEntry (
);
#endif /* DECODE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
index 47c2a07a0f16..3ffc25d58a3f 100644
--- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
+++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
@@ -189,4 +189,3 @@ IsDeviceIdSupported (
}
return FALSE;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
index a0d6b613285d..f309044d9b9d 100644
--- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
+++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
@@ -81,4 +81,3 @@ IsDeviceIdSupported (
UINT16 DeviceId
);
#endif /* DEVICE_SUPPORT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
index 7f32361ef678..76a3fcf69601 100644
--- a/IntelUndiPkg/GigUndiDxe/Dma.c
+++ b/IntelUndiPkg/GigUndiDxe/Dma.c
@@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
return Status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Dma.h b/IntelUndiPkg/GigUndiDxe/Dma.h
index 6763c83dca39..3422acd500de 100644
--- a/IntelUndiPkg/GigUndiDxe/Dma.h
+++ b/IntelUndiPkg/GigUndiDxe/Dma.h
@@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
);
#endif /* _DMA_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
index 9aec9422f1d6..118c1b2b9b04 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
@@ -571,4 +571,3 @@ EFI_DRIVER_CONFIGURATION_PROTOCOL gGigUndiDriverConfiguration = {
GigUndiDriverConfigurationForceDefaults,
"eng"
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
index 9464cddbb756..a15a3a0a2745 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
+++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
@@ -38,4 +38,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MENU_EXIT 6
#endif /* DRIVER_CONFIGURATION_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
index 19b63b6059f6..a9f176ce5324 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
@@ -1548,4 +1548,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gGigUndiDriverDiagnostics2 = {
(EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) GigUndiDriverDiagnosticsRunDiagnostics,
"en-US"
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
index 2a3fe772e80a..c0f984953065 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
@@ -82,4 +82,3 @@ typedef struct {
#pragma pack()
#endif /* DRIVER_DIAGNOSTICS_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
index 83de9e89ab66..b1af371e06db 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
@@ -134,4 +134,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
GetHealthStatus,
Repair
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/E1000.c
index 842778a70d01..fad20d988441 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000.c
+++ b/IntelUndiPkg/GigUndiDxe/E1000.c
@@ -2455,4 +2455,3 @@ WaitForEnter (
gST->ConIn->ReadKeyStroke (gST->ConIn, &Key);
} while (Key.UnicodeChar != 0xD);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/E1000.h
index 38e88f0fd56d..71fe4591af05 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000.h
+++ b/IntelUndiPkg/GigUndiDxe/E1000.h
@@ -1212,4 +1212,3 @@ WaitForEnter (
#endif /* E1000_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
index 4761e7dde99e..0d0047a93048 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
+++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
@@ -639,4 +639,3 @@ e1000_pci_clear_mwi (
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
index 2b5562f21e47..01c0843a2c9a 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
+++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
@@ -575,4 +575,3 @@ typedef BOOLEAN boolean_t;
#endif /* E1000_OSDEP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.c b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
index 8a5cb62190f9..19d867ee58af 100644
--- a/IntelUndiPkg/GigUndiDxe/EepromConfig.c
+++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
@@ -861,4 +861,3 @@ EepromUpdateChecksum (
return EFI_SUCCESS;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
index bd9fa5c0afb2..e0d31f6a151d 100644
--- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
+++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
@@ -204,4 +204,3 @@ EepromUpdateChecksum (
);
#endif /* EEPROM_CONFIG_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
index e52a78723cbf..2d2d0707a686 100644
--- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
+++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
@@ -163,4 +163,3 @@ wol\wol_1G.c
gEfiIfrTianoGuid ## CONSUMES ## Guid
gEfiEventExitBootServicesGuid ## PRODUCES ## Event
gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
index 85818fe964c5..43c184cb03c8 100644
--- a/IntelUndiPkg/GigUndiDxe/Hii.c
+++ b/IntelUndiPkg/GigUndiDxe/Hii.c
@@ -1238,4 +1238,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
RouteConfig,
DriverCallback
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.h b/IntelUndiPkg/GigUndiDxe/Hii.h
index aa39eae7faea..5afdfc8cd174 100644
--- a/IntelUndiPkg/GigUndiDxe/Hii.h
+++ b/IntelUndiPkg/GigUndiDxe/Hii.h
@@ -90,4 +90,3 @@ HiiUnload (
);
#endif /* HII_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
index 21ec03193e26..2aacb63ca158 100644
--- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
+++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
@@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
return EFI_BUFFER_TOO_SMALL;
}
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
index 49abbd280c01..28298652403a 100644
--- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
+++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
@@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
);
#endif /* HII_INTERNAL_LIB_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
index dad31a5f0844..47ed03eb0849 100644
--- a/IntelUndiPkg/GigUndiDxe/Init.c
+++ b/IntelUndiPkg/GigUndiDxe/Init.c
@@ -1876,4 +1876,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
NULL, // ImageHandle
NULL // Driver Binding Handle
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Init.h b/IntelUndiPkg/GigUndiDxe/Init.h
index 308f003ce038..409cb7082340 100644
--- a/IntelUndiPkg/GigUndiDxe/Init.h
+++ b/IntelUndiPkg/GigUndiDxe/Init.h
@@ -45,4 +45,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MAC_ADDRESS_SIZE_IN_BYTES 6
#endif /* INIT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Inventory.vfr b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
index 2c59c380fc09..a6cacaff4e17 100644
--- a/IntelUndiPkg/GigUndiDxe/Inventory.vfr
+++ b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
@@ -370,4 +370,3 @@ formset
endformset;
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
index 50945f37437c..bd7d4defc9a3 100644
--- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
+++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
@@ -136,4 +136,3 @@ typedef struct {
#define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
#define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
#endif /* NV_DATA_STRUC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
index 8b17507ebf4d..10ab4e51bf44 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.c
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
@@ -103,4 +103,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
StopDriver,
StartDriver
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
index fdc0d5b6c1f6..24304d6cc3a7 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.h
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
@@ -67,4 +67,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
};
#endif /* START_STOP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/Version.h b/IntelUndiPkg/GigUndiDxe/Version.h
index 11d9a607c4fa..b3019889634b 100644
--- a/IntelUndiPkg/GigUndiDxe/Version.h
+++ b/IntelUndiPkg/GigUndiDxe/Version.h
@@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MAJORVERSION 4 /* GigUndi major version */
#define MINORVERSION 9 /* GigUndi minor version */
#define BUILDNUMBER 99 /* GigUndi build version */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
index c1ffc814236e..4264f2470f02 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
@@ -1532,4 +1532,3 @@ STATIC void e1000_clear_hw_cntrs_80003es2lan(struct e1000_hw *hw)
E1000_READ_REG(hw, E1000_ICTXQMTC);
E1000_READ_REG(hw, E1000_ICRXDMTC);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
index a37545399c97..df2c53318ce5 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
@@ -93,4 +93,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define GG82563_ICR_DIS_PADDING 0x0010 /* Disable Padding */
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.c b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
index 463e8c6eaa87..d970ce7292b8 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_82571.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
@@ -2079,4 +2079,3 @@ STATIC void e1000_clear_hw_cntrs_82571(struct e1000_hw *hw)
E1000_READ_REG(hw, E1000_ICTXQMTC);
E1000_READ_REG(hw, E1000_ICRXDMTC);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.h b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
index 8862e3e17dce..3df568892529 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_82571.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
@@ -60,4 +60,3 @@ bool e1000_get_laa_state_82571(struct e1000_hw *hw);
void e1000_set_laa_state_82571(struct e1000_hw *hw, bool state);
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.c b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
index f6ad91d4a2d5..b052a38f5d80 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_82575.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
@@ -3342,4 +3342,3 @@ void e1000_write_vfta_i350(struct e1000_hw *hw, u32 offset, u32 value)
}
#endif /* NO_82580_SUPPORT */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.h b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
index 39c1b38324ed..5e6be621ec13 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_82575.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
@@ -433,4 +433,3 @@ s32 e1000_initialize_M88E1512_phy(struct e1000_hw *hw);
s32 e1000_initialize_M88E1543_phy(struct e1000_hw *hw);
#endif /* NO_82580_SUPPORT */
#endif /* _E1000_82575_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.c b/IntelUndiPkg/GigUndiDxe/e1000_api.c
index 1a8e45a2e86f..195992d46a34 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_api.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_api.c
@@ -1280,4 +1280,3 @@ void e1000_shutdown_fiber_serdes_link(struct e1000_hw *hw)
}
#endif /* NO_82575_SUPPORT */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.h b/IntelUndiPkg/GigUndiDxe/e1000_api.h
index c35c366f5e91..6a75ec899a07 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_api.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_api.h
@@ -176,4 +176,3 @@ s32 e1000_mng_write_dhcp_info(struct e1000_hw *hw, u8 *buffer, u16 length);
#define E1000_DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) /* ceil(a/b) */
#endif
#endif /* _E1000_API_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
index 5052b7925c3b..1d07d30aa18e 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
@@ -1636,4 +1636,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define ERROR_REPORT(fmt) do { } while (0)
#endif /* ERROR_REPORT */
#endif /* _E1000_DEFINES_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_hw.h b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
index 86d163e57906..27e34f5ae824 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_hw.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
@@ -969,4 +969,3 @@ void e1000_write_pci_cfg(struct e1000_hw *hw, u32 reg, u16 *value);
#endif
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.c b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
index b485e739a434..5d05e3853361 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_i210.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
@@ -869,4 +869,3 @@ s32 e1000_init_hw_i210(struct e1000_hw *hw)
ret_val = e1000_init_hw_82575(hw);
return ret_val;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.h b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
index 3532126852b1..bde07d357ed6 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_i210.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
@@ -97,4 +97,3 @@ enum E1000_INVM_STRUCTURE_TYPE {
#define E1000_INVM_PLL_WO_VAL 0x0010
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
index e3a3606f8527..7669630a5c03 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
@@ -5684,4 +5684,3 @@ release:
}
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
index 26fe0200e5a4..a435418078d2 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
@@ -290,4 +290,3 @@ s32 e1000_read_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 *data);
s32 e1000_write_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 data);
s32 e1000_set_eee_pchlan(struct e1000_hw *hw);
#endif /* _E1000_ICH8LAN_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.c b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
index a0a13da26316..f3727b9bc0de 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_mac.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
@@ -2293,4 +2293,3 @@ s32 e1000_write_8bit_ctrl_reg_generic(struct e1000_hw *hw, u32 reg,
return E1000_SUCCESS;
}
#endif /* NO_82575_SUPPORT */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.h b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
index 95fb00f3dc87..b8990d908b45 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_mac.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
@@ -97,4 +97,3 @@ void e1000_update_adaptive_generic(struct e1000_hw *hw);
void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32 value);
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.c b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
index 4bf703b2de4a..5fc7fa5704ac 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_manage.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
@@ -582,4 +582,3 @@ s32 e1000_load_firmware(struct e1000_hw *hw, u8 *buffer, u32 length)
#endif /* NO_I210_SUPPORT */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.h b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
index c9002a244a46..090a9a25de63 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_manage.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
@@ -100,4 +100,3 @@ enum e1000_mng_mode {
#define E1000_IAMT_SIGNATURE 0x544D4149
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
index 26244874f4e3..e46130186223 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
@@ -1310,4 +1310,3 @@ STATIC void e1000_reload_nvm_generic(struct e1000_hw *hw)
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
index 06a668f5e912..ef84c51dbeb9 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
@@ -92,4 +92,3 @@ void e1000_release_nvm_generic(struct e1000_hw *hw);
#define E1000_STM_OPCODE 0xDB00
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.c b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
index b1c66d263183..765fcf387d7e 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_phy.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
@@ -4465,4 +4465,3 @@ s32 e1000_write_xmdio_reg(struct e1000_hw *hw, u16 addr, u8 dev_addr, u16 data)
false);
}
#endif /* NO_XMDIO_SUPPORT */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.h b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
index de82fde1f035..3efc73b006ee 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_phy.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
@@ -349,4 +349,3 @@ struct sfp_e1000_flags {
#endif /* NO_82575_SUPPORT */
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_regs.h b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
index 8568edc310a5..d6c66b92e94e 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_regs.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
@@ -772,4 +772,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endif /* NO_I210_SUPPORT */
#endif
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.c b/IntelUndiPkg/GigUndiDxe/wol/wol.c
index 79100219b85b..74ffeafd787a 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wol.c
+++ b/IntelUndiPkg/GigUndiDxe/wol/wol.c
@@ -341,4 +341,3 @@ WolEnableWakeOnLanEx(
return WolGetWakeOnLanStatusEx(Handle);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.h b/IntelUndiPkg/GigUndiDxe/wol/wol.h
index 5ac38d6a3602..4f3140e152f8 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wol.h
+++ b/IntelUndiPkg/GigUndiDxe/wol/wol.h
@@ -84,4 +84,3 @@ WolEnableApmPme(
#endif /* __WOL_H */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
index bba2393d6ff3..02eff0957976 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
+++ b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
@@ -183,4 +183,3 @@ WOL_STATUS _WolEnableLaser(WOL_ADAPTER_HANDLE_TYPE Handle, BOOLEAN Enable)
return WOL_FEATURE_NOT_SUPPORTED;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
index 49d901defd4d..2c35be00f36a 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
+++ b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
@@ -163,4 +163,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
0
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
index a5d536ee99c2..311930372f8b 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
+++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
@@ -166,4 +166,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
return Handle->NicInfo.Function;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
index 84863eddc54e..ed2ffc427093 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
+++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
@@ -77,4 +77,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
#endif /* __WOLIMPL_H */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
index c99667a25f8e..4df14ce2abf6 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
+++ b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
@@ -334,4 +334,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = {
{ 0, 0, 0, 0, 0 } /* Last entry */
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
index 7b8b78daf29b..b2801a673d6e 100644
--- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
+++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
@@ -410,4 +410,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
SetInformation,
GetSupportedTypes
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
index d5d5d52697c1..1401fbdb92fe 100644
--- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
+++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
@@ -102,4 +102,3 @@ UninstallAdapterInformationProtocol (
#endif /* ADAPTER_INFORMATION_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Brand.c b/IntelUndiPkg/I40eUndiDxe/Brand.c
index 250184d8b3ca..22629a933174 100644
--- a/IntelUndiPkg/I40eUndiDxe/Brand.c
+++ b/IntelUndiPkg/I40eUndiDxe/Brand.c
@@ -210,4 +210,3 @@ BRAND_STRUCT mBrandingTable[] = {
UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.c b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
index cb83d3a79dd9..1241862adb81 100644
--- a/IntelUndiPkg/I40eUndiDxe/ComponentName.c
+++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
@@ -275,4 +275,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
EFI_2_70_SYSTEM_TABLE_REVISION
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.h b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
index ed26dcb81b5b..dca634039b66 100644
--- a/IntelUndiPkg/I40eUndiDxe/ComponentName.h
+++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
@@ -73,4 +73,3 @@ ComponentNameGetDriverName (
);
#endif /* COMPONENT_NAME_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.c b/IntelUndiPkg/I40eUndiDxe/Decode.c
index d84255be0f6c..e47979e59126 100644
--- a/IntelUndiPkg/I40eUndiDxe/Decode.c
+++ b/IntelUndiPkg/I40eUndiDxe/Decode.c
@@ -1881,4 +1881,3 @@ BadCdb:
CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.h b/IntelUndiPkg/I40eUndiDxe/Decode.h
index 59f79e0abf5e..555d35620474 100644
--- a/IntelUndiPkg/I40eUndiDxe/Decode.h
+++ b/IntelUndiPkg/I40eUndiDxe/Decode.h
@@ -48,4 +48,3 @@ UndiApiEntry (
#endif /* DECODE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
index 4d1061a794e4..007d651d126f 100644
--- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
+++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
@@ -202,4 +202,3 @@ IsDeviceIdSupported (
}
return FALSE;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
index b26f0ff0ec8c..b0de9f40c572 100644
--- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
+++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
@@ -82,4 +82,3 @@ IsDeviceIdSupported (
UINT16 DeviceId
);
#endif /* DEVICE_SUPPORT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.c b/IntelUndiPkg/I40eUndiDxe/Dma.c
index 17f14bd043f1..9efa705cb6f0 100644
--- a/IntelUndiPkg/I40eUndiDxe/Dma.c
+++ b/IntelUndiPkg/I40eUndiDxe/Dma.c
@@ -283,4 +283,3 @@ UndiDmaUnmapMemory (
return Status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.h b/IntelUndiPkg/I40eUndiDxe/Dma.h
index 58a1f234b5df..d0d00463aa63 100644
--- a/IntelUndiPkg/I40eUndiDxe/Dma.h
+++ b/IntelUndiPkg/I40eUndiDxe/Dma.h
@@ -133,4 +133,3 @@ UndiDmaUnmapMemory (
);
#endif /* _DMA_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
index 536ff7a65522..de07eb0f254f 100644
--- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
@@ -1131,4 +1131,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gUndiDriverDiagnostics2 = {
"en-US"
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
index a6a725c33aa9..c3414f3897fe 100644
--- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
+++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
@@ -80,4 +80,3 @@ typedef struct {
#endif /* DRIVER_DIAGNOSTICS_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
index 500ca3685cfc..30df2f3ec7d0 100644
--- a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
+++ b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
@@ -161,4 +161,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
GetHealthStatus,
Repair
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
index c32302879390..da1d22057dcb 100644
--- a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
+++ b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
@@ -35,4 +35,3 @@ typedef enum {
MODULE_UNSUPPORTED,
} MODULE_QUALIFICATION_STATUS;
#endif /* DRIVER_HEALTH_COMMON_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
index cc47e0437e80..4772715b3979 100644
--- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
+++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
@@ -1254,4 +1254,3 @@ EepromReadPortnumValues (
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
index e547d88b82b4..97e8be1ae80e 100644
--- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
+++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
@@ -556,4 +556,3 @@ EepromReadPortnumValues (
#endif /* EEPROM_CONFIG_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.c b/IntelUndiPkg/I40eUndiDxe/Hii.c
index e411f23d14ce..404e3672aa87 100644
--- a/IntelUndiPkg/I40eUndiDxe/Hii.c
+++ b/IntelUndiPkg/I40eUndiDxe/Hii.c
@@ -1254,4 +1254,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
RouteConfig,
DriverCallback
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.h b/IntelUndiPkg/I40eUndiDxe/Hii.h
index e8e916a5ee90..8ab5108e2c8b 100644
--- a/IntelUndiPkg/I40eUndiDxe/Hii.h
+++ b/IntelUndiPkg/I40eUndiDxe/Hii.h
@@ -91,4 +91,3 @@ HiiUnload (
);
#endif /* HII_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
index 4e6e28fdb5c0..365ed7f2da80 100644
--- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
+++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
@@ -486,4 +486,3 @@ AsciiStrToUnicodeStrWrapper (
return EFI_BUFFER_TOO_SMALL;
}
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
index 16655f384db3..b5ee09c49c9b 100644
--- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
+++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
@@ -163,4 +163,3 @@ AsciiStrToUnicodeStrWrapper (
);
#endif /* HII_INTERNAL_LIB_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.c b/IntelUndiPkg/I40eUndiDxe/I40e.c
index ecf83ebc86df..c2501e4222f5 100644
--- a/IntelUndiPkg/I40eUndiDxe/I40e.c
+++ b/IntelUndiPkg/I40eUndiDxe/I40e.c
@@ -3461,4 +3461,3 @@ I40eGetTxRxDescriptorsCount (
return I40E_DEF_NUM_TX_RX_DESCRIPTORS;
}
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.h b/IntelUndiPkg/I40eUndiDxe/I40e.h
index c5aabf6d7d69..9b994c5ec1c9 100644
--- a/IntelUndiPkg/I40eUndiDxe/I40e.h
+++ b/IntelUndiPkg/I40eUndiDxe/I40e.h
@@ -1504,4 +1504,3 @@ I40eGetTxRxDescriptorsCount (
);
#endif /* I40E_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
index 76df7898bef1..caff5262f6e6 100644
--- a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
+++ b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
@@ -157,4 +157,3 @@ MSFT:*_*_*_CC_FLAGS = /FAcs
gEfiIfrTianoGuid ## CONSUMES ## Guid
gEfiEventExitBootServicesGuid ## PRODUCES ## Event
gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
index 88a9547fc45b..ddd4449ad65c 100644
--- a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
+++ b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
@@ -601,4 +601,3 @@ DelayInMicroseconds (
#endif /* I40E_OSDEP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Init.c b/IntelUndiPkg/I40eUndiDxe/Init.c
index d45d669887d8..68a1699b00ba 100644
--- a/IntelUndiPkg/I40eUndiDxe/Init.c
+++ b/IntelUndiPkg/I40eUndiDxe/Init.c
@@ -2300,4 +2300,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
NULL,
NULL
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Init.h b/IntelUndiPkg/I40eUndiDxe/Init.h
index 217ed75cd179..899eeda1e6df 100644
--- a/IntelUndiPkg/I40eUndiDxe/Init.h
+++ b/IntelUndiPkg/I40eUndiDxe/Init.h
@@ -87,4 +87,3 @@ UndiGetDriverHealthStatus (
);
#endif /* INIT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
index a64b9297291b..ea48aad2bc85 100644
--- a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
+++ b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
@@ -369,4 +369,3 @@ formset
endformset;
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
index 8387a99ae5bc..412cbf4833c7 100644
--- a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
+++ b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
@@ -138,4 +138,3 @@ typedef struct {
#define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
#define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
#endif /* NV_DATA_STRUC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.c b/IntelUndiPkg/I40eUndiDxe/StartStop.c
index 32c9c5e09655..b375b52fe882 100644
--- a/IntelUndiPkg/I40eUndiDxe/StartStop.c
+++ b/IntelUndiPkg/I40eUndiDxe/StartStop.c
@@ -169,4 +169,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
StartDriver
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.h b/IntelUndiPkg/I40eUndiDxe/StartStop.h
index 5ebf063e4913..d80fe79cbc3a 100644
--- a/IntelUndiPkg/I40eUndiDxe/StartStop.h
+++ b/IntelUndiPkg/I40eUndiDxe/StartStop.h
@@ -79,4 +79,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
#endif /* START_STOP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/Version.h b/IntelUndiPkg/I40eUndiDxe/Version.h
index dfb94cedd04c..e5a47633ddf1 100644
--- a/IntelUndiPkg/I40eUndiDxe/Version.h
+++ b/IntelUndiPkg/I40eUndiDxe/Version.h
@@ -30,4 +30,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MAJORVERSION 4 /* I40eUndi major version */
#define MINORVERSION 9 /* I40eUndi minor version */
#define BUILDNUMBER 99 /* I40eUndi build version */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
index af443b398bb9..7d11d1ce4d6a 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
@@ -1095,4 +1095,3 @@ clean_arq_element_err:
return ret_code;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
index d17fe42cae96..51f0af909516 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
@@ -118,4 +118,3 @@ void i40e_fill_default_direct_cmd_desc(struct i40e_aq_desc *desc,
u16 opcode);
#endif /* _I40E_ADMINQ_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
index 8c0c6665ee55..78ec00252201 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
@@ -2974,4 +2974,3 @@ struct i40e_aqc_debug_modify_internals {
I40E_CHECK_CMD_LENGTH(i40e_aqc_debug_modify_internals);
#endif /* _I40E_ADMINQ_CMD_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
index 2f82f8dd72a5..51d83526207b 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
@@ -60,4 +60,3 @@ enum i40e_status_code i40e_free_virt_mem(struct i40e_hw *hw,
struct i40e_virt_mem *mem);
#endif /* _I40E_ALLOC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_common.c b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
index 01bcfeed279c..faa7b8d7483e 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_common.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
@@ -7631,4 +7631,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
track_id, &offset, &info, NULL);
return status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
index 143c3b10c025..64aa672e0004 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
@@ -68,4 +68,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
(d) == I40E_DEV_ID_25G_SFP28)
#endif /* _I40E_DEVIDS_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
index f57fc65f60e0..62e8f8428aaa 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
@@ -193,4 +193,3 @@ enum i40e_status_code i40e_diag_fw_alive_test(struct i40e_hw *hw)
UNREFERENCED_1PARAMETER(hw);
return I40E_SUCCESS;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
index 322cefb45732..4cda8b3444e6 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
@@ -56,4 +56,3 @@ enum i40e_status_code i40e_diag_reg_test(struct i40e_hw *hw);
enum i40e_status_code i40e_diag_eeprom_test(struct i40e_hw *hw);
#endif /* _I40E_DIAG_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
index 28ff0ace4680..b5c084bf3372 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
@@ -366,4 +366,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw,
return i40e_free_dma_mem(hw, &(sd_entry->u.pd_table.pd_page_addr));
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
index c7844edcb7ba..97ff0724729c 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
@@ -240,4 +240,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw,
u32 idx, bool is_pf);
#endif /* _I40E_HMC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
index 93f477d0268d..4720d9f0cc83 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
@@ -1610,4 +1610,3 @@ enum i40e_status_code i40e_set_lan_rx_queue_context_directly(struct i40e_hw *hw,
return i40e_write_queue_context_directly(hw, queue, context_bytes,
I40E_HMC_LAN_RX);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
index a5d59679af17..8842ac04470d 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
@@ -206,4 +206,3 @@ enum i40e_status_code i40e_delete_lan_hmc_object(struct i40e_hw *hw,
struct i40e_hmc_lan_delete_obj_info *info);
#endif /* _I40E_LAN_HMC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
index ef1774c8cc2e..0187d6ecb522 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
@@ -758,4 +758,3 @@ enum i40e_status_code i40e_validate_nvm_checksum(struct i40e_hw *hw,
return ret_code;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
index a85d80093a61..3bf01eaf1f55 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
@@ -593,4 +593,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
struct i40e_profile_segment *profile,
u8 *profile_info_sec, u32 track_id);
#endif /* _I40E_PROTOTYPE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_register.h b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
index 0d8d1cfde13a..4eb955b8eeb5 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_register.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
@@ -5357,4 +5357,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_MASK I40E_MASK(0xFFF, I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT)
#endif /* _I40E_REGISTER_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_status.h b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
index bd03a486d1ae..b5d9c71a37b0 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_status.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
@@ -103,4 +103,3 @@ enum i40e_status_code {
};
#endif /* _I40E_STATUS_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_type.h b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
index 521315c5459e..a2114db104e6 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_type.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
@@ -1840,4 +1840,3 @@ struct i40e_profile_info {
u8 name[I40E_DDP_NAME_SIZE];
};
#endif /* _I40E_TYPE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
index 2c25a79ae96a..4fb7e2428f1a 100644
--- a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
+++ b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
@@ -28,4 +28,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
index cb5c28b052f9..26556e284381 100644
--- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
+++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
@@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
SetInformation,
GetSupportedTypes
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
index 72d08a891d06..3b2039bc5cb2 100644
--- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
+++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
@@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
#endif /* ADAPTER_INFORMATION_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Brand.c b/IntelUndiPkg/XGigUndiDxe/Brand.c
index 9c97bb063df9..c65e57345f22 100644
--- a/IntelUndiPkg/XGigUndiDxe/Brand.c
+++ b/IntelUndiPkg/XGigUndiDxe/Brand.c
@@ -173,4 +173,3 @@ BRAND_STRUCT mBrandingTable[] = {
};
UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
index c136bd7fb436..2972c28bda4e 100644
--- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
+++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
@@ -276,4 +276,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
EFI_2_70_SYSTEM_TABLE_REVISION
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
index c538ea629e50..f63d58b8a18c 100644
--- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
+++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
@@ -74,4 +74,3 @@ ComponentNameGetDriverName (
);
#endif /* COMPONENT_NAME_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c b/IntelUndiPkg/XGigUndiDxe/Decode.c
index 675f0efca34a..70fbce64c64f 100644
--- a/IntelUndiPkg/XGigUndiDxe/Decode.c
+++ b/IntelUndiPkg/XGigUndiDxe/Decode.c
@@ -1851,4 +1851,3 @@ BadCdb:
CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.h b/IntelUndiPkg/XGigUndiDxe/Decode.h
index c0a068716a8b..18cb4e4b1ecf 100644
--- a/IntelUndiPkg/XGigUndiDxe/Decode.h
+++ b/IntelUndiPkg/XGigUndiDxe/Decode.h
@@ -45,4 +45,3 @@ UndiApiEntry (
);
#endif /* DECODE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
index 65f35269eff1..c9878f997c96 100644
--- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
+++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
@@ -189,4 +189,3 @@ IsDeviceIdSupported (
}
return FALSE;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
index e834201b5305..e997983ba3e7 100644
--- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
+++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
@@ -81,4 +81,3 @@ IsDeviceIdSupported (
UINT16 DeviceId
);
#endif /* DEVICE_SUPPORT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.c b/IntelUndiPkg/XGigUndiDxe/Dma.c
index b8df5d387eb2..c8588df96ef5 100644
--- a/IntelUndiPkg/XGigUndiDxe/Dma.c
+++ b/IntelUndiPkg/XGigUndiDxe/Dma.c
@@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
return Status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.h b/IntelUndiPkg/XGigUndiDxe/Dma.h
index 6763c83dca39..3422acd500de 100644
--- a/IntelUndiPkg/XGigUndiDxe/Dma.h
+++ b/IntelUndiPkg/XGigUndiDxe/Dma.h
@@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
);
#endif /* _DMA_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
index 348abc8a9b91..66dc67a5400e 100644
--- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
@@ -525,4 +525,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gXgbeUndiDriverDiagnostics2 = {
(EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) XgbeUndiDriverDiagnosticsRunDiagnostics,
"en-US"
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
index aafd7e65344a..4da70b1c122b 100644
--- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
+++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
@@ -46,4 +46,3 @@ typedef struct {
#pragma pack()
#endif /* DRIVER_DIAGNOSTICS_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
index 31a9dfc9adad..df6cfdf8a123 100644
--- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
+++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
@@ -160,4 +160,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
GetHealthStatus,
Repair
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
index a1542333837f..6bc36d784d1e 100644
--- a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
+++ b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
@@ -34,4 +34,3 @@ typedef enum {
MODULE_UNSUPPORTED,
} MODULE_QUALIFICATION_STATUS;
#endif /* DRIVER_HEALTH_COMMON_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
index 4c8d8e0a70e4..deae76cab0e3 100644
--- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
+++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
@@ -404,4 +404,3 @@ EepromUpdateChecksum (
return EFI_SUCCESS;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
index b1aa113eb4c8..0b53f86ddd69 100644
--- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
+++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
@@ -209,4 +209,3 @@ EepromUpdateChecksum (
#endif /* EEPROM_CONFIG_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.c b/IntelUndiPkg/XGigUndiDxe/Hii.c
index 7a4f5489225f..857a475622f7 100644
--- a/IntelUndiPkg/XGigUndiDxe/Hii.c
+++ b/IntelUndiPkg/XGigUndiDxe/Hii.c
@@ -1199,4 +1199,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
RouteConfig,
DriverCallback
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.h b/IntelUndiPkg/XGigUndiDxe/Hii.h
index 1de4b1b3cc53..8dbc6ec854b4 100644
--- a/IntelUndiPkg/XGigUndiDxe/Hii.h
+++ b/IntelUndiPkg/XGigUndiDxe/Hii.h
@@ -90,4 +90,3 @@ HiiUnload (
);
#endif /* HII_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
index 21ec03193e26..2aacb63ca158 100644
--- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
+++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
@@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
return EFI_BUFFER_TOO_SMALL;
}
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
index 49abbd280c01..28298652403a 100644
--- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
+++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
@@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
);
#endif /* HII_INTERNAL_LIB_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c b/IntelUndiPkg/XGigUndiDxe/Init.c
index 4b03f0f72d5d..bffe3c165866 100644
--- a/IntelUndiPkg/XGigUndiDxe/Init.c
+++ b/IntelUndiPkg/XGigUndiDxe/Init.c
@@ -2173,4 +2173,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
NULL, // ImageHandle
NULL // Driver Binding Handle
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Init.h b/IntelUndiPkg/XGigUndiDxe/Init.h
index 591c5fabefc4..28efcd905379 100644
--- a/IntelUndiPkg/XGigUndiDxe/Init.h
+++ b/IntelUndiPkg/XGigUndiDxe/Init.h
@@ -77,4 +77,3 @@ UndiGetDriverHealthStatus (
);
#endif /* INIT_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
index 3443f460caa3..45fc887d77cb 100644
--- a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
+++ b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
@@ -368,4 +368,3 @@ formset
endformset;
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
index c8cd6fc42779..e5e669681b07 100644
--- a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
+++ b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
@@ -137,4 +137,3 @@ typedef struct {
#define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
#define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
#endif /* NV_DATA_STRUC_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c b/IntelUndiPkg/XGigUndiDxe/StartStop.c
index e49e6c7a92ae..156e927a35c6 100644
--- a/IntelUndiPkg/XGigUndiDxe/StartStop.c
+++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c
@@ -113,4 +113,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
StopDriver,
StartDriver
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.h b/IntelUndiPkg/XGigUndiDxe/StartStop.h
index 97ab9f5da23e..03ad3dc9cecc 100644
--- a/IntelUndiPkg/XGigUndiDxe/StartStop.h
+++ b/IntelUndiPkg/XGigUndiDxe/StartStop.h
@@ -68,4 +68,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
};
#endif /* START_STOP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Version.h b/IntelUndiPkg/XGigUndiDxe/Version.h
index 0ddd9ed7b1ce..78cc7809a16a 100644
--- a/IntelUndiPkg/XGigUndiDxe/Version.h
+++ b/IntelUndiPkg/XGigUndiDxe/Version.h
@@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MAJORVERSION 4 /* XGigUndi major version */
#define MINORVERSION 9 /* XGigUndi minor version */
#define BUILDNUMBER 99 /* XGigUndi build version */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
index 899310735fdf..9e0e4aff0885 100644
--- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
+++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
@@ -152,4 +152,3 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver
gEfiIfrTianoGuid ## CONSUMES ## Guid
gEfiEventExitBootServicesGuid ## PRODUCES ## Event
gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
index b8c4f6077ecc..9e3ee862fb4e 100644
--- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c
+++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
@@ -2401,4 +2401,3 @@ WaitForEnter (
} while (Key.UnicodeChar != 0xD);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
index 27ae1470d48c..5ab088362f90 100644
--- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h
+++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
@@ -1172,4 +1172,3 @@ WaitForEnter (
(BUILDNUMBER / 10 << 12) + (BUILDNUMBER % 10 << 8))
#endif /* XGBE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
index e6828519e4f1..adb62177a272 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
@@ -1536,4 +1536,3 @@ s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval)
return IXGBE_SUCCESS;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
index 297d880c621c..75ca431239d2 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
@@ -52,4 +52,3 @@ void ixgbe_set_lan_id_multi_port_pcie_82598(struct ixgbe_hw *hw);
void ixgbe_set_pcie_completion_timeout(struct ixgbe_hw *hw);
s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval);
#endif /* _IXGBE_82598_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
index 34e9e5273b75..2fb101ea49f8 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
@@ -2783,4 +2783,3 @@ release_i2c_access:
return status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
index 3187c369acc7..aff0481f2612 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
@@ -65,4 +65,3 @@ s32 ixgbe_get_protected_blocks_82599(struct ixgbe_hw *hw,
s32 prot_autoc_read_82599(struct ixgbe_hw *hw, bool *locked, u32 *reg_val);
s32 prot_autoc_write_82599(struct ixgbe_hw *hw, u32 reg_val, bool locked);
#endif /* _IXGBE_82599_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
index c026024d8e10..88e10ca9c49f 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
@@ -1779,4 +1779,3 @@ void ixgbe_set_rate_select_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)
if (hw->mac.ops.set_rate_select_speed)
hw->mac.ops.set_rate_select_speed(hw, speed);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
index 10604eca92d0..6bcf5dc1ebc6 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
@@ -242,4 +242,3 @@ s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg,
u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm);
#endif /* _IXGBE_API_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
index 4c6c79c67a24..62bdde1e1f9e 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
@@ -6064,4 +6064,3 @@ void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,
out:
return;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
index 8557565344f5..4444e8b1eb27 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
@@ -238,4 +238,3 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,
ixgbe_link_speed speed);
#endif /* IXGBE_COMMON */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
index fbc75e3f37f9..291059da8f5b 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
@@ -167,4 +167,3 @@ u8 ixgbe_dcb_get_tc_from_up(struct ixgbe_dcb_config *, int, u8);
s32 ixgbe_dcb_hw_config(struct ixgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *);
s32 ixgbe_dcb_hw_config_cee(struct ixgbe_hw *, struct ixgbe_dcb_config *);
#endif /* _IXGBE_DCB_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
index 4aa05b8049e9..d5b4fc309f92 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
@@ -146,4 +146,3 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *,
s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *, int, u16 *, u16 *, u8 *,
u8 *, u8 *);
#endif /* _IXGBE_DCB_82959_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
index a7d4af9bcd6e..6fa0d1605c7c 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
@@ -553,4 +553,3 @@ typedef BOOLEAN boolean_t;
#define IXGBE_BE16_TO_CPU(a) IxgbeReverseWord (a)
#endif /* IXGBE_OSDEP_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
index 843ea3ce2856..5d748b0603f2 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
@@ -2742,4 +2742,3 @@ s32 ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on)
reg);
return status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
index c317dfcb3e6b..f79d48b64c3f 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
@@ -214,4 +214,3 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg,
s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg,
u16 val, bool lock);
#endif /* _IXGBE_PHY_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
index e11bf564dac4..e3bb1a8a313e 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
@@ -4539,4 +4539,3 @@ struct ixgbe_hw {
#endif /* IXGBE_OSDEP2 */
#endif /* _IXGBE_TYPE_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
index 6d89d8f4f440..f7f75ac52daf 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
@@ -1147,4 +1147,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw,
return status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
index 40b6715ed37a..aa919940141f 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
@@ -67,4 +67,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw,
u16 *eeprom_buffer, u32 eeprom_size);
#endif /* _IXGBE_X540_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
index 92df8322f1ed..d49eb94732c3 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
@@ -4795,4 +4795,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw,
return status;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
index 45303564fd8d..209a2b5bec0f 100644
--- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
+++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
@@ -126,4 +126,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw,
u16 *blocks_size, u32 block_type_mask,
u16 *eeprom_buffer, u32 eeprom_size);
#endif /* _IXGBE_X550_H_ */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.c b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
index 6baf345fb8ee..c4b708d56e46 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wol.c
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
@@ -316,4 +316,3 @@ WolEnableWakeOnLanEx(
return WolGetWakeOnLanStatusEx(Handle);
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.h b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
index edcc250f3140..dfafbe6f4a1d 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wol.h
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
@@ -79,4 +79,3 @@ WolEnableApmPme(
#endif /* __WOL_H */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
index c61de75970e9..6446ab0f7f77 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
@@ -69,4 +69,3 @@ BOOLEAN _WolGetInfoFromEeprom_10G(WOL_ADAPTER_HANDLE_TYPE Handle)
return FALSE;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
index 866a8330c0a1..4affb3aadb16 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
@@ -81,4 +81,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
0
};
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
index d00eb5d82820..f280f7adcbb7 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
@@ -83,4 +83,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
return Handle->NicInfo.Function;
}
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
index eaea7675138d..d3dc0e268bd3 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
@@ -76,4 +76,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
#endif /* __WOLIMPL_H */
-\x1a
\ No newline at end of file
diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
index 7e49225c451d..ad12ddb1af37 100644
--- a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
+++ b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
@@ -175,4 +175,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = {
{ 0, 0, 0, 0, 0 } /* Last entry */
};
-\x1a
\ No newline at end of file
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
@ 2018-11-06 19:34 ` Philippe Mathieu-Daudé
2019-01-29 13:58 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 19:34 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Remove the Ctrl-Z markers at the end of each file: these break the
> GCC build on Linux.
Weird...
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/GigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/GigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000.h | 1 -
> IntelUndiPkg/GigUndiDxe/E1000_osdep.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000_osdep.h | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 1 -
> IntelUndiPkg/GigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/GigUndiDxe/Init.c | 1 -
> IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/GigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/GigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_defines.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> 170 files changed, 170 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index 8268f0da5e9b..b0320b11839b 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> index 72d08a891d06..3b2039bc5cb2 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Brand.c b/IntelUndiPkg/GigUndiDxe/Brand.c
> index 2aba217eb4c5..b29ebce16c71 100644
> --- a/IntelUndiPkg/GigUndiDxe/Brand.c
> +++ b/IntelUndiPkg/GigUndiDxe/Brand.c
> @@ -213,4 +213,3 @@ BRAND_STRUCT mBrandingTable[] = {
> };
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 6ee0dd991505..1473bfbed0af 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -272,4 +272,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> index e3a386ea66f3..5a3d414c6970 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> @@ -72,4 +72,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
> index f858abe10785..88e8be315bd1 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -1866,4 +1866,3 @@ BadCdb:
> CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.h b/IntelUndiPkg/GigUndiDxe/Decode.h
> index b00670f4d290..fb01267d0b2f 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.h
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.h
> @@ -46,4 +46,3 @@ E1000UndiApiEntry (
> );
>
> #endif /* DECODE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> index 47c2a07a0f16..3ffc25d58a3f 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> @@ -189,4 +189,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index a0d6b613285d..f309044d9b9d 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -81,4 +81,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
> index 7f32361ef678..76a3fcf69601 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.h b/IntelUndiPkg/GigUndiDxe/Dma.h
> index 6763c83dca39..3422acd500de 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.h
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.h
> @@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 9aec9422f1d6..118c1b2b9b04 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -571,4 +571,3 @@ EFI_DRIVER_CONFIGURATION_PROTOCOL gGigUndiDriverConfiguration = {
> GigUndiDriverConfigurationForceDefaults,
> "eng"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> index 9464cddbb756..a15a3a0a2745 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> @@ -38,4 +38,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define MENU_EXIT 6
>
> #endif /* DRIVER_CONFIGURATION_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index 19b63b6059f6..a9f176ce5324 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1548,4 +1548,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gGigUndiDriverDiagnostics2 = {
> (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) GigUndiDriverDiagnosticsRunDiagnostics,
> "en-US"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> index 2a3fe772e80a..c0f984953065 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> @@ -82,4 +82,3 @@ typedef struct {
> #pragma pack()
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index 83de9e89ab66..b1af371e06db 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -134,4 +134,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/E1000.c
> index 842778a70d01..fad20d988441 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/E1000.c
> @@ -2455,4 +2455,3 @@ WaitForEnter (
> gST->ConIn->ReadKeyStroke (gST->ConIn, &Key);
> } while (Key.UnicodeChar != 0xD);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/E1000.h
> index 38e88f0fd56d..71fe4591af05 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.h
> +++ b/IntelUndiPkg/GigUndiDxe/E1000.h
> @@ -1212,4 +1212,3 @@ WaitForEnter (
> #endif /* E1000_H_ */
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> index 4761e7dde99e..0d0047a93048 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> @@ -639,4 +639,3 @@ e1000_pci_clear_mwi (
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> index 2b5562f21e47..01c0843a2c9a 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> @@ -575,4 +575,3 @@ typedef BOOLEAN boolean_t;
>
> #endif /* E1000_OSDEP_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.c b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> index 8a5cb62190f9..19d867ee58af 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> @@ -861,4 +861,3 @@ EepromUpdateChecksum (
> return EFI_SUCCESS;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> index bd9fa5c0afb2..e0d31f6a151d 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> @@ -204,4 +204,3 @@ EepromUpdateChecksum (
> );
>
> #endif /* EEPROM_CONFIG_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index e52a78723cbf..2d2d0707a686 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -163,4 +163,3 @@ wol\wol_1G.c
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ## PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
> index 85818fe964c5..43c184cb03c8 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -1238,4 +1238,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.h b/IntelUndiPkg/GigUndiDxe/Hii.h
> index aa39eae7faea..5afdfc8cd174 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.h
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.h
> @@ -90,4 +90,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> index 21ec03193e26..2aacb63ca158 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> index 49abbd280c01..28298652403a 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
> index dad31a5f0844..47ed03eb0849 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -1876,4 +1876,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
> NULL, // ImageHandle
> NULL // Driver Binding Handle
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.h b/IntelUndiPkg/GigUndiDxe/Init.h
> index 308f003ce038..409cb7082340 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.h
> +++ b/IntelUndiPkg/GigUndiDxe/Init.h
> @@ -45,4 +45,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define MAC_ADDRESS_SIZE_IN_BYTES 6
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Inventory.vfr b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> index 2c59c380fc09..a6cacaff4e17 100644
> --- a/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> @@ -370,4 +370,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> index 50945f37437c..bd7d4defc9a3 100644
> --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> @@ -136,4 +136,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 8b17507ebf4d..10ab4e51bf44 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -103,4 +103,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StopDriver,
> StartDriver
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index fdc0d5b6c1f6..24304d6cc3a7 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -67,4 +67,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
> };
>
> #endif /* START_STOP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Version.h b/IntelUndiPkg/GigUndiDxe/Version.h
> index 11d9a607c4fa..b3019889634b 100644
> --- a/IntelUndiPkg/GigUndiDxe/Version.h
> +++ b/IntelUndiPkg/GigUndiDxe/Version.h
> @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* GigUndi major version */
> #define MINORVERSION 9 /* GigUndi minor version */
> #define BUILDNUMBER 99 /* GigUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> index c1ffc814236e..4264f2470f02 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> @@ -1532,4 +1532,3 @@ STATIC void e1000_clear_hw_cntrs_80003es2lan(struct e1000_hw *hw)
> E1000_READ_REG(hw, E1000_ICTXQMTC);
> E1000_READ_REG(hw, E1000_ICRXDMTC);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> index a37545399c97..df2c53318ce5 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> @@ -93,4 +93,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define GG82563_ICR_DIS_PADDING 0x0010 /* Disable Padding */
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.c b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> index 463e8c6eaa87..d970ce7292b8 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> @@ -2079,4 +2079,3 @@ STATIC void e1000_clear_hw_cntrs_82571(struct e1000_hw *hw)
> E1000_READ_REG(hw, E1000_ICTXQMTC);
> E1000_READ_REG(hw, E1000_ICRXDMTC);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.h b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> index 8862e3e17dce..3df568892529 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> @@ -60,4 +60,3 @@ bool e1000_get_laa_state_82571(struct e1000_hw *hw);
> void e1000_set_laa_state_82571(struct e1000_hw *hw, bool state);
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.c b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> index f6ad91d4a2d5..b052a38f5d80 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> @@ -3342,4 +3342,3 @@ void e1000_write_vfta_i350(struct e1000_hw *hw, u32 offset, u32 value)
> }
>
> #endif /* NO_82580_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.h b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> index 39c1b38324ed..5e6be621ec13 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> @@ -433,4 +433,3 @@ s32 e1000_initialize_M88E1512_phy(struct e1000_hw *hw);
> s32 e1000_initialize_M88E1543_phy(struct e1000_hw *hw);
> #endif /* NO_82580_SUPPORT */
> #endif /* _E1000_82575_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.c b/IntelUndiPkg/GigUndiDxe/e1000_api.c
> index 1a8e45a2e86f..195992d46a34 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_api.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.c
> @@ -1280,4 +1280,3 @@ void e1000_shutdown_fiber_serdes_link(struct e1000_hw *hw)
> }
>
> #endif /* NO_82575_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.h b/IntelUndiPkg/GigUndiDxe/e1000_api.h
> index c35c366f5e91..6a75ec899a07 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_api.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.h
> @@ -176,4 +176,3 @@ s32 e1000_mng_write_dhcp_info(struct e1000_hw *hw, u8 *buffer, u16 length);
> #define E1000_DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) /* ceil(a/b) */
> #endif
> #endif /* _E1000_API_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> index 5052b7925c3b..1d07d30aa18e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> @@ -1636,4 +1636,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define ERROR_REPORT(fmt) do { } while (0)
> #endif /* ERROR_REPORT */
> #endif /* _E1000_DEFINES_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_hw.h b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> index 86d163e57906..27e34f5ae824 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> @@ -969,4 +969,3 @@ void e1000_write_pci_cfg(struct e1000_hw *hw, u32 reg, u16 *value);
> #endif
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.c b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> index b485e739a434..5d05e3853361 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> @@ -869,4 +869,3 @@ s32 e1000_init_hw_i210(struct e1000_hw *hw)
> ret_val = e1000_init_hw_82575(hw);
> return ret_val;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.h b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> index 3532126852b1..bde07d357ed6 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> @@ -97,4 +97,3 @@ enum E1000_INVM_STRUCTURE_TYPE {
> #define E1000_INVM_PLL_WO_VAL 0x0010
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> index e3a3606f8527..7669630a5c03 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> @@ -5684,4 +5684,3 @@ release:
> }
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> index 26fe0200e5a4..a435418078d2 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> @@ -290,4 +290,3 @@ s32 e1000_read_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 *data);
> s32 e1000_write_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16 data);
> s32 e1000_set_eee_pchlan(struct e1000_hw *hw);
> #endif /* _E1000_ICH8LAN_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.c b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> index a0a13da26316..f3727b9bc0de 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> @@ -2293,4 +2293,3 @@ s32 e1000_write_8bit_ctrl_reg_generic(struct e1000_hw *hw, u32 reg,
> return E1000_SUCCESS;
> }
> #endif /* NO_82575_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.h b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> index 95fb00f3dc87..b8990d908b45 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> @@ -97,4 +97,3 @@ void e1000_update_adaptive_generic(struct e1000_hw *hw);
> void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32 value);
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.c b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> index 4bf703b2de4a..5fc7fa5704ac 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> @@ -582,4 +582,3 @@ s32 e1000_load_firmware(struct e1000_hw *hw, u8 *buffer, u32 length)
>
> #endif /* NO_I210_SUPPORT */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.h b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> index c9002a244a46..090a9a25de63 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> @@ -100,4 +100,3 @@ enum e1000_mng_mode {
> #define E1000_IAMT_SIGNATURE 0x544D4149
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> index 26244874f4e3..e46130186223 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> @@ -1310,4 +1310,3 @@ STATIC void e1000_reload_nvm_generic(struct e1000_hw *hw)
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> index 06a668f5e912..ef84c51dbeb9 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> @@ -92,4 +92,3 @@ void e1000_release_nvm_generic(struct e1000_hw *hw);
> #define E1000_STM_OPCODE 0xDB00
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.c b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> index b1c66d263183..765fcf387d7e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> @@ -4465,4 +4465,3 @@ s32 e1000_write_xmdio_reg(struct e1000_hw *hw, u16 addr, u8 dev_addr, u16 data)
> false);
> }
> #endif /* NO_XMDIO_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.h b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> index de82fde1f035..3efc73b006ee 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> @@ -349,4 +349,3 @@ struct sfp_e1000_flags {
>
> #endif /* NO_82575_SUPPORT */
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_regs.h b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> index 8568edc310a5..d6c66b92e94e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> @@ -772,4 +772,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #endif /* NO_I210_SUPPORT */
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.c b/IntelUndiPkg/GigUndiDxe/wol/wol.c
> index 79100219b85b..74ffeafd787a 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.c
> @@ -341,4 +341,3 @@ WolEnableWakeOnLanEx(
> return WolGetWakeOnLanStatusEx(Handle);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.h b/IntelUndiPkg/GigUndiDxe/wol/wol.h
> index 5ac38d6a3602..4f3140e152f8 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.h
> @@ -84,4 +84,3 @@ WolEnableApmPme(
>
> #endif /* __WOL_H */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> index bba2393d6ff3..02eff0957976 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> @@ -183,4 +183,3 @@ WOL_STATUS _WolEnableLaser(WOL_ADAPTER_HANDLE_TYPE Handle, BOOLEAN Enable)
> return WOL_FEATURE_NOT_SUPPORTED;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> index 49d901defd4d..2c35be00f36a 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> @@ -163,4 +163,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
> 0
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> index a5d536ee99c2..311930372f8b 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> @@ -166,4 +166,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> return Handle->NicInfo.Function;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> index 84863eddc54e..ed2ffc427093 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> @@ -77,4 +77,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
> WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
>
> #endif /* __WOLIMPL_H */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> index c99667a25f8e..4df14ce2abf6 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> @@ -334,4 +334,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = {
> { 0, 0, 0, 0, 0 } /* Last entry */
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> index 7b8b78daf29b..b2801a673d6e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> @@ -410,4 +410,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> index d5d5d52697c1..1401fbdb92fe 100644
> --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> @@ -102,4 +102,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Brand.c b/IntelUndiPkg/I40eUndiDxe/Brand.c
> index 250184d8b3ca..22629a933174 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Brand.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Brand.c
> @@ -210,4 +210,3 @@ BRAND_STRUCT mBrandingTable[] = {
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.c b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> index cb83d3a79dd9..1241862adb81 100644
> --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> @@ -275,4 +275,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.h b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> index ed26dcb81b5b..dca634039b66 100644
> --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> @@ -73,4 +73,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.c b/IntelUndiPkg/I40eUndiDxe/Decode.c
> index d84255be0f6c..e47979e59126 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Decode.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Decode.c
> @@ -1881,4 +1881,3 @@ BadCdb:
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.h b/IntelUndiPkg/I40eUndiDxe/Decode.h
> index 59f79e0abf5e..555d35620474 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Decode.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Decode.h
> @@ -48,4 +48,3 @@ UndiApiEntry (
>
> #endif /* DECODE_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> index 4d1061a794e4..007d651d126f 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> @@ -202,4 +202,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> index b26f0ff0ec8c..b0de9f40c572 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> @@ -82,4 +82,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.c b/IntelUndiPkg/I40eUndiDxe/Dma.c
> index 17f14bd043f1..9efa705cb6f0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Dma.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Dma.c
> @@ -283,4 +283,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.h b/IntelUndiPkg/I40eUndiDxe/Dma.h
> index 58a1f234b5df..d0d00463aa63 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Dma.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Dma.h
> @@ -133,4 +133,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> index 536ff7a65522..de07eb0f254f 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> @@ -1131,4 +1131,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gUndiDriverDiagnostics2 = {
> "en-US"
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> index a6a725c33aa9..c3414f3897fe 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> @@ -80,4 +80,3 @@ typedef struct {
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> index 500ca3685cfc..30df2f3ec7d0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> @@ -161,4 +161,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> index c32302879390..da1d22057dcb 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> @@ -35,4 +35,3 @@ typedef enum {
> MODULE_UNSUPPORTED,
> } MODULE_QUALIFICATION_STATUS;
> #endif /* DRIVER_HEALTH_COMMON_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> index cc47e0437e80..4772715b3979 100644
> --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> @@ -1254,4 +1254,3 @@ EepromReadPortnumValues (
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> index e547d88b82b4..97e8be1ae80e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> @@ -556,4 +556,3 @@ EepromReadPortnumValues (
>
> #endif /* EEPROM_CONFIG_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.c b/IntelUndiPkg/I40eUndiDxe/Hii.c
> index e411f23d14ce..404e3672aa87 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Hii.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Hii.c
> @@ -1254,4 +1254,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.h b/IntelUndiPkg/I40eUndiDxe/Hii.h
> index e8e916a5ee90..8ab5108e2c8b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Hii.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Hii.h
> @@ -91,4 +91,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> index 4e6e28fdb5c0..365ed7f2da80 100644
> --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> @@ -486,4 +486,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> index 16655f384db3..b5ee09c49c9b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> @@ -163,4 +163,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.c b/IntelUndiPkg/I40eUndiDxe/I40e.c
> index ecf83ebc86df..c2501e4222f5 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e.c
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e.c
> @@ -3461,4 +3461,3 @@ I40eGetTxRxDescriptorsCount (
> return I40E_DEF_NUM_TX_RX_DESCRIPTORS;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.h b/IntelUndiPkg/I40eUndiDxe/I40e.h
> index c5aabf6d7d69..9b994c5ec1c9 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e.h
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e.h
> @@ -1504,4 +1504,3 @@ I40eGetTxRxDescriptorsCount (
> );
>
> #endif /* I40E_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> index 76df7898bef1..caff5262f6e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> +++ b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> @@ -157,4 +157,3 @@ MSFT:*_*_*_CC_FLAGS = /FAcs
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ## PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> index 88a9547fc45b..ddd4449ad65c 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> @@ -601,4 +601,3 @@ DelayInMicroseconds (
>
>
> #endif /* I40E_OSDEP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Init.c b/IntelUndiPkg/I40eUndiDxe/Init.c
> index d45d669887d8..68a1699b00ba 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Init.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Init.c
> @@ -2300,4 +2300,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
> NULL,
> NULL
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Init.h b/IntelUndiPkg/I40eUndiDxe/Init.h
> index 217ed75cd179..899eeda1e6df 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Init.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Init.h
> @@ -87,4 +87,3 @@ UndiGetDriverHealthStatus (
> );
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> index a64b9297291b..ea48aad2bc85 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> @@ -369,4 +369,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> index 8387a99ae5bc..412cbf4833c7 100644
> --- a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> @@ -138,4 +138,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.c b/IntelUndiPkg/I40eUndiDxe/StartStop.c
> index 32c9c5e09655..b375b52fe882 100644
> --- a/IntelUndiPkg/I40eUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.c
> @@ -169,4 +169,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StartDriver
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.h b/IntelUndiPkg/I40eUndiDxe/StartStop.h
> index 5ebf063e4913..d80fe79cbc3a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.h
> @@ -79,4 +79,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
>
> #endif /* START_STOP_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Version.h b/IntelUndiPkg/I40eUndiDxe/Version.h
> index dfb94cedd04c..e5a47633ddf1 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Version.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Version.h
> @@ -30,4 +30,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* I40eUndi major version */
> #define MINORVERSION 9 /* I40eUndi minor version */
> #define BUILDNUMBER 99 /* I40eUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> index af443b398bb9..7d11d1ce4d6a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> @@ -1095,4 +1095,3 @@ clean_arq_element_err:
> return ret_code;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> index d17fe42cae96..51f0af909516 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> @@ -118,4 +118,3 @@ void i40e_fill_default_direct_cmd_desc(struct i40e_aq_desc *desc,
> u16 opcode);
>
> #endif /* _I40E_ADMINQ_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> index 8c0c6665ee55..78ec00252201 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> @@ -2974,4 +2974,3 @@ struct i40e_aqc_debug_modify_internals {
> I40E_CHECK_CMD_LENGTH(i40e_aqc_debug_modify_internals);
>
> #endif /* _I40E_ADMINQ_CMD_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> index 2f82f8dd72a5..51d83526207b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> @@ -60,4 +60,3 @@ enum i40e_status_code i40e_free_virt_mem(struct i40e_hw *hw,
> struct i40e_virt_mem *mem);
>
> #endif /* _I40E_ALLOC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_common.c b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> index 01bcfeed279c..faa7b8d7483e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> @@ -7631,4 +7631,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
> track_id, &offset, &info, NULL);
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> index 143c3b10c025..64aa672e0004 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> @@ -68,4 +68,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> (d) == I40E_DEV_ID_25G_SFP28)
>
> #endif /* _I40E_DEVIDS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> index f57fc65f60e0..62e8f8428aaa 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> @@ -193,4 +193,3 @@ enum i40e_status_code i40e_diag_fw_alive_test(struct i40e_hw *hw)
> UNREFERENCED_1PARAMETER(hw);
> return I40E_SUCCESS;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> index 322cefb45732..4cda8b3444e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> @@ -56,4 +56,3 @@ enum i40e_status_code i40e_diag_reg_test(struct i40e_hw *hw);
> enum i40e_status_code i40e_diag_eeprom_test(struct i40e_hw *hw);
>
> #endif /* _I40E_DIAG_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> index 28ff0ace4680..b5c084bf3372 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> @@ -366,4 +366,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw,
>
> return i40e_free_dma_mem(hw, &(sd_entry->u.pd_table.pd_page_addr));
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> index c7844edcb7ba..97ff0724729c 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> @@ -240,4 +240,3 @@ enum i40e_status_code i40e_remove_pd_page_new(struct i40e_hw *hw,
> u32 idx, bool is_pf);
>
> #endif /* _I40E_HMC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> index 93f477d0268d..4720d9f0cc83 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> @@ -1610,4 +1610,3 @@ enum i40e_status_code i40e_set_lan_rx_queue_context_directly(struct i40e_hw *hw,
> return i40e_write_queue_context_directly(hw, queue, context_bytes,
> I40E_HMC_LAN_RX);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> index a5d59679af17..8842ac04470d 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> @@ -206,4 +206,3 @@ enum i40e_status_code i40e_delete_lan_hmc_object(struct i40e_hw *hw,
> struct i40e_hmc_lan_delete_obj_info *info);
>
> #endif /* _I40E_LAN_HMC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> index ef1774c8cc2e..0187d6ecb522 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> @@ -758,4 +758,3 @@ enum i40e_status_code i40e_validate_nvm_checksum(struct i40e_hw *hw,
>
> return ret_code;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> index a85d80093a61..3bf01eaf1f55 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> @@ -593,4 +593,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
> struct i40e_profile_segment *profile,
> u8 *profile_info_sec, u32 track_id);
> #endif /* _I40E_PROTOTYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_register.h b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> index 0d8d1cfde13a..4eb955b8eeb5 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> @@ -5357,4 +5357,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_MASK I40E_MASK(0xFFF, I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT)
>
> #endif /* _I40E_REGISTER_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_status.h b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> index bd03a486d1ae..b5d9c71a37b0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> @@ -103,4 +103,3 @@ enum i40e_status_code {
> };
>
> #endif /* _I40E_STATUS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_type.h b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> index 521315c5459e..a2114db104e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> @@ -1840,4 +1840,3 @@ struct i40e_profile_info {
> u8 name[I40E_DDP_NAME_SIZE];
> };
> #endif /* _I40E_TYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> index 2c25a79ae96a..4fb7e2428f1a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> @@ -28,4 +28,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> ***************************************************************************/
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> index cb5c28b052f9..26556e284381 100644
> --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> index 72d08a891d06..3b2039bc5cb2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Brand.c b/IntelUndiPkg/XGigUndiDxe/Brand.c
> index 9c97bb063df9..c65e57345f22 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Brand.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Brand.c
> @@ -173,4 +173,3 @@ BRAND_STRUCT mBrandingTable[] = {
> };
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof (mBrandingTable[0]));
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> index c136bd7fb436..2972c28bda4e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> @@ -276,4 +276,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> index c538ea629e50..f63d58b8a18c 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> @@ -74,4 +74,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c b/IntelUndiPkg/XGigUndiDxe/Decode.c
> index 675f0efca34a..70fbce64c64f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c
> @@ -1851,4 +1851,3 @@ BadCdb:
> CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.h b/IntelUndiPkg/XGigUndiDxe/Decode.h
> index c0a068716a8b..18cb4e4b1ecf 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Decode.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Decode.h
> @@ -45,4 +45,3 @@ UndiApiEntry (
> );
>
> #endif /* DECODE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> index 65f35269eff1..c9878f997c96 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> @@ -189,4 +189,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> index e834201b5305..e997983ba3e7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> @@ -81,4 +81,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.c b/IntelUndiPkg/XGigUndiDxe/Dma.c
> index b8df5d387eb2..c8588df96ef5 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Dma.c
> @@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.h b/IntelUndiPkg/XGigUndiDxe/Dma.h
> index 6763c83dca39..3422acd500de 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Dma.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Dma.h
> @@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> index 348abc8a9b91..66dc67a5400e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> @@ -525,4 +525,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gXgbeUndiDriverDiagnostics2 = {
> (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS) XgbeUndiDriverDiagnosticsRunDiagnostics,
> "en-US"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> index aafd7e65344a..4da70b1c122b 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> @@ -46,4 +46,3 @@ typedef struct {
> #pragma pack()
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> index 31a9dfc9adad..df6cfdf8a123 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> @@ -160,4 +160,3 @@ EFI_DRIVER_HEALTH_PROTOCOL gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> index a1542333837f..6bc36d784d1e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> @@ -34,4 +34,3 @@ typedef enum {
> MODULE_UNSUPPORTED,
> } MODULE_QUALIFICATION_STATUS;
> #endif /* DRIVER_HEALTH_COMMON_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> index 4c8d8e0a70e4..deae76cab0e3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> @@ -404,4 +404,3 @@ EepromUpdateChecksum (
> return EFI_SUCCESS;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> index b1aa113eb4c8..0b53f86ddd69 100644
> --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> @@ -209,4 +209,3 @@ EepromUpdateChecksum (
>
> #endif /* EEPROM_CONFIG_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.c b/IntelUndiPkg/XGigUndiDxe/Hii.c
> index 7a4f5489225f..857a475622f7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Hii.c
> @@ -1199,4 +1199,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.h b/IntelUndiPkg/XGigUndiDxe/Hii.h
> index 1de4b1b3cc53..8dbc6ec854b4 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Hii.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Hii.h
> @@ -90,4 +90,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> index 21ec03193e26..2aacb63ca158 100644
> --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> index 49abbd280c01..28298652403a 100644
> --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c b/IntelUndiPkg/XGigUndiDxe/Init.c
> index 4b03f0f72d5d..bffe3c165866 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Init.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Init.c
> @@ -2173,4 +2173,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding = {
> NULL, // ImageHandle
> NULL // Driver Binding Handle
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Init.h b/IntelUndiPkg/XGigUndiDxe/Init.h
> index 591c5fabefc4..28efcd905379 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Init.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Init.h
> @@ -77,4 +77,3 @@ UndiGetDriverHealthStatus (
> );
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> index 3443f460caa3..45fc887d77cb 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> @@ -368,4 +368,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> index c8cd6fc42779..e5e669681b07 100644
> --- a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> @@ -137,4 +137,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x1407
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x1408
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> index e49e6c7a92ae..156e927a35c6 100644
> --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> @@ -113,4 +113,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StopDriver,
> StartDriver
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.h b/IntelUndiPkg/XGigUndiDxe/StartStop.h
> index 97ab9f5da23e..03ad3dc9cecc 100644
> --- a/IntelUndiPkg/XGigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.h
> @@ -68,4 +68,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
> };
>
> #endif /* START_STOP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Version.h b/IntelUndiPkg/XGigUndiDxe/Version.h
> index 0ddd9ed7b1ce..78cc7809a16a 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Version.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Version.h
> @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* XGigUndi major version */
> #define MINORVERSION 9 /* XGigUndi minor version */
> #define BUILDNUMBER 99 /* XGigUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> index 899310735fdf..9e0e4aff0885 100644
> --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> @@ -152,4 +152,3 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ## PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> index b8c4f6077ecc..9e3ee862fb4e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> @@ -2401,4 +2401,3 @@ WaitForEnter (
> } while (Key.UnicodeChar != 0xD);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> index 27ae1470d48c..5ab088362f90 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> @@ -1172,4 +1172,3 @@ WaitForEnter (
> (BUILDNUMBER / 10 << 12) + (BUILDNUMBER % 10 << 8))
>
> #endif /* XGBE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> index e6828519e4f1..adb62177a272 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> @@ -1536,4 +1536,3 @@ s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval)
>
> return IXGBE_SUCCESS;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> index 297d880c621c..75ca431239d2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> @@ -52,4 +52,3 @@ void ixgbe_set_lan_id_multi_port_pcie_82598(struct ixgbe_hw *hw);
> void ixgbe_set_pcie_completion_timeout(struct ixgbe_hw *hw);
> s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval);
> #endif /* _IXGBE_82598_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> index 34e9e5273b75..2fb101ea49f8 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> @@ -2783,4 +2783,3 @@ release_i2c_access:
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> index 3187c369acc7..aff0481f2612 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> @@ -65,4 +65,3 @@ s32 ixgbe_get_protected_blocks_82599(struct ixgbe_hw *hw,
> s32 prot_autoc_read_82599(struct ixgbe_hw *hw, bool *locked, u32 *reg_val);
> s32 prot_autoc_write_82599(struct ixgbe_hw *hw, u32 reg_val, bool locked);
> #endif /* _IXGBE_82599_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> index c026024d8e10..88e10ca9c49f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> @@ -1779,4 +1779,3 @@ void ixgbe_set_rate_select_speed(struct ixgbe_hw *hw, ixgbe_link_speed speed)
> if (hw->mac.ops.set_rate_select_speed)
> hw->mac.ops.set_rate_select_speed(hw, speed);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> index 10604eca92d0..6bcf5dc1ebc6 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> @@ -242,4 +242,3 @@ s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32 adv_reg, u32 lp_reg,
> u32 adv_sym, u32 adv_asm, u32 lp_sym, u32 lp_asm);
>
> #endif /* _IXGBE_API_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> index 4c6c79c67a24..62bdde1e1f9e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> @@ -6064,4 +6064,3 @@ void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,
> out:
> return;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> index 8557565344f5..4444e8b1eb27 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> @@ -238,4 +238,3 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
> void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,
> ixgbe_link_speed speed);
> #endif /* IXGBE_COMMON */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> index fbc75e3f37f9..291059da8f5b 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> @@ -167,4 +167,3 @@ u8 ixgbe_dcb_get_tc_from_up(struct ixgbe_dcb_config *, int, u8);
> s32 ixgbe_dcb_hw_config(struct ixgbe_hw *, u16 *, u16 *, u8 *, u8 *, u8 *);
> s32 ixgbe_dcb_hw_config_cee(struct ixgbe_hw *, struct ixgbe_dcb_config *);
> #endif /* _IXGBE_DCB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> index 4aa05b8049e9..d5b4fc309f92 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> @@ -146,4 +146,3 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *,
> s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *, int, u16 *, u16 *, u8 *,
> u8 *, u8 *);
> #endif /* _IXGBE_DCB_82959_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> index a7d4af9bcd6e..6fa0d1605c7c 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> @@ -553,4 +553,3 @@ typedef BOOLEAN boolean_t;
> #define IXGBE_BE16_TO_CPU(a) IxgbeReverseWord (a)
>
> #endif /* IXGBE_OSDEP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> index 843ea3ce2856..5d748b0603f2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> @@ -2742,4 +2742,3 @@ s32 ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on)
> reg);
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> index c317dfcb3e6b..f79d48b64c3f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> @@ -214,4 +214,3 @@ s32 ixgbe_read_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg,
> s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr, u16 reg,
> u16 val, bool lock);
> #endif /* _IXGBE_PHY_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> index e11bf564dac4..e3bb1a8a313e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> @@ -4539,4 +4539,3 @@ struct ixgbe_hw {
>
> #endif /* IXGBE_OSDEP2 */
> #endif /* _IXGBE_TYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> index 6d89d8f4f440..f7f75ac52daf 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> @@ -1147,4 +1147,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw,
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> index 40b6715ed37a..aa919940141f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> @@ -67,4 +67,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw *hw,
> u16 *eeprom_buffer, u32 eeprom_size);
> #endif /* _IXGBE_X540_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> index 92df8322f1ed..d49eb94732c3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> @@ -4795,4 +4795,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw,
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> index 45303564fd8d..209a2b5bec0f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> @@ -126,4 +126,3 @@ s32 ixgbe_get_protected_blocks_X550(struct ixgbe_hw *hw,
> u16 *blocks_size, u32 block_type_mask,
> u16 *eeprom_buffer, u32 eeprom_size);
> #endif /* _IXGBE_X550_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.c b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> index 6baf345fb8ee..c4b708d56e46 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> @@ -316,4 +316,3 @@ WolEnableWakeOnLanEx(
> return WolGetWakeOnLanStatusEx(Handle);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.h b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> index edcc250f3140..dfafbe6f4a1d 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> @@ -79,4 +79,3 @@ WolEnableApmPme(
>
> #endif /* __WOL_H */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> index c61de75970e9..6446ab0f7f77 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> @@ -69,4 +69,3 @@ BOOLEAN _WolGetInfoFromEeprom_10G(WOL_ADAPTER_HANDLE_TYPE Handle)
> return FALSE;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> index 866a8330c0a1..4affb3aadb16 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> @@ -81,4 +81,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
> 0
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> index d00eb5d82820..f280f7adcbb7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> @@ -83,4 +83,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> return Handle->NicInfo.Function;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> index eaea7675138d..d3dc0e268bd3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> @@ -76,4 +76,3 @@ WOL_STATUS _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
> WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
>
> #endif /* __WOLIMPL_H */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> index 7e49225c451d..ad12ddb1af37 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> @@ -175,4 +175,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[] = {
> { 0, 0, 0, 0, 0 } /* Last entry */
> };
>
> -\x1a
> \ No newline at end of file
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
2018-11-06 19:34 ` Philippe Mathieu-Daudé
@ 2019-01-29 13:58 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 13:58 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
This seems to be an issue within our open source tree generation script
which appends some nasty unexpected characters... MSVC didn't ever
complain about these. Fixed this, next commits should be clean.
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Remove the Ctrl-Z markers at the end of each file: these break the
> GCC build on Linux.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/GigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/GigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000.h | 1 -
> IntelUndiPkg/GigUndiDxe/E1000_osdep.c | 1 -
> IntelUndiPkg/GigUndiDxe/E1000_osdep.h | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 1 -
> IntelUndiPkg/GigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/GigUndiDxe/Init.c | 1 -
> IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/GigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/GigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_defines.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> 170 files changed, 170 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index 8268f0da5e9b..b0320b11839b 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo
> = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> index 72d08a891d06..3b2039bc5cb2 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.h
> @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Brand.c
> b/IntelUndiPkg/GigUndiDxe/Brand.c
> index 2aba217eb4c5..b29ebce16c71 100644
> --- a/IntelUndiPkg/GigUndiDxe/Brand.c
> +++ b/IntelUndiPkg/GigUndiDxe/Brand.c
> @@ -213,4 +213,3 @@ BRAND_STRUCT mBrandingTable[] = {
> };
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof
> (mBrandingTable[0]));
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 6ee0dd991505..1473bfbed0af 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -272,4 +272,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL
> gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> index e3a386ea66f3..5a3d414c6970 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> @@ -72,4 +72,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c
> b/IntelUndiPkg/GigUndiDxe/Decode.c
> index f858abe10785..88e8be315bd1 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -1866,4 +1866,3 @@ BadCdb:
> CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.h
> b/IntelUndiPkg/GigUndiDxe/Decode.h
> index b00670f4d290..fb01267d0b2f 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.h
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.h
> @@ -46,4 +46,3 @@ E1000UndiApiEntry (
> );
>
> #endif /* DECODE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> index 47c2a07a0f16..3ffc25d58a3f 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.c
> @@ -189,4 +189,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index a0d6b613285d..f309044d9b9d 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -81,4 +81,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c
> b/IntelUndiPkg/GigUndiDxe/Dma.c
> index 7f32361ef678..76a3fcf69601 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.h
> b/IntelUndiPkg/GigUndiDxe/Dma.h
> index 6763c83dca39..3422acd500de 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.h
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.h
> @@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 9aec9422f1d6..118c1b2b9b04 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -571,4 +571,3 @@ EFI_DRIVER_CONFIGURATION_PROTOCOL
> gGigUndiDriverConfiguration = {
> GigUndiDriverConfigurationForceDefaults,
> "eng"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> index 9464cddbb756..a15a3a0a2745 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.h
> @@ -38,4 +38,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define MENU_EXIT 6
>
> #endif /* DRIVER_CONFIGURATION_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index 19b63b6059f6..a9f176ce5324 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1548,4 +1548,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL
> gGigUndiDriverDiagnostics2 = {
> (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS)
> GigUndiDriverDiagnosticsRunDiagnostics,
> "en-US"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> index 2a3fe772e80a..c0f984953065 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h
> @@ -82,4 +82,3 @@ typedef struct {
> #pragma pack()
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index 83de9e89ab66..b1af371e06db 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -134,4 +134,3 @@ EFI_DRIVER_HEALTH_PROTOCOL
> gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c
> b/IntelUndiPkg/GigUndiDxe/E1000.c
> index 842778a70d01..fad20d988441 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/E1000.c
> @@ -2455,4 +2455,3 @@ WaitForEnter (
> gST->ConIn->ReadKeyStroke (gST->ConIn, &Key);
> } while (Key.UnicodeChar != 0xD);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h
> b/IntelUndiPkg/GigUndiDxe/E1000.h
> index 38e88f0fd56d..71fe4591af05 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.h
> +++ b/IntelUndiPkg/GigUndiDxe/E1000.h
> @@ -1212,4 +1212,3 @@ WaitForEnter (
> #endif /* E1000_H_ */
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> index 4761e7dde99e..0d0047a93048 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> @@ -639,4 +639,3 @@ e1000_pci_clear_mwi (
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> index 2b5562f21e47..01c0843a2c9a 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> +++ b/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> @@ -575,4 +575,3 @@ typedef BOOLEAN boolean_t;
>
> #endif /* E1000_OSDEP_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> index 8a5cb62190f9..19d867ee58af 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.c
> @@ -861,4 +861,3 @@ EepromUpdateChecksum (
> return EFI_SUCCESS;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> index bd9fa5c0afb2..e0d31f6a151d 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> @@ -204,4 +204,3 @@ EepromUpdateChecksum (
> );
>
> #endif /* EEPROM_CONFIG_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index e52a78723cbf..2d2d0707a686 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -163,4 +163,3 @@ wol\wol_1G.c
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ##
> PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ##
> PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c
> b/IntelUndiPkg/GigUndiDxe/Hii.c
> index 85818fe964c5..43c184cb03c8 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -1238,4 +1238,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL
> gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.h
> b/IntelUndiPkg/GigUndiDxe/Hii.h
> index aa39eae7faea..5afdfc8cd174 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.h
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.h
> @@ -90,4 +90,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> index 21ec03193e26..2aacb63ca158 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> index 49abbd280c01..28298652403a 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.h
> @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c
> b/IntelUndiPkg/GigUndiDxe/Init.c
> index dad31a5f0844..47ed03eb0849 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -1876,4 +1876,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding
> = {
> NULL, // ImageHandle
> NULL // Driver Binding Handle
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.h
> b/IntelUndiPkg/GigUndiDxe/Init.h
> index 308f003ce038..409cb7082340 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.h
> +++ b/IntelUndiPkg/GigUndiDxe/Init.h
> @@ -45,4 +45,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define MAC_ADDRESS_SIZE_IN_BYTES 6
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> index 2c59c380fc09..a6cacaff4e17 100644
> --- a/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/GigUndiDxe/Inventory.vfr
> @@ -370,4 +370,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> index 50945f37437c..bd7d4defc9a3 100644
> --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> @@ -136,4 +136,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x14
> 07
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x14
> 08
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 8b17507ebf4d..10ab4e51bf44 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -103,4 +103,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StopDriver,
> StartDriver
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h
> b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index fdc0d5b6c1f6..24304d6cc3a7 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -67,4 +67,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
> };
>
> #endif /* START_STOP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/Version.h
> b/IntelUndiPkg/GigUndiDxe/Version.h
> index 11d9a607c4fa..b3019889634b 100644
> --- a/IntelUndiPkg/GigUndiDxe/Version.h
> +++ b/IntelUndiPkg/GigUndiDxe/Version.h
> @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* GigUndi major version */
> #define MINORVERSION 9 /* GigUndi minor version */
> #define BUILDNUMBER 99 /* GigUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> index c1ffc814236e..4264f2470f02 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c
> @@ -1532,4 +1532,3 @@ STATIC void
> e1000_clear_hw_cntrs_80003es2lan(struct e1000_hw *hw)
> E1000_READ_REG(hw, E1000_ICTXQMTC);
> E1000_READ_REG(hw, E1000_ICRXDMTC);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> index a37545399c97..df2c53318ce5 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h
> @@ -93,4 +93,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define GG82563_ICR_DIS_PADDING 0x0010 /*
> Disable Padding */
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> index 463e8c6eaa87..d970ce7292b8 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.c
> @@ -2079,4 +2079,3 @@ STATIC void e1000_clear_hw_cntrs_82571(struct
> e1000_hw *hw)
> E1000_READ_REG(hw, E1000_ICTXQMTC);
> E1000_READ_REG(hw, E1000_ICRXDMTC);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> index 8862e3e17dce..3df568892529 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82571.h
> @@ -60,4 +60,3 @@ bool e1000_get_laa_state_82571(struct e1000_hw
> *hw);
> void e1000_set_laa_state_82571(struct e1000_hw *hw, bool state);
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> index f6ad91d4a2d5..b052a38f5d80 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.c
> @@ -3342,4 +3342,3 @@ void e1000_write_vfta_i350(struct e1000_hw *hw,
> u32 offset, u32 value)
> }
>
> #endif /* NO_82580_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> index 39c1b38324ed..5e6be621ec13 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_82575.h
> @@ -433,4 +433,3 @@ s32 e1000_initialize_M88E1512_phy(struct e1000_hw
> *hw);
> s32 e1000_initialize_M88E1543_phy(struct e1000_hw *hw);
> #endif /* NO_82580_SUPPORT */
> #endif /* _E1000_82575_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.c
> b/IntelUndiPkg/GigUndiDxe/e1000_api.c
> index 1a8e45a2e86f..195992d46a34 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_api.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.c
> @@ -1280,4 +1280,3 @@ void e1000_shutdown_fiber_serdes_link(struct
> e1000_hw *hw)
> }
>
> #endif /* NO_82575_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_api.h
> b/IntelUndiPkg/GigUndiDxe/e1000_api.h
> index c35c366f5e91..6a75ec899a07 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_api.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_api.h
> @@ -176,4 +176,3 @@ s32 e1000_mng_write_dhcp_info(struct e1000_hw
> *hw, u8 *buffer, u16 length);
> #define E1000_DIVIDE_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) /*
> ceil(a/b) */
> #endif
> #endif /* _E1000_API_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> index 5052b7925c3b..1d07d30aa18e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
> @@ -1636,4 +1636,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define ERROR_REPORT(fmt) do { } while (0)
> #endif /* ERROR_REPORT */
> #endif /* _E1000_DEFINES_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> index 86d163e57906..27e34f5ae824 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_hw.h
> @@ -969,4 +969,3 @@ void e1000_write_pci_cfg(struct e1000_hw *hw, u32
> reg, u16 *value);
> #endif
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> index b485e739a434..5d05e3853361 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.c
> @@ -869,4 +869,3 @@ s32 e1000_init_hw_i210(struct e1000_hw *hw)
> ret_val = e1000_init_hw_82575(hw);
> return ret_val;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> index 3532126852b1..bde07d357ed6 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_i210.h
> @@ -97,4 +97,3 @@ enum E1000_INVM_STRUCTURE_TYPE {
> #define E1000_INVM_PLL_WO_VAL 0x0010
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> index e3a3606f8527..7669630a5c03 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> @@ -5684,4 +5684,3 @@ release:
> }
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> index 26fe0200e5a4..a435418078d2 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h
> @@ -290,4 +290,3 @@ s32 e1000_read_emi_reg_locked(struct e1000_hw
> *hw, u16 addr, u16 *data);
> s32 e1000_write_emi_reg_locked(struct e1000_hw *hw, u16 addr, u16
> data);
> s32 e1000_set_eee_pchlan(struct e1000_hw *hw);
> #endif /* _E1000_ICH8LAN_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> index a0a13da26316..f3727b9bc0de 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.c
> @@ -2293,4 +2293,3 @@ s32 e1000_write_8bit_ctrl_reg_generic(struct
> e1000_hw *hw, u32 reg,
> return E1000_SUCCESS;
> }
> #endif /* NO_82575_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> index 95fb00f3dc87..b8990d908b45 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_mac.h
> @@ -97,4 +97,3 @@ void e1000_update_adaptive_generic(struct e1000_hw
> *hw);
> void e1000_write_vfta_generic(struct e1000_hw *hw, u32 offset, u32
> value);
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> index 4bf703b2de4a..5fc7fa5704ac 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.c
> @@ -582,4 +582,3 @@ s32 e1000_load_firmware(struct e1000_hw *hw, u8
> *buffer, u32 length)
>
> #endif /* NO_I210_SUPPORT */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> index c9002a244a46..090a9a25de63 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_manage.h
> @@ -100,4 +100,3 @@ enum e1000_mng_mode {
> #define E1000_IAMT_SIGNATURE 0x544D4149
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> index 26244874f4e3..e46130186223 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.c
> @@ -1310,4 +1310,3 @@ STATIC void e1000_reload_nvm_generic(struct
> e1000_hw *hw)
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> index 06a668f5e912..ef84c51dbeb9 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_nvm.h
> @@ -92,4 +92,3 @@ void e1000_release_nvm_generic(struct e1000_hw
> *hw);
> #define E1000_STM_OPCODE 0xDB00
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> index b1c66d263183..765fcf387d7e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.c
> @@ -4465,4 +4465,3 @@ s32 e1000_write_xmdio_reg(struct e1000_hw *hw,
> u16 addr, u8 dev_addr, u16 data)
> false);
> }
> #endif /* NO_XMDIO_SUPPORT */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> index de82fde1f035..3efc73b006ee 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_phy.h
> @@ -349,4 +349,3 @@ struct sfp_e1000_flags {
>
> #endif /* NO_82575_SUPPORT */
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> index 8568edc310a5..d6c66b92e94e 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_regs.h
> @@ -772,4 +772,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #endif /* NO_I210_SUPPORT */
>
> #endif
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.c
> b/IntelUndiPkg/GigUndiDxe/wol/wol.c
> index 79100219b85b..74ffeafd787a 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.c
> @@ -341,4 +341,3 @@ WolEnableWakeOnLanEx(
> return WolGetWakeOnLanStatusEx(Handle);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol.h
> b/IntelUndiPkg/GigUndiDxe/wol/wol.h
> index 5ac38d6a3602..4f3140e152f8 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol.h
> @@ -84,4 +84,3 @@ WolEnableApmPme(
>
> #endif /* __WOL_H */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> index bba2393d6ff3..02eff0957976 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wol_1G.c
> @@ -183,4 +183,3 @@ WOL_STATUS
> _WolEnableLaser(WOL_ADAPTER_HANDLE_TYPE Handle, BOOLEAN Enable)
> return WOL_FEATURE_NOT_SUPPORTED;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> index 49d901defd4d..2c35be00f36a 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolfamily.c
> @@ -163,4 +163,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
> 0
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> index a5d536ee99c2..311930372f8b 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.c
> @@ -166,4 +166,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> return Handle->NicInfo.Function;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> index 84863eddc54e..ed2ffc427093 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> @@ -77,4 +77,3 @@ WOL_STATUS
> _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
> WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
>
> #endif /* __WOLIMPL_H */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> index c99667a25f8e..4df14ce2abf6 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolinfo.c
> @@ -334,4 +334,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[]
> = {
> { 0, 0, 0, 0, 0 } /* Last entry */
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> index 7b8b78daf29b..b2801a673d6e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.c
> @@ -410,4 +410,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo
> = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> index d5d5d52697c1..1401fbdb92fe 100644
> --- a/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/I40eUndiDxe/AdapterInformation.h
> @@ -102,4 +102,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Brand.c
> b/IntelUndiPkg/I40eUndiDxe/Brand.c
> index 250184d8b3ca..22629a933174 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Brand.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Brand.c
> @@ -210,4 +210,3 @@ BRAND_STRUCT mBrandingTable[] = {
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof
> (mBrandingTable[0]));
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> index cb83d3a79dd9..1241862adb81 100644
> --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.c
> @@ -275,4 +275,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL
> gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> index ed26dcb81b5b..dca634039b66 100644
> --- a/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/I40eUndiDxe/ComponentName.h
> @@ -73,4 +73,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.c
> b/IntelUndiPkg/I40eUndiDxe/Decode.c
> index d84255be0f6c..e47979e59126 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Decode.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Decode.c
> @@ -1881,4 +1881,3 @@ BadCdb:
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Decode.h
> b/IntelUndiPkg/I40eUndiDxe/Decode.h
> index 59f79e0abf5e..555d35620474 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Decode.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Decode.h
> @@ -48,4 +48,3 @@ UndiApiEntry (
>
> #endif /* DECODE_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> index 4d1061a794e4..007d651d126f 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.c
> @@ -202,4 +202,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> index b26f0ff0ec8c..b0de9f40c572 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DeviceSupport.h
> @@ -82,4 +82,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.c
> b/IntelUndiPkg/I40eUndiDxe/Dma.c
> index 17f14bd043f1..9efa705cb6f0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Dma.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Dma.c
> @@ -283,4 +283,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Dma.h
> b/IntelUndiPkg/I40eUndiDxe/Dma.h
> index 58a1f234b5df..d0d00463aa63 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Dma.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Dma.h
> @@ -133,4 +133,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> index 536ff7a65522..de07eb0f254f 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c
> @@ -1131,4 +1131,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL
> gUndiDriverDiagnostics2 = {
> "en-US"
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> index a6a725c33aa9..c3414f3897fe 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h
> @@ -80,4 +80,3 @@ typedef struct {
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> index 500ca3685cfc..30df2f3ec7d0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealth.c
> @@ -161,4 +161,3 @@ EFI_DRIVER_HEALTH_PROTOCOL
> gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> index c32302879390..da1d22057dcb 100644
> --- a/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> +++ b/IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h
> @@ -35,4 +35,3 @@ typedef enum {
> MODULE_UNSUPPORTED,
> } MODULE_QUALIFICATION_STATUS;
> #endif /* DRIVER_HEALTH_COMMON_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> index cc47e0437e80..4772715b3979 100644
> --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.c
> @@ -1254,4 +1254,3 @@ EepromReadPortnumValues (
> }
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> index e547d88b82b4..97e8be1ae80e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/I40eUndiDxe/EepromConfig.h
> @@ -556,4 +556,3 @@ EepromReadPortnumValues (
>
> #endif /* EEPROM_CONFIG_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.c
> b/IntelUndiPkg/I40eUndiDxe/Hii.c
> index e411f23d14ce..404e3672aa87 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Hii.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Hii.c
> @@ -1254,4 +1254,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL
> gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Hii.h
> b/IntelUndiPkg/I40eUndiDxe/Hii.h
> index e8e916a5ee90..8ab5108e2c8b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Hii.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Hii.h
> @@ -91,4 +91,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> index 4e6e28fdb5c0..365ed7f2da80 100644
> --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c
> @@ -486,4 +486,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> index 16655f384db3..b5ee09c49c9b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h
> @@ -163,4 +163,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.c
> b/IntelUndiPkg/I40eUndiDxe/I40e.c
> index ecf83ebc86df..c2501e4222f5 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e.c
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e.c
> @@ -3461,4 +3461,3 @@ I40eGetTxRxDescriptorsCount (
> return I40E_DEF_NUM_TX_RX_DESCRIPTORS;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e.h
> b/IntelUndiPkg/I40eUndiDxe/I40e.h
> index c5aabf6d7d69..9b994c5ec1c9 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e.h
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e.h
> @@ -1504,4 +1504,3 @@ I40eGetTxRxDescriptorsCount (
> );
>
> #endif /* I40E_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> index 76df7898bef1..caff5262f6e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> +++ b/IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf
> @@ -157,4 +157,3 @@ MSFT:*_*_*_CC_FLAGS = /FAcs
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ## PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ## PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> index 88a9547fc45b..ddd4449ad65c 100644
> --- a/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> +++ b/IntelUndiPkg/I40eUndiDxe/I40e_osdep.h
> @@ -601,4 +601,3 @@ DelayInMicroseconds (
>
>
> #endif /* I40E_OSDEP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Init.c
> b/IntelUndiPkg/I40eUndiDxe/Init.c
> index d45d669887d8..68a1699b00ba 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Init.c
> +++ b/IntelUndiPkg/I40eUndiDxe/Init.c
> @@ -2300,4 +2300,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding
> = {
> NULL,
> NULL
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Init.h
> b/IntelUndiPkg/I40eUndiDxe/Init.h
> index 217ed75cd179..899eeda1e6df 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Init.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Init.h
> @@ -87,4 +87,3 @@ UndiGetDriverHealthStatus (
> );
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> index a64b9297291b..ea48aad2bc85 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/I40eUndiDxe/Inventory.vfr
> @@ -369,4 +369,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> index 8387a99ae5bc..412cbf4833c7 100644
> --- a/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/NVDataStruc.h
> @@ -138,4 +138,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x14
> 07
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x14
> 08
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.c
> b/IntelUndiPkg/I40eUndiDxe/StartStop.c
> index 32c9c5e09655..b375b52fe882 100644
> --- a/IntelUndiPkg/I40eUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.c
> @@ -169,4 +169,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StartDriver
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/StartStop.h
> b/IntelUndiPkg/I40eUndiDxe/StartStop.h
> index 5ebf063e4913..d80fe79cbc3a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/I40eUndiDxe/StartStop.h
> @@ -79,4 +79,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
>
> #endif /* START_STOP_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/Version.h
> b/IntelUndiPkg/I40eUndiDxe/Version.h
> index dfb94cedd04c..e5a47633ddf1 100644
> --- a/IntelUndiPkg/I40eUndiDxe/Version.h
> +++ b/IntelUndiPkg/I40eUndiDxe/Version.h
> @@ -30,4 +30,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* I40eUndi major version */
> #define MINORVERSION 9 /* I40eUndi minor version */
> #define BUILDNUMBER 99 /* I40eUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> index af443b398bb9..7d11d1ce4d6a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.c
> @@ -1095,4 +1095,3 @@ clean_arq_element_err:
> return ret_code;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> index d17fe42cae96..51f0af909516 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq.h
> @@ -118,4 +118,3 @@ void i40e_fill_default_direct_cmd_desc(struct
> i40e_aq_desc *desc,
> u16 opcode);
>
> #endif /* _I40E_ADMINQ_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> index 8c0c6665ee55..78ec00252201 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h
> @@ -2974,4 +2974,3 @@ struct i40e_aqc_debug_modify_internals {
> I40E_CHECK_CMD_LENGTH(i40e_aqc_debug_modify_internals);
>
> #endif /* _I40E_ADMINQ_CMD_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> index 2f82f8dd72a5..51d83526207b 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_alloc.h
> @@ -60,4 +60,3 @@ enum i40e_status_code i40e_free_virt_mem(struct
> i40e_hw *hw,
> struct i40e_virt_mem *mem);
>
> #endif /* _I40E_ALLOC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> index 01bcfeed279c..faa7b8d7483e 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_common.c
> @@ -7631,4 +7631,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
> track_id, &offset, &info, NULL);
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> index 143c3b10c025..64aa672e0004 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_devids.h
> @@ -68,4 +68,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> (d) == I40E_DEV_ID_25G_SFP28)
>
> #endif /* _I40E_DEVIDS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> index f57fc65f60e0..62e8f8428aaa 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.c
> @@ -193,4 +193,3 @@ enum i40e_status_code
> i40e_diag_fw_alive_test(struct i40e_hw *hw)
> UNREFERENCED_1PARAMETER(hw);
> return I40E_SUCCESS;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> index 322cefb45732..4cda8b3444e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_diag.h
> @@ -56,4 +56,3 @@ enum i40e_status_code i40e_diag_reg_test(struct
> i40e_hw *hw);
> enum i40e_status_code i40e_diag_eeprom_test(struct i40e_hw *hw);
>
> #endif /* _I40E_DIAG_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> index 28ff0ace4680..b5c084bf3372 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.c
> @@ -366,4 +366,3 @@ enum i40e_status_code
> i40e_remove_pd_page_new(struct i40e_hw *hw,
>
> return i40e_free_dma_mem(hw, &(sd_entry-
> >u.pd_table.pd_page_addr));
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> index c7844edcb7ba..97ff0724729c 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_hmc.h
> @@ -240,4 +240,3 @@ enum i40e_status_code
> i40e_remove_pd_page_new(struct i40e_hw *hw,
> u32 idx, bool is_pf);
>
> #endif /* _I40E_HMC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> index 93f477d0268d..4720d9f0cc83 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c
> @@ -1610,4 +1610,3 @@ enum i40e_status_code
> i40e_set_lan_rx_queue_context_directly(struct i40e_hw *hw,
> return i40e_write_queue_context_directly(hw, queue,
> context_bytes,
> I40E_HMC_LAN_RX);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> index a5d59679af17..8842ac04470d 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h
> @@ -206,4 +206,3 @@ enum i40e_status_code
> i40e_delete_lan_hmc_object(struct i40e_hw *hw,
> struct i40e_hmc_lan_delete_obj_info
> *info);
>
> #endif /* _I40E_LAN_HMC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> index ef1774c8cc2e..0187d6ecb522 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_nvm.c
> @@ -758,4 +758,3 @@ enum i40e_status_code
> i40e_validate_nvm_checksum(struct i40e_hw *hw,
>
> return ret_code;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> index a85d80093a61..3bf01eaf1f55 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_prototype.h
> @@ -593,4 +593,3 @@ i40e_add_pinfo_to_list(struct i40e_hw *hw,
> struct i40e_profile_segment *profile,
> u8 *profile_info_sec, u32 track_id);
> #endif /* _I40E_PROTOTYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> index 0d8d1cfde13a..4eb955b8eeb5 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_register.h
> @@ -5357,4 +5357,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_MASK I40E_MASK(0xFFF,
> I40E_VFPE_WQEALLOC1_WQE_DESC_INDEX_SHIFT)
>
> #endif /* _I40E_REGISTER_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> index bd03a486d1ae..b5d9c71a37b0 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_status.h
> @@ -103,4 +103,3 @@ enum i40e_status_code {
> };
>
> #endif /* _I40E_STATUS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> index 521315c5459e..a2114db104e6 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_type.h
> @@ -1840,4 +1840,3 @@ struct i40e_profile_info {
> u8 name[I40E_DDP_NAME_SIZE];
> };
> #endif /* _I40E_TYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> index 2c25a79ae96a..4fb7e2428f1a 100644
> --- a/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> +++ b/IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h
> @@ -28,4 +28,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> ********************************************************************
> *******/
>
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> index cb5c28b052f9..26556e284381 100644
> --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c
> @@ -409,4 +409,3 @@ EFI_ADAPTER_INFORMATION_PROTOCOL gUndiAdapterInfo
> = {
> SetInformation,
> GetSupportedTypes
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> index 72d08a891d06..3b2039bc5cb2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.h
> @@ -101,4 +101,3 @@ UninstallAdapterInformationProtocol (
>
> #endif /* ADAPTER_INFORMATION_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Brand.c
> b/IntelUndiPkg/XGigUndiDxe/Brand.c
> index 9c97bb063df9..c65e57345f22 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Brand.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Brand.c
> @@ -173,4 +173,3 @@ BRAND_STRUCT mBrandingTable[] = {
> };
>
> UINTN mBrandingTableSize = (sizeof (mBrandingTable) / sizeof
> (mBrandingTable[0]));
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> index c136bd7fb436..2972c28bda4e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c
> @@ -276,4 +276,3 @@ EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL
> gUndiSupportedEfiVersion = {
> sizeof (EFI_DRIVER_SUPPORTED_EFI_VERSION_PROTOCOL),
> EFI_2_70_SYSTEM_TABLE_REVISION
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> index c538ea629e50..f63d58b8a18c 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h
> @@ -74,4 +74,3 @@ ComponentNameGetDriverName (
> );
>
> #endif /* COMPONENT_NAME_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c
> b/IntelUndiPkg/XGigUndiDxe/Decode.c
> index 675f0efca34a..70fbce64c64f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Decode.c
> @@ -1851,4 +1851,3 @@ BadCdb:
> CdbPtr->StatFlags = PXE_STATFLAGS_COMMAND_FAILED;
> CdbPtr->StatCode = PXE_STATCODE_INVALID_CDB;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.h
> b/IntelUndiPkg/XGigUndiDxe/Decode.h
> index c0a068716a8b..18cb4e4b1ecf 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Decode.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Decode.h
> @@ -45,4 +45,3 @@ UndiApiEntry (
> );
>
> #endif /* DECODE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> index 65f35269eff1..c9878f997c96 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.c
> @@ -189,4 +189,3 @@ IsDeviceIdSupported (
> }
> return FALSE;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> index e834201b5305..e997983ba3e7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DeviceSupport.h
> @@ -81,4 +81,3 @@ IsDeviceIdSupported (
> UINT16 DeviceId
> );
> #endif /* DEVICE_SUPPORT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.c
> b/IntelUndiPkg/XGigUndiDxe/Dma.c
> index b8df5d387eb2..c8588df96ef5 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Dma.c
> @@ -282,4 +282,3 @@ UndiDmaUnmapMemory (
> return Status;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Dma.h
> b/IntelUndiPkg/XGigUndiDxe/Dma.h
> index 6763c83dca39..3422acd500de 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Dma.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Dma.h
> @@ -132,4 +132,3 @@ UndiDmaUnmapMemory (
> );
>
> #endif /* _DMA_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> index 348abc8a9b91..66dc67a5400e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c
> @@ -525,4 +525,3 @@ EFI_DRIVER_DIAGNOSTICS2_PROTOCOL
> gXgbeUndiDriverDiagnostics2 = {
> (EFI_DRIVER_DIAGNOSTICS2_RUN_DIAGNOSTICS)
> XgbeUndiDriverDiagnosticsRunDiagnostics,
> "en-US"
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> index aafd7e65344a..4da70b1c122b 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h
> @@ -46,4 +46,3 @@ typedef struct {
> #pragma pack()
>
> #endif /* DRIVER_DIAGNOSTICS_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> index 31a9dfc9adad..df6cfdf8a123 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c
> @@ -160,4 +160,3 @@ EFI_DRIVER_HEALTH_PROTOCOL
> gUndiDriverHealthProtocol = {
> GetHealthStatus,
> Repair
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> index a1542333837f..6bc36d784d1e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h
> @@ -34,4 +34,3 @@ typedef enum {
> MODULE_UNSUPPORTED,
> } MODULE_QUALIFICATION_STATUS;
> #endif /* DRIVER_HEALTH_COMMON_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> index 4c8d8e0a70e4..deae76cab0e3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.c
> @@ -404,4 +404,3 @@ EepromUpdateChecksum (
> return EFI_SUCCESS;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> index b1aa113eb4c8..0b53f86ddd69 100644
> --- a/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/XGigUndiDxe/EepromConfig.h
> @@ -209,4 +209,3 @@ EepromUpdateChecksum (
>
> #endif /* EEPROM_CONFIG_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.c
> b/IntelUndiPkg/XGigUndiDxe/Hii.c
> index 7a4f5489225f..857a475622f7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Hii.c
> @@ -1199,4 +1199,3 @@ EFI_HII_CONFIG_ACCESS_PROTOCOL
> gUndiHiiConfigAccess = {
> RouteConfig,
> DriverCallback
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Hii.h
> b/IntelUndiPkg/XGigUndiDxe/Hii.h
> index 1de4b1b3cc53..8dbc6ec854b4 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Hii.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Hii.h
> @@ -90,4 +90,3 @@ HiiUnload (
> );
>
> #endif /* HII_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> index 21ec03193e26..2aacb63ca158 100644
> --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
> @@ -485,4 +485,3 @@ AsciiStrToUnicodeStrWrapper (
> return EFI_BUFFER_TOO_SMALL;
> }
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> index 49abbd280c01..28298652403a 100644
> --- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> +++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h
> @@ -162,4 +162,3 @@ AsciiStrToUnicodeStrWrapper (
> );
>
> #endif /* HII_INTERNAL_LIB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c
> b/IntelUndiPkg/XGigUndiDxe/Init.c
> index 4b03f0f72d5d..bffe3c165866 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Init.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Init.c
> @@ -2173,4 +2173,3 @@ EFI_DRIVER_BINDING_PROTOCOL gUndiDriverBinding
> = {
> NULL, // ImageHandle
> NULL // Driver Binding Handle
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Init.h
> b/IntelUndiPkg/XGigUndiDxe/Init.h
> index 591c5fabefc4..28efcd905379 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Init.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Init.h
> @@ -77,4 +77,3 @@ UndiGetDriverHealthStatus (
> );
>
> #endif /* INIT_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> index 3443f460caa3..45fc887d77cb 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> +++ b/IntelUndiPkg/XGigUndiDxe/Inventory.vfr
> @@ -368,4 +368,3 @@ formset
>
> endformset;
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> index c8cd6fc42779..e5e669681b07 100644
> --- a/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/XGigUndiDxe/NVDataStruc.h
> @@ -137,4 +137,3 @@ typedef struct {
> #define QUESTION_ID_TMP_SUPPORT_ALT_MAC_ADDR 0x14
> 07
> #define QUESTION_ID_TMP_SUPPORT_LINK_SPD_STATUS 0x14
> 08
> #endif /* NV_DATA_STRUC_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c
> b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> index e49e6c7a92ae..156e927a35c6 100644
> --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c
> @@ -113,4 +113,3 @@ EFI_DRIVER_STOP_PROTOCOL gUndiDriverStop = {
> StopDriver,
> StartDriver
> };
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.h
> b/IntelUndiPkg/XGigUndiDxe/StartStop.h
> index 97ab9f5da23e..03ad3dc9cecc 100644
> --- a/IntelUndiPkg/XGigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.h
> @@ -68,4 +68,3 @@ struct EFI_DRIVER_STOP_PROTOCOL_S {
> };
>
> #endif /* START_STOP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Version.h
> b/IntelUndiPkg/XGigUndiDxe/Version.h
> index 0ddd9ed7b1ce..78cc7809a16a 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Version.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Version.h
> @@ -29,4 +29,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #define MAJORVERSION 4 /* XGigUndi major version */
> #define MINORVERSION 9 /* XGigUndi minor version */
> #define BUILDNUMBER 99 /* XGigUndi build version */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> index 899310735fdf..9e0e4aff0885 100644
> --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf
> @@ -152,4 +152,3 @@ UNLOAD_IMAGE = UnloadXGigUndiDriver
> gEfiIfrTianoGuid ## CONSUMES ## Guid
> gEfiEventExitBootServicesGuid ##
> PRODUCES ## Event
> gEfiEventVirtualAddressChangeGuid ##
> PRODUCES ## Event
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> index b8c4f6077ecc..9e3ee862fb4e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
> @@ -2401,4 +2401,3 @@ WaitForEnter (
> } while (Key.UnicodeChar != 0xD);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> index 27ae1470d48c..5ab088362f90 100644
> --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h
> @@ -1172,4 +1172,3 @@ WaitForEnter (
> (BUILDNUMBER / 10 << 12) + (BUILDNUMBER % 10
> << 8))
>
> #endif /* XGBE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> index e6828519e4f1..adb62177a272 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c
> @@ -1536,4 +1536,3 @@ s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw
> *hw, u32 regval)
>
> return IXGBE_SUCCESS;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> index 297d880c621c..75ca431239d2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h
> @@ -52,4 +52,3 @@ void ixgbe_set_lan_id_multi_port_pcie_82598(struct
> ixgbe_hw *hw);
> void ixgbe_set_pcie_completion_timeout(struct ixgbe_hw *hw);
> s32 ixgbe_enable_rx_dma_82598(struct ixgbe_hw *hw, u32 regval);
> #endif /* _IXGBE_82598_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> index 34e9e5273b75..2fb101ea49f8 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c
> @@ -2783,4 +2783,3 @@ release_i2c_access:
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> index 3187c369acc7..aff0481f2612 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h
> @@ -65,4 +65,3 @@ s32 ixgbe_get_protected_blocks_82599(struct
> ixgbe_hw *hw,
> s32 prot_autoc_read_82599(struct ixgbe_hw *hw, bool *locked, u32
> *reg_val);
> s32 prot_autoc_write_82599(struct ixgbe_hw *hw, u32 reg_val, bool
> locked);
> #endif /* _IXGBE_82599_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> index c026024d8e10..88e10ca9c49f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.c
> @@ -1779,4 +1779,3 @@ void ixgbe_set_rate_select_speed(struct
> ixgbe_hw *hw, ixgbe_link_speed speed)
> if (hw->mac.ops.set_rate_select_speed)
> hw->mac.ops.set_rate_select_speed(hw, speed);
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> index 10604eca92d0..6bcf5dc1ebc6 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_api.h
> @@ -242,4 +242,3 @@ s32 ixgbe_negotiate_fc(struct ixgbe_hw *hw, u32
> adv_reg, u32 lp_reg,
> u32 adv_sym, u32 adv_asm, u32 lp_sym, u32
> lp_asm);
>
> #endif /* _IXGBE_API_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> index 4c6c79c67a24..62bdde1e1f9e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.c
> @@ -6064,4 +6064,3 @@ void ixgbe_set_soft_rate_select_speed(struct
> ixgbe_hw *hw,
> out:
> return;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> index 8557565344f5..4444e8b1eb27 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_common.h
> @@ -238,4 +238,3 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct
> ixgbe_hw *hw,
> void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,
> ixgbe_link_speed speed);
> #endif /* IXGBE_COMMON */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> index fbc75e3f37f9..291059da8f5b 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h
> @@ -167,4 +167,3 @@ u8 ixgbe_dcb_get_tc_from_up(struct
> ixgbe_dcb_config *, int, u8);
> s32 ixgbe_dcb_hw_config(struct ixgbe_hw *, u16 *, u16 *, u8 *, u8 *,
> u8 *);
> s32 ixgbe_dcb_hw_config_cee(struct ixgbe_hw *, struct
> ixgbe_dcb_config *);
> #endif /* _IXGBE_DCB_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> index 4aa05b8049e9..d5b4fc309f92 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h
> @@ -146,4 +146,3 @@ s32 ixgbe_dcb_config_82599(struct ixgbe_hw *,
> s32 ixgbe_dcb_hw_config_82599(struct ixgbe_hw *, int, u16 *, u16 *,
> u8 *,
> u8 *, u8 *);
> #endif /* _IXGBE_DCB_82959_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> index a7d4af9bcd6e..6fa0d1605c7c 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h
> @@ -553,4 +553,3 @@ typedef BOOLEAN boolean_t;
> #define IXGBE_BE16_TO_CPU(a) IxgbeReverseWord (a)
>
> #endif /* IXGBE_OSDEP_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> index 843ea3ce2856..5d748b0603f2 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c
> @@ -2742,4 +2742,3 @@ s32 ixgbe_set_copper_phy_power(struct ixgbe_hw
> *hw, bool on)
> reg);
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> index c317dfcb3e6b..f79d48b64c3f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h
> @@ -214,4 +214,3 @@ s32 ixgbe_read_i2c_combined_generic_int(struct
> ixgbe_hw *, u8 addr, u16 reg,
> s32 ixgbe_write_i2c_combined_generic_int(struct ixgbe_hw *, u8 addr,
> u16 reg,
> u16 val, bool lock);
> #endif /* _IXGBE_PHY_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> index e11bf564dac4..e3bb1a8a313e 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_type.h
> @@ -4539,4 +4539,3 @@ struct ixgbe_hw {
>
> #endif /* IXGBE_OSDEP2 */
> #endif /* _IXGBE_TYPE_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> index 6d89d8f4f440..f7f75ac52daf 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c
> @@ -1147,4 +1147,3 @@ s32 ixgbe_get_protected_blocks_X540(struct
> ixgbe_hw *hw,
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> index 40b6715ed37a..aa919940141f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h
> @@ -67,4 +67,3 @@ s32 ixgbe_get_protected_blocks_X540(struct ixgbe_hw
> *hw,
> u16 *eeprom_buffer, u32 eeprom_size);
> #endif /* _IXGBE_X540_H_ */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> index 92df8322f1ed..d49eb94732c3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c
> @@ -4795,4 +4795,3 @@ s32 ixgbe_get_protected_blocks_X550(struct
> ixgbe_hw *hw,
>
> return status;
> }
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> index 45303564fd8d..209a2b5bec0f 100644
> --- a/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> +++ b/IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h
> @@ -126,4 +126,3 @@ s32 ixgbe_get_protected_blocks_X550(struct
> ixgbe_hw *hw,
> u16 *blocks_size, u32 block_type_mask,
> u16 *eeprom_buffer, u32 eeprom_size);
> #endif /* _IXGBE_X550_H_ */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> index 6baf345fb8ee..c4b708d56e46 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.c
> @@ -316,4 +316,3 @@ WolEnableWakeOnLanEx(
> return WolGetWakeOnLanStatusEx(Handle);
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> index edcc250f3140..dfafbe6f4a1d 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol.h
> @@ -79,4 +79,3 @@ WolEnableApmPme(
>
> #endif /* __WOL_H */
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> index c61de75970e9..6446ab0f7f77 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c
> @@ -69,4 +69,3 @@ BOOLEAN
> _WolGetInfoFromEeprom_10G(WOL_ADAPTER_HANDLE_TYPE Handle)
> return FALSE;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> index 866a8330c0a1..4affb3aadb16 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c
> @@ -81,4 +81,3 @@ WOL_MAC_TYPE const WOL_LASER_TABLE[] = {
> 0
> };
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> index d00eb5d82820..f280f7adcbb7 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c
> @@ -83,4 +83,3 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> return Handle->NicInfo.Function;
> }
>
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> index eaea7675138d..d3dc0e268bd3 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h
> @@ -76,4 +76,3 @@ WOL_STATUS
> _WolEepromWrite16(WOL_ADAPTER_HANDLE_TYPE Handle, UINT16 Offset, UINT
> WOL_STATUS _WolEepromUpdateChecksum(WOL_ADAPTER_HANDLE_TYPE Handle);
>
> #endif /* __WOLIMPL_H */
> -\x1a
> \ No newline at end of file
> diff --git a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> index 7e49225c451d..ad12ddb1af37 100644
> --- a/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> +++ b/IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c
> @@ -175,4 +175,3 @@ _WOL_DEVICE_INFO_t const WOL_DEVICE_INFO_TABLE[]
> = {
> { 0, 0, 0, 0, 0 } /* Last entry */
> };
>
> -\x1a
> \ No newline at end of file
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 19:35 ` Philippe Mathieu-Daudé
2019-01-29 14:21 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
` (17 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace
all #include references with lowercase ones as well.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +-
IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +-
IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +-
IntelUndiPkg/GigUndiDxe/Dma.c | 2 +-
IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +-
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +-
IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +-
IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +-
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++----
IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +-
IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +-
IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +-
IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0
IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +-
IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0
IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +-
18 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
index b0320b11839b..8918c538e447 100644
--- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
+++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
@@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
#include "Uefi.h"
-#include "E1000.h"
+#include "e1000.h"
#include "AdapterInformation.h"
diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
index 1473bfbed0af..70baf00f4a5d 100644
--- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
+++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "ComponentName.h"
#include "DeviceSupport.h"
diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
index 88e8be315bd1..14060db0d050 100644
--- a/IntelUndiPkg/GigUndiDxe/Decode.c
+++ b/IntelUndiPkg/GigUndiDxe/Decode.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include <Uefi\UEfiPxe.h>
/** This routine determines the operational state of the UNDI. It updates the state flags in the
diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
index f309044d9b9d..e156b587f6a7 100644
--- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
+++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
@@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#ifndef DEVICE_SUPPORT_H_
#define DEVICE_SUPPORT_H_
-#include "E1000.h"
+#include "e1000.h"
typedef struct BRAND_STRUCT_S BRAND_STRUCT;
diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
index 76a3fcf69601..bf94c1e2fd54 100644
--- a/IntelUndiPkg/GigUndiDxe/Dma.c
+++ b/IntelUndiPkg/GigUndiDxe/Dma.c
@@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "Dma.h"
diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
index 118c1b2b9b04..20d40ab672ef 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "DriverConfiguration.h"
/* Protocol structure tentative definition */
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
index a9f176ce5324..559f2133281e 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "DriverDiagnostics.h"
/* Protocol structures tentative definitions */
diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
index b1af371e06db..b5b7db5fd814 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
/** Retrieves the health status of a controller in the platform.
diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
index e0d31f6a151d..272292d107e1 100644
--- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
+++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
@@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#ifndef EEPROM_CONFIG_H_
#define EEPROM_CONFIG_H_
-#include "E1000.h"
+#include "e1000.h"
// EEPROM power management bit definitions
#define E1000_INIT_CONTROL_WORD1 0x0A
diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
index 2d2d0707a686..0e4462733df6 100644
--- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
+++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
@@ -72,8 +72,8 @@ DriverConfiguration.c
DriverConfiguration.h
DriverDiagnostics.c
DriverDiagnostics.h
-E1000.h
-E1000.c
+e1000.h
+e1000.c
e1000_80003es2lan.h
e1000_80003es2lan.c
e1000_82571.h
@@ -92,8 +92,8 @@ e1000_manage.h
e1000_manage.c
e1000_nvm.h
e1000_nvm.c
-E1000_osdep.h
-E1000_osdep.c
+e1000_osdep.h
+e1000_osdep.c
e1000_phy.h
e1000_phy.c
e1000_regs.h
diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
index 47ed03eb0849..74b933674589 100644
--- a/IntelUndiPkg/GigUndiDxe/Init.c
+++ b/IntelUndiPkg/GigUndiDxe/Init.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "Init.h"
#include "DeviceSupport.h"
#include "Decode.h"
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
index 10ab4e51bf44..32bed7ce288d 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.c
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "StartStop.h"
EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID;
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
index 24304d6cc3a7..255f17aabaa4 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.h
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
@@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#ifndef START_STOP_H_
#define START_STOP_H_
-#include "E1000.h"
+#include "e1000.h"
#define EFI_DRIVER_STOP_PROTOCOL_GUID \
{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
similarity index 99%
rename from IntelUndiPkg/GigUndiDxe/E1000.c
rename to IntelUndiPkg/GigUndiDxe/e1000.c
index fad20d988441..6f8529abf046 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
#include "DeviceSupport.h"
diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h
similarity index 100%
rename from IntelUndiPkg/GigUndiDxe/E1000.h
rename to IntelUndiPkg/GigUndiDxe/e1000.h
diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
similarity index 99%
rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c
rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c
index 0d0047a93048..3aa18e735dee 100644
--- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
@@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
-#include "E1000.h"
+#include "e1000.h"
/** Reads from the PCI capabality region.
diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
similarity index 100%
rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h
rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h
diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
index ed2ffc427093..ec67d000e9ae 100644
--- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
+++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
@@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#ifndef __WOLIMPL_H
#define __WOLIMPL_H
-#include <E1000.h>
+#include <e1000.h>
#define WOL_1G 2
typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE;
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
@ 2018-11-06 19:35 ` Philippe Mathieu-Daudé
2019-01-29 14:21 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 19:35 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace
> all #include references with lowercase ones as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +-
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +-
> IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +-
> IntelUndiPkg/GigUndiDxe/Dma.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +-
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++----
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +-
> 18 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index b0320b11839b..8918c538e447 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> ***************************************************************************/
> #include "Uefi.h"
>
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> #include "AdapterInformation.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 1473bfbed0af..70baf00f4a5d 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "ComponentName.h"
> #include "DeviceSupport.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
> index 88e8be315bd1..14060db0d050 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include <Uefi\UEfiPxe.h>
>
> /** This routine determines the operational state of the UNDI. It updates the state flags in the
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index f309044d9b9d..e156b587f6a7 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef DEVICE_SUPPORT_H_
> #define DEVICE_SUPPORT_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> typedef struct BRAND_STRUCT_S BRAND_STRUCT;
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
> index 76a3fcf69601..bf94c1e2fd54 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "Dma.h"
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 118c1b2b9b04..20d40ab672ef 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverConfiguration.h"
>
> /* Protocol structure tentative definition */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index a9f176ce5324..559f2133281e 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverDiagnostics.h"
>
> /* Protocol structures tentative definitions */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index b1af371e06db..b5b7db5fd814 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> /** Retrieves the health status of a controller in the platform.
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> index e0d31f6a151d..272292d107e1 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef EEPROM_CONFIG_H_
> #define EEPROM_CONFIG_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> // EEPROM power management bit definitions
> #define E1000_INIT_CONTROL_WORD1 0x0A
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 2d2d0707a686..0e4462733df6 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -72,8 +72,8 @@ DriverConfiguration.c
> DriverConfiguration.h
> DriverDiagnostics.c
> DriverDiagnostics.h
> -E1000.h
> -E1000.c
> +e1000.h
> +e1000.c
> e1000_80003es2lan.h
> e1000_80003es2lan.c
> e1000_82571.h
> @@ -92,8 +92,8 @@ e1000_manage.h
> e1000_manage.c
> e1000_nvm.h
> e1000_nvm.c
> -E1000_osdep.h
> -E1000_osdep.c
> +e1000_osdep.h
> +e1000_osdep.c
> e1000_phy.h
> e1000_phy.c
> e1000_regs.h
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
> index 47ed03eb0849..74b933674589 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "Init.h"
> #include "DeviceSupport.h"
> #include "Decode.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 10ab4e51bf44..32bed7ce288d 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "StartStop.h"
>
> EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID;
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index 24304d6cc3a7..255f17aabaa4 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef START_STOP_H_
> #define START_STOP_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #define EFI_DRIVER_STOP_PROTOCOL_GUID \
> { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000.c
> rename to IntelUndiPkg/GigUndiDxe/e1000.c
> index fad20d988441..6f8529abf046 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DeviceSupport.h"
>
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000.h
> rename to IntelUndiPkg/GigUndiDxe/e1000.h
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> index 0d0047a93048..3aa18e735dee 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> -#include "E1000.h"
> +#include "e1000.h"
>
> /** Reads from the PCI capabality region.
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> index ed2ffc427093..ec67d000e9ae 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #ifndef __WOLIMPL_H
> #define __WOLIMPL_H
>
> -#include <E1000.h>
> +#include <e1000.h>
> #define WOL_1G 2
>
> typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE;
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
2018-11-06 19:35 ` Philippe Mathieu-Daudé
@ 2019-01-29 14:21 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 14:21 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Rename E1000.[ch] and E1000_osdep.[ch] to all lowercase, and replace
> all #include references with lowercase ones as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 2 +-
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 +-
> IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 2 +-
> IntelUndiPkg/GigUndiDxe/Dma.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 +-
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 +-
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 2 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 8 ++++---
> -
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.c | 2 +-
> IntelUndiPkg/GigUndiDxe/StartStop.h | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 0
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c} | 2 +-
> IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h} | 0
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 2 +-
> 18 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index b0320b11839b..8918c538e447 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -28,7 +28,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> ********************************************************************
> *******/
> #include "Uefi.h"
>
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> #include "AdapterInformation.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 1473bfbed0af..70baf00f4a5d 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "ComponentName.h"
> #include "DeviceSupport.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c
> b/IntelUndiPkg/GigUndiDxe/Decode.c
> index 88e8be315bd1..14060db0d050 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include <Uefi\UEfiPxe.h>
>
> /** This routine determines the operational state of the UNDI. It
> updates the state flags in the
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index f309044d9b9d..e156b587f6a7 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #ifndef DEVICE_SUPPORT_H_
> #define DEVICE_SUPPORT_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> typedef struct BRAND_STRUCT_S BRAND_STRUCT;
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c
> b/IntelUndiPkg/GigUndiDxe/Dma.c
> index 76a3fcf69601..bf94c1e2fd54 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #include "Dma.h"
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 118c1b2b9b04..20d40ab672ef 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverConfiguration.h"
>
> /* Protocol structure tentative definition */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index a9f176ce5324..559f2133281e 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DriverDiagnostics.h"
>
> /* Protocol structures tentative definitions */
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index b1af371e06db..b5b7db5fd814 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
>
>
> /** Retrieves the health status of a controller in the platform.
> diff --git a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> index e0d31f6a151d..272292d107e1 100644
> --- a/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> +++ b/IntelUndiPkg/GigUndiDxe/EepromConfig.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #ifndef EEPROM_CONFIG_H_
> #define EEPROM_CONFIG_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> // EEPROM power management bit definitions
> #define E1000_INIT_CONTROL_WORD1 0x0A
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 2d2d0707a686..0e4462733df6 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -72,8 +72,8 @@ DriverConfiguration.c
> DriverConfiguration.h
> DriverDiagnostics.c
> DriverDiagnostics.h
> -E1000.h
> -E1000.c
> +e1000.h
> +e1000.c
> e1000_80003es2lan.h
> e1000_80003es2lan.c
> e1000_82571.h
> @@ -92,8 +92,8 @@ e1000_manage.h
> e1000_manage.c
> e1000_nvm.h
> e1000_nvm.c
> -E1000_osdep.h
> -E1000_osdep.c
> +e1000_osdep.h
> +e1000_osdep.c
> e1000_phy.h
> e1000_phy.c
> e1000_regs.h
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c
> b/IntelUndiPkg/GigUndiDxe/Init.c
> index 47ed03eb0849..74b933674589 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "Init.h"
> #include "DeviceSupport.h"
> #include "Decode.h"
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 10ab4e51bf44..32bed7ce288d 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "StartStop.h"
>
> EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID;
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h
> b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index 24304d6cc3a7..255f17aabaa4 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #ifndef START_STOP_H_
> #define START_STOP_H_
>
> -#include "E1000.h"
> +#include "e1000.h"
>
> #define EFI_DRIVER_STOP_PROTOCOL_GUID \
> { 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.c
> b/IntelUndiPkg/GigUndiDxe/e1000.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000.c
> rename to IntelUndiPkg/GigUndiDxe/e1000.c
> index fad20d988441..6f8529abf046 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
> #include "DeviceSupport.h"
>
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000.h
> b/IntelUndiPkg/GigUndiDxe/e1000.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000.h
> rename to IntelUndiPkg/GigUndiDxe/e1000.h
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> similarity index 99%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> index 0d0047a93048..3aa18e735dee 100644
> --- a/IntelUndiPkg/GigUndiDxe/E1000_osdep.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.c
> @@ -26,7 +26,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
> IN ANY WAY OUT OF THE USE
> OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> -#include "E1000.h"
> +#include "e1000.h"
>
> /** Reads from the PCI capabality region.
>
> diff --git a/IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> similarity index 100%
> rename from IntelUndiPkg/GigUndiDxe/E1000_osdep.h
> rename to IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> diff --git a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> index ed2ffc427093..ec67d000e9ae 100644
> --- a/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> +++ b/IntelUndiPkg/GigUndiDxe/wol/wolimpl.h
> @@ -29,7 +29,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #ifndef __WOLIMPL_H
> #define __WOLIMPL_H
>
> -#include <E1000.h>
> +#include <e1000.h>
> #define WOL_1G 2
>
> typedef UNDI_PRIVATE_DATA *WOL_ADAPTER_HANDLE_TYPE;
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (2 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 19:37 ` Philippe Mathieu-Daudé
2019-01-29 14:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
` (16 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Replace backslashes in paths with forward slashes to be compatible with
non-Windows OSes.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++++++-------
IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
index 14060db0d050..9f8a5a8c1c81 100644
--- a/IntelUndiPkg/GigUndiDxe/Decode.c
+++ b/IntelUndiPkg/GigUndiDxe/Decode.c
@@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
***************************************************************************/
#include "e1000.h"
-#include <Uefi\UEfiPxe.h>
+#include <Uefi/UefiPxe.h>
/** This routine determines the operational state of the UNDI. It updates the state flags in the
Command Descriptor Block based on information derived from the GigAdapter instance data.
diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
index 0e4462733df6..6c195872c00f 100644
--- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
+++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
@@ -115,13 +115,13 @@ AdapterInformation.c
AdapterInformation.h
Version.h
-wol\wol.h
-wol\wol.c
-wol\wolimpl.h
-wol\wolimpl.c
-wol\wolfamily.c
-wol\wolinfo.c
-wol\wol_1G.c
+wol/wol.h
+wol/wol.c
+wol/wolimpl.h
+wol/wolimpl.c
+wol/wolfamily.c
+wol/wolinfo.c
+wol/wol_1G.c
[sources.X64]
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
index 01c0843a2c9a..4408b409a445 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
@@ -31,8 +31,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <Uefi.h>
#include <Base.h>
-#include <Library\BaseLib.h>
-#include <Library\BaseMemoryLib.h>
+#include <Library/BaseLib.h>
+#include <Library/BaseMemoryLib.h>
#pragma warning(disable : 4244)
#pragma warning(disable : 4206)
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
@ 2018-11-06 19:37 ` Philippe Mathieu-Daudé
2019-01-29 14:26 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 19:37 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Replace backslashes in paths with forward slashes to be compatible with
> non-Windows OSes.
I thought the Windows format expected escaped backslashes...
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++++++-------
> IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++--
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c b/IntelUndiPkg/GigUndiDxe/Decode.c
> index 14060db0d050..9f8a5a8c1c81 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> ***************************************************************************/
> #include "e1000.h"
> -#include <Uefi\UEfiPxe.h>
> +#include <Uefi/UefiPxe.h>
>
> /** This routine determines the operational state of the UNDI. It updates the state flags in the
> Command Descriptor Block based on information derived from the GigAdapter instance data.
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 0e4462733df6..6c195872c00f 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -115,13 +115,13 @@ AdapterInformation.c
> AdapterInformation.h
> Version.h
>
> -wol\wol.h
> -wol\wol.c
> -wol\wolimpl.h
> -wol\wolimpl.c
> -wol\wolfamily.c
> -wol\wolinfo.c
> -wol\wol_1G.c
> +wol/wol.h
> +wol/wol.c
> +wol/wolimpl.h
> +wol/wolimpl.c
> +wol/wolfamily.c
> +wol/wolinfo.c
> +wol/wol_1G.c
>
> [sources.X64]
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> index 01c0843a2c9a..4408b409a445 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> @@ -31,8 +31,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> #include <Uefi.h>
> #include <Base.h>
> -#include <Library\BaseLib.h>
> -#include <Library\BaseMemoryLib.h>
> +#include <Library/BaseLib.h>
> +#include <Library/BaseMemoryLib.h>
>
> #pragma warning(disable : 4244)
> #pragma warning(disable : 4206)
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
2018-11-06 19:37 ` Philippe Mathieu-Daudé
@ 2019-01-29 14:26 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 14:26 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Replace backslashes in paths with forward slashes to be compatible
> with
> non-Windows OSes.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/Decode.c | 2 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 14 +++++++-------
> IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 4 ++--
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Decode.c
> b/IntelUndiPkg/GigUndiDxe/Decode.c
> index 14060db0d050..9f8a5a8c1c81 100644
> --- a/IntelUndiPkg/GigUndiDxe/Decode.c
> +++ b/IntelUndiPkg/GigUndiDxe/Decode.c
> @@ -27,7 +27,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
>
> ********************************************************************
> *******/
> #include "e1000.h"
> -#include <Uefi\UEfiPxe.h>
> +#include <Uefi/UefiPxe.h>
>
> /** This routine determines the operational state of the UNDI. It
> updates the state flags in the
> Command Descriptor Block based on information derived from the
> GigAdapter instance data.
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 0e4462733df6..6c195872c00f 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -115,13 +115,13 @@ AdapterInformation.c
> AdapterInformation.h
> Version.h
>
> -wol\wol.h
> -wol\wol.c
> -wol\wolimpl.h
> -wol\wolimpl.c
> -wol\wolfamily.c
> -wol\wolinfo.c
> -wol\wol_1G.c
> +wol/wol.h
> +wol/wol.c
> +wol/wolimpl.h
> +wol/wolimpl.c
> +wol/wolfamily.c
> +wol/wolinfo.c
> +wol/wol_1G.c
>
> [sources.X64]
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> index 01c0843a2c9a..4408b409a445 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> @@ -31,8 +31,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
>
> #include <Uefi.h>
> #include <Base.h>
> -#include <Library\BaseLib.h>
> -#include <Library\BaseMemoryLib.h>
> +#include <Library/BaseLib.h>
> +#include <Library/BaseMemoryLib.h>
>
> #pragma warning(disable : 4244)
> #pragma warning(disable : 4206)
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (3 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-29 16:02 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
` (15 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Move the extern declaration of mBrandingTable[] after the definition of
the type. This solves a build issue with GCC.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
index e156b587f6a7..e2b730131f8e 100644
--- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
+++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
@@ -33,9 +33,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
typedef struct BRAND_STRUCT_S BRAND_STRUCT;
-extern BRAND_STRUCT mBrandingTable[];
-extern UINTN mBrandingTableSize;
-
/* Defines */
#define INVALID_VENDOR_ID 0xFFFF
#define INVALID_SUBVENDOR_ID 0xFFFF
@@ -53,6 +50,9 @@ struct BRAND_STRUCT_S {
CHAR16 *BrandString;
};
+extern BRAND_STRUCT mBrandingTable[];
+extern UINTN mBrandingTableSize;
+
/* Function declarations */
/** Returns pointer to current device's branding string (looks for best match)
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition
2018-11-06 17:58 ` [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
@ 2019-01-29 16:02 ` Ryszard Knop
0 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 16:02 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Hmm, BRAND_STRUCT_S could be simplified into a single struct def -
works on both MSVC and GCC.
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Move the extern declaration of mBrandingTable[] after the definition
> of
> the type. This solves a build issue with GCC.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> index e156b587f6a7..e2b730131f8e 100644
> --- a/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> +++ b/IntelUndiPkg/GigUndiDxe/DeviceSupport.h
> @@ -33,9 +33,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
>
> typedef struct BRAND_STRUCT_S BRAND_STRUCT;
>
> -extern BRAND_STRUCT mBrandingTable[];
> -extern UINTN mBrandingTableSize;
> -
> /* Defines */
> #define INVALID_VENDOR_ID 0xFFFF
> #define INVALID_SUBVENDOR_ID 0xFFFF
> @@ -53,6 +50,9 @@ struct BRAND_STRUCT_S {
> CHAR16 *BrandString;
> };
>
> +extern BRAND_STRUCT mBrandingTable[];
> +extern UINTN mBrandingTableSize;
> +
> /* Function declarations */
>
> /** Returns pointer to current device's branding string (looks for
> best match)
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (4 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-30 10:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
` (14 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Use intermediate (UINTN) casts when casting pointers to UINT64.
This is needed to be able to build this code for 32-bit architectures
such as ARM or IA32.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/Dma.c | 8 ++++----
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 6 +++---
IntelUndiPkg/GigUndiDxe/Init.c | 6 +++---
IntelUndiPkg/GigUndiDxe/e1000.c | 10 +++++-----
IntelUndiPkg/GigUndiDxe/e1000.h | 4 ++--
5 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c b/IntelUndiPkg/GigUndiDxe/Dma.c
index bf94c1e2fd54..eee2aa8a1ce3 100644
--- a/IntelUndiPkg/GigUndiDxe/Dma.c
+++ b/IntelUndiPkg/GigUndiDxe/Dma.c
@@ -127,7 +127,7 @@ FREE_BUF_ON_ERROR:
PciIo->FreeBuffer (
PciIo,
BytesToPages (DmaMapping->Size),
- (VOID *) DmaMapping->UnmappedAddress
+ (VOID *)(UINTN)DmaMapping->UnmappedAddress
);
DmaMapping->Size = 0;
DmaMapping->UnmappedAddress = 0;
@@ -173,7 +173,7 @@ UndiDmaFreeCommonBuffer (
PciIo->FreeBuffer (
PciIo,
BytesToPages (DmaMapping->Size),
- (VOID *) DmaMapping->UnmappedAddress
+ (VOID *)(UINTN)DmaMapping->UnmappedAddress
);
DmaMapping->UnmappedAddress = 0;
@@ -209,7 +209,7 @@ UndiDmaMapCommonBuffer (
return PciIo->Map (
PciIo,
EfiPciIoOperationBusMasterCommonBuffer,
- (VOID *) DmaMapping->UnmappedAddress,
+ (VOID *)(UINTN)DmaMapping->UnmappedAddress,
&DmaMapping->Size,
&DmaMapping->PhysicalAddress,
&DmaMapping->Mapping
@@ -243,7 +243,7 @@ UndiDmaMapMemoryRead (
return PciIo->Map (
PciIo,
EfiPciIoOperationBusMasterRead,
- (VOID *) DmaMapping->UnmappedAddress,
+ (VOID *)(UINTN)DmaMapping->UnmappedAddress,
&DmaMapping->Size,
&DmaMapping->PhysicalAddress,
&DmaMapping->Mapping
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
index 559f2133281e..aceb015e480f 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
@@ -1132,7 +1132,7 @@ GigUndiRunPhyLoopback (
while (j < PHY_LOOPBACK_ITERATIONS) {
Status = E1000Transmit (
GigAdapterInfo,
- (UINT64) &PxeCpbTransmit,
+ (UINT64)(UINTN)&PxeCpbTransmit,
PXE_OPFLAGS_TRANSMIT_WHOLE
);
_DisplayBuffersAndDescriptors (GigAdapterInfo);
@@ -1161,8 +1161,8 @@ GigUndiRunPhyLoopback (
for (i = 0; i <= 100000; i++) {
Status = E1000Receive (
GigAdapterInfo,
- (UINT64) &CpbReceive,
- (UINT64) &DbReceive
+ (UINT64)(UINTN)&CpbReceive,
+ (UINT64)(UINTN)&DbReceive
);
gBS->Stall (10);
diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
index 74b933674589..f99734d72823 100644
--- a/IntelUndiPkg/GigUndiDxe/Init.c
+++ b/IntelUndiPkg/GigUndiDxe/Init.c
@@ -301,7 +301,7 @@ GigUndiPxeStructInit (
PXE_ROMID_IMP_TX_COMPLETE_INT_SUPPORTED |
PXE_ROMID_IMP_PACKET_RX_INT_SUPPORTED;
- PxePtr->EntryPoint = (UINT64) E1000UndiApiEntry;
+ PxePtr->EntryPoint = (UINT64)(UINTN)E1000UndiApiEntry;
PxePtr->reserved2[0] = 0;
PxePtr->reserved2[1] = 0;
PxePtr->reserved2[2] = 0;
@@ -842,7 +842,7 @@ InitNiiProtocol (
return EFI_INVALID_PARAMETER;
}
- NiiProtocol31->Id = (UINT64) (mE1000Pxe31);
+ NiiProtocol31->Id = (UINT64)(UINTN)mE1000Pxe31;
NiiProtocol31->IfNum = mE1000Pxe31->IFcnt;
NiiProtocol31->Revision = EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_REVISION_31;
@@ -938,7 +938,7 @@ InitUndiCallbackFunctions (
NicInfo->MapMem = (VOID *) 0;
NicInfo->UnMapMem = (VOID *) 0;
NicInfo->SyncMem = (VOID *) 0;
- NicInfo->UniqueId = (UINT64) NicInfo;
+ NicInfo->UniqueId = (UINT64)(UINTN)NicInfo;
NicInfo->VersionFlag = 0x31;
}
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
index 6f8529abf046..1f08a5d67b2d 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000.c
@@ -128,7 +128,7 @@ E1000MapMem (
VirtualAddress,
Size,
TO_DEVICE,
- (UINT64) MappedAddress
+ (UINT64)(UINTN)MappedAddress
);
if (*MappedAddress == 0) {
@@ -1079,7 +1079,7 @@ E1000TxRxConfigure (
ZeroMem (GigAdapter->TxBufferMappings, sizeof (GigAdapter->TxBufferMappings));
- RxBuffer = (LOCAL_RX_BUFFER *) GigAdapter->RxBufferMapping.PhysicalAddress;
+ RxBuffer = (LOCAL_RX_BUFFER *)(UINTN)GigAdapter->RxBufferMapping.PhysicalAddress;
DEBUGPRINT (
E1000, ("Tx Ring %x Added %x\n",
@@ -1578,17 +1578,17 @@ E1000Inititialize (
TempBar = NULL;
ZeroMem (
- (VOID *) GigAdapter->RxRing.UnmappedAddress,
+ (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,
RX_RING_SIZE
);
ZeroMem (
- (VOID *) GigAdapter->TxRing.UnmappedAddress,
+ (VOID *)(UINTN)GigAdapter->TxRing.UnmappedAddress,
TX_RING_SIZE
);
ZeroMem (
- (VOID *) GigAdapter->RxBufferMapping.UnmappedAddress,
+ (VOID *)(UINTN)GigAdapter->RxBufferMapping.UnmappedAddress,
RX_BUFFERS_SIZE
);
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.h b/IntelUndiPkg/GigUndiDxe/e1000.h
index 71fe4591af05..a44fe3fa2ec8 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000.h
@@ -233,7 +233,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
@return Descriptor retrieved
**/
#define E1000_RX_DESC(R, i) \
- (&(((struct e1000_rx_desc *) ((R)->UnmappedAddress))[i]))
+ (&(((struct e1000_rx_desc *)(UINTN)((R)->UnmappedAddress))[i]))
/** Retrieves TX descriptor from TX ring structure
@@ -243,7 +243,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
@return Descriptor retrieved
**/
#define E1000_TX_DESC(R, i) \
- (&(((struct e1000_tx_desc *) ((R)->UnmappedAddress))[i]))
+ (&(((struct e1000_tx_desc *)(UINTN)((R)->UnmappedAddress))[i]))
/** Retrieves UNDI_PRIVATE_DATA structure using NII Protocol 3.1 instance
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers
2018-11-06 17:58 ` [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
@ 2019-01-30 10:59 ` Ryszard Knop
0 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 10:59 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Use intermediate (UINTN) casts when casting pointers to UINT64.
> This is needed to be able to build this code for 32-bit architectures
> such as ARM or IA32.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/Dma.c | 8 ++++----
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 6 +++---
> IntelUndiPkg/GigUndiDxe/Init.c | 6 +++---
> IntelUndiPkg/GigUndiDxe/e1000.c | 10 +++++-----
> IntelUndiPkg/GigUndiDxe/e1000.h | 4 ++--
> 5 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Dma.c
> b/IntelUndiPkg/GigUndiDxe/Dma.c
> index bf94c1e2fd54..eee2aa8a1ce3 100644
> --- a/IntelUndiPkg/GigUndiDxe/Dma.c
> +++ b/IntelUndiPkg/GigUndiDxe/Dma.c
> @@ -127,7 +127,7 @@ FREE_BUF_ON_ERROR:
> PciIo->FreeBuffer (
> PciIo,
> BytesToPages (DmaMapping->Size),
> - (VOID *) DmaMapping->UnmappedAddress
> + (VOID *)(UINTN)DmaMapping->UnmappedAddress
> );
> DmaMapping->Size = 0;
> DmaMapping->UnmappedAddress = 0;
> @@ -173,7 +173,7 @@ UndiDmaFreeCommonBuffer (
> PciIo->FreeBuffer (
> PciIo,
> BytesToPages (DmaMapping->Size),
> - (VOID *) DmaMapping->UnmappedAddress
> + (VOID *)(UINTN)DmaMapping->UnmappedAddress
> );
>
> DmaMapping->UnmappedAddress = 0;
> @@ -209,7 +209,7 @@ UndiDmaMapCommonBuffer (
> return PciIo->Map (
> PciIo,
> EfiPciIoOperationBusMasterCommonBuffer,
> - (VOID *) DmaMapping->UnmappedAddress,
> + (VOID *)(UINTN)DmaMapping->UnmappedAddress,
> &DmaMapping->Size,
> &DmaMapping->PhysicalAddress,
> &DmaMapping->Mapping
> @@ -243,7 +243,7 @@ UndiDmaMapMemoryRead (
> return PciIo->Map (
> PciIo,
> EfiPciIoOperationBusMasterRead,
> - (VOID *) DmaMapping->UnmappedAddress,
> + (VOID *)(UINTN)DmaMapping->UnmappedAddress,
> &DmaMapping->Size,
> &DmaMapping->PhysicalAddress,
> &DmaMapping->Mapping
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index 559f2133281e..aceb015e480f 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1132,7 +1132,7 @@ GigUndiRunPhyLoopback (
> while (j < PHY_LOOPBACK_ITERATIONS) {
> Status = E1000Transmit (
> GigAdapterInfo,
> - (UINT64) &PxeCpbTransmit,
> + (UINT64)(UINTN)&PxeCpbTransmit,
> PXE_OPFLAGS_TRANSMIT_WHOLE
> );
> _DisplayBuffersAndDescriptors (GigAdapterInfo);
> @@ -1161,8 +1161,8 @@ GigUndiRunPhyLoopback (
> for (i = 0; i <= 100000; i++) {
> Status = E1000Receive (
> GigAdapterInfo,
> - (UINT64) &CpbReceive,
> - (UINT64) &DbReceive
> + (UINT64)(UINTN)&CpbReceive,
> + (UINT64)(UINTN)&DbReceive
> );
> gBS->Stall (10);
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c
> b/IntelUndiPkg/GigUndiDxe/Init.c
> index 74b933674589..f99734d72823 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -301,7 +301,7 @@ GigUndiPxeStructInit (
> PXE_ROMID_IMP_TX_COMPLETE_INT_SUPPORTED |
> PXE_ROMID_IMP_PACKET_RX_INT_SUPPORTED;
>
> - PxePtr->EntryPoint = (UINT64) E1000UndiApiEntry;
> + PxePtr->EntryPoint = (UINT64)(UINTN)E1000UndiApiEntry;
> PxePtr->reserved2[0] = 0;
> PxePtr->reserved2[1] = 0;
> PxePtr->reserved2[2] = 0;
> @@ -842,7 +842,7 @@ InitNiiProtocol (
> return EFI_INVALID_PARAMETER;
> }
>
> - NiiProtocol31->Id = (UINT64) (mE1000Pxe31);
> + NiiProtocol31->Id = (UINT64)(UINTN)mE1000Pxe31;
> NiiProtocol31->IfNum = mE1000Pxe31->IFcnt;
>
> NiiProtocol31->Revision =
> EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL_REVISION_31;
> @@ -938,7 +938,7 @@ InitUndiCallbackFunctions (
> NicInfo->MapMem = (VOID *) 0;
> NicInfo->UnMapMem = (VOID *) 0;
> NicInfo->SyncMem = (VOID *) 0;
> - NicInfo->UniqueId = (UINT64) NicInfo;
> + NicInfo->UniqueId = (UINT64)(UINTN)NicInfo;
> NicInfo->VersionFlag = 0x31;
> }
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c
> b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 6f8529abf046..1f08a5d67b2d 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -128,7 +128,7 @@ E1000MapMem (
> VirtualAddress,
> Size,
> TO_DEVICE,
> - (UINT64) MappedAddress
> + (UINT64)(UINTN)MappedAddress
> );
>
> if (*MappedAddress == 0) {
> @@ -1079,7 +1079,7 @@ E1000TxRxConfigure (
>
> ZeroMem (GigAdapter->TxBufferMappings, sizeof (GigAdapter-
> >TxBufferMappings));
>
> - RxBuffer = (LOCAL_RX_BUFFER *) GigAdapter-
> >RxBufferMapping.PhysicalAddress;
> + RxBuffer = (LOCAL_RX_BUFFER *)(UINTN)GigAdapter-
> >RxBufferMapping.PhysicalAddress;
>
> DEBUGPRINT (
> E1000, ("Tx Ring %x Added %x\n",
> @@ -1578,17 +1578,17 @@ E1000Inititialize (
> TempBar = NULL;
>
> ZeroMem (
> - (VOID *) GigAdapter->RxRing.UnmappedAddress,
> + (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,
> RX_RING_SIZE
> );
>
> ZeroMem (
> - (VOID *) GigAdapter->TxRing.UnmappedAddress,
> + (VOID *)(UINTN)GigAdapter->TxRing.UnmappedAddress,
> TX_RING_SIZE
> );
>
> ZeroMem (
> - (VOID *) GigAdapter->RxBufferMapping.UnmappedAddress,
> + (VOID *)(UINTN)GigAdapter->RxBufferMapping.UnmappedAddress,
> RX_BUFFERS_SIZE
> );
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.h
> b/IntelUndiPkg/GigUndiDxe/e1000.h
> index 71fe4591af05..a44fe3fa2ec8 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.h
> @@ -233,7 +233,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> @return Descriptor retrieved
> **/
> #define E1000_RX_DESC(R, i) \
> - (&(((struct e1000_rx_desc *) ((R)->UnmappedAddress))[i]))
> + (&(((struct e1000_rx_desc *)(UINTN)((R)-
> >UnmappedAddress))[i]))
>
> /** Retrieves TX descriptor from TX ring structure
>
> @@ -243,7 +243,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> @return Descriptor retrieved
> **/
> #define E1000_TX_DESC(R, i) \
> - (&(((struct e1000_tx_desc *) ((R)->UnmappedAddress))[i]))
> + (&(((struct e1000_tx_desc *)(UINTN)((R)-
> >UnmappedAddress))[i]))
>
> /** Retrieves UNDI_PRIVATE_DATA structure using NII Protocol 3.1
> instance
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (5 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-30 11:48 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
` (13 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Prefix the existing MSFT only build option overrides with MSFT: and
create the GCC: counterparts so we can build this code with GCC as
well.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
index 6c195872c00f..19dae9a0987a 100644
--- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
+++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
@@ -41,20 +41,20 @@ ENTRY_POINT = InitializeGigUNDIDriver
UNLOAD_IMAGE = GigUndiUnload
[BuildOptions.common]
-
-*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
+ MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
+ GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
[BuildOptions.X64]
-
-*_*_*_CC_FLAGS = /D EFIX64
+ MSFT:*_*_*_CC_FLAGS = /D EFIX64
+ GCC:*_*_*_CC_FLAGS = -D EFIX64
[BuildOptions.IPF]
-
-*_*_*_CC_FLAGS = /D EFI64
+ MSFT:*_*_*_CC_FLAGS = /D EFI64
+ GCC:*_*_*_CC_FLAGS = -D EFI64
[BuildOptions.IA32]
-
-*_*_*_CC_FLAGS = /D EFI32
+ MSFT:*_*_*_CC_FLAGS = /D EFI32
+ GCC:*_*_*_CC_FLAGS = -D EFI32
[sources.common]
InventoryStrings.uni
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options
2018-11-06 17:58 ` [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
@ 2019-01-30 11:48 ` Ryszard Knop
0 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 11:48 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Just one note for this: We have separate defines for EFI32 (IA32),
EFI64 (IPF) and EFIX64 (X64) to sprinkle some workarounds where needed.
It seems ARM doesn't need that for now, but I'll add similar defines
for it as well so that we have that available in the future.
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Prefix the existing MSFT only build option overrides with MSFT: and
> create the GCC: counterparts so we can build this code with GCC as
> well.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 6c195872c00f..19dae9a0987a 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -41,20 +41,20 @@ ENTRY_POINT = InitializeGigUNDIDriver
> UNLOAD_IMAGE = GigUndiUnload
>
> [BuildOptions.common]
> -
> -*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
> + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
> + GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
>
> [BuildOptions.X64]
> -
> -*_*_*_CC_FLAGS = /D EFIX64
> + MSFT:*_*_*_CC_FLAGS = /D EFIX64
> + GCC:*_*_*_CC_FLAGS = -D EFIX64
>
> [BuildOptions.IPF]
> -
> -*_*_*_CC_FLAGS = /D EFI64
> + MSFT:*_*_*_CC_FLAGS = /D EFI64
> + GCC:*_*_*_CC_FLAGS = -D EFI64
>
> [BuildOptions.IA32]
> -
> -*_*_*_CC_FLAGS = /D EFI32
> + MSFT:*_*_*_CC_FLAGS = /D EFI32
> + GCC:*_*_*_CC_FLAGS = -D EFI32
>
> [sources.common]
> InventoryStrings.uni
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (6 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-07 9:16 ` Philippe Mathieu-Daudé
` (2 more replies)
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
` (12 subsequent siblings)
20 siblings, 3 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Unlike Visual Studio, GCC does not permit implicit conversion between
a pointer-to-void-pointer and pointer to a typed pointer. So add the
explicit casts where necessary.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++----
IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
index 43c184cb03c8..a5d8ae207819 100644
--- a/IntelUndiPkg/GigUndiDxe/Hii.c
+++ b/IntelUndiPkg/GigUndiDxe/Hii.c
@@ -459,7 +459,7 @@ HiiOpenProtocol (
Status = gBS->LocateProtocol (
&gEfiHiiDatabaseProtocolGuid,
NULL,
- &UndiPrivateData->HiiDatabase
+ (VOID **)&UndiPrivateData->HiiDatabase
);
if (EFI_ERROR (Status)) {
DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status));
@@ -472,7 +472,7 @@ HiiOpenProtocol (
Status = gBS->LocateProtocol (
&gEfiHiiStringProtocolGuid,
NULL,
- &UndiPrivateData->HiiString
+ (VOID **)&UndiPrivateData->HiiString
);
if (EFI_ERROR (Status)) {
DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status));
@@ -485,7 +485,7 @@ HiiOpenProtocol (
Status = gBS->LocateProtocol (
&gEfiFormBrowser2ProtocolGuid,
NULL,
- &UndiPrivateData->FormBrowser2
+ (VOID **)&UndiPrivateData->FormBrowser2
);
if (EFI_ERROR (Status)) {
DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status));
@@ -498,7 +498,7 @@ HiiOpenProtocol (
Status = gBS->LocateProtocol (
&gEfiHiiConfigRoutingProtocolGuid,
NULL,
- &UndiPrivateData->HiiConfigRouting
+ (VOID **)&UndiPrivateData->HiiConfigRouting
);
if (EFI_ERROR (Status)) {
DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status));
diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
index f99734d72823..1de424c26fe2 100644
--- a/IntelUndiPkg/GigUndiDxe/Init.c
+++ b/IntelUndiPkg/GigUndiDxe/Init.c
@@ -177,7 +177,7 @@ GigAppendMac2DevPath (
Status = gBS->AllocatePool (
EfiBootServicesData, // EfiRuntimeServicesData,
TotalPathLen,
- &DevicePtr
+ (VOID **)&DevicePtr
);
if (Status != EFI_SUCCESS) {
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
@ 2018-11-07 9:16 ` Philippe Mathieu-Daudé
2018-11-07 14:05 ` Philippe Mathieu-Daudé
2019-01-30 12:05 ` Ryszard Knop
2 siblings, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-07 9:16 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Unlike Visual Studio, GCC does not permit implicit conversion between
> a pointer-to-void-pointer and pointer to a typed pointer. So add the
> explicit casts where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++----
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
> index 43c184cb03c8..a5d8ae207819 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -459,7 +459,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiDatabaseProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiDatabase
> + (VOID **)&UndiPrivateData->HiiDatabase
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status));
> @@ -472,7 +472,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiStringProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiString
> + (VOID **)&UndiPrivateData->HiiString
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status));
> @@ -485,7 +485,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiFormBrowser2ProtocolGuid,
> NULL,
> - &UndiPrivateData->FormBrowser2
> + (VOID **)&UndiPrivateData->FormBrowser2
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status));
> @@ -498,7 +498,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiConfigRoutingProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiConfigRouting
> + (VOID **)&UndiPrivateData->HiiConfigRouting
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status));
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
> index f99734d72823..1de424c26fe2 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -177,7 +177,7 @@ GigAppendMac2DevPath (
> Status = gBS->AllocatePool (
> EfiBootServicesData, // EfiRuntimeServicesData,
> TotalPathLen,
> - &DevicePtr
> + (VOID **)&DevicePtr
> );
>
> if (Status != EFI_SUCCESS) {
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
2018-11-07 9:16 ` Philippe Mathieu-Daudé
@ 2018-11-07 14:05 ` Philippe Mathieu-Daudé
2019-01-30 12:05 ` Ryszard Knop
2 siblings, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-07 14:05 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Unlike Visual Studio, GCC does not permit implicit conversion between
> a pointer-to-void-pointer and pointer to a typed pointer. So add the
> explicit casts where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++----
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
> index 43c184cb03c8..a5d8ae207819 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -459,7 +459,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiDatabaseProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiDatabase
> + (VOID **)&UndiPrivateData->HiiDatabase
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n", Status));
> @@ -472,7 +472,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiStringProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiString
> + (VOID **)&UndiPrivateData->HiiString
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII String protocol: %r\n", Status));
> @@ -485,7 +485,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiFormBrowser2ProtocolGuid,
> NULL,
> - &UndiPrivateData->FormBrowser2
> + (VOID **)&UndiPrivateData->FormBrowser2
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol: %r\n", Status));
> @@ -498,7 +498,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiConfigRoutingProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiConfigRouting
> + (VOID **)&UndiPrivateData->HiiConfigRouting
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting protocol: %r\n", Status));
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c b/IntelUndiPkg/GigUndiDxe/Init.c
> index f99734d72823..1de424c26fe2 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -177,7 +177,7 @@ GigAppendMac2DevPath (
> Status = gBS->AllocatePool (
> EfiBootServicesData, // EfiRuntimeServicesData,
> TotalPathLen,
> - &DevicePtr
> + (VOID **)&DevicePtr
> );
>
> if (Status != EFI_SUCCESS) {
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
2018-11-07 9:16 ` Philippe Mathieu-Daudé
2018-11-07 14:05 ` Philippe Mathieu-Daudé
@ 2019-01-30 12:05 ` Ryszard Knop
2 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 12:05 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Unlike Visual Studio, GCC does not permit implicit conversion between
> a pointer-to-void-pointer and pointer to a typed pointer. So add the
> explicit casts where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/Hii.c | 8 ++++----
> IntelUndiPkg/GigUndiDxe/Init.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c
> b/IntelUndiPkg/GigUndiDxe/Hii.c
> index 43c184cb03c8..a5d8ae207819 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -459,7 +459,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiDatabaseProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiDatabase
> + (VOID **)&UndiPrivateData->HiiDatabase
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII protocol: %r\n",
> Status));
> @@ -472,7 +472,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiStringProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiString
> + (VOID **)&UndiPrivateData->HiiString
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII String protocol:
> %r\n", Status));
> @@ -485,7 +485,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiFormBrowser2ProtocolGuid,
> NULL,
> - &UndiPrivateData->FormBrowser2
> + (VOID **)&UndiPrivateData->FormBrowser2
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII form browser protocol:
> %r\n", Status));
> @@ -498,7 +498,7 @@ HiiOpenProtocol (
> Status = gBS->LocateProtocol (
> &gEfiHiiConfigRoutingProtocolGuid,
> NULL,
> - &UndiPrivateData->HiiConfigRouting
> + (VOID **)&UndiPrivateData->HiiConfigRouting
> );
> if (EFI_ERROR (Status)) {
> DEBUGPRINT (CRITICAL, ("Error finding HII ConfigRouting
> protocol: %r\n", Status));
> diff --git a/IntelUndiPkg/GigUndiDxe/Init.c
> b/IntelUndiPkg/GigUndiDxe/Init.c
> index f99734d72823..1de424c26fe2 100644
> --- a/IntelUndiPkg/GigUndiDxe/Init.c
> +++ b/IntelUndiPkg/GigUndiDxe/Init.c
> @@ -177,7 +177,7 @@ GigAppendMac2DevPath (
> Status = gBS->AllocatePool (
> EfiBootServicesData, // EfiRuntimeServicesData,
> TotalPathLen,
> - &DevicePtr
> + (VOID **)&DevicePtr
> );
>
> if (Status != EFI_SUCCESS) {
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (7 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:31 ` Philippe Mathieu-Daudé
2019-01-30 12:30 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
` (11 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
UINT8 and CHAR8 are not the same underlying type on all architectures,
so add an explicit cast where necessary.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
index a5d8ae207819..737a59fbbbac 100644
--- a/IntelUndiPkg/GigUndiDxe/Hii.c
+++ b/IntelUndiPkg/GigUndiDxe/Hii.c
@@ -817,7 +817,7 @@ HiiSetMenuStrings (
Status = ReadPbaString (
&UndiPrivateData->NicInfo,
- PBAString8,
+ (UINT8 *)PBAString8,
MAX_PBA_STR_LENGTH
);
if (Status == EFI_SUCCESS) {
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
@ 2018-11-06 20:31 ` Philippe Mathieu-Daudé
2018-11-06 20:35 ` Ard Biesheuvel
2019-01-30 12:37 ` Ryszard Knop
2019-01-30 12:30 ` Ryszard Knop
1 sibling, 2 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:31 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
Hi Ard,
On 6/11/18 18:58, Ard Biesheuvel wrote:
> UINT8 and CHAR8 are not the same underlying type on all architectures,
> so add an explicit cast where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
> index a5d8ae207819..737a59fbbbac 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -817,7 +817,7 @@ HiiSetMenuStrings (
>
> Status = ReadPbaString (
> &UndiPrivateData->NicInfo,
> - PBAString8,
> + (UINT8 *)PBAString8,
> MAX_PBA_STR_LENGTH
> );
> if (Status == EFI_SUCCESS) {
>
I'm not sure why ReadPbaString() takes UINT8* instead of CHAR8*.
Having the device part number stored into a CHAR8[] seems correct, what
do you think?
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 20:31 ` Philippe Mathieu-Daudé
@ 2018-11-06 20:35 ` Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 12:37 ` Ryszard Knop
1 sibling, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 20:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: edk2-devel@lists.01.org, Kinney, Michael D, Jin, Eric
On 6 November 2018 at 21:31, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Hi Ard,
>
> On 6/11/18 18:58, Ard Biesheuvel wrote:
>>
>> UINT8 and CHAR8 are not the same underlying type on all architectures,
>> so add an explicit cast where necessary.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
>> index a5d8ae207819..737a59fbbbac 100644
>> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
>> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
>> @@ -817,7 +817,7 @@ HiiSetMenuStrings (
>> Status = ReadPbaString (
>> &UndiPrivateData->NicInfo,
>> - PBAString8,
>> + (UINT8 *)PBAString8,
>> MAX_PBA_STR_LENGTH
>> );
>> if (Status == EFI_SUCCESS) {
>>
>
> I'm not sure why ReadPbaString() takes UINT8* instead of CHAR8*.
> Having the device part number stored into a CHAR8[] seems correct, what do
> you think?
I guess. But that just moves the bubble in the waterbed to elsewhere:
EFI_STATUS
ReadPbaString (
IN GIG_DRIVER_DATA *GigAdapter,
IN OUT UINT8 * PbaNumber,
IN UINT32 PbaNumberSize
)
{
if (e1000_read_pba_string (&GigAdapter->Hw, PbaNumber,
PbaNumberSize) == E1000_SUCCESS) {
return EFI_SUCCESS;
} else {
return EFI_DEVICE_ERROR;
}
}
and
$ git grep e1000_read_pba_string
IntelUndiPkg/GigUndiDxe/e1000.c: if (e1000_read_pba_string
(&GigAdapter->Hw, PbaNumber, PbaNumberSize) == E1000_SUCCESS) {
IntelUndiPkg/GigUndiDxe/e1000_api.c: * e1000_read_pba_string - Read
device part number string
IntelUndiPkg/GigUndiDxe/e1000_api.c:s32 e1000_read_pba_string(struct
e1000_hw *hw, u8 *pba_num, u32 pba_num_size)
IntelUndiPkg/GigUndiDxe/e1000_api.c: return
e1000_read_pba_string_generic(hw, pba_num, pba_num_size);
IntelUndiPkg/GigUndiDxe/e1000_api.h:s32 e1000_read_pba_string(struct
e1000_hw *hw, u8 *pba_num, u32 pba_num_size);
IntelUndiPkg/GigUndiDxe/e1000_nvm.c: * e1000_read_pba_string_generic
- Read device part number
IntelUndiPkg/GigUndiDxe/e1000_nvm.c:s32
e1000_read_pba_string_generic(struct e1000_hw *hw, u8 *pba_num,
IntelUndiPkg/GigUndiDxe/e1000_nvm.c:
DEBUGFUNC("e1000_read_pba_string_generic");
IntelUndiPkg/GigUndiDxe/e1000_nvm.h:s32
e1000_read_pba_string_generic(struct e1000_hw *hw, u8 *pba_num,
(unless you want to add a cast in ReadPbaString() instead)
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 20:35 ` Ard Biesheuvel
@ 2018-11-07 9:08 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-07 9:08 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org, Kinney, Michael D, Jin, Eric
On 6/11/18 21:35, Ard Biesheuvel wrote:
> On 6 November 2018 at 21:31, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> Hi Ard,
>>
>> On 6/11/18 18:58, Ard Biesheuvel wrote:
>>>
>>> UINT8 and CHAR8 are not the same underlying type on all architectures,
>>> so add an explicit cast where necessary.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> ---
>>> IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c
>>> index a5d8ae207819..737a59fbbbac 100644
>>> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
>>> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
>>> @@ -817,7 +817,7 @@ HiiSetMenuStrings (
>>> Status = ReadPbaString (
>>> &UndiPrivateData->NicInfo,
>>> - PBAString8,
>>> + (UINT8 *)PBAString8,
>>> MAX_PBA_STR_LENGTH
>>> );
>>> if (Status == EFI_SUCCESS) {
>>>
>>
>> I'm not sure why ReadPbaString() takes UINT8* instead of CHAR8*.
>> Having the device part number stored into a CHAR8[] seems correct, what do
>> you think?
>
> I guess. But that just moves the bubble in the waterbed to elsewhere:
>
> EFI_STATUS
> ReadPbaString (
> IN GIG_DRIVER_DATA *GigAdapter,
> IN OUT UINT8 * PbaNumber,
> IN UINT32 PbaNumberSize
> )
> {
> if (e1000_read_pba_string (&GigAdapter->Hw, PbaNumber,
> PbaNumberSize) == E1000_SUCCESS) {
> return EFI_SUCCESS;
> } else {
> return EFI_DEVICE_ERROR;
> }
> }
>
> and
>
> $ git grep e1000_read_pba_string
> IntelUndiPkg/GigUndiDxe/e1000.c: if (e1000_read_pba_string
> (&GigAdapter->Hw, PbaNumber, PbaNumberSize) == E1000_SUCCESS) {
> IntelUndiPkg/GigUndiDxe/e1000_api.c: * e1000_read_pba_string - Read
> device part number string
> IntelUndiPkg/GigUndiDxe/e1000_api.c:s32 e1000_read_pba_string(struct
> e1000_hw *hw, u8 *pba_num, u32 pba_num_size)
> IntelUndiPkg/GigUndiDxe/e1000_api.c: return
> e1000_read_pba_string_generic(hw, pba_num, pba_num_size);
> IntelUndiPkg/GigUndiDxe/e1000_api.h:s32 e1000_read_pba_string(struct
> e1000_hw *hw, u8 *pba_num, u32 pba_num_size);
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c: * e1000_read_pba_string_generic
> - Read device part number
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c:s32
> e1000_read_pba_string_generic(struct e1000_hw *hw, u8 *pba_num,
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c:
> DEBUGFUNC("e1000_read_pba_string_generic");
> IntelUndiPkg/GigUndiDxe/e1000_nvm.h:s32
> e1000_read_pba_string_generic(struct e1000_hw *hw, u8 *pba_num,
>
> (unless you want to add a cast in ReadPbaString() instead)
Hmm I now see the inconsistency.
Since the goal of this series is not to sort it out, then I'm OK with
your patch.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 20:31 ` Philippe Mathieu-Daudé
2018-11-06 20:35 ` Ard Biesheuvel
@ 2019-01-30 12:37 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 12:37 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel, Philippe Mathieu-Daud?
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
On Tue, 2018-11-06 at 21:31 +0100, philmd at redhat.com wrote:
> Hi Ard,
>
> On 6/11/18 18:58, Ard Biesheuvel wrote:
> > UINT8 and CHAR8 are not the same underlying type on all
> > architectures,
> > so add an explicit cast where necessary.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > ---
> > IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c
> > b/IntelUndiPkg/GigUndiDxe/Hii.c
> > index a5d8ae207819..737a59fbbbac 100644
> > --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> > +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> > @@ -817,7 +817,7 @@ HiiSetMenuStrings (
> >
> > Status = ReadPbaString (
> > &UndiPrivateData->NicInfo,
> > - PBAString8,
> > + (UINT8 *)PBAString8,
> > MAX_PBA_STR_LENGTH
> > );
> > if (Status == EFI_SUCCESS) {
> >
>
> I'm not sure why ReadPbaString() takes UINT8* instead of CHAR8*.
> Having the device part number stored into a CHAR8[] seems correct,
> what
> do you think?
I agree that it should use CHAR8, but the underlying code in
e1000_nvm.c is shared between multiple drivers expecting uint8_t or
equivalent, so as Ard said it'd just move the problem elsewhere. It'd
be nice to keep this conversion in ReadPbaString, but as this is the
only place where this function is used, it's fine for now. Hii.c and
friends overall need some solid refactoring if time allows.
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
2018-11-06 20:31 ` Philippe Mathieu-Daudé
@ 2019-01-30 12:30 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 12:30 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> UINT8 and CHAR8 are not the same underlying type on all
> architectures,
> so add an explicit cast where necessary.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/Hii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c
> b/IntelUndiPkg/GigUndiDxe/Hii.c
> index a5d8ae207819..737a59fbbbac 100644
> --- a/IntelUndiPkg/GigUndiDxe/Hii.c
> +++ b/IntelUndiPkg/GigUndiDxe/Hii.c
> @@ -817,7 +817,7 @@ HiiSetMenuStrings (
>
> Status = ReadPbaString (
> &UndiPrivateData->NicInfo,
> - PBAString8,
> + (UINT8 *)PBAString8,
> MAX_PBA_STR_LENGTH
> );
> if (Status == EFI_SUCCESS) {
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (8 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:34 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
` (10 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
The Data4 member of the GUID/EFI_GUID struct type is an array of
UINT8, so literals require two sets of { } braces. Add them where
missing.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++--
IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
index bd7d4defc9a3..72f6a95ccb6d 100644
--- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
+++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
@@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define E1000_HII_FORM_GUID \
{ \
- 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 \
+ 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 } \
}
#define E1000_HII_DATA_GUID \
{ \
- 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 \
+ 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 } \
}
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
index 255f17aabaa4..b29a5002bb8e 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.h
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
@@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include "e1000.h"
#define EFI_DRIVER_STOP_PROTOCOL_GUID \
-{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
-0xb5, 0xfd, 0x7d, 0xc1 }
+{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \
+0xb5, 0xfd, 0x7d, 0xc1 } }
typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL;
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
@ 2018-11-06 20:34 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:34 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> The Data4 member of the GUID/EFI_GUID struct type is an array of
> UINT8, so literals require two sets of { } braces. Add them where
> missing.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++--
> IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> index bd7d4defc9a3..72f6a95ccb6d 100644
> --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> #define E1000_HII_FORM_GUID \
> { \
> - 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 \
> + 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d, 0xb7, 0xe2 } \
> }
>
> #define E1000_HII_DATA_GUID \
> { \
> - 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 \
> + 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67, 0x40, 0xf3 } \
> }
>
>
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index 255f17aabaa4..b29a5002bb8e 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> #include "e1000.h"
>
> #define EFI_DRIVER_STOP_PROTOCOL_GUID \
> -{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
> -0xb5, 0xfd, 0x7d, 0xc1 }
> +{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \
> +0xb5, 0xfd, 0x7d, 0xc1 } }
>
> typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL;
>
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
2018-11-06 20:34 ` Philippe Mathieu-Daudé
@ 2019-01-30 12:59 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 12:59 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> The Data4 member of the GUID/EFI_GUID struct type is an array of
> UINT8, so literals require two sets of { } braces. Add them where
> missing.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 4 ++--
> IntelUndiPkg/GigUndiDxe/StartStop.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> index bd7d4defc9a3..72f6a95ccb6d 100644
> --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> @@ -34,12 +34,12 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
>
> #define E1000_HII_FORM_GUID \
> { \
> - 0x77f2ea2f, 0x4312, 0x4569, 0x85, 0xc4, 0x58, 0x3a, 0xcd, 0x8d,
> 0xb7, 0xe2 \
> + 0x77f2ea2f, 0x4312, 0x4569, { 0x85, 0xc4, 0x58, 0x3a, 0xcd,
> 0x8d, 0xb7, 0xe2 } \
> }
>
> #define E1000_HII_DATA_GUID \
> { \
> - 0xa31abb16, 0xc627, 0x475b, 0x98, 0x8e, 0x7e, 0xe0, 0x77, 0x67,
> 0x40, 0xf3 \
> + 0xa31abb16, 0xc627, 0x475b, { 0x98, 0x8e, 0x7e, 0xe0, 0x77,
> 0x67, 0x40, 0xf3 } \
> }
>
>
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.h
> b/IntelUndiPkg/GigUndiDxe/StartStop.h
> index 255f17aabaa4..b29a5002bb8e 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.h
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.h
> @@ -32,8 +32,8 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #include "e1000.h"
>
> #define EFI_DRIVER_STOP_PROTOCOL_GUID \
> -{ 0x34d59603, 0x1428, 0x4429, 0xa4, 0x14, 0xe6, 0xb3, \
> -0xb5, 0xfd, 0x7d, 0xc1 }
> +{ 0x34d59603, 0x1428, 0x4429, { 0xa4, 0x14, 0xe6, 0xb3, \
> +0xb5, 0xfd, 0x7d, 0xc1 } }
>
> typedef struct EFI_DRIVER_STOP_PROTOCOL_S EFI_DRIVER_STOP_PROTOCOL;
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (9 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-30 13:35 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
` (9 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
The ## CPP token pasting operator is used to paste *tokens*, which
is not the same thing as pasting arbitrary macro arguments. Since a
token cannot contain . or ) characters in the first place, using
the ## operator here is wrong and unnecessary, so just remove it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
index 72f6a95ccb6d..04f08b41c842 100644
--- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
+++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
@@ -112,7 +112,7 @@ typedef struct {
@return Width of given field is returned
**/
-#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData->Configuration. ## Field ## )
+#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData->Configuration.Field)
// General parameters
#define QUESTION_ID_EFI_DRIVER_VER 0x1100
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting
2018-11-06 17:58 ` [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
@ 2019-01-30 13:35 ` Ryszard Knop
0 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 13:35 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> The ## CPP token pasting operator is used to paste *tokens*, which
> is not the same thing as pasting arbitrary macro arguments. Since a
> token cannot contain . or ) characters in the first place, using
> the ## operator here is wrong and unnecessary, so just remove it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> index 72f6a95ccb6d..04f08b41c842 100644
> --- a/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> +++ b/IntelUndiPkg/GigUndiDxe/NVDataStruc.h
> @@ -112,7 +112,7 @@ typedef struct {
>
> @return Width of given field is returned
> **/
> -#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData-
> >Configuration. ## Field ## )
> +#define UNDI_CONFIG_WIDTH(Field) sizeof (UndiPrivateData-
> >Configuration.Field)
>
> // General parameters
> #define QUESTION_ID_EFI_DRIVER_VER 0x11
> 00
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (10 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:35 ` Philippe Mathieu-Daudé
2019-01-30 13:37 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
` (8 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the
arguments to the correct type.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
index 1f08a5d67b2d..4c9a06b8cf73 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000.c
@@ -674,8 +674,8 @@ E1000Receive (
// Copy the packet from our list to the EFI buffer.
E1000MemCopy (
- (INT8 *) (UINTN) CpbReceive->BufferAddr,
- (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
+ (UINT8 *) (UINTN) CpbReceive->BufferAddr,
+ (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
TempLen
);
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
@ 2018-11-06 20:35 ` Philippe Mathieu-Daudé
2019-01-30 13:37 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:35 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the
> arguments to the correct type.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 1f08a5d67b2d..4c9a06b8cf73 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -674,8 +674,8 @@ E1000Receive (
>
> // Copy the packet from our list to the EFI buffer.
> E1000MemCopy (
> - (INT8 *) (UINTN) CpbReceive->BufferAddr,
> - (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> + (UINT8 *) (UINTN) CpbReceive->BufferAddr,
> + (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> TempLen
> );
>
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
2018-11-06 20:35 ` Philippe Mathieu-Daudé
@ 2019-01-30 13:37 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 13:37 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> E1000MemCopy () takes UINT8 pointers not INT8 pointers, so cast the
> arguments to the correct type.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c
> b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 1f08a5d67b2d..4c9a06b8cf73 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -674,8 +674,8 @@ E1000Receive (
>
> // Copy the packet from our list to the EFI buffer.
> E1000MemCopy (
> - (INT8 *) (UINTN) CpbReceive->BufferAddr,
> - (INT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> + (UINT8 *) (UINTN) CpbReceive->BufferAddr,
> + (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> TempLen
> );
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (11 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:36 ` Philippe Mathieu-Daudé
2019-01-30 13:41 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
` (7 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Taking the address of a cast expression is not permitted in C. Instead,
take the address of the variable, and cast the pointer to the desired
pointer type.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
index 4c9a06b8cf73..28c900e3ad63 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000.c
@@ -1107,7 +1107,7 @@ E1000TxRxConfigure (
// Set the MemPtr to the high dword of the rx_ring so we can store it in RDBAH0.
// Right shifts do not seem to work with the EFI compiler so we do it like this for now.
MemAddr = (UINT64) (UINTN) GigAdapter->RxRing.PhysicalAddress;
- MemPtr = &((UINT32) MemAddr);
+ MemPtr = (UINT32 *)&MemAddr;
MemPtr++;
E1000_WRITE_REG (&GigAdapter->Hw, E1000_RDBAH (0), *MemPtr);
@@ -1185,7 +1185,7 @@ E1000TxRxConfigure (
E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAL (0), (UINT32) (UINTN) (GigAdapter->TxRing.PhysicalAddress));
MemAddr = (UINT64) (UINTN) GigAdapter->TxRing.PhysicalAddress;
- MemPtr = &((UINT32) MemAddr);
+ MemPtr = (UINT32 *)&MemAddr;
MemPtr++;
E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAH (0), *MemPtr);
DEBUGPRINT (E1000, ("TdBah0 %X\n", *MemPtr));
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
@ 2018-11-06 20:36 ` Philippe Mathieu-Daudé
2019-01-30 13:41 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:36 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Taking the address of a cast expression is not permitted in C. Instead,
> take the address of the variable, and cast the pointer to the desired
> pointer type.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 4c9a06b8cf73..28c900e3ad63 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -1107,7 +1107,7 @@ E1000TxRxConfigure (
> // Set the MemPtr to the high dword of the rx_ring so we can store it in RDBAH0.
> // Right shifts do not seem to work with the EFI compiler so we do it like this for now.
> MemAddr = (UINT64) (UINTN) GigAdapter->RxRing.PhysicalAddress;
> - MemPtr = &((UINT32) MemAddr);
> + MemPtr = (UINT32 *)&MemAddr;
> MemPtr++;
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_RDBAH (0), *MemPtr);
>
> @@ -1185,7 +1185,7 @@ E1000TxRxConfigure (
>
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAL (0), (UINT32) (UINTN) (GigAdapter->TxRing.PhysicalAddress));
> MemAddr = (UINT64) (UINTN) GigAdapter->TxRing.PhysicalAddress;
> - MemPtr = &((UINT32) MemAddr);
> + MemPtr = (UINT32 *)&MemAddr;
> MemPtr++;
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAH (0), *MemPtr);
> DEBUGPRINT (E1000, ("TdBah0 %X\n", *MemPtr));
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
2018-11-06 20:36 ` Philippe Mathieu-Daudé
@ 2019-01-30 13:41 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 13:41 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Taking the address of a cast expression is not permitted in C.
> Instead,
> take the address of the variable, and cast the pointer to the desired
> pointer type.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/e1000.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c
> b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 4c9a06b8cf73..28c900e3ad63 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -1107,7 +1107,7 @@ E1000TxRxConfigure (
> // Set the MemPtr to the high dword of the rx_ring so we can store
> it in RDBAH0.
> // Right shifts do not seem to work with the EFI compiler so we do
> it like this for now.
> MemAddr = (UINT64) (UINTN) GigAdapter->RxRing.PhysicalAddress;
> - MemPtr = &((UINT32) MemAddr);
> + MemPtr = (UINT32 *)&MemAddr;
> MemPtr++;
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_RDBAH (0), *MemPtr);
>
> @@ -1185,7 +1185,7 @@ E1000TxRxConfigure (
>
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAL (0), (UINT32)
> (UINTN) (GigAdapter->TxRing.PhysicalAddress));
> MemAddr = (UINT64) (UINTN) GigAdapter->TxRing.PhysicalAddress;
> - MemPtr = &((UINT32) MemAddr);
> + MemPtr = (UINT32 *)&MemAddr;
> MemPtr++;
> E1000_WRITE_REG (&GigAdapter->Hw, E1000_TDBAH (0), *MemPtr);
> DEBUGPRINT (E1000, ("TdBah0 %X\n", *MemPtr));
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (12 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
` (6 subsequent siblings)
20 siblings, 0 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Use (VOID) casts to silence unreferenced parameter warnings on GCC. The
existing macros generate 'statement with no effect' warnings instead,
which does not really help.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/e1000_defines.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_defines.h b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
index 1d07d30aa18e..b9ce1e5e6339 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_defines.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_defines.h
@@ -1622,12 +1622,19 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endif /* NO_82575_SUPPORT */
#ifndef UNREFERENCED_XPARAMETER
-#define UNREFERENCED_XPARAMETER
+#ifdef _MSC_VER
#define UNREFERENCED_1PARAMETER(_p) (_p)
#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q);
#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r);
#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s);
#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t);
+#else
+#define UNREFERENCED_1PARAMETER(_p) (VOID)(_p)
+#define UNREFERENCED_2PARAMETER(_p, _q) (VOID)(_p); (VOID)(_q);
+#define UNREFERENCED_3PARAMETER(_p, _q, _r) (VOID)(_p); (VOID)(_q); (VOID)(_r);
+#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (VOID)(_p); (VOID)(_q); (VOID)(_r); (VOID)(_s);
+#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (VOID)(_p); (VOID)(_q); (VOID)(_r); (VOID)(_s); (VOID)(_t);
+#endif
#endif /* UNREFERENCED_XPARAMETER */
#ifndef E1000_UNUSEDARG
#define E1000_UNUSEDARG
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (13 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:40 ` Philippe Mathieu-Daudé
2019-01-30 15:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation Ard Biesheuvel
` (5 subsequent siblings)
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which
is never defined anywhere in the code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
index 7669630a5c03..e9fc5394ab28 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
@@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw);
STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw);
STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw);
STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw);
-#if !defined(NO_ULP_IN_S5_SUPPORT)
-STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force);
-#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */
STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw);
STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw,
u16 *speed, u16 *duplex);
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
@ 2018-11-06 20:40 ` Philippe Mathieu-Daudé
2019-01-30 15:26 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:40 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which
> is never defined anywhere in the code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
(Not tested with Visual Studio)
> ---
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> index 7669630a5c03..e9fc5394ab28 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw);
> STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw);
> STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw);
> STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw);
> -#if !defined(NO_ULP_IN_S5_SUPPORT)
> -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force);
> -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */
> STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw);
> STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw,
> u16 *speed, u16 *duplex);
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
2018-11-06 20:40 ` Philippe Mathieu-Daudé
@ 2019-01-30 15:26 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 15:26 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Remove the forward declaration of e1000_disable_ulp_lpt_lp (), which
> is never defined anywhere in the code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> index 7669630a5c03..e9fc5394ab28 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> @@ -103,9 +103,6 @@ STATIC s32 e1000_reset_hw_ich8lan(struct
> e1000_hw *hw);
> STATIC s32 e1000_init_hw_ich8lan(struct e1000_hw *hw);
> STATIC s32 e1000_setup_link_ich8lan(struct e1000_hw *hw);
> STATIC s32 e1000_setup_copper_link_ich8lan(struct e1000_hw *hw);
> -#if !defined(NO_ULP_IN_S5_SUPPORT)
> -STATIC s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool
> force);
> -#endif /* !NO_ULP_IN_S5_SUPPORT && !ULP_IN_D0_SUPPORT */
> STATIC s32 e1000_setup_copper_link_pch_lpt(struct e1000_hw *hw);
> STATIC s32 e1000_get_link_up_info_ich8lan(struct e1000_hw *hw,
> u16 *speed, u16 *duplex);
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (14 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-06 20:41 ` Philippe Mathieu-Daudé
2018-11-06 17:58 ` [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
` (4 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Silence a 'misleading indentation' GCC warning by fixing the
incorrect indentation.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
index e9fc5394ab28..6ce9ac3c5195 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
@@ -1102,13 +1102,13 @@ STATIC s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)
if (!mac->get_link_status)
return E1000_SUCCESS;
- /* First we want to see if the MII Status Register reports
- * link. If so, then we want to get the current speed/duplex
- * of the PHY.
- */
- ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
- if (ret_val)
- return ret_val;
+ /* First we want to see if the MII Status Register reports
+ * link. If so, then we want to get the current speed/duplex
+ * of the PHY.
+ */
+ ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
+ if (ret_val)
+ return ret_val;
if (hw->mac.type == e1000_pchlan) {
ret_val = e1000_k1_gig_workaround_hv(hw, link);
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation
2018-11-06 17:58 ` [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation Ard Biesheuvel
@ 2018-11-06 20:41 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-06 20:41 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Silence a 'misleading indentation' GCC warning by fixing the
> incorrect indentation.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> index e9fc5394ab28..6ce9ac3c5195 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c
> @@ -1102,13 +1102,13 @@ STATIC s32 e1000_check_for_copper_link_ich8lan(struct e1000_hw *hw)
> if (!mac->get_link_status)
> return E1000_SUCCESS;
>
> - /* First we want to see if the MII Status Register reports
> - * link. If so, then we want to get the current speed/duplex
> - * of the PHY.
> - */
> - ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
> - if (ret_val)
> - return ret_val;
> + /* First we want to see if the MII Status Register reports
> + * link. If so, then we want to get the current speed/duplex
> + * of the PHY.
> + */
> + ret_val = e1000_phy_has_link_generic(hw, 1, 0, &link);
> + if (ret_val)
> + return ret_val;
>
> if (hw->mac.type == e1000_pchlan) {
> ret_val = e1000_k1_gig_workaround_hv(hw, link);
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (15 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-30 14:09 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
` (3 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
GCC chokes on the unknown MSVC specific #pragmas used for suppressing
warnings, so remove them and use the INF BuildOptions section instead.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 2 +-
IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
index 19dae9a0987a..9159e826ec45 100644
--- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
+++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
@@ -41,7 +41,7 @@ ENTRY_POINT = InitializeGigUNDIDriver
UNLOAD_IMAGE = GigUndiUnload
[BuildOptions.common]
- MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
+ MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /wd4244 /wd4206
GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
[BuildOptions.X64]
diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
index 4408b409a445..70f33811dd04 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
+++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
@@ -34,9 +34,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
-#pragma warning(disable : 4244)
-#pragma warning(disable : 4206)
-
#ifndef EFI_SPECIFICATION_VERSION
#define EFI_SPECIFICATION_VERSION 0x00020000
#endif /* EFI_SPECIFICATION_VERSION */
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file
2018-11-06 17:58 ` [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
@ 2019-01-30 14:09 ` Ryszard Knop
0 siblings, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 14:09 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> GCC chokes on the unknown MSVC specific #pragmas used for suppressing
> warnings, so remove them and use the INF BuildOptions section
> instead.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 2 +-
> IntelUndiPkg/GigUndiDxe/e1000_osdep.h | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> index 19dae9a0987a..9159e826ec45 100644
> --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf
> @@ -41,7 +41,7 @@ ENTRY_POINT = InitializeGigUNDIDriver
> UNLOAD_IMAGE = GigUndiUnload
>
> [BuildOptions.common]
> - MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG
> + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG /wd4244 /wd4206
> GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG
>
> [BuildOptions.X64]
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> index 4408b409a445..70f33811dd04 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> +++ b/IntelUndiPkg/GigUndiDxe/e1000_osdep.h
> @@ -34,9 +34,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
>
> -#pragma warning(disable : 4244)
> -#pragma warning(disable : 4206)
> -
> #ifndef EFI_SPECIFICATION_VERSION
> #define EFI_SPECIFICATION_VERSION 0x00020000
> #endif /* EFI_SPECIFICATION_VERSION */
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (16 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2019-01-30 15:15 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
` (2 subsequent siblings)
20 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++
IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++
IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +
IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 +
IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++
IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++
7 files changed, 14 insertions(+)
diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
index 8918c538e447..1cece79911b1 100644
--- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
+++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
@@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
**/
STATIC
EFI_STATUS
+EFIAPI
GetInformation (
IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
IN EFI_GUID * InformationType,
@@ -188,6 +189,7 @@ GetInformation (
**/
STATIC
EFI_STATUS
+EFIAPI
SetInformation (
IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
IN EFI_GUID * InformationType,
@@ -234,6 +236,7 @@ SetInformation (
**/
STATIC
EFI_STATUS
+EFIAPI
GetSupportedTypes (
IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
OUT EFI_GUID ** InfoTypesBuffer,
diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c b/IntelUndiPkg/GigUndiDxe/ComponentName.c
index 70baf00f4a5d..2bf9bbfbe0e4 100644
--- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
+++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
@@ -112,6 +112,7 @@ ComponentNameInitializeControllerName (
language specified by Language.
**/
EFI_STATUS
+EFIAPI
ComponentNameGetDriverName (
IN EFI_COMPONENT_NAME_PROTOCOL *This,
IN CHAR8 * Language,
@@ -182,6 +183,7 @@ ComponentNameGetDriverName (
language specified by Language.
**/
EFI_STATUS
+EFIAPI
ComponentNameGetControllerName (
IN EFI_COMPONENT_NAME_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle,
diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h b/IntelUndiPkg/GigUndiDxe/ComponentName.h
index 5a3d414c6970..0b93a5410fc0 100644
--- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
+++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
@@ -65,6 +65,7 @@ ComponentNameInitializeControllerName (
language specified by Language.
**/
EFI_STATUS
+EFIAPI
ComponentNameGetDriverName (
IN EFI_COMPONENT_NAME_PROTOCOL *This,
IN CHAR8 * Language,
diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
index 20d40ab672ef..99e086d81044 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
@@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu (
@retval EFI_SUCCESS Configuration was successful
**/
EFI_STATUS
+EFIAPI
GigUndiDriverConfigurationSetOptions (
IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle,
@@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions (
@retval EFI_SUCCESS Always returned
**/
EFI_STATUS
+EFIAPI
GigUndiDriverConfigurationOptionsValid (
IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle,
@@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid (
@retval EFI_SUCCESS Configuration was successful
**/
EFI_STATUS
+EFIAPI
GigUndiDriverConfigurationForceDefaults (
IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle,
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
index aceb015e480f..f6152cd24c59 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
@@ -1394,6 +1394,7 @@ Error:
ChildHandle did not pass the diagnostic.
**/
EFI_STATUS
+EFIAPI
GigUndiDriverDiagnosticsRunDiagnostics (
IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle,
diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
index b5b7db5fd814..ea306843679a 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
@@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
@retval !EFI_SUCCESS Failure to retrieve health status
**/
EFI_STATUS
+EFIAPI
GetHealthStatus (
IN EFI_DRIVER_HEALTH_PROTOCOL * This,
IN EFI_HANDLE ControllerHandle, OPTIONAL
@@ -119,6 +120,7 @@ GetHealthStatus (
@retval EFI_UNSUPPORTED This function is unsupported
**/
EFI_STATUS
+EFIAPI
Repair (
IN EFI_DRIVER_HEALTH_PROTOCOL *This,
IN EFI_HANDLE ControllerHandle,
diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c b/IntelUndiPkg/GigUndiDxe/StartStop.c
index 32bed7ce288d..a788da247e6d 100644
--- a/IntelUndiPkg/GigUndiDxe/StartStop.c
+++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
@@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID;
@retval EFI_SUCCESS Driver is stopped successfully
**/
EFI_STATUS
+EFIAPI
StopDriver (
IN EFI_DRIVER_STOP_PROTOCOL *This
)
@@ -62,6 +63,7 @@ StopDriver (
@retval EFI_SUCCESS If driver has restarted successfully
**/
EFI_STATUS
+EFIAPI
StartDriver (
IN EFI_DRIVER_STOP_PROTOCOL *This
)
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
2018-11-06 17:58 ` [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
@ 2019-01-30 15:15 ` Ryszard Knop
2019-01-30 15:20 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 15:15 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
I'm going through all the protocols we have defined/used and in
Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
tested an X64 GCC build under OVMF and these calls were broken due to
mismatched calling conventions. Did this work correctly for your builds
on your platforms?
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++
> IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 +
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++
> IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++
> 7 files changed, 14 insertions(+)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> index 8918c538e447..1cece79911b1 100644
> --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> GetInformation (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> IN EFI_GUID * InformationType,
> @@ -188,6 +189,7 @@ GetInformation (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> SetInformation (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> IN EFI_GUID * InformationType,
> @@ -234,6 +236,7 @@ SetInformation (
> **/
> STATIC
> EFI_STATUS
> +EFIAPI
> GetSupportedTypes (
> IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> OUT EFI_GUID ** InfoTypesBuffer,
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> index 70baf00f4a5d..2bf9bbfbe0e4 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetDriverName (
> IN EFI_COMPONENT_NAME_PROTOCOL *This,
> IN CHAR8 * Language,
> @@ -182,6 +183,7 @@ ComponentNameGetDriverName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetControllerName (
> IN EFI_COMPONENT_NAME_PROTOCOL
> * This,
> IN EFI_HANDLE Co
> ntrollerHandle,
> diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> index 5a3d414c6970..0b93a5410fc0 100644
> --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName (
> language specified by Language.
> **/
> EFI_STATUS
> +EFIAPI
> ComponentNameGetDriverName (
> IN EFI_COMPONENT_NAME_PROTOCOL *This,
> IN CHAR8 * Language,
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> index 20d40ab672ef..99e086d81044 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu (
> @retval EFI_SUCCESS Configuration was successful
> **/
> EFI_STATUS
> +EFIAPI
> GigUndiDriverConfigurationSetOptions (
> IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> IN EFI_HANDLE ControllerHandle,
> @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions (
> @retval EFI_SUCCESS Always returned
> **/
> EFI_STATUS
> +EFIAPI
> GigUndiDriverConfigurationOptionsValid (
> IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> IN EFI_HANDLE ControllerHandle,
> @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid (
> @retval EFI_SUCCESS Configuration was successful
> **/
> EFI_STATUS
> +EFIAPI
> GigUndiDriverConfigurationForceDefaults (
> IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> IN
> EFI_HANDLE ControllerHandl
> e,
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index aceb015e480f..f6152cd24c59 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1394,6 +1394,7 @@ Error:
> ChildHandle did not pass the
> diagnostic.
> **/
> EFI_STATUS
> +EFIAPI
> GigUndiDriverDiagnosticsRunDiagnostics (
> IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This,
> IN EFI_HANDLE ControllerHandle,
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> index b5b7db5fd814..ea306843679a 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> POSSIBILITY OF SUCH DAMAGE.
> @retval !EFI_SUCCESS Failure to retrieve health status
> **/
> EFI_STATUS
> +EFIAPI
> GetHealthStatus (
> IN EFI_DRIVER_HEALTH_PROTOCOL * This,
> IN EFI_HANDLE ControllerHandle, OPTIONAL
> @@ -119,6 +120,7 @@ GetHealthStatus (
> @retval EFI_UNSUPPORTED This function is unsupported
> **/
> EFI_STATUS
> +EFIAPI
> Repair (
> IN EFI_DRIVER_HEALTH_PROTOCOL *This,
> IN EFI_HANDLE ControllerHandle,
> diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> b/IntelUndiPkg/GigUndiDxe/StartStop.c
> index 32bed7ce288d..a788da247e6d 100644
> --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid =
> EFI_DRIVER_STOP_PROTOCOL_GUID;
> @retval EFI_SUCCESS Driver is stopped successfully
> **/
> EFI_STATUS
> +EFIAPI
> StopDriver (
> IN EFI_DRIVER_STOP_PROTOCOL *This
> )
> @@ -62,6 +63,7 @@ StopDriver (
> @retval EFI_SUCCESS If driver has restarted successfully
> **/
> EFI_STATUS
> +EFIAPI
> StartDriver (
> IN EFI_DRIVER_STOP_PROTOCOL *This
> )
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
2019-01-30 15:15 ` Ryszard Knop
@ 2019-01-30 15:20 ` Ard Biesheuvel
2019-01-30 15:31 ` Ryszard Knop
0 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2019-01-30 15:20 UTC (permalink / raw)
To: Ryszard Knop
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Wed, 30 Jan 2019 at 16:15, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> I'm going through all the protocols we have defined/used and in
> Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
> tested an X64 GCC build under OVMF and these calls were broken due to
> mismatched calling conventions. Did this work correctly for your builds
> on your platforms?
>
Do you mean the builds were broken? Or the resulting builds didn't work?
In any case, that issue only exists on X64, since there are different
SysV and MS calling conventions. and GCC uses the former by default.
On ARM, there is no such difference.
> Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
>
> On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > ---
> > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++
> > IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++
> > IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +
> > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++
> > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 +
> > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++
> > IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++
> > 7 files changed, 14 insertions(+)
> >
> > diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > index 8918c538e447..1cece79911b1 100644
> > --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
> > **/
> > STATIC
> > EFI_STATUS
> > +EFIAPI
> > GetInformation (
> > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > IN EFI_GUID * InformationType,
> > @@ -188,6 +189,7 @@ GetInformation (
> > **/
> > STATIC
> > EFI_STATUS
> > +EFIAPI
> > SetInformation (
> > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > IN EFI_GUID * InformationType,
> > @@ -234,6 +236,7 @@ SetInformation (
> > **/
> > STATIC
> > EFI_STATUS
> > +EFIAPI
> > GetSupportedTypes (
> > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > OUT EFI_GUID ** InfoTypesBuffer,
> > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > index 70baf00f4a5d..2bf9bbfbe0e4 100644
> > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName (
> > language specified by Language.
> > **/
> > EFI_STATUS
> > +EFIAPI
> > ComponentNameGetDriverName (
> > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > IN CHAR8 * Language,
> > @@ -182,6 +183,7 @@ ComponentNameGetDriverName (
> > language specified by Language.
> > **/
> > EFI_STATUS
> > +EFIAPI
> > ComponentNameGetControllerName (
> > IN EFI_COMPONENT_NAME_PROTOCOL
> > * This,
> > IN EFI_HANDLE Co
> > ntrollerHandle,
> > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > index 5a3d414c6970..0b93a5410fc0 100644
> > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName (
> > language specified by Language.
> > **/
> > EFI_STATUS
> > +EFIAPI
> > ComponentNameGetDriverName (
> > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > IN CHAR8 * Language,
> > diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > index 20d40ab672ef..99e086d81044 100644
> > --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu (
> > @retval EFI_SUCCESS Configuration was successful
> > **/
> > EFI_STATUS
> > +EFIAPI
> > GigUndiDriverConfigurationSetOptions (
> > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > IN EFI_HANDLE ControllerHandle,
> > @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions (
> > @retval EFI_SUCCESS Always returned
> > **/
> > EFI_STATUS
> > +EFIAPI
> > GigUndiDriverConfigurationOptionsValid (
> > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > IN EFI_HANDLE ControllerHandle,
> > @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid (
> > @retval EFI_SUCCESS Configuration was successful
> > **/
> > EFI_STATUS
> > +EFIAPI
> > GigUndiDriverConfigurationForceDefaults (
> > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > IN
> > EFI_HANDLE ControllerHandl
> > e,
> > diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > index aceb015e480f..f6152cd24c59 100644
> > --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > @@ -1394,6 +1394,7 @@ Error:
> > ChildHandle did not pass the
> > diagnostic.
> > **/
> > EFI_STATUS
> > +EFIAPI
> > GigUndiDriverDiagnosticsRunDiagnostics (
> > IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This,
> > IN EFI_HANDLE ControllerHandle,
> > diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > index b5b7db5fd814..ea306843679a 100644
> > --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> > POSSIBILITY OF SUCH DAMAGE.
> > @retval !EFI_SUCCESS Failure to retrieve health status
> > **/
> > EFI_STATUS
> > +EFIAPI
> > GetHealthStatus (
> > IN EFI_DRIVER_HEALTH_PROTOCOL * This,
> > IN EFI_HANDLE ControllerHandle, OPTIONAL
> > @@ -119,6 +120,7 @@ GetHealthStatus (
> > @retval EFI_UNSUPPORTED This function is unsupported
> > **/
> > EFI_STATUS
> > +EFIAPI
> > Repair (
> > IN EFI_DRIVER_HEALTH_PROTOCOL *This,
> > IN EFI_HANDLE ControllerHandle,
> > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > index 32bed7ce288d..a788da247e6d 100644
> > --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid =
> > EFI_DRIVER_STOP_PROTOCOL_GUID;
> > @retval EFI_SUCCESS Driver is stopped successfully
> > **/
> > EFI_STATUS
> > +EFIAPI
> > StopDriver (
> > IN EFI_DRIVER_STOP_PROTOCOL *This
> > )
> > @@ -62,6 +63,7 @@ StopDriver (
> > @retval EFI_SUCCESS If driver has restarted successfully
> > **/
> > EFI_STATUS
> > +EFIAPI
> > StartDriver (
> > IN EFI_DRIVER_STOP_PROTOCOL *This
> > )
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
2019-01-30 15:20 ` Ard Biesheuvel
@ 2019-01-30 15:31 ` Ryszard Knop
2019-01-30 15:33 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 15:31 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
Builds were fine, the result didn't work. Adding proper EFIAPIs fixed
that, so should be okay everywhere.
On Wed, 2019-01-30 at 16:20 +0100, Ard Biesheuvel wrote:
> On Wed, 30 Jan 2019 at 16:15, Ryszard Knop <
> ryszard.knop@linux.intel.com> wrote:
> > I'm going through all the protocols we have defined/used and in
> > Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
> > tested an X64 GCC build under OVMF and these calls were broken due
> > to
> > mismatched calling conventions. Did this work correctly for your
> > builds
> > on your platforms?
> >
>
> Do you mean the builds were broken? Or the resulting builds didn't
> work?
>
> In any case, that issue only exists on X64, since there are different
> SysV and MS calling conventions. and GCC uses the former by default.
> On ARM, there is no such difference.
>
> > Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
> >
> > On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > > ---
> > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++
> > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++
> > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +
> > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++
> > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 +
> > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++
> > > IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++
> > > 7 files changed, 14 insertions(+)
> > >
> > > diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > index 8918c538e447..1cece79911b1 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
> > > **/
> > > STATIC
> > > EFI_STATUS
> > > +EFIAPI
> > > GetInformation (
> > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > IN EFI_GUID * InformationType,
> > > @@ -188,6 +189,7 @@ GetInformation (
> > > **/
> > > STATIC
> > > EFI_STATUS
> > > +EFIAPI
> > > SetInformation (
> > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > IN EFI_GUID * InformationType,
> > > @@ -234,6 +236,7 @@ SetInformation (
> > > **/
> > > STATIC
> > > EFI_STATUS
> > > +EFIAPI
> > > GetSupportedTypes (
> > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > OUT EFI_GUID ** InfoTypesBuffer,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > index 70baf00f4a5d..2bf9bbfbe0e4 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName (
> > > language specified by
> > > Language.
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > ComponentNameGetDriverName (
> > > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > > IN CHAR8 * Language,
> > > @@ -182,6 +183,7 @@ ComponentNameGetDriverName (
> > > language specified by
> > > Language.
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > ComponentNameGetControllerName (
> > > IN EFI_COMPONENT_NAME_PROTOCOL
> > > * This,
> > > IN EFI_HANDLE
> > > Co
> > > ntrollerHandle,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > index 5a3d414c6970..0b93a5410fc0 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName (
> > > language specified by
> > > Language.
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > ComponentNameGetDriverName (
> > > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > > IN CHAR8 * Language,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > index 20d40ab672ef..99e086d81044 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu (
> > > @retval EFI_SUCCESS Configuration was successful
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > GigUndiDriverConfigurationSetOptions (
> > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > IN
> > > EFI_HANDLE ControllerHandle,
> > > @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions (
> > > @retval EFI_SUCCESS Always returned
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > GigUndiDriverConfigurationOptionsValid (
> > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > IN EFI_HANDLE ControllerHandle,
> > > @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid (
> > > @retval EFI_SUCCESS Configuration was successful
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > GigUndiDriverConfigurationForceDefaults (
> > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > IN
> > > EFI_HANDLE ControllerH
> > > andl
> > > e,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > index aceb015e480f..f6152cd24c59 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > @@ -1394,6 +1394,7 @@ Error:
> > > ChildHandle did not pass the
> > > diagnostic.
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > GigUndiDriverDiagnosticsRunDiagnostics (
> > > IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This,
> > > IN
> > > EFI_HANDLE ControllerHandle,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > index b5b7db5fd814..ea306843679a 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> > > POSSIBILITY OF SUCH DAMAGE.
> > > @retval !EFI_SUCCESS Failure to retrieve health
> > > status
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > GetHealthStatus (
> > > IN EFI_DRIVER_HEALTH_PROTOCOL * This,
> > > IN EFI_HANDLE ControllerHandle,
> > > OPTIONAL
> > > @@ -119,6 +120,7 @@ GetHealthStatus (
> > > @retval EFI_UNSUPPORTED This function is unsupported
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > Repair (
> > > IN EFI_DRIVER_HEALTH_PROTOCOL *This,
> > > IN EFI_HANDLE ControllerHandle
> > > ,
> > > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > index 32bed7ce288d..a788da247e6d 100644
> > > --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid =
> > > EFI_DRIVER_STOP_PROTOCOL_GUID;
> > > @retval EFI_SUCCESS Driver is stopped successfully
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > StopDriver (
> > > IN EFI_DRIVER_STOP_PROTOCOL *This
> > > )
> > > @@ -62,6 +63,7 @@ StopDriver (
> > > @retval EFI_SUCCESS If driver has restarted successfully
> > > **/
> > > EFI_STATUS
> > > +EFIAPI
> > > StartDriver (
> > > IN EFI_DRIVER_STOP_PROTOCOL *This
> > > )
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
2019-01-30 15:31 ` Ryszard Knop
@ 2019-01-30 15:33 ` Ard Biesheuvel
0 siblings, 0 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2019-01-30 15:33 UTC (permalink / raw)
To: Ryszard Knop
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Wed, 30 Jan 2019 at 16:31, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> Builds were fine, the result didn't work. Adding proper EFIAPIs fixed
> that, so should be okay everywhere.
>
Right. No I didn't spot that - I did build tests of all architectures,
and boot tests on 64-bit ARM. (I don't have x86 hardware with PCIe
slots)
> On Wed, 2019-01-30 at 16:20 +0100, Ard Biesheuvel wrote:
> > On Wed, 30 Jan 2019 at 16:15, Ryszard Knop <
> > ryszard.knop@linux.intel.com> wrote:
> > > I'm going through all the protocols we have defined/used and in
> > > Decode.c/h there's [E1000]UndiApiEntry for PXE/UNDI callbacks. I've
> > > tested an X64 GCC build under OVMF and these calls were broken due
> > > to
> > > mismatched calling conventions. Did this work correctly for your
> > > builds
> > > on your platforms?
> > >
> >
> > Do you mean the builds were broken? Or the resulting builds didn't
> > work?
> >
> > In any case, that issue only exists on X64, since there are different
> > SysV and MS calling conventions. and GCC uses the former by default.
> > On ARM, there is no such difference.
> >
> > > Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
> > >
> > > On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > > > ---
> > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 3 +++
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 2 ++
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 1 +
> > > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 3 +++
> > > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 1 +
> > > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 2 ++
> > > > IntelUndiPkg/GigUndiDxe/StartStop.c | 2 ++
> > > > 7 files changed, 14 insertions(+)
> > > >
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > > b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > > index 8918c538e447..1cece79911b1 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/AdapterInformation.c
> > > > @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock (
> > > > **/
> > > > STATIC
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GetInformation (
> > > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > > IN EFI_GUID * InformationType,
> > > > @@ -188,6 +189,7 @@ GetInformation (
> > > > **/
> > > > STATIC
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > SetInformation (
> > > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > > IN EFI_GUID * InformationType,
> > > > @@ -234,6 +236,7 @@ SetInformation (
> > > > **/
> > > > STATIC
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GetSupportedTypes (
> > > > IN EFI_ADAPTER_INFORMATION_PROTOCOL *This,
> > > > OUT EFI_GUID ** InfoTypesBuffer,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > > b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > > index 70baf00f4a5d..2bf9bbfbe0e4 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.c
> > > > @@ -112,6 +112,7 @@ ComponentNameInitializeControllerName (
> > > > language specified by
> > > > Language.
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > ComponentNameGetDriverName (
> > > > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > > > IN CHAR8 * Language,
> > > > @@ -182,6 +183,7 @@ ComponentNameGetDriverName (
> > > > language specified by
> > > > Language.
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > ComponentNameGetControllerName (
> > > > IN EFI_COMPONENT_NAME_PROTOCOL
> > > > * This,
> > > > IN EFI_HANDLE
> > > > Co
> > > > ntrollerHandle,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > > b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > > index 5a3d414c6970..0b93a5410fc0 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > > +++ b/IntelUndiPkg/GigUndiDxe/ComponentName.h
> > > > @@ -65,6 +65,7 @@ ComponentNameInitializeControllerName (
> > > > language specified by
> > > > Language.
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > ComponentNameGetDriverName (
> > > > IN EFI_COMPONENT_NAME_PROTOCOL *This,
> > > > IN CHAR8 * Language,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > > b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > > index 20d40ab672ef..99e086d81044 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/DriverConfiguration.c
> > > > @@ -310,6 +310,7 @@ GigUndiDriverConfigurationDisplayMenu (
> > > > @retval EFI_SUCCESS Configuration was successful
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GigUndiDriverConfigurationSetOptions (
> > > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > > IN
> > > > EFI_HANDLE ControllerHandle,
> > > > @@ -418,6 +419,7 @@ GigUndiDriverConfigurationSetOptions (
> > > > @retval EFI_SUCCESS Always returned
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GigUndiDriverConfigurationOptionsValid (
> > > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > > IN EFI_HANDLE ControllerHandle,
> > > > @@ -442,6 +444,7 @@ GigUndiDriverConfigurationOptionsValid (
> > > > @retval EFI_SUCCESS Configuration was successful
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GigUndiDriverConfigurationForceDefaults (
> > > > IN EFI_DRIVER_CONFIGURATION_PROTOCOL * This,
> > > > IN
> > > > EFI_HANDLE ControllerH
> > > > andl
> > > > e,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > > b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > > index aceb015e480f..f6152cd24c59 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> > > > @@ -1394,6 +1394,7 @@ Error:
> > > > ChildHandle did not pass the
> > > > diagnostic.
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GigUndiDriverDiagnosticsRunDiagnostics (
> > > > IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This,
> > > > IN
> > > > EFI_HANDLE ControllerHandle,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > > b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > > index b5b7db5fd814..ea306843679a 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/DriverHealth.c
> > > > @@ -44,6 +44,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> > > > POSSIBILITY OF SUCH DAMAGE.
> > > > @retval !EFI_SUCCESS Failure to retrieve health
> > > > status
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > GetHealthStatus (
> > > > IN EFI_DRIVER_HEALTH_PROTOCOL * This,
> > > > IN EFI_HANDLE ControllerHandle,
> > > > OPTIONAL
> > > > @@ -119,6 +120,7 @@ GetHealthStatus (
> > > > @retval EFI_UNSUPPORTED This function is unsupported
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > Repair (
> > > > IN EFI_DRIVER_HEALTH_PROTOCOL *This,
> > > > IN EFI_HANDLE ControllerHandle
> > > > ,
> > > > diff --git a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > > b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > > index 32bed7ce288d..a788da247e6d 100644
> > > > --- a/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > > +++ b/IntelUndiPkg/GigUndiDxe/StartStop.c
> > > > @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid =
> > > > EFI_DRIVER_STOP_PROTOCOL_GUID;
> > > > @retval EFI_SUCCESS Driver is stopped successfully
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > StopDriver (
> > > > IN EFI_DRIVER_STOP_PROTOCOL *This
> > > > )
> > > > @@ -62,6 +63,7 @@ StopDriver (
> > > > @retval EFI_SUCCESS If driver has restarted successfully
> > > > **/
> > > > EFI_STATUS
> > > > +EFIAPI
> > > > StartDriver (
> > > > IN EFI_DRIVER_STOP_PROTOCOL *This
> > > > )
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (17 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
@ 2018-11-06 17:58 ` Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 14:32 ` Ryszard Knop
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
2019-01-29 13:13 ` Ryszard Knop
20 siblings, 2 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 17:58 UTC (permalink / raw)
To: edk2-devel
Cc: maciej.rabeda, michael.d.kinney, eric.jin, leif.lindholm,
Ard Biesheuvel
Drop variables that are assigned but never used, or move them into
a conditional preprocessor block if the only references occur from
such code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 --
IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 2 --
IntelUndiPkg/GigUndiDxe/e1000.c | 16 +++++++---------
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
index f6152cd24c59..af8aaa797e68 100644
--- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
+++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
@@ -1123,11 +1123,9 @@ GigUndiRunPhyLoopback (
UINT64 FreeTxBuffer[DEFAULT_TX_DESCRIPTORS];
UINT32 j;
UINT32 i;
- struct e1000_hw *Hw;
Status = EFI_SUCCESS;
j = 0;
- Hw = &GigAdapterInfo->Hw;
while (j < PHY_LOOPBACK_ITERATIONS) {
Status = E1000Transmit (
diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
index 2aacb63ca158..690d8314be74 100644
--- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
+++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
@@ -197,7 +197,6 @@ GetNextRequestElement (
)
{
EFI_STRING StringPtr;
- EFI_STRING TmpPtr;
EFI_STATUS Status;
UINTN Length;
UINT8 * TmpBuffer;
@@ -227,7 +226,6 @@ GetNextRequestElement (
}
// Back up the header of one <BlockName>
- TmpPtr = StringPtr;
StringPtr += StrLen (L"OFFSET=");
diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
index 28c900e3ad63..3d4a21c62d77 100644
--- a/IntelUndiPkg/GigUndiDxe/e1000.c
+++ b/IntelUndiPkg/GigUndiDxe/e1000.c
@@ -412,7 +412,6 @@ E1000Transmit (
E1000_TRANSMIT_DESCRIPTOR *TransmitDescriptor;
UINT32 i;
INT16 WaitMsec;
- EFI_STATUS Status;
UNDI_DMA_MAPPING *TxBufMapping;
TxBufMapping = &GigAdapter->TxBufferMappings[GigAdapter->CurTxInd];
@@ -483,7 +482,7 @@ E1000Transmit (
TxBufMapping->Size = TxBuffer->DataLen + TxBuffer->MediaheaderLen;
// Make the Tx buffer accessible for adapter over DMA
- Status = UndiDmaMapMemoryRead (
+ UndiDmaMapMemoryRead (
GigAdapter->PciIo,
TxBufMapping
);
@@ -594,20 +593,21 @@ E1000Receive (
E1000_RECEIVE_DESCRIPTOR *ReceiveDescriptor;
ETHER_HEADER * EtherHeader;
PXE_STATCODE StatCode;
- UINT16 i;
UINT16 TempLen;
+#if (DBG_LVL & RX)
+ UINT16 i;
UINT8 * PacketPtr;
#if (DBG_LVL & CRITICAL)
-#if (DBG_LVL & RX)
UINT32 Rdh;
UINT32 Rdt;
-#endif /* (DBG_LVL & RX) */
+
#endif /* (DBG_LVL & CRITICAL) */
+ i = 0;
+#endif /* (DBG_LVL & RX) */
PacketType = PXE_FRAME_TYPE_NONE;
StatCode = PXE_STATCODE_NO_DATA;
- i = 0;
// acknowledge the interrupts
E1000_READ_REG (&GigAdapter->Hw, E1000_ICR);
@@ -679,9 +679,9 @@ E1000Receive (
TempLen
);
+#if (DBG_LVL & RX)
PacketPtr = (UINT8 *) (UINTN) CpbReceive->BufferAddr;
-#if (DBG_LVL & RX)
DEBUGPRINT (RX, ("Packet Data \n"));
for (i = 0; i < TempLen; i++) {
DEBUGPRINT (RX, ("%x ", PacketPtr[i]));
@@ -1569,13 +1569,11 @@ E1000Inititialize (
GIG_DRIVER_DATA *GigAdapter
)
{
- UINT32 * TempBar;
PXE_STATCODE PxeStatcode;
DEBUGPRINT (E1000, ("E1000Inititialize\n"));
PxeStatcode = PXE_STATCODE_SUCCESS;
- TempBar = NULL;
ZeroMem (
(VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,
--
2.19.1
^ permalink raw reply related [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
@ 2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 14:32 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-11-07 9:08 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel; +Cc: michael.d.kinney, eric.jin
On 6/11/18 18:58, Ard Biesheuvel wrote:
> Drop variables that are assigned but never used, or move them into
> a conditional preprocessor block if the only references occur from
> such code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 --
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 2 --
> IntelUndiPkg/GigUndiDxe/e1000.c | 16 +++++++---------
> 3 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index f6152cd24c59..af8aaa797e68 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1123,11 +1123,9 @@ GigUndiRunPhyLoopback (
> UINT64 FreeTxBuffer[DEFAULT_TX_DESCRIPTORS];
> UINT32 j;
> UINT32 i;
> - struct e1000_hw *Hw;
>
> Status = EFI_SUCCESS;
> j = 0;
> - Hw = &GigAdapterInfo->Hw;
>
> while (j < PHY_LOOPBACK_ITERATIONS) {
> Status = E1000Transmit (
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> index 2aacb63ca158..690d8314be74 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> @@ -197,7 +197,6 @@ GetNextRequestElement (
> )
> {
> EFI_STRING StringPtr;
> - EFI_STRING TmpPtr;
> EFI_STATUS Status;
> UINTN Length;
> UINT8 * TmpBuffer;
> @@ -227,7 +226,6 @@ GetNextRequestElement (
> }
>
> // Back up the header of one <BlockName>
> - TmpPtr = StringPtr;
>
> StringPtr += StrLen (L"OFFSET=");
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 28c900e3ad63..3d4a21c62d77 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -412,7 +412,6 @@ E1000Transmit (
> E1000_TRANSMIT_DESCRIPTOR *TransmitDescriptor;
> UINT32 i;
> INT16 WaitMsec;
> - EFI_STATUS Status;
> UNDI_DMA_MAPPING *TxBufMapping;
>
> TxBufMapping = &GigAdapter->TxBufferMappings[GigAdapter->CurTxInd];
> @@ -483,7 +482,7 @@ E1000Transmit (
> TxBufMapping->Size = TxBuffer->DataLen + TxBuffer->MediaheaderLen;
>
> // Make the Tx buffer accessible for adapter over DMA
> - Status = UndiDmaMapMemoryRead (
> + UndiDmaMapMemoryRead (
> GigAdapter->PciIo,
> TxBufMapping
> );
> @@ -594,20 +593,21 @@ E1000Receive (
> E1000_RECEIVE_DESCRIPTOR *ReceiveDescriptor;
> ETHER_HEADER * EtherHeader;
> PXE_STATCODE StatCode;
> - UINT16 i;
> UINT16 TempLen;
> +#if (DBG_LVL & RX)
> + UINT16 i;
> UINT8 * PacketPtr;
> #if (DBG_LVL & CRITICAL)
> -#if (DBG_LVL & RX)
> UINT32 Rdh;
> UINT32 Rdt;
> -#endif /* (DBG_LVL & RX) */
> +
> #endif /* (DBG_LVL & CRITICAL) */
> + i = 0;
> +#endif /* (DBG_LVL & RX) */
This context is easier to understand when looking at the whole function.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
> PacketType = PXE_FRAME_TYPE_NONE;
> StatCode = PXE_STATCODE_NO_DATA;
> - i = 0;
>
> // acknowledge the interrupts
> E1000_READ_REG (&GigAdapter->Hw, E1000_ICR);
> @@ -679,9 +679,9 @@ E1000Receive (
> TempLen
> );
>
> +#if (DBG_LVL & RX)
> PacketPtr = (UINT8 *) (UINTN) CpbReceive->BufferAddr;
>
> -#if (DBG_LVL & RX)
> DEBUGPRINT (RX, ("Packet Data \n"));
> for (i = 0; i < TempLen; i++) {
> DEBUGPRINT (RX, ("%x ", PacketPtr[i]));
> @@ -1569,13 +1569,11 @@ E1000Inititialize (
> GIG_DRIVER_DATA *GigAdapter
> )
> {
> - UINT32 * TempBar;
> PXE_STATCODE PxeStatcode;
>
> DEBUGPRINT (E1000, ("E1000Inititialize\n"));
>
> PxeStatcode = PXE_STATCODE_SUCCESS;
> - TempBar = NULL;
>
> ZeroMem (
> (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
@ 2019-01-30 14:32 ` Ryszard Knop
1 sibling, 0 replies; 67+ messages in thread
From: Ryszard Knop @ 2019-01-30 14:32 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
Just one thing - in E1000Receive, the removed Status is actually
needed, we've missed the error handling block in 1G while backporting
DMA changes from 40G drivers.
Reviewed-by: Ryszard Knop <ryszard.knop@linux.intel.com>
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> Drop variables that are assigned but never used, or move them into
> a conditional preprocessor block if the only references occur from
> such code.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 2 --
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 2 --
> IntelUndiPkg/GigUndiDxe/e1000.c | 16 +++++++---------
> 3 files changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> index f6152cd24c59..af8aaa797e68 100644
> --- a/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> +++ b/IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c
> @@ -1123,11 +1123,9 @@ GigUndiRunPhyLoopback (
> UINT64 FreeTxBuffer[DEFAULT_TX_DESCRIPTORS];
> UINT32 j;
> UINT32 i;
> - struct e1000_hw *Hw;
>
> Status = EFI_SUCCESS;
> j = 0;
> - Hw = &GigAdapterInfo->Hw;
>
> while (j < PHY_LOOPBACK_ITERATIONS) {
> Status = E1000Transmit (
> diff --git a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> index 2aacb63ca158..690d8314be74 100644
> --- a/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> +++ b/IntelUndiPkg/GigUndiDxe/HiiInternalLib.c
> @@ -197,7 +197,6 @@ GetNextRequestElement (
> )
> {
> EFI_STRING StringPtr;
> - EFI_STRING TmpPtr;
> EFI_STATUS Status;
> UINTN Length;
> UINT8 * TmpBuffer;
> @@ -227,7 +226,6 @@ GetNextRequestElement (
> }
>
> // Back up the header of one <BlockName>
> - TmpPtr = StringPtr;
>
> StringPtr += StrLen (L"OFFSET=");
>
> diff --git a/IntelUndiPkg/GigUndiDxe/e1000.c
> b/IntelUndiPkg/GigUndiDxe/e1000.c
> index 28c900e3ad63..3d4a21c62d77 100644
> --- a/IntelUndiPkg/GigUndiDxe/e1000.c
> +++ b/IntelUndiPkg/GigUndiDxe/e1000.c
> @@ -412,7 +412,6 @@ E1000Transmit (
> E1000_TRANSMIT_DESCRIPTOR *TransmitDescriptor;
> UINT32 i;
> INT16 WaitMsec;
> - EFI_STATUS Status;
> UNDI_DMA_MAPPING *TxBufMapping;
>
> TxBufMapping = &GigAdapter->TxBufferMappings[GigAdapter-
> >CurTxInd];
> @@ -483,7 +482,7 @@ E1000Transmit (
> TxBufMapping->Size = TxBuffer->DataLen + TxBuffer-
> >MediaheaderLen;
>
> // Make the Tx buffer accessible for adapter over DMA
> - Status = UndiDmaMapMemoryRead (
> + UndiDmaMapMemoryRead (
> GigAdapter->PciIo,
> TxBufMapping
> );
> @@ -594,20 +593,21 @@ E1000Receive (
> E1000_RECEIVE_DESCRIPTOR *ReceiveDescriptor;
> ETHER_HEADER * EtherHeader;
> PXE_STATCODE StatCode;
> - UINT16 i;
> UINT16 TempLen;
> +#if (DBG_LVL & RX)
> + UINT16 i;
> UINT8 * PacketPtr;
> #if (DBG_LVL & CRITICAL)
> -#if (DBG_LVL & RX)
> UINT32 Rdh;
> UINT32 Rdt;
> -#endif /* (DBG_LVL & RX) */
> +
> #endif /* (DBG_LVL & CRITICAL) */
> + i = 0;
> +#endif /* (DBG_LVL & RX) */
>
>
> PacketType = PXE_FRAME_TYPE_NONE;
> StatCode = PXE_STATCODE_NO_DATA;
> - i = 0;
>
> // acknowledge the interrupts
> E1000_READ_REG (&GigAdapter->Hw, E1000_ICR);
> @@ -679,9 +679,9 @@ E1000Receive (
> TempLen
> );
>
> +#if (DBG_LVL & RX)
> PacketPtr = (UINT8 *) (UINTN) CpbReceive->BufferAddr;
>
> -#if (DBG_LVL & RX)
> DEBUGPRINT (RX, ("Packet Data \n"));
> for (i = 0; i < TempLen; i++) {
> DEBUGPRINT (RX, ("%x ", PacketPtr[i]));
> @@ -1569,13 +1569,11 @@ E1000Inititialize (
> GIG_DRIVER_DATA *GigAdapter
> )
> {
> - UINT32 * TempBar;
> PXE_STATCODE PxeStatcode;
>
> DEBUGPRINT (E1000, ("E1000Inititialize\n"));
>
> PxeStatcode = PXE_STATCODE_SUCCESS;
> - TempBar = NULL;
>
> ZeroMem (
> (VOID *)(UINTN)GigAdapter->RxRing.UnmappedAddress,
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (18 preceding siblings ...)
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
@ 2018-11-06 22:10 ` Kinney, Michael D
2018-11-06 23:03 ` Ard Biesheuvel
2018-11-07 14:56 ` Leif Lindholm
2019-01-29 13:13 ` Ryszard Knop
20 siblings, 2 replies; 67+ messages in thread
From: Kinney, Michael D @ 2018-11-06 22:10 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel@lists.01.org, Kinney, Michael D,
Rabeda, Maciej, Kacperski, Kamil, Orlowski, Pawel,
Kinney, Michael D
Cc: Rabeda, Maciej, Jin, Eric, leif.lindholm@linaro.org
Hi Ard,
Can you please add CC lines to the commit message
for the developers that have contributed to the
edk2-staging/Intel_UNDI branch?
This would include:
Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Cc: Kamil Kacperski <kamil.kacperski@intel.com>
Cc: Pawel Orlowski <pawel.orlowski@intel.com>
Thanks,
Mike
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, November 6, 2018 9:58 AM
> To: edk2-devel@lists.01.org
> Cc: Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Jin, Eric
> <eric.jin@intel.com>; leif.lindholm@linaro.org; Ard
> Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH edk2-staging 00/19]
> IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
>
> This series fixes the GigUndiDxe in the edk2-
> staging/Intel_UNDI branch
> at github.com/tianocore so it can be built with GCC on
> Linux for ARM
> and AARCH64 (as well as X64)
>
> Ard Biesheuvel (19):
> IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to
> supported
> architectures
> IntelUndiPkg: remove EOF markers
> IntelUndiPkg/GigUndiDxe: consistently use lowercase
> for e1000 in
> filenames
> IntelUndiPkg/GigUndiDxe: consistently use forward
> slashes as path
> separators
> IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration
> after type
> definition
> IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts
> for pointers
> IntelUndiPkg/GigUndiDxe: create GCC alternatives for
> MSFT build
> options
> IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> IntelUndiPkg/GigUndiDxe: add missing braces to GUID
> literals
> IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP
> token pasting
> IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to
> correct pointer
> type
> IntelUndiPkg/GigUndiDxe: don't take address of cast
> expression
> IntelUndiPkg/GigUndiDxe: redefine
> UNREFERENCED_nPARAMETER macros for
> GCC
> IntelUndiPkg/GigUndiDxe: remove forward declaration of
> non-existent
> function
> IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> IntelUndiPkg/GigUndiDxe: move MSFT warning overrides
> to INF file
> IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> IntelUndiPkg/GigUndiDxe: remove or reorganize unused
> variables
>
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++--
> -
> IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++-
> --
> IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++-
> --
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39
> +++++++++----------
> IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++-
> --
> IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/GigUndiDxe/Init.c | 11 +++-
> --
> IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37
> ++++++++----------
> IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10
> ++++-
> IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18
> ++++-----
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13
> ++++++-
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> 171 files changed, 120 insertions(+), 270 deletions(-)
> rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c}
> (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h}
> (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c =>
> e1000_osdep.c} (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h =>
> e1000_osdep.h} (99%)
>
> --
> 2.19.1
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
@ 2018-11-06 23:03 ` Ard Biesheuvel
2018-11-09 17:54 ` Knop, Ryszard
2018-11-07 14:56 ` Leif Lindholm
1 sibling, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-06 23:03 UTC (permalink / raw)
To: Kinney, Michael D
Cc: edk2-devel@lists.01.org, Rabeda, Maciej, Kacperski, Kamil,
Orlowski, Pawel, Jin, Eric, leif.lindholm@linaro.org
On 6 November 2018 at 23:10, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
> Hi Ard,
>
> Can you please add CC lines to the commit message
> for the developers that have contributed to the
> edk2-staging/Intel_UNDI branch?
>
> This would include:
>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Maciej was already on cc. I hope he can forward the emails to his
colleagues, if they can't find them in the archives.
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-06 23:03 ` Ard Biesheuvel
@ 2018-11-09 17:54 ` Knop, Ryszard
2018-11-09 18:00 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Knop, Ryszard @ 2018-11-09 17:54 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel@lists.01.org
Cc: Jin, Eric, Kinney, Michael D, Kacperski, Kamil, Orlowski, Pawel,
Rabeda, Maciej
Hey Ard, I'm from the Preboot team responsible for this component. We're too busy to review and merge this at the moment, so this'll have to stay on the list for now, but we'll come back to it in a few weeks once we've finished some of our current tasks.
Thanks, Richard.
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Wednesday, November 7, 2018 0:04
To: Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Jin, Eric <eric.jin@intel.com>; edk2-devel@lists.01.org; Kacperski, Kamil <kamil.kacperski@intel.com>; Orlowski, Pawel <pawel.orlowski@intel.com>
Subject: Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
On 6 November 2018 at 23:10, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> Hi Ard,
>
> Can you please add CC lines to the commit message for the developers
> that have contributed to the edk2-staging/Intel_UNDI branch?
>
> This would include:
>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
Maciej was already on cc. I hope he can forward the emails to his colleagues, if they can't find them in the archives.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-09 17:54 ` Knop, Ryszard
@ 2018-11-09 18:00 ` Ard Biesheuvel
0 siblings, 0 replies; 67+ messages in thread
From: Ard Biesheuvel @ 2018-11-09 18:00 UTC (permalink / raw)
To: Knop, Ryszard
Cc: edk2-devel@lists.01.org, Jin, Eric, Kinney, Michael D,
Kacperski, Kamil, Orlowski, Pawel, Rabeda, Maciej
On 9 November 2018 at 18:54, Knop, Ryszard <ryszard.knop@intel.com> wrote:
> Hey Ard, I'm from the Preboot team responsible for this component. We're too busy to review and merge this at the moment, so this'll have to stay on the list for now, but we'll come back to it in a few weeks once we've finished some of our current tasks.
> Thanks, Richard.
>
Thank you. No rush.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
> Sent: Wednesday, November 7, 2018 0:04
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Jin, Eric <eric.jin@intel.com>; edk2-devel@lists.01.org; Kacperski, Kamil <kamil.kacperski@intel.com>; Orlowski, Pawel <pawel.orlowski@intel.com>
> Subject: Re: [edk2] [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
>
> On 6 November 2018 at 23:10, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
>> Hi Ard,
>>
>> Can you please add CC lines to the commit message for the developers
>> that have contributed to the edk2-staging/Intel_UNDI branch?
>>
>> This would include:
>>
>> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
>
> Maciej was already on cc. I hope he can forward the emails to his colleagues, if they can't find them in the archives.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> --------------------------------------------------------------------
>
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
>
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
2018-11-06 23:03 ` Ard Biesheuvel
@ 2018-11-07 14:56 ` Leif Lindholm
1 sibling, 0 replies; 67+ messages in thread
From: Leif Lindholm @ 2018-11-07 14:56 UTC (permalink / raw)
To: Kinney, Michael D
Cc: Ard Biesheuvel, edk2-devel@lists.01.org, Rabeda, Maciej,
Kacperski, Kamil, Orlowski, Pawel, Jin, Eric
On Tue, Nov 06, 2018 at 10:10:16PM +0000, Kinney, Michael D wrote:
> Hi Ard,
>
> Can you please add CC lines to the commit message
> for the developers that have contributed to the
> edk2-staging/Intel_UNDI branch?
>
> This would include:
>
> Cc: Maciej Rabeda <maciej.rabeda@intel.com>
> Cc: Kamil Kacperski <kamil.kacperski@intel.com>
Could these two be added to the top-level Readme.MD?
(Pawel is already listed as the branch owner.)
Regards,
Leif
> Cc: Pawel Orlowski <pawel.orlowski@intel.com>
>
> Thanks,
>
> Mike
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Tuesday, November 6, 2018 9:58 AM
> > To: edk2-devel@lists.01.org
> > Cc: Rabeda, Maciej <maciej.rabeda@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Jin, Eric
> > <eric.jin@intel.com>; leif.lindholm@linaro.org; Ard
> > Biesheuvel <ard.biesheuvel@linaro.org>
> > Subject: [PATCH edk2-staging 00/19]
> > IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
> >
> > This series fixes the GigUndiDxe in the edk2-
> > staging/Intel_UNDI branch
> > at github.com/tianocore so it can be built with GCC on
> > Linux for ARM
> > and AARCH64 (as well as X64)
> >
> > Ard Biesheuvel (19):
> > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to
> > supported
> > architectures
> > IntelUndiPkg: remove EOF markers
> > IntelUndiPkg/GigUndiDxe: consistently use lowercase
> > for e1000 in
> > filenames
> > IntelUndiPkg/GigUndiDxe: consistently use forward
> > slashes as path
> > separators
> > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration
> > after type
> > definition
> > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts
> > for pointers
> > IntelUndiPkg/GigUndiDxe: create GCC alternatives for
> > MSFT build
> > options
> > IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> > IntelUndiPkg/GigUndiDxe: add missing braces to GUID
> > literals
> > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP
> > token pasting
> > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to
> > correct pointer
> > type
> > IntelUndiPkg/GigUndiDxe: don't take address of cast
> > expression
> > IntelUndiPkg/GigUndiDxe: redefine
> > UNREFERENCED_nPARAMETER macros for
> > GCC
> > IntelUndiPkg/GigUndiDxe: remove forward declaration of
> > non-existent
> > function
> > IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides
> > to INF file
> > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> > IntelUndiPkg/GigUndiDxe: remove or reorganize unused
> > variables
> >
> > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> > IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++--
> > -
> > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++-
> > --
> > IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++-
> > --
> > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39
> > +++++++++----------
> > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++-
> > --
> > IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++-
> > --
> > IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> > IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37
> > ++++++++----------
> > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10
> > ++++-
> > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18
> > ++++-----
> > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> > .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> > .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13
> > ++++++-
> > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> > 171 files changed, 120 insertions(+), 270 deletions(-)
> > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c}
> > (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h}
> > (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c =>
> > e1000_osdep.c} (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h =>
> > e1000_osdep.h} (99%)
> >
> > --
> > 2.19.1
>
^ permalink raw reply [flat|nested] 67+ messages in thread
* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
` (19 preceding siblings ...)
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
@ 2019-01-29 13:13 ` Ryszard Knop
2019-01-29 13:55 ` Ryszard Knop
20 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 13:13 UTC (permalink / raw)
To: edk2-devel
Hi Ard,
I've finally got some time to review and merge all of this. A bit
problematic thing is that we internally have a separate tree that we
need to merge those commits into, then generate the open source tree
and related commits from that. This will result in somewhat broken
history, so sorry about that in advance - we're still figuring out the
proper way to handle multiple source trees on our end without messing
it up. I'll push these changes to edk2-staging once we've got it all
ready.
On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI
> branch
> at github.com/tianocore so it can be built with GCC on Linux for ARM
> and AARCH64 (as well as X64)
>
> Ard Biesheuvel (19):
> IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported
> architectures
> IntelUndiPkg: remove EOF markers
> IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in
> filenames
> IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path
> separators
> IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type
> definition
> IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers
> IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build
> options
> IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
> IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting
> IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct
> pointer
> type
> IntelUndiPkg/GigUndiDxe: don't take address of cast expression
> IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros
> for
> GCC
> IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent
> function
> IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file
> IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
>
> IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++---
> IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++---
> IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++---
> IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 +++++++++------
> ----
> IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++---
> IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/GigUndiDxe/Init.c | 11 +++---
> IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 ++++++++---------
> -
> IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 ++++-
> IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 ++++-----
> IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++-
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> 171 files changed, 120 insertions(+), 270 deletions(-)
> rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c}
> (99%)
> rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h}
> (99%)
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2019-01-29 13:13 ` Ryszard Knop
@ 2019-01-29 13:55 ` Ryszard Knop
2019-03-27 15:32 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-01-29 13:55 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel
Cc: kamil.kacperski, eric.jin, pawel.orlowski, michael.d.kinney,
harry.l.hsiung
+Team
On Tue, 2019-01-29 at 14:13 +0100, Ryszard Knop wrote:
> Hi Ard,
>
> I've finally got some time to review and merge all of this. A bit
> problematic thing is that we internally have a separate tree that we
> need to merge those commits into, then generate the open source tree
> and related commits from that. This will result in somewhat broken
> history, so sorry about that in advance - we're still figuring out
> the
> proper way to handle multiple source trees on our end without messing
> it up. I'll push these changes to edk2-staging once we've got it all
> ready.
>
> On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI
> > branch
> > at github.com/tianocore so it can be built with GCC on Linux for
> > ARM
> > and AARCH64 (as well as X64)
> >
> > Ard Biesheuvel (19):
> > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported
> > architectures
> > IntelUndiPkg: remove EOF markers
> > IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in
> > filenames
> > IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path
> > separators
> > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type
> > definition
> > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for
> > pointers
> > IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build
> > options
> > IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> > IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
> > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting
> > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct
> > pointer
> > type
> > IntelUndiPkg/GigUndiDxe: don't take address of cast expression
> > IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros
> > for
> > GCC
> > IntelUndiPkg/GigUndiDxe: remove forward declaration of non-
> > existent
> > function
> > IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file
> > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> > IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
> >
> > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> > IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++---
> > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++---
> > IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++---
> > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 +++++++++------
> > ----
> > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++---
> > IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++---
> > IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> > IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 ++++++++-------
> > --
> > -
> > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 ++++-
> > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 ++++-----
> > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> > .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> > .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++-
> > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> > 171 files changed, 120 insertions(+), 270 deletions(-)
> > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c}
> > (99%)
> > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h}
> > (99%)
> >
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2019-01-29 13:55 ` Ryszard Knop
@ 2019-03-27 15:32 ` Ard Biesheuvel
2019-03-28 10:46 ` Ryszard Knop
0 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2019-03-27 15:32 UTC (permalink / raw)
To: Ryszard Knop
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Tue, 29 Jan 2019 at 14:55, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> +Team
>
As it turns out, this driver is still broken for non-1:1 mapped DMA.
In particular, I am hitting a crash on
E1000MemCopy (
(UINT8 *) (UINTN) CpbReceive->BufferAddr,
(UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
TempLen
);
(around line 676 in e1000.c), which uses the DMA address
'ReceiveDescriptor->buffer_addr' in a memory copy operation performed
by the CPU. This causes a crash on systems where the DMA address is
not also a valid CPU address.
> On Tue, 2019-01-29 at 14:13 +0100, Ryszard Knop wrote:
> > Hi Ard,
> >
> > I've finally got some time to review and merge all of this. A bit
> > problematic thing is that we internally have a separate tree that we
> > need to merge those commits into, then generate the open source tree
> > and related commits from that. This will result in somewhat broken
> > history, so sorry about that in advance - we're still figuring out
> > the
> > proper way to handle multiple source trees on our end without messing
> > it up. I'll push these changes to edk2-staging once we've got it all
> > ready.
> >
> > On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > > This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI
> > > branch
> > > at github.com/tianocore so it can be built with GCC on Linux for
> > > ARM
> > > and AARCH64 (as well as X64)
> > >
> > > Ard Biesheuvel (19):
> > > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported
> > > architectures
> > > IntelUndiPkg: remove EOF markers
> > > IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in
> > > filenames
> > > IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path
> > > separators
> > > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type
> > > definition
> > > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for
> > > pointers
> > > IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build
> > > options
> > > IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> > > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> > > IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
> > > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting
> > > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct
> > > pointer
> > > type
> > > IntelUndiPkg/GigUndiDxe: don't take address of cast expression
> > > IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros
> > > for
> > > GCC
> > > IntelUndiPkg/GigUndiDxe: remove forward declaration of non-
> > > existent
> > > function
> > > IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> > > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file
> > > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> > > IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables
> > >
> > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> > > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> > > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> > > IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++---
> > > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++---
> > > IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++---
> > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> > > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> > > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 +++++++++------
> > > ----
> > > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++---
> > > IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++---
> > > IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> > > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> > > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> > > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> > > IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 ++++++++-------
> > > --
> > > -
> > > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 ++++-
> > > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 ++++-----
> > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> > > .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> > > .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> > > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> > > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> > > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> > > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> > > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> > > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++-
> > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> > > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> > > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> > > 171 files changed, 120 insertions(+), 270 deletions(-)
> > > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} (99%)
> > > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} (99%)
> > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => e1000_osdep.c}
> > > (99%)
> > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => e1000_osdep.h}
> > > (99%)
> > >
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2019-03-27 15:32 ` Ard Biesheuvel
@ 2019-03-28 10:46 ` Ryszard Knop
2019-03-28 11:38 ` Ard Biesheuvel
0 siblings, 1 reply; 67+ messages in thread
From: Ryszard Knop @ 2019-03-28 10:46 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Wed, 2019-03-27 at 16:32 +0100, Ard Biesheuvel wrote:
> On Tue, 29 Jan 2019 at 14:55, Ryszard Knop <
> ryszard.knop@linux.intel.com> wrote:
> > +Team
> >
>
> As it turns out, this driver is still broken for non-1:1 mapped DMA.
>
> In particular, I am hitting a crash on
>
> E1000MemCopy (
> (UINT8 *) (UINTN) CpbReceive->BufferAddr,
> (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> TempLen
> );
>
> (around line 676 in e1000.c), which uses the DMA address
> 'ReceiveDescriptor->buffer_addr' in a memory copy operation performed
> by the CPU. This causes a crash on systems where the DMA address is
> not also a valid CPU address.
Huh, this is new... I don't have access to any system behaving this
way, so I can't test this, but E1000.c -> E1000TxRxConfigure links
RxDesc->buffer_addr to the physical addresses, that descriptor is used
by the hardware to DMA data where needed, and we try to copy from that
same physical address later, while we should copy from unmapped
addresses instead.
This probably should be solved by having a separate array/something
with CurRxInd -> unmapped addresses, but I'll have to talk with my team
to solve this in a sensible way.
In the meantime, maybe you know if there's a way to simulate this
situation under QEMU or something?
> > On Tue, 2019-01-29 at 14:13 +0100, Ryszard Knop wrote:
> > > Hi Ard,
> > >
> > > I've finally got some time to review and merge all of this. A bit
> > > problematic thing is that we internally have a separate tree that
> > > we
> > > need to merge those commits into, then generate the open source
> > > tree
> > > and related commits from that. This will result in somewhat
> > > broken
> > > history, so sorry about that in advance - we're still figuring
> > > out
> > > the
> > > proper way to handle multiple source trees on our end without
> > > messing
> > > it up. I'll push these changes to edk2-staging once we've got it
> > > all
> > > ready.
> > >
> > > On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > > > This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI
> > > > branch
> > > > at github.com/tianocore so it can be built with GCC on Linux
> > > > for
> > > > ARM
> > > > and AARCH64 (as well as X64)
> > > >
> > > > Ard Biesheuvel (19):
> > > > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported
> > > > architectures
> > > > IntelUndiPkg: remove EOF markers
> > > > IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000
> > > > in
> > > > filenames
> > > > IntelUndiPkg/GigUndiDxe: consistently use forward slashes as
> > > > path
> > > > separators
> > > > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after
> > > > type
> > > > definition
> > > > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for
> > > > pointers
> > > > IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT
> > > > build
> > > > options
> > > > IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> > > > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> > > > IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
> > > > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token
> > > > pasting
> > > > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct
> > > > pointer
> > > > type
> > > > IntelUndiPkg/GigUndiDxe: don't take address of cast
> > > > expression
> > > > IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER
> > > > macros
> > > > for
> > > > GCC
> > > > IntelUndiPkg/GigUndiDxe: remove forward declaration of non-
> > > > existent
> > > > function
> > > > IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> > > > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF
> > > > file
> > > > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> > > > IntelUndiPkg/GigUndiDxe: remove or reorganize unused
> > > > variables
> > > >
> > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> > > > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> > > > IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++---
> > > > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> > > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++---
> > > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> > > > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 +++++++++
> > > > ------
> > > > ----
> > > > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> > > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> > > > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> > > > IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 ++++++++---
> > > > ----
> > > > --
> > > > -
> > > > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> > > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 ++++-
> > > > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 ++++-----
> > > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> > > > .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> > > > .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> > > > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> > > > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> > > > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++-
> > > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> > > > 171 files changed, 120 insertions(+), 270 deletions(-)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c =>
> > > > e1000_osdep.c}
> > > > (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h =>
> > > > e1000_osdep.h}
> > > > (99%)
> > > >
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 67+ messages in thread* Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
2019-03-28 10:46 ` Ryszard Knop
@ 2019-03-28 11:38 ` Ard Biesheuvel
2020-01-07 12:49 ` [edk2-devel] " Maciej Rabeda
0 siblings, 1 reply; 67+ messages in thread
From: Ard Biesheuvel @ 2019-03-28 11:38 UTC (permalink / raw)
To: Ryszard Knop
Cc: edk2-devel@lists.01.org, Kacperski, Kamil, Jin, Eric,
Orlowski, Pawel, Kinney, Michael D, Hsiung, Harry L
On Thu, 28 Mar 2019 at 11:46, Ryszard Knop <ryszard.knop@linux.intel.com> wrote:
>
> On Wed, 2019-03-27 at 16:32 +0100, Ard Biesheuvel wrote:
> > On Tue, 29 Jan 2019 at 14:55, Ryszard Knop <
> > ryszard.knop@linux.intel.com> wrote:
> > > +Team
> > >
> >
> > As it turns out, this driver is still broken for non-1:1 mapped DMA.
> >
> > In particular, I am hitting a crash on
> >
> > E1000MemCopy (
> > (UINT8 *) (UINTN) CpbReceive->BufferAddr,
> > (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> > TempLen
> > );
> >
> > (around line 676 in e1000.c), which uses the DMA address
> > 'ReceiveDescriptor->buffer_addr' in a memory copy operation performed
> > by the CPU. This causes a crash on systems where the DMA address is
> > not also a valid CPU address.
>
> Huh, this is new... I don't have access to any system behaving this
> way, so I can't test this, but E1000.c -> E1000TxRxConfigure links
> RxDesc->buffer_addr to the physical addresses, that descriptor is used
> by the hardware to DMA data where needed, and we try to copy from that
> same physical address later, while we should copy from unmapped
> addresses instead.
>
Indeed.
> This probably should be solved by having a separate array/something
> with CurRxInd -> unmapped addresses, but I'll have to talk with my team
> to solve this in a sensible way.
>
> In the meantime, maybe you know if there's a way to simulate this
> situation under QEMU or something?
>
I am using an arm64 board with modified firmware to emulate different
PCIe host bridge configurations. I don't know whether QEMU has support
for non-1:1 mapped DMA on x86, but it does emulate various boards
(such as the raspberry pi 2 iirc) where the CPU and device addressing
is not 1:1.
^ permalink raw reply [flat|nested] 67+ messages in thread