From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::334; helo=mail-wm1-x334.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 014102118D93D for ; Wed, 7 Nov 2018 06:56:50 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id f2-v6so2384047wme.3 for ; Wed, 07 Nov 2018 06:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+wm0+m2Is7DZRoU7jbKGOxhmQr9dKU6yY6elDAj1rKE=; b=Z9i5TIStx93JPfjLhX7pYzIPOpX31/xW+92nLqN3txyKjr9cofVGDZloz2wR/ugHmZ NBLBBNSoLuVnimlmPnVRODktI3prvxpPOA3Q/5nw/DeFQOncu4+ufGgXugaiVaQpHR0g ncUIAhvEXiazLGH3HR2BArElDCQ45s/j5IPFo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+wm0+m2Is7DZRoU7jbKGOxhmQr9dKU6yY6elDAj1rKE=; b=QY5kFWaxWeYGmUTak81p8dyxOY1YjDbEj+7IQz0W20SSZMZCSaWsAb1dCOtLeXrp8N MOiHNZqpoyuWgg41KEBsWUF9NtfMxFj6R8NsuT2miIqOStwZcqs+WXToz+uU7JNvSDg+ cHqbiEP5QVXJzKjjH89OCFeczJ6KSNhTIw9Yo04wXyUXp//SIF/5zt7xwuks7CZ6YkDs HWHQkGQjJwcfXnNi3rG/iUZKi0wPjAOssciFc4Jh1MCZXawf+wPFgz5UmwvrGhf455pr qZVIj73Ce2iicr49LNl7YWL/jsxhPSRPDJtQCbm0JMHix/ypP0xIricz8mVy2TMgCK/O CX1w== X-Gm-Message-State: AGRZ1gKSImWOT3CBhnlz9z5ffaMUA2qjfQeTDp7vtf6DXsrEhh9zOeGR gNRezSF3grYKwPBkIS8YzefHzQ== X-Google-Smtp-Source: AJdET5dfwd6ezhy2vEVvMX5XoE0koo8iqjFlDxoyxnqdPBXa5onSpNtMSNGMxGTl1iei1g5IdNWr3A== X-Received: by 2002:a1c:34d1:: with SMTP id b200-v6mr435144wma.115.1541602608947; Wed, 07 Nov 2018 06:56:48 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id i10-v6sm1089215wrr.69.2018.11.07.06.56.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Nov 2018 06:56:47 -0800 (PST) Date: Wed, 7 Nov 2018 14:56:46 +0000 From: Leif Lindholm To: "Kinney, Michael D" Cc: Ard Biesheuvel , "edk2-devel@lists.01.org" , "Rabeda, Maciej" , "Kacperski, Kamil" , "Orlowski, Pawel" , "Jin, Eric" Message-ID: <20181107145646.d5tkxriajvdx7vc4@bivouac.eciton.net> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 14:56:51 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 06, 2018 at 10:10:16PM +0000, Kinney, Michael D wrote: > Hi Ard, > > Can you please add CC lines to the commit message > for the developers that have contributed to the > edk2-staging/Intel_UNDI branch? > > This would include: > > Cc: Maciej Rabeda > Cc: Kamil Kacperski Could these two be added to the top-level Readme.MD? (Pawel is already listed as the branch owner.) Regards, Leif > Cc: Pawel Orlowski > > Thanks, > > Mike > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Tuesday, November 6, 2018 9:58 AM > > To: edk2-devel@lists.01.org > > Cc: Rabeda, Maciej ; Kinney, > > Michael D ; Jin, Eric > > ; leif.lindholm@linaro.org; Ard > > Biesheuvel > > Subject: [PATCH edk2-staging 00/19] > > IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC > > > > This series fixes the GigUndiDxe in the edk2- > > staging/Intel_UNDI branch > > at github.com/tianocore so it can be built with GCC on > > Linux for ARM > > and AARCH64 (as well as X64) > > > > Ard Biesheuvel (19): > > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to > > supported > > architectures > > IntelUndiPkg: remove EOF markers > > IntelUndiPkg/GigUndiDxe: consistently use lowercase > > for e1000 in > > filenames > > IntelUndiPkg/GigUndiDxe: consistently use forward > > slashes as path > > separators > > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration > > after type > > definition > > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts > > for pointers > > IntelUndiPkg/GigUndiDxe: create GCC alternatives for > > MSFT build > > options > > IntelUndiPkg/GigUndiDxe: add missing VOID** cast > > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast > > IntelUndiPkg/GigUndiDxe: add missing braces to GUID > > literals > > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP > > token pasting > > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to > > correct pointer > > type > > IntelUndiPkg/GigUndiDxe: don't take address of cast > > expression > > IntelUndiPkg/GigUndiDxe: redefine > > UNREFERENCED_nPARAMETER macros for > > GCC > > IntelUndiPkg/GigUndiDxe: remove forward declaration of > > non-existent > > function > > IntelUndiPkg/GigUndiDxe: fix incorrect indentation > > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides > > to INF file > > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers > > IntelUndiPkg/GigUndiDxe: remove or reorganize unused > > variables > > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++- > > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 - > > IntelUndiPkg/GigUndiDxe/Brand.c | 1 - > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++- > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +- > > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +-- > > IntelUndiPkg/GigUndiDxe/Decode.h | 1 - > > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 - > > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++-- > > - > > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++- > > -- > > IntelUndiPkg/GigUndiDxe/Dma.h | 1 - > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++- > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 - > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++- > > -- > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 - > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++- > > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 - > > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +- > > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 > > +++++++++---------- > > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++- > > -- > > IntelUndiPkg/GigUndiDxe/Hii.h | 1 - > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 -- > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 - > > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++- > > -- > > IntelUndiPkg/GigUndiDxe/Init.h | 1 - > > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 - > > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++-- > > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++- > > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++-- > > IntelUndiPkg/GigUndiDxe/Version.h | 1 - > > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 > > ++++++++---------- > > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +-- > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 > > ++++- > > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 > > ++++----- > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 - > > .../{E1000_osdep.c => e1000_osdep.c} | 3 +- > > .../{E1000_osdep.h => e1000_osdep.h} | 8 +--- > > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 - > > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 - > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +- > > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 - > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 - > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 - > > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 - > > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 - > > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 - > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 - > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 - > > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 - > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 - > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 - > > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 - > > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 - > > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 - > > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 - > > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 - > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 - > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 - > > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 - > > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 - > > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 - > > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Init.c | 1 - > > IntelUndiPkg/I40eUndiDxe/Init.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 - > > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 - > > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 - > > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 - > > IntelUndiPkg/I40eUndiDxe/Version.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 - > > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 - > > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 > > ++++++- > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 - > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 - > > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 - > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 - > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 - > > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 - > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 - > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 - > > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 - > > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 - > > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 - > > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 - > > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 - > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 - > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Init.c | 1 - > > IntelUndiPkg/XGigUndiDxe/Init.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 - > > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 - > > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 - > > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 - > > IntelUndiPkg/XGigUndiDxe/Version.h | 1 - > > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 - > > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 - > > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 - > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 - > > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 - > > 171 files changed, 120 insertions(+), 270 deletions(-) > > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} > > (99%) > > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} > > (99%) > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c => > > e1000_osdep.c} (99%) > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h => > > e1000_osdep.h} (99%) > > > > -- > > 2.19.1 >