[PATCH] Nt32Pkg: Remove PcdShellFile in DSC

[PATCH] Nt32Pkg: Remove PcdShellFile in DSC

[Shenglei Zhang]

https://bugzilla.tianocore.org/show_bug.cgi?id=1298
This change is based on the change below:
https://lists.01.org/pipermail/edk2-devel/2018-November/031875.html

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 Nt32Pkg/Nt32Pkg.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
index bbaa415ee0..4dbde0cc45 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -280,7 +280,6 @@
   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
 !endif
 
-  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
 
 !if $(SECURE_BOOT_ENABLE) == TRUE
   # override the default values from SecurityPkg to ensure images from all sources are verified in secure boot
-- 
2.18.0.windows.1

[PATCH] EmulatorPkg: Remove PcdShellFile in DSC

[Shenglei Zhang]

https://bugzilla.tianocore.org/show_bug.cgi?id=1298
The change is based on the change below:
https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 EmulatorPkg/EmulatorPkg.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 7af7a5ada0..4097e1192e 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -196,7 +196,6 @@
   # Change PcdBootManagerMenuFile to UiApp
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
 
-  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
 
 #define BOOT_WITH_FULL_CONFIGURATION                  0x00
 #define BOOT_WITH_MINIMAL_CONFIGURATION               0x01
-- 
2.18.0.windows.1

Re: [PATCH] EmulatorPkg: Remove PcdShellFile in DSC

[Ni, Ruiyu]

On 11/8/2018 10:28 AM, Shenglei Zhang wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1298
> The change is based on the change below:
> https://lists.01.org/pipermail/edk2-devel/2018-November/031877.html
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>   EmulatorPkg/EmulatorPkg.dsc | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index 7af7a5ada0..4097e1192e 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -196,7 +196,6 @@
>     # Change PcdBootManagerMenuFile to UiApp
>     gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>   
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>   
>   #define BOOT_WITH_FULL_CONFIGURATION                  0x00
>   #define BOOT_WITH_MINIMAL_CONFIGURATION               0x01
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray

Re: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC

[Wu, Hao A]

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, November 08, 2018 10:28 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH] Nt32Pkg: Remove PcdShellFile in DSC
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1298
> This change is based on the change below:
> https://lists.01.org/pipermail/edk2-devel/2018-November/031875.html

Hi,

The patch is good to me.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

However, IMO it will be more clear to append this patch and the one for
EmulatorPkg after the patch series you mentioned above:

[PATCH v3 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC

and make a v4 for the series.

Best Regards,
Hao Wu

> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Nt32Pkg/Nt32Pkg.dsc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
> index bbaa415ee0..4dbde0cc45 100644
> --- a/Nt32Pkg/Nt32Pkg.dsc
> +++ b/Nt32Pkg/Nt32Pkg.dsc
> @@ -280,7 +280,6 @@
>    gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>  !endif
> 
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5,
> 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4,
> 0xD1 }
> 
>  !if $(SECURE_BOOT_ENABLE) == TRUE
>    # override the default values from SecurityPkg to ensure images from all
> sources are verified in secure boot
> --
> 2.18.0.windows.1