From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BFFF021A00AE6 for ; Thu, 8 Nov 2018 03:37:13 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id i17-v6so20883665wre.7 for ; Thu, 08 Nov 2018 03:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yQkYfbhyqBAZtq3wJTKVi5bZ5EkmJ6ONKtMTTiYGJ9g=; b=D/E3WPsRgBn8a7OnEFJSFRxsF60gqrkKyjzhPDIPjq5t/qR5WuWyVKi+a9psy33nvQ xCEUlUkFG/T9q1JXyHHXSkRyjHTePlWf61TkjUN1m1w9fhvxfE1yQolHbC2DIJHp8sRg M3+nU9sUphUL7yTgDMVXZJBPr0Nth24hOxaVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yQkYfbhyqBAZtq3wJTKVi5bZ5EkmJ6ONKtMTTiYGJ9g=; b=SNVL3dlDkbi2/YqUn25hOyJN/z6W+OJzXIiyxguj/wb1hCZg5fE5GtoOrO+w9Hvwdq hNHHkEVrnsQcESMVTfApTt/qusRFopyD3syaq8LTquMQXbZHN5on0MRGo0xMWCjlvWKm 9Z7WTvKTWGAkj7+bbKdXEV1MMUCA2WTT/9/s1JYjQ4vEkaNQhxDfb8kA+aMWrjR+w9UI kiE1JHUVzKcWeggBHW+DICPb1MaTuWqglaxhGnq8/ZzZ5I0Wr5BGPUzsywIpqjDEmB0e y1y6D+kCdW5t71BdErNi61Ngnml3Jatbd4QQ45e7FyKarN3Z41REBAuOybZuazXBSPBc Xacw== X-Gm-Message-State: AGRZ1gKzfM71gppclZPeNYG4xlJw978fOfE/oZ01ATLIGQYR8xqUM1qz fCDh3h6jwWup9Ee0lkKMCfp3Cg== X-Google-Smtp-Source: AJdET5eVnlp57Fn6MKdghMommA14lgDLH8Y+7WwaS4uEw8glCeXx2cJKvWpRnCLPosKdp+x7fJuwyw== X-Received: by 2002:adf:e581:: with SMTP id l1-v6mr3869505wrm.253.1541677031826; Thu, 08 Nov 2018 03:37:11 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u14-v6sm4185083wrs.27.2018.11.08.03.37.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 03:37:10 -0800 (PST) Date: Thu, 8 Nov 2018 11:37:09 +0000 From: Leif Lindholm To: Andrew Turner Cc: edk2-devel@lists.01.org, Ard Biesheuvel Message-ID: <20181108113709.r5ftoiuuo6czyzu2@bivouac.eciton.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] Platform/ARM: Fix FVP broken build with "-D DT_SUPPORT" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 11:37:14 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 01, 2018 at 11:35:42AM +0000, Andrew Turner wrote: > The UEFI build fails for ArmVExpress-FVP-AArch64 when using the > "-D DT_SUPPORT" buildoption. > > ArmVExpressDtPlatformDtbLoaderLib is missing the ArmVExpressPkg.dec package > and fails with: > .../Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h:19:33: > fatal error: VExpressMotherBoard.h: No such file or directory > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Andrew Turner > --- > .../ArmVExpressDtPlatformDtbLoaderLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > index 5012101..eb821c7 100644 > --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf > @@ -26,6 +26,7 @@ > [Packages] > ArmPkg/ArmPkg.dec > MdePkg/MdePkg.dec > ++ Platform/ARM/VExpressPkg/ArmVExpressPkg.dec Dropped this extra leading + (is this some sort of alternative diff format or a character encoding issue?). With that: Reviewed-by: Leif Lindholm Pushed as 113d2def98. > EmbeddedPkg/EmbeddedPkg.dec > > [LibraryClasses] > -- > 2.7.4 >