From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::32b; helo=mail-wm1-x32b.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BCF2821959CB2 for ; Fri, 9 Nov 2018 10:09:02 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id r63-v6so2856580wma.4 for ; Fri, 09 Nov 2018 10:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4owBY41kcvIYNQQcAtCONdpSFS4rtLjuQwyKOBnJf9Y=; b=HkFomod0FaUy6zIaqRv6AiKvh93JREmttrjjkedeD3vUZHPvIFrrD13cfByGjYgAB7 l3kwhCRKBT/3cnkKw9RybpYX6nbzihifdHP0dGjMlbLFPKVNQFwuK0M0slIHjlKJr7EW slxp/E5uS1LLy56Nje8W8XvJQUDqEQ/TfrPug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4owBY41kcvIYNQQcAtCONdpSFS4rtLjuQwyKOBnJf9Y=; b=T+bfUYiP8rI81aWD5ZD4vPjgDqhg4cvlUwr2t9oNnbh+PIt6mcUYCF8ufRoMlAjY6Q cOYV7Bfhcm5UAiqw2Ax/W6ql9aO0oV7Nc4yJO34wQ4brNRpJO7iwziEOV0taGwIiBkVL PGUx2UW+z5ZSeO6Pb5hOKAjq+sG5rvJEdA2jgHAvlqS9FhuQHwKbRxu/TG61inr1SU+E CXCBEwF+FbAANltdvvLeT73NRFTABSm704u9qQ+H2L6WAGhjtKAsDIHR7eSZuxTEXiCb C+Pw9+lapMX3ei5SdzrJN5DGu/KA/M9nIHQG1DEAQL6VXe3RLZXMzd4YuMNY+OzLn2hl BjLw== X-Gm-Message-State: AGRZ1gLam0YrR4+EFpVyptVmT6ce27YOoxefY/Hf5ubi0hcGS3lbRPLE HQ7yKCKMFPzNTp/kaLge7X0afQ== X-Google-Smtp-Source: AJdET5d7O4GwueFYFQYEi42cgP2AO172uNYd4SyB0p9JNBl9x73jEMaBhIK0B02mEgFE84GPxigFHw== X-Received: by 2002:a1c:7dd7:: with SMTP id y206-v6mr354723wmc.78.1541786940170; Fri, 09 Nov 2018 10:09:00 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id u14-v6sm8914425wrs.27.2018.11.09.10.08.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 10:08:59 -0800 (PST) Date: Fri, 9 Nov 2018 18:08:57 +0000 From: Leif Lindholm To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Stephano Cetola , Brian Richardson , "Gao, Liming" , Michael Kinney , yuchenlin , Gerd Hoffmann , Phil Dennis-Jordan , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20181109180857.2i3icjmxwja3dpm7@bivouac.eciton.net> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3659AB@SHSMSX104.ccr.corp.intel.com> <20181107153829.juygpydwln2s5jkj@bivouac.eciton.net> <01176b5b-8826-2c82-beef-45250fd88bef@redhat.com> <8ff81475-1712-86b0-a96e-0f281bc4a734@redhat.com> MIME-Version: 1.0 In-Reply-To: <8ff81475-1712-86b0-a96e-0f281bc4a734@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [urgent] Soft Feature Freeze has started since Nov.1 for dk2-stable201811 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 18:09:03 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Laszlo, On Fri, Nov 09, 2018 at 05:46:47PM +0100, Laszlo Ersek wrote: > + Yuchenlin, + Gerd, + both Phils > > On 11/07/18 20:13, Laszlo Ersek wrote: > > >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): > >>> > >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file" > >>> 2 98856a724c2a Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" > >>> 3 438ada5aa5a1 Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O." > >>> 4 328409ce8de7 Revert "OvmfPkg: VMWare SVGA display device register definitions" > >>> > >>> which are the first four patches (out of five) from the following > >>> series: > >>> > >>> [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga > >>> > >>> These reverts are arguably not bugfixes; they are preparation for > >>> re-implementing a feature from scratch (the last patch in that series). > >>> Thus, had I known we were already in the Soft Feature Freeze, I wouldn't > >>> have pushed them, because the review was not complete before the soft > >>> freeze start. > >>> > >>> But I had just returned from a week (or more) of PTO, there was no > >>> announcement on the list yet, and I didn't remember the wiki page. > >>> > >>> (In the technical sense, the reverts are not disruptive, luckily; they > >>> remove code that is dead anyway.) > > I've given this more thought. > > The reverts indeed remove dead code, but the code in question is dead > *only* on QEMU v2.10+. On QEMU v2.9 and earlier, the code is not dead. > > (See the original discussion in the thread "[edk2] [PATCH] OvmfPkg: > initialize bochs when initializing vmsvga".) > > This means that, with only the first four patches applied from the > series (= the reverts), and with the fifth patch (= the clean > re-implementation of the feature) postponed, people running > edk2-stable201811 on *old* -- v2.9 or older -- QEMU, with VMW SVGA, will > suffer a regression. > > So that leaves me with a question. Should I revert the first four > patches now, for edk2-stable201811? (I.e., revert the reverts --> > re-instate the incorrect VMW SVGA driver impl, that happens to work on > v2.9 and earlier.) > > ... Note that upstream QEMU no longer supports (= maintains stable > branches) for v2.9 and earlier releases. The QEMU homepage > currently advertizes: > - 3.1.0-rc0 > - 3.0.0 > - 2.12.1 > - 2.11.2 > > Personally I'm leaning towards keeping the reverts for > edk2-stable201811. (v2.9 is really old, and the VMW SVGA device model is > virtually unused.) For my professional integrity though, I must ask this > question publicly. Well, I don't really have a horse in this race, but since you've directed the email at me (at least that's what mailman makes it look like :) I'll state my opinion: My leaning would be towards reverting the reverts. My workstation runs Debian Stretch, and the QEMU included there is 2.8.1. So a current "stable" distribution would be affected ... ... for people who run bleeding edge EDK2 on stable-distro-provided QEMU. Which is why it's only leaning. There is no such thing as too many reverts. / Leif