From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9662D2118F35A for ; Sun, 11 Nov 2018 04:19:31 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id y3-v6so6365125wrh.10 for ; Sun, 11 Nov 2018 04:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ReM3tI938UFmopGnHg45u/6292sM4mlPhgypLK8IkrY=; b=TaTaHGJV8TXfwTC6OzX4eAwzMDCIQR6qGMMaTyYFh87BDxESvIEOr0qD4Ep90EngkH DsRhH+7vD28S+a5gUY9LoPTjAjABu+b2lONMwAG9jE1VVUGyHnGNmcvMlbAhibRgmmBd Vbw1JVonQ8qCxwQSq7BmJe4+hPEE/lAmL7X8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ReM3tI938UFmopGnHg45u/6292sM4mlPhgypLK8IkrY=; b=hfnTmOYfTRlxukvdbTqbz425jN5cub0QK6abdkmx3H0+iXT8S9C7LQH8Hmh6rmTgpA oV2rSzg1gTKV7VGdsdjNhgmcJjSmSY6qUsYpXkhiWqO8aG3k0GcYn1nTJ6awSURgywY/ e4e9qTIbkqQAx9jkugW4LCWReXxl9ncrxXp3KzOIvGLl0Hj8AhM4H9OIfS0OAYc23lwG huTVG5MnSYWSZw+DgFjiyqwp/sRqXu5iifl4dbnkqucssT0/tkm8QgXvTE8qGSVGnLZe A8hN3GDao3Xg3h+m0gx5kRgYzKc2JGG6pSIWSRuH8aJ15dm0n/WWoZjhZQeSgE3niUus b7xA== X-Gm-Message-State: AGRZ1gI8NkrIdCLU4U9PGncv/7NhPVHDDdKOaVUiXeNjY7TUU1dYlKUd l9a0DrnjmKU0cjGDOkdVxnFfOQ== X-Google-Smtp-Source: AJdET5ffyADdSp/mA0uaQPnmkU54gaNfNE0lteMePRCAZEs/xSt4wDEHWy/4nbknXiCWUJBupCyWgw== X-Received: by 2002:a5d:4e01:: with SMTP id p1-v6mr14764873wrt.320.1541938769713; Sun, 11 Nov 2018 04:19:29 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x8-v6sm33330409wrd.54.2018.11.11.04.19.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Nov 2018 04:19:28 -0800 (PST) Date: Sun, 11 Nov 2018 12:19:26 +0000 From: Leif Lindholm To: "Gao, Liming" Cc: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Laszlo Ersek (lersek@redhat.com)" , "Kinney, Michael D" , "afish@apple.com" Message-ID: <20181111121926.q4qkof54nt737plp@bivouac.eciton.net> References: <1541721496-13332-1-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3686EA@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3686EA@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [Patch 0/3] Fix UEFI and Tiano Decompression logic issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 12:19:33 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Liming, I have no issue with a fix for this issue going in during the hard freeze, but neither the commit messages nor the cover letter contain information of what problem was caused by the bug. It also does not say anything about the likelihood of hitting this bug, or what criteria need to be met. Nor does the bugzilla entry. The bugzilla entry talks only about the TianoCompress utility, but we the patches also modify runtime code. Detail in commit messages are always important, but since this modifies the behaviour of CVE fixes, there needs to be no room left (for reviewers) to wonder whether the bugs have been sufficiently understood and investigated. Regards, Leif On Sat, Nov 10, 2018 at 02:18:51PM +0000, Gao, Liming wrote: > Hi, all > This patch fixes the Uefi and Tiano decompression issue. I will > push it for edk2-stable201811 tag. If you have any comments, > please let me know. > > Thanks > Liming > > -----Original Message----- > > From: Zhu, Yonghong > > Sent: Saturday, November 10, 2018 4:54 PM > > To: Gao, Liming ; edk2-devel@lists.01.org > > Cc: Zhu, Yonghong > > Subject: RE: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic issue > > > > Reviewed-by: Yonghong Zhu > > > > Best Regards, > > Zhu Yonghong > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > > Sent: Friday, November 09, 2018 7:58 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [Patch 0/3] Fix UEFI and Tiano Decompression logic issue > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1317 > > > > This is a regression issue caused by previous change with more checkers in UefiDecompress. In Decode() function, once mOutBuf is fully > > filled, Decode() should return. Current logic misses the checker of mOutBuf after while() loop. > > > > Liming Gao (3): > > BaseTools: Fix UEFI and Tiano Decompression logic issue > > MdePkg BaseUefiDecompressLib: Fix UEFI Decompression logic issue > > IntelFrameworkModulePkg: Fix UEFI and Tiano Decompression logic issue > > > > BaseTools/Source/C/Common/Decompress.c | 6 ++++++ > > BaseTools/Source/C/TianoCompress/TianoCompress.c | 6 ++++++ > > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c | 6 ++++++ > > MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c | 6 ++++++ > > 4 files changed, 24 insertions(+) > > > > -- > > 2.16.2.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel