From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::442; helo=mail-wr1-x442.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9BE182118F367 for ; Tue, 13 Nov 2018 16:29:59 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id z13-v6so15334716wrs.3 for ; Tue, 13 Nov 2018 16:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+ApbA2qjnZ2m9NL7+ZsZXnyvlGNoyVnCFzkh0TFwFCQ=; b=Pa9qJ8MmpxcSgYpAsAqZFD4A3gkRJMQflfVUOYEpxYKuuOvfijFWJ/rlzH4DbjWSHY lxiE54JC+a5nV5SySK7WCWR7KA4Qx7bFpe/MgN0vVH/+l9RxkON6lVH2qlkIsPSWvycx TtomCC4QzrOyF/4Bc6G1ztxRmF46RPEsh8C6E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+ApbA2qjnZ2m9NL7+ZsZXnyvlGNoyVnCFzkh0TFwFCQ=; b=paU2JeMaYYooYV+h76mAeikZ4iu0y+sRjP5awO9jxRYC/g6I1HsOJA8JZ+pQRRnfjs ZK5m8cQSW7iB9o5gylPDX4x21i6Nb1DYVnzQady09eljhSfgWyBTFd5ymLOAe1mChoz4 8/QcPQoXx1jZeSNVvJLYIXBHQR9clZzaB4IJmvPvifEUzQOMpk0dRTwPkutkxu1Ecx59 diYo7N01FyJNWKgi0AZKjCjbAM1zBTjSFenWO/9oTUN3fgDD4p67+F9ax7r7JuP5/4ku XFH+rIcSYyvL0LM+n04ia6G/oUj+0ClaMcSuwds38uKmWx1ylxWvu6cX4vv4egNM/XAm 9TcQ== X-Gm-Message-State: AGRZ1gLo3jSrUoY5pkpyTMc8yK4LPhDl6wq5qBLo7T4+wbaiTaMJWowU gL0EUW4o4Rrck4IZA9pgkZlLvA== X-Google-Smtp-Source: AJdET5eNB6DtxTyqqTdye/S126f/fMxgbHZtDSNRPObqkyOllBvc2uj1EupPvxn33PhrrNUdhVjzNQ== X-Received: by 2002:adf:c550:: with SMTP id s16-v6mr6925390wrf.264.1542155398109; Tue, 13 Nov 2018 16:29:58 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 6-v6sm14495049wra.35.2018.11.13.16.29.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Nov 2018 16:29:57 -0800 (PST) Date: Wed, 14 Nov 2018 00:29:55 +0000 From: Leif Lindholm To: Ming Huang Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com Message-ID: <20181114002955.57b2kmg5jaiglrjw@bivouac.eciton.net> References: <20181029033249.45363-1-ming.huang@linaro.org> <20181029033249.45363-12-ming.huang@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181029033249.45363-12-ming.huang@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH edk2-platforms v1 11/12] Hisilicon/D06: Modify Gic base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 00:30:00 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 29, 2018 at 11:32:48AM +0800, Ming Huang wrote: > The values of PcdGicInterruptInterfaceBase and GICD are wrong, so modify it. > Fix SBSA test case 21: > 21 : Check GIC version > GIC version is 0 > Failed on PE - 0 for Level= 3 : Result: --FAIL-- 2 I'm confused here. How could this ever have worked? And what is the change? I see values changing, but what do they mean? / Leif > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > --- > Platform/Hisilicon/D06/D06.dsc | 2 +- > Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc > index 8ee20342b1..6296fcd9ec 100644 > --- a/Platform/Hisilicon/D06/D06.dsc > +++ b/Platform/Hisilicon/D06/D06.dsc > @@ -183,7 +183,7 @@ > gHisiTokenSpaceGuid.PcdArmPrimaryCoreTemp|0x80010000 > gArmTokenSpaceGuid.PcdGicDistributorBase|0xAE000000 > gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000 > - gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000 > + gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000 > > > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > index 43b43142af..d3de69a3ef 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc > @@ -361,7 +361,7 @@ EFI_ACPI_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = { > 0x0, 0x0, 25, 0x4000AA000000 + 0x6C0000 /* GicRBase */, 0), > }, > > - EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAA000000, 0, 0x4), > + EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAE000000, 0, 0x4), > { > EFI_ACPI_6_1_GIC_ITS_INIT(0,0x202100000), //peri a > // EFI_ACPI_6_1_GIC_ITS_INIT(1,0x400202100000), //peri a > -- > 2.18.0 >