From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 13E9621B02822 for ; Tue, 13 Nov 2018 17:12:26 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id j10so1178325wru.4 for ; Tue, 13 Nov 2018 17:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qxMhFn7qooCj6iKSFcxIYe52E1nvMLxIgbDkvKUWFf4=; b=LbJfICwy2O6Xn/1JLnuikkeEg8EV6DVQFr1OM74t5oF3ZAiRWvytWC72x7alUDs+gL 2kB8zIw0MJpqY7as8wZ4Ro+LCXZVWVQAIGqWdFg1ITtjh0xC2bqACGbpZ6JCbOidAkQd zmXF6QBAp6qKlQH4VtlPysfJDSemb4bUfJaVc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qxMhFn7qooCj6iKSFcxIYe52E1nvMLxIgbDkvKUWFf4=; b=ssMmixceYhtQ7Cq+DsvHAQin8HknJexZpo5EskmdsJF2yGPWCXnZKRhAC233xaSmeR LNb1mr9JGN0cLRfJRLrJRoM6uW14y93dNC+pE0zXTVu4HDxpv8JbbWWSpfilcFskKgbi Y1a5IziilGUIE8jRmLOgHD6nBUnEbC5838h5QsLONqYbJAgmMcEdU6UnI9H/z4OP5K9o +N1JrdUYGqE1kfry9azsasssDDjJj8+Chqe2mq9B5zRqSQyyZs43e8Saz5HUcziBDrvc 3Npo9drkVeB/lVcATBWoik+qKpJK3+xPa4jKfwXQ6OlwqRge9333wnIn6mQlmPf7EVCB rD3g== X-Gm-Message-State: AGRZ1gK0NP+/YMiOJLfdH0RNtg08Q3x5+K8gz66XHfVSiFyKub+wypgU iGsOZW501N5/kZDACERNnl7OpQ== X-Google-Smtp-Source: AJdET5evUXvp3pDwRFYbnoa2QHICiBbwZeNjX0I6OUDn+KrWXft9rKlNR7R/l4JnOm296+YfdXbp9g== X-Received: by 2002:a05:6000:1152:: with SMTP id d18mr6909701wrx.247.1542157945474; Tue, 13 Nov 2018 17:12:25 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h67-v6sm5994490wma.10.2018.11.13.17.12.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Nov 2018 17:12:23 -0800 (PST) Date: Wed, 14 Nov 2018 01:12:22 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel@lists.01.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Message-ID: <20181114011222.pqyq2rlkcvn7glmq@bivouac.eciton.net> References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-3-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1540000661-1956-3-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 01:12:27 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote: > This patch extends library with GPIO devices per-board > description. Both embedded SoC controllers and > I2C IO expanders are supported. Add a helper routine > for obtaining information about the latter. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 23 ++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > index ee8e06e..109164c 100644 > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > @@ -25,6 +25,29 @@ typedef struct { > } MV_BOARD_COMPHY_DESC; > > // > +// GPIO devices per-board description > +// > +typedef struct { > + UINTN ChipId; > + UINTN I2cAddress; > + UINTN I2cBus; > +} MV_I2C_IO_EXPANDER_DESC; > + > +typedef struct { > + MV_SOC_GPIO_DESC *SoC; > + UINTN GpioDevCount; > + MV_I2C_IO_EXPANDER_DESC *I2cIoExpanderDesc; > + UINTN I2cIoExpanderCount; > +} MV_BOARD_GPIO_DESC; > + > +EFI_STATUS > +EFIAPI > +ArmadaBoardDescGpioGet ( > + IN OUT MV_I2C_IO_EXPANDER_DESC **I2cIoExpanderDesc, > + IN OUT UINTN *I2cIoExpanderCount Please expand all DESC/Desc to descriptor/description/whatever as appropriate. With that, Reviewed-by: Leif Lindholm > + ); > + > +// > // I2C devices per-board description > // > typedef struct { > -- > 2.7.4 >