From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::443; helo=mail-wr1-x443.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C4FE2118DC5D for ; Wed, 14 Nov 2018 09:29:44 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id 96so1315987wrb.2 for ; Wed, 14 Nov 2018 09:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rO9FMp4odpJnZvzazQGKDMS8y8Ns1QHfxKi4DIt6l3Q=; b=UU92eSw3dTdmWKWgF2d5t/rrgY6Sa+4Z9mhapT1IBAWOk27mWKaJQVXQxnyjvYMJf/ DXm3IoiJIAgUm4g69Zmyhd0AvIKOCRTOH/KvHz2GGV/RhBti3e+XpHK5f7LnY8Cr5QUw 8STL1zHmVLyCYrpKVZR4IbQ2IUUn1gBd7T+Y0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rO9FMp4odpJnZvzazQGKDMS8y8Ns1QHfxKi4DIt6l3Q=; b=m6grDvU2mhXaTU3QeAxjLw6dtG5ddz6MfVeoeLQk56VxEsCcCP5K96hVN+gQQ7v3wq trm9yD3pPmY7UguMXVHTiVpvXQlsMvjJJaBFtiWgZeblmvIA1jcumIKi40fXFjnApJjk KzZ/oAoBD0f+/5/8vUa5vd6Ia+Tp1CMyc9JHYWV7sKRjWRtjKcThVfcTM8PM5Qy8sIgi BHm3Ul/QS9vNMiuzE8Uz9NzldgQlwzxh67y19Dmh1R0et9Hb150hYE8fFTpBkNz5zXQD qtwkAWV/omMTiji6nppGfU6ZfieOalj63zRHotAVLe9E5rfcrgSjCB6qSAAENW5RYekM xV0Q== X-Gm-Message-State: AGRZ1gJNS726bP3D6ztC/8kFpX1XWSwAie0qWIefXOz6kitqc2HofMNJ M7F5jOEIyzHVxlgVIZiW2QJYug== X-Google-Smtp-Source: AJdET5fX1oHLCWreHI7+sjqVskDMvji7F0emUbB83AMUn89J5FuiKnTGuI+g/f6GcjWCBu2QqYpn3w== X-Received: by 2002:adf:de0b:: with SMTP id b11-v6mr2641623wrm.119.1542216582954; Wed, 14 Nov 2018 09:29:42 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z8sm22964305wrw.78.2018.11.14.09.29.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 09:29:41 -0800 (PST) Date: Wed, 14 Nov 2018 17:29:40 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20181114172940.27iitrycma7hkogi@bivouac.eciton.net> References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-3-git-send-email-mw@semihalf.com> <20181114011222.pqyq2rlkcvn7glmq@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 02/12] Marvell/Library: ArmadaBoardDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 17:29:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Nov 14, 2018 at 07:16:33AM +0100, Marcin Wojtas wrote: > Hi Leif, > > śr., 14 lis 2018 o 02:12 Leif Lindholm napisał(a): > > > > On Sat, Oct 20, 2018 at 03:57:31AM +0200, Marcin Wojtas wrote: > > > This patch extends library with GPIO devices per-board > > > description. Both embedded SoC controllers and > > > I2C IO expanders are supported. Add a helper routine > > > for obtaining information about the latter. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marcin Wojtas > > > --- > > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 23 ++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > index ee8e06e..109164c 100644 > > > --- a/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > +++ b/Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > > @@ -25,6 +25,29 @@ typedef struct { > > > } MV_BOARD_COMPHY_DESC; > > > > > > // > > > +// GPIO devices per-board description > > > +// > > > +typedef struct { > > > + UINTN ChipId; > > > + UINTN I2cAddress; > > > + UINTN I2cBus; > > > +} MV_I2C_IO_EXPANDER_DESC; > > > + > > > +typedef struct { > > > + MV_SOC_GPIO_DESC *SoC; > > > + UINTN GpioDevCount; > > > + MV_I2C_IO_EXPANDER_DESC *I2cIoExpanderDesc; > > > + UINTN I2cIoExpanderCount; > > > +} MV_BOARD_GPIO_DESC; > > > + > > > +EFI_STATUS > > > +EFIAPI > > > +ArmadaBoardDescGpioGet ( > > > + IN OUT MV_I2C_IO_EXPANDER_DESC **I2cIoExpanderDesc, > > > + IN OUT UINTN *I2cIoExpanderCount > > > > Please expand all DESC/Desc to descriptor/description/whatever as > > appropriate. > > Just to confirm - until now in every case there was an abbreviation > used (in SoCDescLib, structures names, etc.). It may look somewhat > inconsistently, but of course I can change according to your wish. > Please let know your thoughts on that. Well, I'd prefer to change it all, but I'm happy to stick to following the coding style for new patches. / Leif