From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::344; helo=mail-wm1-x344.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BD882118FF29 for ; Wed, 14 Nov 2018 09:33:43 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id r11-v6so16232684wmb.2 for ; Wed, 14 Nov 2018 09:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tM47nboWgTdGeTG2QAlYUqBBnviEk97tjM/pu+sDwmU=; b=awrH9gtqHkltToI442m9Cp98GA1Ndc3PFepGsV2ePIsNCREXPU8B6PUTEVCiblyaei tiKaVzdVyjxW1NnmSGO38ewOq06Rugw7od+M2YAI0skEc/5npRIo9t3rpzRKPwnLC1ai cBsXDCcXsRp1E6R/bJYVZCi8zdatMKprddyh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tM47nboWgTdGeTG2QAlYUqBBnviEk97tjM/pu+sDwmU=; b=f7o6R/ocWavlJzVVUPFTgORx6ARF4pfSTSOO6XmCZ7FMyUOi2Cgl3DFk/0nfONodCA +QmX924phdWZSZ8nR52TgyQijYP83dLNUWIQGeyuii7HNq3u9CDFeOCCgdy8gZMkEMXW fdQ46hN3Rfr806gZBdV06KWp0LbZ4itcP79tgMxNf2jPp9nc1NMw/TotzeQfRNdx2sUX GowXOW7kfvQIR9irRP5Rw0+rpEbc8xRPTIZXQ63ThgfeDJaYiQBl+oxJ53E9JMLz78Oh bjFrDmrdbI4AyJZT2CHBce39Iu7ibXzWZPCtAwRIWso8L/0u9sdIzJqurPq1YRTFHkEh CPEA== X-Gm-Message-State: AGRZ1gL2E7ek/K7OQ6HqVW4Sby8UgqmR1uxfWEIj5TCdKtlnQLoqNl5b HV82NK/ptPQzttIkOr+SP/FnWw== X-Google-Smtp-Source: AJdET5cyhDz95EqPiWOrM2mS+yCVXmcVL8cHKtSDyv2fzT7NIY7suHwq06wMynXg0l/wUcOTlD99Kw== X-Received: by 2002:a1c:af4a:: with SMTP id y71-v6mr2508822wme.94.1542216822425; Wed, 14 Nov 2018 09:33:42 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id j4-v6sm26192290wrp.68.2018.11.14.09.33.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 09:33:41 -0800 (PST) Date: Wed, 14 Nov 2018 17:33:39 +0000 From: Leif Lindholm To: Marcin Wojtas Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Message-ID: <20181114173339.edjjmygvmrirtzvc@bivouac.eciton.net> References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-2-git-send-email-mw@semihalf.com> <20181114011044.inajftqy7qmfq7n3@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 17:33:44 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > I think all of my comments on this patch can be summarised as "what is > > an AP in this context"? > > > > The term either needs explicit documenting, or expansion in the macro > > names such that documentation is not required. > > Isn't a glossary on top of this file: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h#L13 > and C file: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8ff9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c#L13 > sufficient? I will confess I missed that. But that also clearly shows the problem. The glossary in is sufficient according to the coding style. But it gets confusing, specifically for the abbreviation "AP", since this has a specific (and different) meaning in PI. / Leif