From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4864:20::441; helo=mail-wr1-x441.google.com; envelope-from=leif.lindholm@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B024D2117D29E for ; Wed, 14 Nov 2018 12:00:40 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id u9-v6so18686350wrr.0 for ; Wed, 14 Nov 2018 12:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fBBIRfXuXf7IelElPgkv2MOkQWPRxyEAUaCsOmYWFM4=; b=dzzO4j7OQSG5Tn+DA0x5XOszzDuaGgxqaDUZDKHRAF8m1tonnEnVhdNTd548CRUip3 Uw1cN8uzgXtCfPje7uWnkuqGLkjHpxK4ACAoYYqCOuXBzcrzoZdD5GSjeVwN4SETIUsT ndE31mygbqgnWfqjV8OIkK1mt58aKq9dsvHgU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fBBIRfXuXf7IelElPgkv2MOkQWPRxyEAUaCsOmYWFM4=; b=n9tOXeVtpzEcJaYi2pxOzMBqJ1XxRhmWyaU9VKI85D2D7H90tnr25Qptv5+VCBpfDR FtRIAradI//psDVrjpQPmuJXuA02yAwCh2K4d9lq2wk9XBIHw0d5G6/whYnKQvnNtqN4 cp/354FQ7m6ziuRfowzGkZbCW64Ae68B6LMD06RB6v6hac6wc8tUDx5AAQY97XrNBl2V VI6Y4djHoZrXVMqWqvmt9CFtvYvR40yJOqJJ6a8jw6UwRxq0oWAcqvqRF6+O/CprVLoH c/V7sqfaOyc5S9Fv1XhZYRYUPgZXzPDZ/kVP4mNbIqRrFuLJ73L6XvqvtmLSRoE47Qsr 7iAw== X-Gm-Message-State: AGRZ1gIN/IySJ9+5whS6iY6uGgp5LAmy6wL9m0lxayJnNCxCQIiiYaL9 4LtK2E9OC0mogS3LCshgFigU2A== X-Google-Smtp-Source: AJdET5fh1xCa5ffdH5VQcpvwjnRBJgGauzPp2DL03HH1HMwwPnfawGV1TZZ8QLJnPtKi7G/ye4Oo9Q== X-Received: by 2002:adf:e4c1:: with SMTP id v1-v6mr3124574wrm.227.1542225638910; Wed, 14 Nov 2018 12:00:38 -0800 (PST) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a12sm8518772wro.18.2018.11.14.12.00.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 12:00:37 -0800 (PST) Date: Wed, 14 Nov 2018 20:00:36 +0000 From: Leif Lindholm To: Ard Biesheuvel Cc: edk2-devel@lists.01.org Message-ID: <20181114200036.o5nv5qnkwlmbkwxu@bivouac.eciton.net> References: <20181114192724.27068-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20181114192724.27068-1-ard.biesheuvel@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [PATCH] ArmPkg/ArmGicDxe ARM: fix encoding for GICv3 interrupt acknowledge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 20:00:41 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 14, 2018 at 11:27:24AM -0800, Ard Biesheuvel wrote: > Fix a typo in the 32-bit ARM version of the GICv3 driver, which uses > the wrong system register encoding to access ICC_IAR1, and attempted > to access ICC_IAR0 instead. This results in boot time hangs both > under QEMU emulation and on real hardware. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm I would say given how long we've gone without finding this, it's not justifiable to push this before the stable tag is made - so please hold off on pushing it until we open the flood gates. / Leif > --- > ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.S | 2 +- > ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.S b/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.S > index a72f3c865163..c308d2fa3e2f 100644 > --- a/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.S > +++ b/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.S > @@ -66,7 +66,7 @@ ASM_FUNC(ArmGicV3EndOfInterrupt) > // VOID > // ); > ASM_FUNC(ArmGicV3AcknowledgeInterrupt) > - mrc p15, 0, r0, c12, c8, 0 //ICC_IAR1 > + mrc p15, 0, r0, c12, c12, 0 //ICC_IAR1 > bx lr > > //VOID > diff --git a/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm b/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm > index 4228fb59be54..222047d1ad43 100644 > --- a/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm > +++ b/ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm > @@ -66,7 +66,7 @@ > // VOID > // ); > RVCT_ASM_EXPORT ArmGicV3AcknowledgeInterrupt > - mrc p15, 0, r0, c12, c8, 0 //ICC_IAR1 > + mrc p15, 0, r0, c12, c12, 0 //ICC_IAR1 > bx lr > > //VOID > -- > 2.17.1 >