From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D7BC21191739 for ; Wed, 14 Nov 2018 18:34:21 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id w3-v6so8259999pgs.11 for ; Wed, 14 Nov 2018 18:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XZsatKNchnoIx7N3MmvGSZf4KDV3cZ0L8e/2cbI1RLk=; b=Dau8uHz35I/3Qz+Y3LsTfO4K9sVgLC3ra+jEX5h7GvFYToUeYC5YO1dHDh2BA6atHi U1BrYgqFPUy16p/x8QV+F1AiLNxvK9mfbOqwmkxC9SJ5J0QXcW7v8PkDxoFAWd6iv8ld TXDkvHVGTEExRWVk158ZyNt0gUMEIP/vAnI5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XZsatKNchnoIx7N3MmvGSZf4KDV3cZ0L8e/2cbI1RLk=; b=B4k4v4wcxVs+Tp/0v4Kl2nq3mRa9dXTmJnkxOBkLKYyRDX94WSdTjy1Y11eaNHmcbp bpOP/cb2g2wRsMnwfipppq1afGYPbF2ay2mB+F1sv5om5gCeJBZAwSEJivsidrnSRsDE NoP9TkM7jvJ7ZRZjznnd6XJehgMPsp9nqLti8NsABd3WImlPcqNKMTcyEKrhEbFuSyR+ vgfYfri+MqXFbALulFtNR9n1Ij0JZeicyvRM1chL9x2sOKa4C7nba72G0NPUsIy8Ermx tS1IofwJb9BnULmIAi0TGpLWWRbOoaFUypEc3Ocirx2ScO1deLPfU6sBtAVbh7bkjdw9 teDg== X-Gm-Message-State: AGRZ1gK+KA1xgb1wgwNWLn29kL+gytvVPtWkzDO1El8UMphX+Fa5ZNlO fZroPviIYB6nZT0MhU9gse2taW0YSCeA4A== X-Google-Smtp-Source: AJdET5ebW49CgqL0GKAiMP8YCRSoFmDTCa9pnixtvAL/j8/EkciKwFKGjoJP9N8wLcTQ5vltSA4aIg== X-Received: by 2002:a63:42c1:: with SMTP id p184mr4098267pga.202.1542249260596; Wed, 14 Nov 2018 18:34:20 -0800 (PST) Received: from mba13.psav.com ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id v185-v6sm27323393pfv.48.2018.11.14.18.34.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:34:19 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, maciej.rabeda@intel.com, kamil.kacperski@intel.com, pawel.orlowski@intel.com, philmd@redhat.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com, eric.jin@intel.com, Ard Biesheuvel Date: Wed, 14 Nov 2018 18:33:49 -0800 Message-Id: <20181115023353.20159-17-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181115023353.20159-1-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> Subject: [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 02:34:21 -0000 When building for the X64 target using GCC, correct use of the EFIAPI modifiers is essential to ensure that the correct calling convention is used. So add the missing ones where appropriate. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 3 +++ IntelUndiPkg/XGigUndiDxe/ComponentName.c | 2 ++ IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 + IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 + IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 2 ++ IntelUndiPkg/XGigUndiDxe/StartStop.c | 2 ++ 6 files changed, 11 insertions(+) diff --git a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c index 26556e284381..b25ed7c4f022 100644 --- a/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c +++ b/IntelUndiPkg/XGigUndiDxe/AdapterInformation.c @@ -123,6 +123,7 @@ GetIpv6SupportInformationBlock ( **/ STATIC EFI_STATUS +EFIAPI GetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -188,6 +189,7 @@ GetInformation ( **/ STATIC EFI_STATUS +EFIAPI SetInformation ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, IN EFI_GUID * InformationType, @@ -234,6 +236,7 @@ SetInformation ( **/ STATIC EFI_STATUS +EFIAPI GetSupportedTypes ( IN EFI_ADAPTER_INFORMATION_PROTOCOL *This, OUT EFI_GUID ** InfoTypesBuffer, diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.c b/IntelUndiPkg/XGigUndiDxe/ComponentName.c index 2972c28bda4e..eee59d7c14f4 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.c +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.c @@ -116,6 +116,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, @@ -186,6 +187,7 @@ ComponentNameGetDriverName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetControllerName ( IN EFI_COMPONENT_NAME_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/ComponentName.h b/IntelUndiPkg/XGigUndiDxe/ComponentName.h index f63d58b8a18c..4f62e48379ed 100644 --- a/IntelUndiPkg/XGigUndiDxe/ComponentName.h +++ b/IntelUndiPkg/XGigUndiDxe/ComponentName.h @@ -67,6 +67,7 @@ ComponentNameInitializeControllerName ( language specified by Language. **/ EFI_STATUS +EFIAPI ComponentNameGetDriverName ( IN EFI_COMPONENT_NAME_PROTOCOL *This, IN CHAR8 * Language, diff --git a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c index 2f9c66771910..77b7a954698b 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c @@ -370,6 +370,7 @@ XgbeUndiPhyLoopback ( ChildHandle did not pass the diagnostic. **/ EFI_STATUS +EFIAPI XgbeUndiDriverDiagnosticsRunDiagnostics ( IN EFI_DRIVER_DIAGNOSTICS_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c index df6cfdf8a123..4b173bc8d8a9 100644 --- a/IntelUndiPkg/XGigUndiDxe/DriverHealth.c +++ b/IntelUndiPkg/XGigUndiDxe/DriverHealth.c @@ -45,6 +45,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. @retval !EFI_SUCCESS Failure to retrieve health status **/ EFI_STATUS +EFIAPI GetHealthStatus ( IN EFI_DRIVER_HEALTH_PROTOCOL * This, IN EFI_HANDLE ControllerHandle, OPTIONAL @@ -145,6 +146,7 @@ GetHealthStatus ( @retval EFI_UNSUPPORTED This function is unsupported **/ EFI_STATUS +EFIAPI Repair ( IN EFI_DRIVER_HEALTH_PROTOCOL *This, IN EFI_HANDLE ControllerHandle, diff --git a/IntelUndiPkg/XGigUndiDxe/StartStop.c b/IntelUndiPkg/XGigUndiDxe/StartStop.c index 156e927a35c6..c881c811aefb 100644 --- a/IntelUndiPkg/XGigUndiDxe/StartStop.c +++ b/IntelUndiPkg/XGigUndiDxe/StartStop.c @@ -38,6 +38,7 @@ EFI_GUID gEfiStartStopProtocolGuid = EFI_DRIVER_STOP_PROTOCOL_GUID; @retval EFI_SUCCESS Driver is stopped successfully **/ EFI_STATUS +EFIAPI StopDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) @@ -63,6 +64,7 @@ StopDriver ( @retval EFI_DEVICE_ERROR Failed to initialize hardware **/ EFI_STATUS +EFIAPI StartDriver ( IN EFI_DRIVER_STOP_PROTOCOL *This ) -- 2.17.1