[PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, maciej.rabeda@intel.com,
	kamil.kacperski@intel.com, pawel.orlowski@intel.com,
	philmd@redhat.com, michael.d.kinney@intel.com,
	harry.l.hsiung@intel.com, eric.jin@intel.com,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables
Date: Wed, 14 Nov 2018 18:33:50 -0800	[thread overview]
Message-ID: <20181115023353.20159-18-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <20181115023353.20159-1-ard.biesheuvel@linaro.org>

Drop some variables that are defined, assigned but never referenced.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 IntelUndiPkg/XGigUndiDxe/Decode.c         | 3 ---
 IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 4 ----
 IntelUndiPkg/XGigUndiDxe/Xgbe.c           | 2 --
 3 files changed, 9 deletions(-)

diff --git a/IntelUndiPkg/XGigUndiDxe/Decode.c b/IntelUndiPkg/XGigUndiDxe/Decode.c
index 5f37ce254872..c8dc3f4eb659 100644
--- a/IntelUndiPkg/XGigUndiDxe/Decode.c
+++ b/IntelUndiPkg/XGigUndiDxe/Decode.c
@@ -1454,14 +1454,11 @@ UndiStatus (
   )
 {
   PXE_DB_GET_STATUS *          DbPtr;
-  UINT16                       i;
   UINT32                       IntStatus;
   UINT16                       NumEntries;
   struct ixgbe_legacy_rx_desc *RxPtr;
   bool                         LinkUp;
 
-  i = 0;
-
   if (XgbeAdapter->DriverBusy) {
   
     //DEBUGPRINT (CRITICAL, ("ERROR: UndiStatus called when driver busy\n"));
diff --git a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
index 2aacb63ca158..df5238a3b55a 100644
--- a/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
+++ b/IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c
@@ -197,7 +197,6 @@ GetNextRequestElement (
   )
 {
   EFI_STRING StringPtr;
-  EFI_STRING TmpPtr;
   EFI_STATUS Status;
   UINTN      Length;
   UINT8 *    TmpBuffer;
@@ -226,9 +225,6 @@ GetNextRequestElement (
     return NULL;
   }
 
-  // Back up the header of one <BlockName>
-  TmpPtr = StringPtr;
-
   StringPtr += StrLen (L"OFFSET=");
 
   // Get Offset
diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.c b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
index 6769f2dc72ab..b3dbbd2b1d08 100644
--- a/IntelUndiPkg/XGigUndiDxe/Xgbe.c
+++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.c
@@ -1399,12 +1399,10 @@ XgbeInitialize (
   XGBE_DRIVER_DATA *XgbeAdapter
   )
 {
-  UINT32 *     TempBar;
   PXE_STATCODE PxeStatcode;
   EFI_STATUS   Status;
 
   PxeStatcode = PXE_STATCODE_SUCCESS;
-  TempBar     = NULL;
 
   ZeroMem (
     (VOID *)(UINTN)XgbeAdapter->RxRing.UnmappedAddress,
-- 
2.17.1

next prev parent reply	other threads:[~2018-11-15  2:34 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  2:33 [PATCH edk2-staging 00/20] IntelUndiPkg/XGigUndiDxe: fix GCC / ARM build issues Ard Biesheuvel
2018-11-15  2:33 ` [PATCH edk2-staging 01/20] IntelUndiPkg/XGigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
2019-01-30 15:41   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 02/20] IntelUndiPkg/XGigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
2019-01-30 15:44   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 03/20] IntelUndiPkg/XGigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
2019-01-30 15:49   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 04/20] IntelUndiPkg/XGigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
2019-01-30 15:49   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 05/20] IntelUndiPkg/XGigUndiDxe: add missing VOID** cast Ard Biesheuvel
2019-01-30 15:51   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 06/20] IntelUndiPkg/XGigUndiDxe: add missing UINT8* cast Ard Biesheuvel
2019-01-30 15:51   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle Ard Biesheuvel
2019-01-30 16:05   ` Ryszard Knop
2019-01-30 16:06     ` Ard Biesheuvel
2019-01-30 16:17       ` Ryszard Knop
2019-01-30 16:56     ` Andrew Fish
2018-11-15  2:33 ` [PATCH edk2-staging 08/20] IntelUndiPkg/XGigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
2019-01-30 16:06   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 09/20] IntelUndiPkg/XGigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
2019-01-30 16:06   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 10/20] IntelUndiPkg/XGigUndiDxe: drop StdLibC library class reference Ard Biesheuvel
2018-11-15 15:16   ` Carsey, Jaben
2019-01-30 17:26   ` Ryszard Knop
2019-01-30 18:34     ` Andrew Fish
2019-02-06  9:46       ` Ryszard Knop
2019-01-30 20:58     ` Kinney, Michael D
2019-02-06 10:14       ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 11/20] IntelUndiPkg/XGigUndiDxe: cast XgbeMemCopy () args to correct pointer type Ard Biesheuvel
2019-01-30 16:20   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 12/20] IntelUndiPkg/XGigUndiDxe: don't take address of cast expression Ard Biesheuvel
2019-01-30 16:20   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 13/20] IntelUndiPkg/XGigUndiDxe: drop locally defined ASSERT() macro Ard Biesheuvel
2018-11-15  2:33 ` [PATCH edk2-staging 14/20] IntelUndiPkg/XGigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
2019-01-30 16:22   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 15/20] IntelUndiPkg/XGigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
2019-01-30 16:26   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 16/20] IntelUndiPkg/XGigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
2019-01-30 16:27   ` Ryszard Knop
2018-11-15  2:33 ` Ard Biesheuvel [this message]
2019-01-30 16:39   ` [PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 18/20] IntelUndiPkg/XGigUndiDxe: set MDEPKG_NDEBUG only for RELEASE builds Ard Biesheuvel
2019-01-30 17:15   ` Ryszard Knop
2018-11-15  2:33 ` [PATCH edk2-staging 19/20] IntelUndiPkg/XGigUndiDxe: drop separate debug macros for DBG_LVL Ard Biesheuvel
2018-11-15  2:33 ` [PATCH edk2-staging 20/20] IntelUndiPkg/XGigUndiDxe: avoid unused var warnings for ERROR_REPORTn() Ard Biesheuvel

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:5f37ce25487 dfblob:c8dc3f4eb65 dfblob:2aacb63ca15
dfblob:df5238a3b55 dfblob:6769f2dc72a dfblob:b3dbbd2b1d0 )
 OR (
bs:"[PATCH edk2-staging 17/20] IntelUndiPkg/XGigUndiDxe: drop unused variables" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115023353.20159-18-ard.biesheuvel@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox