From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A2932119073A for ; Wed, 14 Nov 2018 18:34:24 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id e22-v6so8891785pfn.8 for ; Wed, 14 Nov 2018 18:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tC3chdOfdMiFKKtihaUa2a86E/XH7N4CV+EBAvH2khI=; b=dCb5GrZDE3uq9gVgqS2YI2rR76pW6kyuAekyjpN2SbPL4caVyJQVP68xirJdusAFoP nt1N4sNTq9IjHGrW9dh1sDSqa+9EbWPRbnlz3HrPzqd+IXE3J6l49uQntl8KEVWakuuQ X5/XlbQ9LUbhJf1o1QbrAhUtQ9KpCFUNsvDi0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tC3chdOfdMiFKKtihaUa2a86E/XH7N4CV+EBAvH2khI=; b=prnHyMfggH+e0RY+G+4YSZ3KnJ7B8O40wuv5TcE9SSEv2FDxHu+cHMGdp+pTUs/tJN XQ+xVoiMrSar3FoI/H5few+EyZrOw5FuGwxEZPRPtG1FuCI21zda6qLRPPBdfCsMdh+e lpXIMsJr3vhqOrwQ7anfyB6c1td9suIPeVXYGbBeXNVADyaWjM2CqjYDRLs28UhDwA04 TTpQvQdzuGY4rL1oFAvR8kDUZQzsK+Bzcwi1oOkxp1q+b9LcO7DiUbAPHNk4G1AuhXRB 4+3gJqTA2cerIdViW/CkBYP0CXuq1fzrBbTbANiB4Ub2z7qLThPcfhAGB3IfHf8wvKGr M3bA== X-Gm-Message-State: AGRZ1gJiaZJIVR8ahq+H0PtM8zvsjEvpM4hJB6m9TWWHsJNzkud2pm7i ss+rzRbBdexXYZZuEHohfk8hAM/5EpC1mA== X-Google-Smtp-Source: AJdET5eAzv+KLQRPKWovc18zkQu1+N4bKONZDlpmDrIKbGwOy07qkECx4bINl+Tg7NIbto2YY/Mdlg== X-Received: by 2002:a63:f141:: with SMTP id o1mr4211798pgk.134.1542249264003; Wed, 14 Nov 2018 18:34:24 -0800 (PST) Received: from mba13.psav.com ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id v185-v6sm27323393pfv.48.2018.11.14.18.34.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 18:34:23 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, maciej.rabeda@intel.com, kamil.kacperski@intel.com, pawel.orlowski@intel.com, philmd@redhat.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com, eric.jin@intel.com, Ard Biesheuvel Date: Wed, 14 Nov 2018 18:33:52 -0800 Message-Id: <20181115023353.20159-20-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181115023353.20159-1-ard.biesheuvel@linaro.org> References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> Subject: [PATCH edk2-staging 19/20] IntelUndiPkg/XGigUndiDxe: drop separate debug macros for DBG_LVL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 02:34:24 -0000 The DBG_LVL bit tests are already done at build time, so there is no point in having separate definitions, since they only result in unused variable warnings. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- IntelUndiPkg/XGigUndiDxe/Xgbe.h | 21 -------------------- 1 file changed, 21 deletions(-) diff --git a/IntelUndiPkg/XGigUndiDxe/Xgbe.h b/IntelUndiPkg/XGigUndiDxe/Xgbe.h index 2a904de5bf2f..ecfcc1032e8b 100644 --- a/IntelUndiPkg/XGigUndiDxe/Xgbe.h +++ b/IntelUndiPkg/XGigUndiDxe/Xgbe.h @@ -1112,7 +1112,6 @@ WaitForEnter ( ); // This is the Macro Section -#if DBG_LVL /** When specific debug level is currently set this macro prints debug message. @@ -1137,26 +1136,6 @@ WaitForEnter ( if ((DBG_LVL & Lvl) != 0) { \ WaitForEnter (); \ } -#else /* NOT DBG_LVL */ - -// Comment out the debug stuff -/** When DBG_LVL is not defined leave occurences of DEBUGPRINT blank - - @param[in] Lvl Debug level - @param[in] Msg Debug message - - @return None -**/ -#define DEBUGPRINT(Lvl, Msg) - -/** When DBG_LVL is not defined leave occurences of DEBUGWAIT blank - - @param[in] Lvl Debug level - - @return None -**/ -#define DEBUGWAIT(Lvl) -#endif /* DBG_LVL */ /** Delays code execution for specified time in milliseconds -- 2.17.1